From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E55A6C433F5 for ; Thu, 24 Mar 2022 02:47:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F4CC6B0072; Wed, 23 Mar 2022 22:47:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A3056B0073; Wed, 23 Mar 2022 22:47:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 269FD6B0074; Wed, 23 Mar 2022 22:47:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 16EFC6B0072 for ; Wed, 23 Mar 2022 22:47:13 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id D6E186020B for ; Thu, 24 Mar 2022 02:47:12 +0000 (UTC) X-FDA: 79277743104.07.C50B745 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf04.hostedemail.com (Postfix) with ESMTP id 713D34002E for ; Thu, 24 Mar 2022 02:47:12 +0000 (UTC) Received: by mail-pj1-f52.google.com with SMTP id gb19so3547319pjb.1 for ; Wed, 23 Mar 2022 19:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=90v/5Py9W7EAZEot7188HYCPw8B0VfqItjFqNp0yU8I=; b=dxrv0V3AiE2m0/WOX54xvV5yxB0eJv9FvLmxGfHi84fR/RWgBOp4yXdDNToYvyAawj kFAqEG2QtJP6dJm1A/UKmq+1eB7PdUAV/zCkGhgbi9FbsP45vrQ9Soh8L719JjYtuwIg N8NN/8zPbZSLvzEiIEYCgbzuHQ3nWPE/VgE7HlJAPPawvyRDtRTBtdnSAeEjeXLRRFJY hF4aVeYUjd1A+GEfDEvARaNz62S+hP9Rhjqv1hfCPw9ceQkOiviCfxLNeiibnjpNAGNi /6516352cSybYQDMu2cYXhPHBes/c1Nn7vARgXL0a/M/f8rTpmQpxgaP5aNDcNn0GcUs QfDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=90v/5Py9W7EAZEot7188HYCPw8B0VfqItjFqNp0yU8I=; b=f0exq4ND9iXJy0bAqJGsLclZ/+Q9iiNu8kOgvhk0YEu04UEj92djwGMOA7l4uEerPt r2IxjwVfxYRG/hR77GY+ver6cGssYeWn9d325c66u4HaXtZQJOeFB/lYBmX5NG4tWGzQ YEGswFhhLULL/7ZqOp7XsUdEqK8DdsfS/QGQjqrbQ9oH1ko7kEJ6xpQYZIr42q2k5uYN xIMuqaQbX41Y1PsJAQ9uYwakPC8BK0O8AhvwqOs7StgQSt4Wkh0dmoTSx+nB6lK/j4Bh OBljsH7M4DtTnmPL5m2kqqCZFGSDI5sB8Def4G27foEUG+k4p1JANZxBT+u0DC/HSdFJ /90w== X-Gm-Message-State: AOAM530lhO5rXc5VIFuPB9WuPC5NBVZHNcLQ1/34YacB71Nbv0kyS2sZ 2kf5i9m/WzpIfnkJ4Bi9wL9XRSL/M6C6wZ6M1tU= X-Google-Smtp-Source: ABdhPJzEvjnYd7B0WIGRcPh8gW/FvpiuSCSRc80jOwhBs6SPVLjct24P89mwBuS0aVh2B9zE/pT9CUr0CDpyaw6jaGg= X-Received: by 2002:a17:903:1cd:b0:154:5edf:5704 with SMTP id e13-20020a17090301cd00b001545edf5704mr3481459plh.26.1648090031398; Wed, 23 Mar 2022 19:47:11 -0700 (PDT) MIME-Version: 1.0 References: <20220317234827.447799-1-shy828301@gmail.com> In-Reply-To: From: Yang Shi Date: Wed, 23 Mar 2022 19:46:59 -0700 Message-ID: Subject: Re: [v2 PATCH 0/8] Make khugepaged collapse readonly FS THP more consistent To: "Theodore Ts'o" Cc: Vlastimil Babka , "Kirill A. Shutemov" , Miaohe Lin , Song Liu , Rik van Riel , Matthew Wilcox , Zi Yan , Andrew Morton , Andreas Dilger , darrick.wong@oracle.com, Linux MM , Linux FS-devel Mailing List , linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dxrv0V3A; spf=pass (imf04.hostedemail.com: domain of shy828301@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 713D34002E X-Stat-Signature: c5ohuyzcomwuzggfrk1urdo9pwx8y4cp X-HE-Tag: 1648090032-298809 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 23, 2022 at 6:48 PM Theodore Ts'o wrote: > > On Thu, Mar 17, 2022 at 04:48:19PM -0700, Yang Shi wrote: > > > > The patch 1 ~ 7 are minor bug fixes, clean up and preparation patches. > > The patch 8 converts ext4 and xfs. We may need convert more filesystems, > > but I'd like to hear some comments before doing that. > > Adding a hard-coded call to khugepage_enter_file() in ext4 and xfs, > and potentially, each file system, seems kludgy as all heck. Is there > any reason not to simply call it in the mm code which calls f_op->mmap()? Thanks, Ted. Very good point. I just didn't think of it. I think it is doable. We may be able to clean up the code further. > > - Ted