From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A64F0C433C1 for ; Tue, 30 Mar 2021 16:57:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2C275619CC for ; Tue, 30 Mar 2021 16:57:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C275619CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B6A7A6B0081; Tue, 30 Mar 2021 12:57:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1B8E6B0083; Tue, 30 Mar 2021 12:57:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9BE8E6B0085; Tue, 30 Mar 2021 12:57:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0112.hostedemail.com [216.40.44.112]) by kanga.kvack.org (Postfix) with ESMTP id 81DE26B0081 for ; Tue, 30 Mar 2021 12:57:50 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4A55A2476 for ; Tue, 30 Mar 2021 16:57:50 +0000 (UTC) X-FDA: 77977147500.12.A3443E7 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf29.hostedemail.com (Postfix) with ESMTP id B0DA23505 for ; Tue, 30 Mar 2021 16:57:34 +0000 (UTC) Received: by mail-ej1-f44.google.com with SMTP id kt15so25837273ejb.12 for ; Tue, 30 Mar 2021 09:57:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+XfVc4bp3tv0baSA+ilwDRzBCXkderlgKxQptH0HURI=; b=FXDblg0wNnodckIP6GMY3vTyctrhMiYtey2021Tp4EOt16c88je16Z2zkEouQy9i7C YjC8ViVk3IbidZDd4L8UFnw8ivbm3n2yfucm8JelQB9ycBPKMM7zI+pRY1SiuKf2d4Tr CE7Og6EYft9PllVA0v0xxmyCkszijaerPrLtzD8ErcTGzpJyETftvIWiRxgN1ontC8h5 zQwdQ4KnJ7WrBcTi2buhD55a/AzVj1VuQ8kwKypa3gDFWT/ssEfB3cafF4cPQV6z/vIm xQ0Do6WwvOdLl1Bf9IKVA/fo/S7KBVIalDxEKHYF02vif6E6MgcI1GkBaMFWTkXDl/b5 SU6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+XfVc4bp3tv0baSA+ilwDRzBCXkderlgKxQptH0HURI=; b=ASLqB8kVFDhla3sY8zk+PUmviNgsf7wYeyUerXLfClFuL/eZ4Ykzg6rvNblAzFh+sp v2Cdo8i+t9s2mfcaaXKoK3oZMTNC+5Rbs6iTgkUePuHq/wepfIKykVqaabWzo7l5N1OW CCo+8N0NedVzDlGd3DvJ0BRMTrWmdciF0aOeQHPbyuq2sRARjI8BqhhjKFhcCvkMFa/Y 6fvguo13O2izdua1Qj0lP7eq1EqpiDoho0gtyYXqUh6msV6/WR4hRjg/ODICHWOUU64X Nfs1UiXNtQgwUlbRwezzxrWXa+Gz2bScE+mj5lHRTST8CzcZa9dTk0aNusutJ5KuBkGi 8FvQ== X-Gm-Message-State: AOAM532joXiorGTgsGH08rqsLVzUrp2kLqoWCHRUUX7GBmYTfc6ltSLj U9LzHM4Coxnn/RBn34qoBk/KSWzYxvxvFyWEZy4= X-Google-Smtp-Source: ABdhPJzqmI1tqocjFgXr/ivxD3GjusCtTDyrS1vQ7POxVI58Kmtv7oI6yaTYepmOHpzjpz0uwyxOen0NcRHj+/bW5FI= X-Received: by 2002:a17:906:bcfc:: with SMTP id op28mr33921639ejb.238.1617123445646; Tue, 30 Mar 2021 09:57:25 -0700 (PDT) MIME-Version: 1.0 References: <20210329183312.178266-1-shy828301@gmail.com> <20210329183312.178266-4-shy828301@gmail.com> <87ft0dbif0.fsf@yhuang6-desk1.ccr.corp.intel.com> In-Reply-To: <87ft0dbif0.fsf@yhuang6-desk1.ccr.corp.intel.com> From: Yang Shi Date: Tue, 30 Mar 2021 09:57:13 -0700 Message-ID: Subject: Re: [PATCH 3/6] mm: migrate: teach migrate_misplaced_page() about THP To: "Huang, Ying" Cc: Mel Gorman , "Kirill A. Shutemov" , Zi Yan , Michal Hocko , Hugh Dickins , hca@linux.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com, Andrew Morton , Linux MM , linux-s390@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B0DA23505 X-Stat-Signature: c8ojrearti9pqdoebhnh54xwf3cu5xf8 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf29; identity=mailfrom; envelope-from=""; helo=mail-ej1-f44.google.com; client-ip=209.85.218.44 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617123454-868682 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 29, 2021 at 5:21 PM Huang, Ying wrote: > > Yang Shi writes: > > > In the following patch the migrate_misplaced_page() will be used to migrate THP > > for NUMA faul too. Prepare to deal with THP. > > > > Signed-off-by: Yang Shi > > --- > > include/linux/migrate.h | 6 ++++-- > > mm/memory.c | 2 +- > > mm/migrate.c | 2 +- > > 3 files changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/include/linux/migrate.h b/include/linux/migrate.h > > index 3a389633b68f..6abd34986cc5 100644 > > --- a/include/linux/migrate.h > > +++ b/include/linux/migrate.h > > @@ -102,14 +102,16 @@ static inline void __ClearPageMovable(struct page *page) > > #ifdef CONFIG_NUMA_BALANCING > > extern bool pmd_trans_migrating(pmd_t pmd); > > extern int migrate_misplaced_page(struct page *page, > > - struct vm_area_struct *vma, int node); > > + struct vm_area_struct *vma, int node, > > + bool compound); > > #else > > static inline bool pmd_trans_migrating(pmd_t pmd) > > { > > return false; > > } > > static inline int migrate_misplaced_page(struct page *page, > > - struct vm_area_struct *vma, int node) > > + struct vm_area_struct *vma, int node, > > + bool compound) > > { > > return -EAGAIN; /* can't migrate now */ > > } > > diff --git a/mm/memory.c b/mm/memory.c > > index 003bbf3187d4..7fed578bdc31 100644 > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -4169,7 +4169,7 @@ static vm_fault_t do_numa_page(struct vm_fault *vmf) > > } > > > > /* Migrate to the requested node */ > > - migrated = migrate_misplaced_page(page, vma, target_nid); > > + migrated = migrate_misplaced_page(page, vma, target_nid, false); > > if (migrated) { > > page_nid = target_nid; > > flags |= TNF_MIGRATED; > > diff --git a/mm/migrate.c b/mm/migrate.c > > index 62b81d5257aa..9c4ae5132919 100644 > > --- a/mm/migrate.c > > +++ b/mm/migrate.c > > @@ -2127,7 +2127,7 @@ static inline bool is_shared_exec_page(struct vm_area_struct *vma, > > * the page that will be dropped by this function before returning. > > */ > > int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma, > > - int node) > > + int node, bool compound) > > Can we just use PageCompound(page) instead? Yes, I think so. The current base page NUMA hinting does bail out early if PTE mapped THP is met. So the THP just could be PMD mapped as long as it reaches here. > > Best Regards, > Huang, Ying > > > { > > pg_data_t *pgdat = NODE_DATA(node); > > int isolated; >