From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D72BAC25B75 for ; Thu, 6 Jun 2024 03:44:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EBD66B00A5; Wed, 5 Jun 2024 23:44:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 573716B00A6; Wed, 5 Jun 2024 23:44:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3ECAE6B00A7; Wed, 5 Jun 2024 23:44:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1FC286B00A5 for ; Wed, 5 Jun 2024 23:44:53 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BCB0D1A08A2 for ; Thu, 6 Jun 2024 03:44:52 +0000 (UTC) X-FDA: 82199072424.30.88F5C73 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf23.hostedemail.com (Postfix) with ESMTP id DD9A314000E for ; Thu, 6 Jun 2024 03:44:50 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Xjl9ardO; spf=pass (imf23.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717645491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ib9GO6vz0LdgeFQK3Y0w0q6XW+0rDitHhAT13NO4NRw=; b=VDMnEb19sIaHZ1rCalO/BnaIyYGSoThfe9NB9emkTQL9vqxgWpge+8WoLAzrx9wxpS0Ogy j+qDtiGkGB6ZRqotlR3WBQZmHZ9f8S0Nok5/AuBsm2m3UilgTZLierK8iNDpNKpiu359XP krVpNjhnpDnRYIZfzxgNvCEc5N5cxGY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Xjl9ardO; spf=pass (imf23.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717645491; a=rsa-sha256; cv=none; b=ahMCiUqEGzPoeniGfMhlV9HN6LkzVQkVIM4HerH9uxNdAQlD0/PU0upzCWe+T3Gc6i0QTm MzFA93J22YG+Oige0n4IGCLwJmNSYgf7MzMy/U30V6c2iypuViL2A8CBgcxdqUPxOhDr1c kqKbwczqqQ0RxUN4IvXsYY7YnXS4lHc= Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-57a68b0a229so443181a12.3 for ; Wed, 05 Jun 2024 20:44:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717645489; x=1718250289; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ib9GO6vz0LdgeFQK3Y0w0q6XW+0rDitHhAT13NO4NRw=; b=Xjl9ardOLdEEivd6FPfU8FZBbV2jXPgSplEwgR8WWAiz9EVmBVRfDeQUsvgp/3hJlq ZYhVtQaYU7ZTlVFA+8NI9UJgcz4KzO/4z+6TTrwEG3vZjqvOdJ+7AiyoazYoWCwrhGAv B3tE1jak6VPlsKRKufbbxkNmMmw8AB5G0uedGvBUbS0pVZ9lw0fE29VPxlDeVfnseCPV uOfaeq4ZBRcLVGH6XEliphZmdjJcoMdi+ZBf8pyq2rSQ0sou94K9jYp2bwMY7qmwjNyL C1ocxoKia4K/pZVCPY35jN3kjje9WqXpV+CXH9Twf+Av0HHPjtevE3gTBK1NeHfMfqtz h/jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717645489; x=1718250289; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ib9GO6vz0LdgeFQK3Y0w0q6XW+0rDitHhAT13NO4NRw=; b=ZQRGLUA0bv6+4oYjo5Ns5jHJ6xJiNzpgmRYbplPQwd3BLK/YA7XunD9wIHxr/ReXV4 9D/YGaMFlpOAXhFY901QDKLmjoOTYprCdvLUbRkmP9GucOlByqeqNO0oX7AShLamKRi4 g4bdTeBCH+W9bIPeXYYwUmEUn2BtUIYvGcpbUXGvwShqpHH9rw8GuxIN8557BzW9bAu5 9iLR41vJuEYWmdGnmpp7HmSPvfVrJPHef7xZHnQHB7F6qCT/p4C633RPHMUmF97pXhtH h7TkTydnGNjYf2G/23WP4NPftYsJw+dAURawtyjDswRuAMpF3yJh9DbWrW370yaJ5wLk lxow== X-Forwarded-Encrypted: i=1; AJvYcCWQqb3b6JmIuq8FMJTMCW2+8a4/XPZ49ex/+LMgRzlMiZvPLngEB//vsmpDaosCdnhIcVMsxHkICVsvJaIZ40JsJxQ= X-Gm-Message-State: AOJu0YzgdAHbU0CsDQkt8XEndTUZys8oACmPVjek2ng9dXeCjlCLEW9K IWruuFaXWhiMQI6hiv6hMupfq6V/ytfPtCsHXV2x/QCjrGRy7zs2gqLXgGrrPNeEcdn+gNiCDYn ZzbQ2br1Md580BHOPLAm9MdEE8BE= X-Google-Smtp-Source: AGHT+IFiXQqdqqvbzsI3R836Jg4kIdO1IeQxSUIVe4ULPHAQP7IHpTZ7oFtJHCmNCmpMe6JdxjA097Iuyfuvf9B2U64= X-Received: by 2002:a17:906:dca:b0:a69:67e3:57fd with SMTP id a640c23a62f3a-a69a002272dmr275028866b.47.1717645488946; Wed, 05 Jun 2024 20:44:48 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yang Shi Date: Wed, 5 Jun 2024 20:44:37 -0700 Message-ID: Subject: Re: [linus:master] [mm] efa7df3e3b: kernel_BUG_at_include/linux/page_ref.h To: Oliver Sang Cc: Andrew Morton , Christopher Lameter , David Hildenbrand , Jason Gunthorpe , Matthew Wilcox , Peter Xu , Rik van Riel , Vivek Kasireddy , linux-kernel@vger.kernel.org, linux-mm@kvack.org, lkp@intel.com, oe-lkp@lists.linux.dev Content-Type: multipart/alternative; boundary="000000000000380746061a308167" X-Stat-Signature: 1zpud9fm9op5fbrs4d7ji8g9s8ahqa3k X-Rspamd-Queue-Id: DD9A314000E X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1717645490-95862 X-HE-Meta: U2FsdGVkX188Kh/DYpuX3MoYKE5N+5vY9ZUpc7dsszdjLtk/yZF5+X8MHVv8Av41U9MLDEltlvk4C+FKjHJ55N3Qzrj6ZesbqAnJMQappBIO6aastK1bZeYEEtqT1i1Jy0m7tmZtpX0374PpSVVu9oVqFwrvtyFx+nUldD164blJBHEIoOlSEV/0ytq7sLEqZ5ZCTuk3SWfTXIcXzrIzS/ZNA8BGfC837OJguoigTXP7pSH+WYVsZnSunRUNngEQ5d1VrfSMm8HXm4og1vvdtWI5hvMs1bsNrajJTFGafmhQovaWfithQUl4T2BleTNcHHSHD5nqsF3Dyo55Sz6q1e50dj4l1AeCU16cnR/xS5g0F61pqiJKgTnKmWXl6xvPJ8t02Y3ioJyIZYfwvIE/g6V96mohKi9gcVh0NPyC0ACBkuZM5iSJ1YVFnluYZ4DhMD9w+XLc6iMSK7FhNYM/UYEHl2MHD9sX33n0/OtJEZi4f/7Iuvj3A0162VFeAfcsqokW54KgzdVNuLU/FznJZvsdkSngCPwC/Lfb33TGc32UKd7a05FXh2v0nuRlzFZ0aFAejCCfTvartWlSH4A0RjobcfBJer42/hW3KheUp82jap0Nv8YUoYQhaOYH+Dv7LcwwUBxdabqZJqlyR/9jHpSGFdG3oa8bxkTUvUR88EWXx7NuH7Qeek0lfKIxbbWY+CH916qIl3xmfLcYAhAN+So2Bo/7zNZzkb1mOkJzBcOQ3hEXXxU0a3aoM8ZXx1aYY6gIbUxC8iI2NRFkPcH5RaNnGVdRoT5p6stBm63p2Vjy3lEr9LVMa4Jnc77cjyAtPFWZgOT86sNTeEdTvDvOvKb62pAfbBg7+mn4yOF6rokmlQ/avs5cXVSxZqReCla11IEGY6/t3lTP+l4c5B64R+25+RM59EPJ91fGfx/YQC7J/kAG0Dx2bnVqy0gIQxB4/uA/vogrJ2kvMfBfLDD 5NGFyhCZ d2UDgFhUPJhsOd1pxDE7z82NjZarTTSrmAu3CTe4LrhldvoeSWEaAdOjuSb4nPCW4CwYViPq3Q22swmz7WTn4T9qx5BgEtqrXXYFbbkBTVVuFzv8E9rtMP2gOB3emLWoGffXeHQD+usqB2qwywcimue7fFTyb6MzyFHSZ6nfYJj1MBFcg4u12RXGlZ7hfsZ5mw2abnR6M2pEM7GptBoqnFUhZXtbugyHNMVl6nEv/BRpSIgCbtmc7gQwJrMBrYRXgQ/BDoPKYiEU+rpapZ4NMpZkhjI6QDXNtjwpicEDU92m6LpN6kFDXgrl6AldzOh2WvCCEWqzcri8n+Vi3Q3ahybVkeM2VnQyTi9/e7dqr5fVEpN2XrrHLsxnnz+AvYfqOSkeL+jclFgVDj6CQIl8pBuvHw9VwI9CpTvrrpwcHbUEOoumVzAeLkPwiJU6lQyorkw3iGo64eaI+/ldAx8w8/bzTJ3U0fm2ilotJ0Rl2XRxpaqqdrPXPMgffABLRuAI6nhgvKXIu0I8aW5wIeP02Y+A+0lIgK5hvlRSIUfQobv19FZjo30nuFCjGeKbDozshqHYyfxnm+uXxUQ1ndb8e6yRp31PDgZgODvadQd/Zik+qYBhWPaFJEoM73OeErrlSq8Q6oF4dRCINf93gGdMMcNIjCP1jTy0wpEZLXNRYNWh4bkU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --000000000000380746061a308167 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Oliver Sang =E4=BA=8E2024=E5=B9=B46=E6=9C=885=E6=97= =A5 =E5=91=A8=E4=B8=8919:16=E5=86=99=E9=81=93=EF=BC=9A > hi, Yang Shi, > > On Tue, Jun 04, 2024 at 04:53:56PM -0700, Yang Shi wrote: > > On Mon, Jun 3, 2024 at 9:54=E2=80=AFAM Yang Shi w= rote: > > > > > > On Mon, Jun 3, 2024 at 7:02=E2=80=AFAM Oliver Sang > wrote: > > > > > > > > hi, Yang Shi, > > > > > > > > On Fri, May 31, 2024 at 01:57:06PM -0700, Yang Shi wrote: > > > > > Hi Oliver, > > > > > > > > > > I just came up with a quick patch (just build test) per the > discussion > > > > > and attached, can you please to give it a try? Once it is > verified, I > > > > > will refine the patch and submit for review. > > > > > > > > what's the base of this patch? I tried to apply it upon efa7df3e3b = or > > > > v6.10-rc2. both failed. > > > > > > Its base is mm-unstable. The head commit is 8e06d6b9274d ("mm: add > > > swappiness=3D arg to memory.reclaim"). Sorry for the confusion, I sho= uld > > > have mentioned this. > > > > I just figured out a bug in the patch. Anyway, we are going to take a > > different approach to fix the issue per the discussion. I already sent > > the series to the mailing list. Please refer to > > > https://lore.kernel.org/linux-mm/20240604234858.948986-1-yang@os.ampereco= mputing.com/ > > got it. seems you will submit v2? should we wait v2 to do the tests? The real fix is patch #1, that doesn=E2=80=99t need v2. So you just need to= test that. For patch #2, I haven=E2=80=99t received any comment yet and I=E2=80=99m go= ing to travel so I=E2=80=99m not going to submit v2 soon . And I heard if hugepd is going to be gone soon, so I may wait for that then rebase on top of it. Anyway it is just a clean up. > > sorry that due to resource constraint, we cannot respond test request ver= y > quickly now. > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > Yang > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Cheers, > > > > > > > > > > > > > > David / dhildenb > > > > > > > > > > > > > > > > > > --000000000000380746061a308167 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Oliver Sang <ol= iver.sang@intel.com>=E4=BA=8E2024=E5=B9=B46=E6=9C=885=E6=97=A5 =E5= =91=A8=E4=B8=8919:16=E5=86=99=E9=81=93=EF=BC=9A
= hi, Yang Shi,

On Tue, Jun 04, 2024 at 04:53:56PM -0700, Yang Shi wrote:
> On Mon, Jun 3, 2024 at 9:54=E2=80=AFAM Yang Shi <shy828301@gmail.com> wrote: > >
> > On Mon, Jun 3, 2024 at 7:02=E2=80=AFAM Oliver Sang <oliver.sang@intel.com&= gt; wrote:
> > >
> > > hi, Yang Shi,
> > >
> > > On Fri, May 31, 2024 at 01:57:06PM -0700, Yang Shi wrote: > > > > Hi Oliver,
> > > >
> > > > I just came up with a quick patch (just build test) per= the discussion
> > > > and attached, can you please to give it a try? Once it = is verified, I
> > > > will refine the patch and submit for review.
> > >
> > > what's the base of this patch? I tried to apply it upon = efa7df3e3b or
> > > v6.10-rc2. both failed.
> >
> > Its base is mm-unstable. The head commit is 8e06d6b9274d ("m= m: add
> > swappiness=3D arg to memory.reclaim"). Sorry for the confusi= on, I should
> > have mentioned this.
>
> I just figured out a bug in the patch. Anyway, we are going to take a<= br> > different approach to fix the issue per the discussion. I already sent=
> the series to the mailing list. Please refer to
> https://lo= re.kernel.org/linux-mm/20240604234858.948986-1-yang@os.amperecomputing.com/=

got it. seems you will submit v2? should we wait v2 to do the tests?

The real fix is patch #= 1, that doesn=E2=80=99t need v2. So you just need to test that.

For patch #2, I haven=E2=80=99t rec= eived any comment yet and I=E2=80=99m going to travel so I=E2=80=99m not go= ing to submit v2 soon .

= And I heard if hugepd is going to be gone soon, so I may wait for that then= rebase on top of it. Anyway it is just a clean up.
=



sorry that due to resource constraint, we cannot respond test request very<= br> quickly now.

>
> >
> > >
> > > >
> > > > Thanks,
> > > > Yang
> > > >
> > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Cheers,
> > > > > >
> > > > > > David / dhildenb
> > > > > >
> > >
> > >
>
--000000000000380746061a308167--