From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50568C27C4F for ; Wed, 26 Jun 2024 20:45:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDC376B0083; Wed, 26 Jun 2024 16:45:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C8B506B0088; Wed, 26 Jun 2024 16:45:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2BB26B0092; Wed, 26 Jun 2024 16:45:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 927DF6B0083 for ; Wed, 26 Jun 2024 16:45:36 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 444B4A43D2 for ; Wed, 26 Jun 2024 20:45:36 +0000 (UTC) X-FDA: 82274220672.02.8580961 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf05.hostedemail.com (Postfix) with ESMTP id 6BCFF100004 for ; Wed, 26 Jun 2024 20:45:34 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TxZ3UwLy; spf=pass (imf05.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719434718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PM40bjTPz1dqcC17Wbu3ggrPNq45RxrBUEE+94YRk58=; b=kort7gPVQ8lKYo02UOvScBM7UKklOG2Q0kYorIHnplrSPT37Ol6j68qgPnWG4ujemYl42v ki3SCON1KdFcm/L9b+TW2D0gUNfVvxgoN+7HoIEoTXklEN3hPNO7Q2usK460/bjuxDLLGL 9aPXvYygCOUHgpRghyOVLei1h/uXHy0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719434718; a=rsa-sha256; cv=none; b=o+sJ2ciXepWONwXruSK144B72lfVWGAQFljZiYZdOrSf8nKoOwkzusW/o501i+2NpSviwo rwA0EFmPbHXsCaWBbsEKz8Siwfk0DI8AMdjOx1QcMCGPhns1ogdYoydCiEuu9B6P+G8nE1 gaeLcotxfgByIyeafxgPQ6gP1KSnsz4= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TxZ3UwLy; spf=pass (imf05.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a6fdd947967so539931366b.2 for ; Wed, 26 Jun 2024 13:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719434733; x=1720039533; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PM40bjTPz1dqcC17Wbu3ggrPNq45RxrBUEE+94YRk58=; b=TxZ3UwLyPpzrrqoJ9cZXmRRQtL0mgrZSNRrFs+Q76Ukaco8jwK/BbiUjS/0b+wpDKV bY/g+V1wyO5LTSYsRUdfs5HsdvATxXKu0UeSq5c1soCbUznxjFyBveS8XK9h3gHtqFM2 0biySCx+yNYIkVGKBBk4myCliueXi6/Do6bDbQTuuI/5lVfih25QF+klfDoeezAb/sfb dFvqqUqstzZyfNHsGiCxF1HvrUJEKcO4Cm6WqfrizD9piJNfGogBKmbBwGug3BxvmSZ1 qL6rGz0YKj2owAOCPbnV2Nlm8TeMGNYv1mh9ICvmBT6Ob5IwjrCJEr6+K3xioUNGECzY QNHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719434733; x=1720039533; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PM40bjTPz1dqcC17Wbu3ggrPNq45RxrBUEE+94YRk58=; b=RFOK6PtVUFZIXXodw222yFXpzHpB8PTxBiLA599lF0MTs/2pvAP4ckdGZ+d2qF+IDp vIhKLiILtj35BZRnVQlOkAp72bI2CO36kq409xeDBp39sSeOq5OAtCbAZVXnHVf8/gbn v+X5kkpIZ/UHL3uRJzbvU3y4kA8yy9w58a7asxdLOtnLEn1SAfIG6tWaOY2FmFwYHSXw WWsEs4NbC8XIC7fgfrGR2Hso4urty0G3FTaWEgJKMRqWHDS7mbyUejLbvhVgCtVBaDzE KqNyzSRrpQd1QxHR0ucYQzShF+qQVU9BEmKNsgtqKLjE1hGGciuPolvLLc+m+tGXer11 U20Q== X-Forwarded-Encrypted: i=1; AJvYcCVdyq+V6x/cOCw30yZkZW4udh2jxeUMFFVVupgGXwrvqqNa96hiqUiPFMJFAECdZZmGFcTOKgyGK/2tERtiZYI/Xn8= X-Gm-Message-State: AOJu0YwPGz+tOiOPgTbOAr2DOMHrmjpOBeD9XNzdZiahbkWc1w25OadB QhsEuJhOGUxs/eQ0UgBFBbXFnjNrxhRCLQ0b7HCnoGoEV2Et6Va8wtTu+bXMyioy9Clkp4+Ahtm ZY9/rDf4AKDk23zsBicG/ASHZPnk= X-Google-Smtp-Source: AGHT+IFIRD6vR6RZbUSKa+Iu6mFYmGbrivykjIXvuUN7o+SZbuCk++mtJV0gWcJhINPw5bth5v4hzGNitCpERXZOcuc= X-Received: by 2002:a17:907:6d25:b0:a6f:ab9c:7779 with SMTP id a640c23a62f3a-a7245b8507fmr1256206766b.9.1719434732571; Wed, 26 Jun 2024 13:45:32 -0700 (PDT) MIME-Version: 1.0 References: <20240625233717.2769975-1-yang@os.amperecomputing.com> <20240626134040.63fe621bff6a5fe1c0503999@linux-foundation.org> In-Reply-To: <20240626134040.63fe621bff6a5fe1c0503999@linux-foundation.org> From: Yang Shi Date: Wed, 26 Jun 2024 13:45:20 -0700 Message-ID: Subject: Re: [PATCH] hugetlbfs: add MTE support To: Andrew Morton Cc: Yang Shi , muchun.song@linux.dev, catalin.marinas@arm.com, will@kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: axn9n1hkty1fkt19w4cte13kxs9k76or X-Rspamd-Queue-Id: 6BCFF100004 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719434734-43595 X-HE-Meta: U2FsdGVkX1/3dxcBagk+JbgH83WU4LAAgrGEZ7Im/NJKU89byA9iJI2uyGIOVsPVuaiAS+5t6LD3gBiktxmfL8eOfFf89oShPDv09QQ/kZGEPGQckp99lmix5msmlGp4F1y1eKaz2ssG/wRLIsYnw2KYbUI0cQMlFgVkH9maaziNl1QnL3o7KwEWe73yIO24BFjYjaNYb4dKNQcn0RLAppzdlHTJYrh8abnypFXV7pjxd+uJ1UitHvRbAxSmInNQ2QEFjaW5oAWuAhQNUZWVzveWylBYHuC0wW91U09Rd56gAS6TEjWVtcHyaEOzjqvwF70yR2wBhfTTMKa6oZqufGs8kwdMTt2OEUdOLgwiyTNJ3092Es6BLFmADApm8mbeQds3OP7qJh03Wv9rgPg/QetqnRYf+yILTzAbRP5kyogn/+Els/FpEVz7bD096j56j8ph0YqLc3GHvbP17fLn2LbYNZzxeocmbvNYx39yXzbHpq09PuhOkILWsBhwDKihemYXfWiUhdjnuskr+jLgkmXBQHqsFrkeugtyq7IP4bjcpAL3l9q/kvbB668JjeUH+FuHiIH0OOCJgFrH8lsTULD0PUoHCb0pZBthU9F+LH0DgZHVHawWTpNaS65jLkwlYCCNZEFb0UNXxcllSaCzWmhDHv5iB+v5GF+POC8XK1Lw2id4Rz7gUZ4BKI9uR8P3p3+7PHKIp8xwXlXXWSo3CzTNri0xdcZPEQ7UFZs2y6UKkQXiiTvtUszc8GSbT1w0neYRicfhLv1D51k8qgqT+ck7FdqjzRLXog6t5mD3fT9o+V8g7ISvBVOivjfkzrtH3QmSDo2gzAEDKeyBBKuX/pSzAuYPZ1KODnScia2okILwCc62rpitco4TruXiX0mrjd5SKboyQRAWJLLpJjhbi8oBpnAq91pmyq+FcsJVimCoc387YNKNFYZCEDi6iwHyfwhr8Uq5hm/xTXaCF6c QOBoDRSD X1bfD3kgn48dzSQDcp57jpqV5oC1cKNsE+gUp5MqtXPILlqqaRzuhOZ1D/V4DcW9dD6PCJoNih8hnaqkC9tBzZj7zm2Bqu69ceZCFDOKsleDSg5YkVwuJn9aSTFc1+b8Dbx6pyQUViK0JE3XI9XB9uGCjzgka1/zcrxsSiusImafx1A1ZVCN1Aw2kfqR9hQf7tWAbHeRPYSJY8gKoZx0QOr7juwTIffDwO77BDdTtNPgbdv8HC0PL3K3H+8I3zMbK4EMcjMUoJi8BKcinz3qzxJAmlvJ3yY6GbZhHR8L118CRkcI+yZt5r/53LLIZv/85vYwZJr7hC/BbfZ9g26y+9og/GaCeg8uEiOGVAH1xCZkNAx06BZ3AK5QQ3SDWLwi+n74IUstlXFpZo5fHtIzADqcmKeeQ6jUnE5GN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000089, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 26, 2024 at 1:40=E2=80=AFPM Andrew Morton wrote: > > On Tue, 25 Jun 2024 16:37:17 -0700 Yang Shi = wrote: > > > MTE can be supported on ram based filesystem. It is supported on tmpfs. > > There is use case to use MTE on hugetlbfs as well, adding MTE support. > > > > --- a/fs/hugetlbfs/inode.c > > +++ b/fs/hugetlbfs/inode.c > > @@ -110,7 +110,7 @@ static int hugetlbfs_file_mmap(struct file *file, s= truct vm_area_struct *vma) > > * way when do_mmap unwinds (may be important on powerpc > > * and ia64). > > */ > > - vm_flags_set(vma, VM_HUGETLB | VM_DONTEXPAND); > > + vm_flags_set(vma, VM_HUGETLB | VM_DONTEXPAND | VM_MTE_ALLOWED); > > vma->vm_ops =3D &hugetlb_vm_ops; > > > > ret =3D seal_check_write(info->seals, vma); > > How thoroughly has this been tested? > > Can we expect normal linux-next testing to exercise this, or must > testers make special arangements to get the coverage? It requires special arrangements. This needs hardware support and custom-patched QEMU. We did in-house test on AmpereOne platform with patched QEMU 8.1. >