From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3495C3DA4A for ; Tue, 20 Aug 2024 19:24:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05C886B007B; Tue, 20 Aug 2024 15:24:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00CB46B0082; Tue, 20 Aug 2024 15:24:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E166C6B0083; Tue, 20 Aug 2024 15:24:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C3AED6B007B for ; Tue, 20 Aug 2024 15:24:20 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 64D11404B1 for ; Tue, 20 Aug 2024 19:24:20 +0000 (UTC) X-FDA: 82473599880.04.C0A26DC Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com [209.85.222.54]) by imf24.hostedemail.com (Postfix) with ESMTP id 8CD8418001E for ; Tue, 20 Aug 2024 19:24:18 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IHJKh4lM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of shy828301@gmail.com designates 209.85.222.54 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724181794; a=rsa-sha256; cv=none; b=mNOedgKbJCNMJXM2qkg53Yv2fbVaGmILyl17JeWvMzg0AURGRDJ0PI9/srf7rPDwNqY2vX zrwrawTGDOjFRCjBrUAB4qkpmj9MkT0YylULWYx6Ah2vjEO2DapXzGE0t9yLYBHzhNLoib m3jPNo5Qnqg7UR/LWzWwYd23QAUXUss= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IHJKh4lM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of shy828301@gmail.com designates 209.85.222.54 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724181794; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z1tmc8256vAJgUbRussYJhC9pRhaSG2mZOYaopGSWZw=; b=uQ//Ga109oNax8biqT2X0VHU11VhyaN4XDS10QaD+qZQQjXl9jKbQ0SolFx9trwSLgCafE ua1Q5xPxHKXymoRAVttrt5kHRml6ph7XV+lpKpzIJhdvKx1GKURANsUGMcxlgvZWral9rc Z5sNKGjAF3KjFAh6GMq/cNxB9gcQpHg= Received: by mail-ua1-f54.google.com with SMTP id a1e0cc1a2514c-842f04589f3so1587616241.2 for ; Tue, 20 Aug 2024 12:24:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724181857; x=1724786657; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=z1tmc8256vAJgUbRussYJhC9pRhaSG2mZOYaopGSWZw=; b=IHJKh4lMVU2joJeV9U6gtONTB5DmMxk/ApEc4kkT4LMgS3XuiiaYPtm3RbkhkjsvAs qUaxCYFmeiWgiyXlVEMxUCokNdqCis4H7II1dG9pgKvGvOZJAuGyUtEPAi7SiBxpStNx geYzXNK2EV7Kpf+4NWmWFgUO3Xa4wpkggeFQV2NYE4egbEJC7afDy8QhvJvFMhXBvL6W tvcM687GnEaEGzksiLq7cHfcdq6pKPql/3ngBUV49k64eu4L3X1oOSRuT4A1AIA5M6Rs /q8AdEZQd66uie/JIggI9N1tAq172Q8GrCU/kbPci1STJEWgA55LhCk0LOCA1ze7Wbv5 FQiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724181857; x=1724786657; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z1tmc8256vAJgUbRussYJhC9pRhaSG2mZOYaopGSWZw=; b=lvhz2MH6w+f9itqOgx5CiG4lJP0tVDnQ8wei9XiMStgN+sxxuIONPft/TMt8XmEcOZ Ndaw+4VFzPhmzh4MQO9xNs2TEz8b3sUNuZ5uvKY4HzT1X4zI+fFO89dCfjtm+7jkpxVQ AvWIGm74Si54QifpD7dPgkHgJh79DCHUrFUPKGprAeLFvS6b+WhQANOso7xj/dJWk4FP 7KDYdv1I0+V7gEHcHvRT2QMTuLQgmed64Xd0DZMXqYMljeIP/DWjEgYY/py2zmexG10e 4lmDvRxlOf1UxmEryaUMDHI4ATiEhsqOY+45NDMzNzSYNLMrMlDPNDUTdnX+Mz73VnkU fZ/g== X-Forwarded-Encrypted: i=1; AJvYcCVX3eCBSVCRav1rQBhC9ECU55BdxrIc5JMlWbz3QPxEm6CiIGwIwuFYP8EKIqewTWtRfc498ngg7g==@kvack.org X-Gm-Message-State: AOJu0YxeyytL9R+rjOaEAJJfbr362WmylyKWWq4vupJsi1qQOvRM8EzR 7Cu+UHr0h+aa1/vCAzZ++5hFzcIb/79wyXsIDPGOBZsl/Ckcqa3Fedl+pkX95kXmQi6rm0WxqyD OB7XtrUyATEcxURjOwjdci/DvXGU= X-Google-Smtp-Source: AGHT+IFY2u+n2n/e06BscZuEAQwIezb1O2o7j3+4kMxl1BnN3srbwIJ5I/Lxw2uojzdORefUqRGnSPfHUc9eN4WlX04= X-Received: by 2002:a05:6102:38cd:b0:498:d1b0:210f with SMTP id ada2fe7eead31-498d3deec3cmr135794137.11.1724181857571; Tue, 20 Aug 2024 12:24:17 -0700 (PDT) MIME-Version: 1.0 References: <20240819-numa_policy-v1-1-f096cff543ee@gentwo.org> In-Reply-To: <20240819-numa_policy-v1-1-f096cff543ee@gentwo.org> From: Yang Shi Date: Tue, 20 Aug 2024 12:24:05 -0700 Message-ID: Subject: Re: [PATCH] Reenable NUMA policy support in the slab allocator To: cl@gentwo.org Cc: "Matthew Wilcox (Oracle)" , Johannes Weiner , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 8CD8418001E X-Stat-Signature: gbfwhh8idefnti1gzk491jqaombek5uw X-Rspam-User: X-HE-Tag: 1724181858-786068 X-HE-Meta: U2FsdGVkX19YRNcZk1T7Ba7CkBHEDW61Nw7GkMIsT4l4xiPmsEClxvF49R/6gPPp9VHShSWFAkUu8lXRRnSzGrg/rdF6kd0N/R9a1CYvEwNEDhKd964N3HHVXbQ6fWTBHwiliCjYoQnGRB0MpPsFIpby+A3vvzep8Ah6iu6nuXO+ls+rShLWSDJmURAj4G1xlF5DBeBhm8vulp/up2uQL+1H1vgBXmkzC3YG/O6Xckgvfyjfeuk5A9/OCITWYk4zUOwMOCoVc3ohD/kgY8LRWGflWixe7SgCjGfi/jlebfihCOFg/AQxOfZTlOCUFwx0SnxTg6z069D2Ry+sEKyD7TGccR482bOyMyeRXaPimdXejyN8JF0mDSLnwnTfWo5xzMXthzJi0hhHMOvbgOoiWfMMIcORzlE6n3DVuovQSa2Hp1PuKS8OVJTDJyQLJUNBJAUfJNY0U+DXHZnijmWSRO2EtfSFSWNUpB1r8QP4qiW8xRTU4/S+jqN4Y4SpD3RiUZ2XxOsB6veWf35vDkB+TEsgHtmZpOB0f2ihIdkRhT3ZEM+/wbjzrbVd6S4Jr/V0Y5b52hOyAr4aw0zyLVRIBBY/NYBa5vn+SLDfnUp5AnuUHkEdT3BcgBFeq6I+lv2BVk9M8G5iFWDRLN1OE4/L+B+ovGd7BHE9p2Ot5W+Vg4YpftmxVtieDDni/Vt6Ks9YeCNF6HDSw1nG0b3YBZ3cxB4l1CLtmjQ3ORhZMImebzg1rsK1kmSRslc91DjE/ycFSu51xkXhWb7Lr6r+AnAC+bHWVp6qffPr2n78E7J3zyft2VChNRywBx8iCxEBnNHbCHtbodhgfkFw8elmiPS2Kme0siv8ahjWQsjtVHXAU7rBk0kv91+1+pk4AAS2K3nPPIN70m0OFhnUQ4wfzdX1qrW0RZTAYO+ryU2MmbU4JAGZEh4iE4OqQp1rnLKEcXj6X7gfBzngjnMoieSdLAF ullbIBWu BDUo0YJc5J8NHvKoJHc+8Yoj/A81g33BKhr71IDW/g7czMk/cukdSHKX8yIhdtFvSfA5SiCB7aJ53mhhmOUHaLLOZMBrjX6sBDCPRaUfOy0tVbzHBZCtjPcjnZAyrE1ya6zxa3UwdCd+Ui9As9jzKA2MOLOPCZz8VyHOkAxroHCFbfdDTAR7g1JlHquIdC+VbFwXNUzADFbY8Nrq37YDRMhBw3VqMbdCO6NdrDZoOEqa5a/nEIfkr5j70n1o38G7hfoGQRz+4I+8A9u4NcC6M85jkZ8OLJUq84dXirXSGTRIrhizkNcfcAeCYneKw1JlzHURtik9JsgM8k1H6I2+kTRQr4hZDfwm/oGXzUao5UTuH2Zt/0TrMB/jkqRfJt9npvIWmGys+jH+awhzpNlC8oU7KysmXvAHzZ5jUJ7vsY64Pn20jJn3/JNNbM+uy+CMn0mUaDsVsHjo0NjJ4pOw0BsKkshcAz+jEaPbECAKneYd6h+k7+z6ed8ZzVGNUMffZlgqQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 19, 2024 at 11:54=E2=80=AFAM Christoph Lameter via B4 Relay wrote: > > From: Christoph Lameter > > Revert commit 8014c46ad991 ("slub: use alloc_pages_node() in alloc_slab_p= age()"). > > The patch disabled the numa policy support in the slab allocator. It > did not consider that alloc_pages() uses memory policies but > alloc_pages_node() does not. > > As a result of this patch slab memory allocations are no longer spread vi= a > interleave policy across all available NUMA nodes on bootup. Instead > all slab memory is allocated close to the boot processor. This leads to > an imbalance of memory accesses on NUMA systems. > > Also applications using MPOL_INTERLEAVE as a memory policy will no longer > spread slab allocations over all nodes in the interleave set but allocate > memory locally. This may also result in unbalanced allocations > on a single numa node. > > SLUB does not apply memory policies to individual object allocations. > However, it relies on the page allocators support of memory policies > through alloc_pages() to do the NUMA memory allocations on a per > folio or page level. SLUB also applies memory policies when retrieving > partial allocated slab pages from the partial list. > > Fixes: 8014c46ad991 ("slub: use alloc_pages_node() in alloc_slab_page()") > Cc: stable@kernel.org > Signed-off-by: Christoph Lameter Reviewed-by: Yang Shi > --- > mm/slub.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index c9d8a2497fd6..4dea3c7df5ad 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2318,7 +2318,11 @@ static inline struct slab *alloc_slab_page(gfp_t f= lags, int node, > struct slab *slab; > unsigned int order =3D oo_order(oo); > > - folio =3D (struct folio *)alloc_pages_node(node, flags, order); > + if (node =3D=3D NUMA_NO_NODE) > + folio =3D (struct folio *)alloc_pages(flags, order); > + else > + folio =3D (struct folio *)__alloc_pages_node(node, flags,= order); > + > if (!folio) > return NULL; > > > --- > base-commit: b0da640826ba3b6506b4996a6b23a429235e6923 > change-id: 20240806-numa_policy-5188f44ba0d8 > > Best regards, > -- > Christoph Lameter > >