From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FFD6C00140 for ; Wed, 10 Aug 2022 17:07:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A05B16B0071; Wed, 10 Aug 2022 13:07:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B5F06B0072; Wed, 10 Aug 2022 13:07:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 857908E0001; Wed, 10 Aug 2022 13:07:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 774656B0071 for ; Wed, 10 Aug 2022 13:07:46 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 550521C0FC4 for ; Wed, 10 Aug 2022 17:07:46 +0000 (UTC) X-FDA: 79784314932.18.A75E549 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf23.hostedemail.com (Postfix) with ESMTP id B5859140167 for ; Wed, 10 Aug 2022 17:07:45 +0000 (UTC) Received: by mail-pf1-f182.google.com with SMTP id h28so14237925pfq.11 for ; Wed, 10 Aug 2022 10:07:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=+DbX3SDxILgYRcy9rAL2BFcYYrfgkda6PI0B6f6Q+Wc=; b=dXIzUSwtUBZ6mwguU9x6MqXFayTwWdFNH/quGDfA9cjEFMjiD6eWlfL3UKACXmpFwo yEXz3do8WJKLybz4SqQxbq0tjhRBfuEnaPAXz+6a5hitQyZqrGh9vmHxhwXOBza8hr0I CZ+eN/gi9PXzFknQXrKXv2KdcC7io2kdThNMxYtApvINmDFr8Eewi7gEVdRaxa9+aV8n ORtpoQvtg9l6fwhnvjiSxYwHYLQIZAQ5RyFVuLGF4gBQ8F7xg4ef3hyznBCgqlh/jO/o wVsox4lfUfkHfKUyFgh3U9uj/cxFG2BPj+FjeGBuPr0SZVdKGYX4I1XL3MlFGy35WAcS qrxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=+DbX3SDxILgYRcy9rAL2BFcYYrfgkda6PI0B6f6Q+Wc=; b=xeiwd9Jbk1E4hBMtQfs6XC/SZ/c4WLE7uK392LdLyUraiJ+CABaclNwjMqk4OzOmbT prlVii9xGDtEYaPQ+o+Picb14EJWeRgxWq90H7ATGN112oa59i7QnST58wgZ1hz5+x/T N9nqPD9KzmBLD3Hejg6Bd/zFSFdMojTLksjnH1mWxy6FvI47xBZz/R3mRSOKpoqvI9M9 HVYrIz3aftkKmKddO91tgWp/ZugicmdGkUyGPXW+9nBOD4uq/SCnUDj8Vr/hB1oWsVEf vAIU7VXmuNsPjmQW/IRHw6oAc3XU4F1EIY2oG2GujUV8Tg4uU83prdah402hQf48GcyP PZFA== X-Gm-Message-State: ACgBeo1WZb9tnNGQYygkMSOOtq2WrQMcog5jcIVFxuO6lsW0GmWy+Qbc 9RYhELF1a8hKENlK5+a81ubbkbqgPjsg6MAovM4= X-Google-Smtp-Source: AA6agR6hExV1SvfL6DRTRzFUR5H98AfQE+kaKcvA7Cbd9AMeX+kOeD9uSPVVwyjGz56ei3Qfhgdd6XtAkS6/FM/rUO8= X-Received: by 2002:a63:8848:0:b0:41c:45da:2db9 with SMTP id l69-20020a638848000000b0041c45da2db9mr23108542pgd.206.1660151264726; Wed, 10 Aug 2022 10:07:44 -0700 (PDT) MIME-Version: 1.0 References: <20220805184016.2926168-1-alexlzhu@fb.com> <0b16dbac6444bfcdfbeb4df4280354839bfe1a8f.camel@fb.com> <1F8B9D85-A735-4832-AD58-CA4BD474248D@fb.com> In-Reply-To: From: Yang Shi Date: Wed, 10 Aug 2022 10:07:32 -0700 Message-ID: Subject: Re: [PATCH v3] mm: add thp_utilization metrics to /proc/thp_utilization To: Yu Zhao Cc: "Alex Zhu (Kernel)" , Rik van Riel , Kernel Team , "linux-mm@kvack.org" , "willy@infradead.org" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , Ning Zhang Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660151265; a=rsa-sha256; cv=none; b=XxBUmyELDbrLMhd0iiTvJcA60DMA+xLV4tQhN+BcitiN8nNqIhTqOCNFBHgoZQBbwuJyjr d6rFKdjcMugbeghpyCuqpDmybvjQk9e1ku5N5xxVNebD0mkSo3uanpMGlL52c8N+kwixRr TmnpX8SjOLBg3zsmw5eW5nyMWnT1BrI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dXIzUSwt; spf=pass (imf23.hostedemail.com: domain of shy828301@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660151265; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+DbX3SDxILgYRcy9rAL2BFcYYrfgkda6PI0B6f6Q+Wc=; b=UTBY0QKNkUu2/v518l68KS1AIdcJE1M3729J+JVpd0q0znx09mUO16OVGxkZb550HnLG6W RtBOszmB4B+3Vayu/UFotwyVg8L/ghJ5k2T17kpLXP/Ka8fdO2+blZ73L1c1OZBnUTU1sU l2G9DKUGRTm0/R820j+FBrTbq3NSDnY= X-Rspam-User: X-Stat-Signature: n9m6cdpnqnsw9tepbf5sc6prigh3zxbg X-Rspamd-Queue-Id: B5859140167 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dXIzUSwt; spf=pass (imf23.hostedemail.com: domain of shy828301@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam01 X-HE-Tag: 1660151265-203290 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 9, 2022 at 4:36 PM Yu Zhao wrote: > > On Tue, Aug 9, 2022 at 11:16 AM Alex Zhu (Kernel) wrote: > > > > > > > OK, it is hard to tell what it looks like now. But the THPs on the > > > deferred split list may be on the "low utilization split" list too? > > > IIUC the major difference is to replace zero-filled subpage to special > > > zero page, so you implemented another THP split function to handle it? > > > > > > Anyway the code should answer the most questions. > > > > They can indeed end up on both lists. This did have to be handled when > > implementing the shrinker. > > > > We free the zero filled subpages, while modifying the existing split_huge_page() > > function. Will follow up that change in another patch. > > FYI. This series does it: > > https://lore.kernel.org/r/20210731063938.1391602-1-yuzhao@google.com/ > > And this one: > > https://lore.kernel.org/r/1635422215-99394-1-git-send-email-ningzhang@linux.alibaba.com/ Thanks, Yu. I totally forgot about these series. It is time to refresh my memory.