From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B29EEC433ED for ; Fri, 30 Apr 2021 22:56:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3A23F613AD for ; Fri, 30 Apr 2021 22:56:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A23F613AD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BBA5B6B0036; Fri, 30 Apr 2021 18:56:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B43516B006E; Fri, 30 Apr 2021 18:56:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 995FE6B0070; Fri, 30 Apr 2021 18:56:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0058.hostedemail.com [216.40.44.58]) by kanga.kvack.org (Postfix) with ESMTP id 79C0F6B0036 for ; Fri, 30 Apr 2021 18:56:10 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9D8631802DE16 for ; Fri, 30 Apr 2021 22:56:08 +0000 (UTC) X-FDA: 78090543216.17.C39BE49 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf06.hostedemail.com (Postfix) with ESMTP id D4D62C0007EF for ; Fri, 30 Apr 2021 22:56:10 +0000 (UTC) Received: by mail-ej1-f43.google.com with SMTP id r9so107497710ejj.3 for ; Fri, 30 Apr 2021 15:56:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=43RdY4J01ubRDzd5g6EG2t/oZB879vC8jt3238dCcs0=; b=Mx50A2iy1FlEe+zLekdead91PpW+PDcjsTYGU+y4zfGgdao6k2ptEai2z7Tk1J6jQX Dx8WpHP3QZBLbrDRJkvK3kXt3rs15dTcraPO89OUhL65ZhlypvXPO55stCUO1vvA/QqV JAbOAtUUA31rAQ/NCdSAkoD54/t8sqJ797KFQCBTUH7q1iOm5arzsZ57jCGkuZ9Yp6MM AtlOneM+a82iiRYQo2k18iBO4mMI2hK4t1/emQCyQ1ql06o+e92L1todxrcphvaq3B4w K9/xKTQjLPocQyDTMbEhB6dvzVDj1NLSMiyXu+fFaw4s9zSQt1GC+aH4a2E6felkegis xfHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=43RdY4J01ubRDzd5g6EG2t/oZB879vC8jt3238dCcs0=; b=ZPXwZpb1Jkm3TvP8azq5iAZeaU07pQsqCz/teqt31qQWL4leTx4sE4NvNZRbMdI+tp U/3ARmsHJkrP2emwJhLn1kiYgk/P6l4fGHWUJ5TK4i+fkekdrW1gpFGGTOBCnNFm4iQT GbLcCeT37ZyEC7FiS3o3AwV08dPCEUf08hIdz73/KA6hmkND3IrY2yKmdPNBwyHa6UpC YxrGS3KHzpl4hoOIBXZZovtctl+MF3gtiUzMbpIrlJtIUGZfhMNA6K3ib+3zGDR5mbQ0 KHJTO44mMxFvcS8K+54PZhbYIvWfucU30hxzgpGraanM96nizlevBBuGVThmBHJP2zd9 4tJA== X-Gm-Message-State: AOAM530jMemu8zYwfV3HcGjXsNq3OoewjAGqzZCiKC3Op1aKKPM6t4Y2 xxMdM/9SO/u4zO+j1+9dYrDhR0qSYKQrbR9tqW4= X-Google-Smtp-Source: ABdhPJy/S3reHe9A4CyRyZ7t0e43+EGuChbikZ8E+imKfTVItGYuDJlK4v+35CpdXBEJdR08KpAq7e2Y8Q+hFHWHe8g= X-Received: by 2002:a17:906:c099:: with SMTP id f25mr6644244ejz.499.1619823367028; Fri, 30 Apr 2021 15:56:07 -0700 (PDT) MIME-Version: 1.0 References: <20210430210744.216095-1-shy828301@gmail.com> <07E637C5-3FCD-4D78-936F-186FD051D6A9@nvidia.com> In-Reply-To: <07E637C5-3FCD-4D78-936F-186FD051D6A9@nvidia.com> From: Yang Shi Date: Fri, 30 Apr 2021 15:55:54 -0700 Message-ID: Subject: Re: [PATCH] mm: thp: check total_mapcount instead of page_mapcount To: Zi Yan Cc: "Kirill A. Shutemov" , Wang Yugui , Hugh Dickins , Andrew Morton , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=Mx50A2iy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: D4D62C0007EF X-Stat-Signature: ojm3zzaix5rnwhzq9wfc5uwigz13zzr9 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf06; identity=mailfrom; envelope-from=""; helo=mail-ej1-f43.google.com; client-ip=209.85.218.43 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619823370-813036 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 30, 2021 at 3:30 PM Zi Yan wrote: > > On 30 Apr 2021, at 17:56, Yang Shi wrote: > > > On Fri, Apr 30, 2021 at 2:30 PM Zi Yan wrote: > >> > >> On 30 Apr 2021, at 17:07, Yang Shi wrote: > >> > >>> When debugging the bug reported by Wang Yugui [1], try_to_unmap() may > >>> return false positive for PTE-mapped THP since page_mapcount() is use= d > >>> to check if the THP is unmapped, but it just checks compound mapount = and > >>> head page's mapcount. If the THP is PTE-mapped and head page is not > >>> mapped, it may return false positive. > >>> > >>> Use total_mapcount() instead of page_mapcount() and do so for the > >>> VM_BUG_ON_PAGE in split_huge_page_to_list as well. > >>> > >>> [1] https://lore.kernel.org/linux-mm/20210412180659.B9E3.409509F4@e16= -tech.com/ > >>> > >>> Signed-off-by: Yang Shi > >>> --- > >>> mm/huge_memory.c | 2 +- > >>> mm/rmap.c | 2 +- > >>> 2 files changed, 2 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/mm/huge_memory.c b/mm/huge_memory.c > >>> index 63ed6b25deaa..2122c3e853b9 100644 > >>> --- a/mm/huge_memory.c > >>> +++ b/mm/huge_memory.c > >>> @@ -2718,7 +2718,7 @@ int split_huge_page_to_list(struct page *page, = struct list_head *list) > >>> } > >>> > >>> unmap_page(head); > >>> - VM_BUG_ON_PAGE(compound_mapcount(head), head); > >>> + VM_BUG_ON_PAGE(total_mapcount(head), head); > >> > >> I am not sure about this change. The code below also checks total_mapc= ount(head) > >> and returns EBUSY if the count is non-zero. This change makes the code= dead. > > > > It is actually dead if CONFIG_DEBUG_VM is enabled and total_mapcount > > is not 0 regardless of this change due to the below code, right? > > > > if (IS_ENABLED(CONFIG_DEBUG_VM) && mapcount) { > > pr_alert("total_mapcount: %u, page_count(): %u\= n", > > mapcount, count); > > if (PageTail(page)) > > dump_page(head, NULL); > > dump_page(page, "total_mapcount(head) > 0"); > > BUG(); > > } > > Right. But with this change, mapcount will never be non-zero. The code ab= ove > will be useless and can be removed. Yes, you are correct. > > >> On the other hand, the change will force all mappings to the page have= to be > >> successfully unmapped all the time. I am not sure if we want to do tha= t. > >> Maybe it is better to just check total_mapcount() and fail the split. > >> The same situation happens with the code change below. > > > > IIUC, the code did force all mappings to the page to be unmapped in > > order to split it. > >> > >>> > >>> /* block interrupt reentry in xa_lock and spinlock */ > >>> local_irq_disable(); > >>> diff --git a/mm/rmap.c b/mm/rmap.c > >>> index 693a610e181d..2e547378ab5f 100644 > >>> --- a/mm/rmap.c > >>> +++ b/mm/rmap.c > >>> @@ -1777,7 +1777,7 @@ bool try_to_unmap(struct page *page, enum ttu_f= lags flags) > >>> else > >>> rmap_walk(page, &rwc); > >>> > >>> - return !page_mapcount(page) ? true : false; > >>> + return !total_mapcount(page) ? true : false; > >>> } > >> > >> In unmap_page(), VM_BUG_ON_PAGE(!unmap_success, page) will force all m= appings > >> to the page have to be all unmapped, which might not be the case we wa= nt. > > > > AFAICT, I don't see such a case from all the callers of > > try_to_unmap(). Imay miss something, but I do have a hard time > > thinking of a usecase which can proceed safely with "not fully > > unmapped" page. > > This code change is correct, but after the change unmap_page() will fire = VM_BUG_ON > when not all mappings are unmapped. Along with the change above, we will = have > two identical VM_BUG_ONs happen one after another. We might want to remov= e one > of them. Yes. I'd prefer keep the one after unmap_page() since it seems more obvious. Any objection? > > Also, this changes the semantics of try_to_unmap. The comment for try_to_= unmap > might need to be updated. What comment do you refer to? > > > =E2=80=94 > Best Regards, > Yan Zi