From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A6B7C43334 for ; Thu, 16 Jun 2022 00:40:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CAACC8D0001; Wed, 15 Jun 2022 20:40:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C5AAC6B007E; Wed, 15 Jun 2022 20:40:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AFAFE8D0001; Wed, 15 Jun 2022 20:40:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9D3636B007D for ; Wed, 15 Jun 2022 20:40:37 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 7070112108E for ; Thu, 16 Jun 2022 00:40:37 +0000 (UTC) X-FDA: 79582243314.23.26CB39C Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf26.hostedemail.com (Postfix) with ESMTP id 0FF29140080 for ; Thu, 16 Jun 2022 00:40:36 +0000 (UTC) Received: by mail-pl1-f171.google.com with SMTP id t2so966pld.4 for ; Wed, 15 Jun 2022 17:40:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TcCZJRFbxoGfTo67jDtrqKzufdCi7UaSWExZ0v8GNEk=; b=gURvnx+CVl2L0EGZLNhdn/9OuS0m/MN87cPWESlDah6rtJWmVeciSvCkf24xk2R/Yw OWI8cx+W+Khdmab8KJYJKfLGw3kB68I50AmT7pUgSuVdERhrOcbOFiDHJPxQKvsdMKpU yuM5e6mKguZn/8hFr7yJI9laC+isA4pbE8eN+l2laIVJXOqRqSfaA4giTCnLlCsAT2uf BMjKenCuUBfz4+riVR3XeGfbC2r6gzIXUTigxdX2rPOxoI6iSWvU5OYvv2v/jF2qZFFf /jE20GO0x66MJtlvKIIm6akFDcnvZR/Dtb5woGJ8pqb99WS1qyojFkiktzL4/78j5RuK paeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TcCZJRFbxoGfTo67jDtrqKzufdCi7UaSWExZ0v8GNEk=; b=glBp4aDrsMgGiZp/Ifn7nuwz9//rfjWhiic76S5HfpEniM/b+WpubuJLIEJ3Y1LBed T3hSXXl+/w00HYl9BwB2OaA7zu7VzIkz9CGU6Qzxa7+o6Bpei+Dg/q9V5Z30DXBRrZ2g 16iNoBhsGzIsUcG1O7+VGhN59x7rw2LhGWpI3D7VwgA5f+DYuOGSdSHmV8g4KS2NbjmI SmTBt+ZdyejI/NdoJf/CWJkATbzflr6DpIqo+qYVj3WL+F3/G6oBtcY79mHxJ4ILT8j0 3DOXQnUJW1uHMLIkcSnK0dhezyhmImMEqMwBXk85bcASlv2zOl5m4slOanahcKA6R0Pc z32Q== X-Gm-Message-State: AJIora/iul0dmRFfWQx656x7u2OIiaXttKuKVtvss3qQAqJ0W5jlB0KI BdXWo7QsC2+VUVbCfDqo6Ib7yY3q9VF292rLLrVDDiioFCE= X-Google-Smtp-Source: AGRyM1siKTF+R6uwKfazYTe8Xg0CPDF5bbBzf4TfDdTqgC6WGqwqg8SFY/Ka4131n5yVpTRaPbDml7n64VDQF6Cj8L8= X-Received: by 2002:a17:90a:de15:b0:1df:63dd:9cfc with SMTP id m21-20020a17090ade1500b001df63dd9cfcmr2227079pjv.200.1655340036096; Wed, 15 Jun 2022 17:40:36 -0700 (PDT) MIME-Version: 1.0 References: <20220611022314.21593-1-linmiaohe@huawei.com> <8b34a515-e5fd-731a-4164-9080c275d4e9@google.com> <7c363619-4159-8a21-d55a-535e21b5c8b4@arm.com> In-Reply-To: <7c363619-4159-8a21-d55a-535e21b5c8b4@arm.com> From: Yang Shi Date: Wed, 15 Jun 2022 17:40:23 -0700 Message-ID: Subject: Re: [PATCH] mm/shmem.c: use helper transhuge_vma_enabled() To: Anshuman Khandual Cc: Hugh Dickins , Miaohe Lin , Andrew Morton , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655340037; a=rsa-sha256; cv=none; b=G9FIu7Rimk0Tba777oYrh1lHmYwnkQspRtUn9T5GcvXAbT+2NOxXsLoSuk7jk61+Duj8ZO W+vbCFgPTvd7p9urT0Amy5yEOy2NQ+gU+PnXZOyKrIOu4nwG//Eh276EgpdU+kpnGzU0Ol WMBQVlc5LAMfaza04lxYZUbRZpQnv74= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gURvnx+C; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of shy828301@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655340037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TcCZJRFbxoGfTo67jDtrqKzufdCi7UaSWExZ0v8GNEk=; b=knA8Btdgfldww+17pqFIPHJWhkO1m37dndj12jYRYg30M+z7DvaOmOtCA1tzU1fKCTf/qt 7YjzBFJ+XTsRmtQSCdCYzvtvfMjqM0RxvNTSaYVIT9g/DgmLJbxYHzRV+Utze2qshLSt8M CTqoHoLW/lfECoAryuI8AJ+/HWqBSAc= Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gURvnx+C; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of shy828301@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-Rspam-User: X-Stat-Signature: tutfj3jcormcp4wyza89p87n6hn6cn8g X-Rspamd-Queue-Id: 0FF29140080 X-Rspamd-Server: rspam08 X-HE-Tag: 1655340036-319311 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 14, 2022 at 10:02 PM Anshuman Khandual wrote: > > > > On 6/11/22 08:44, Hugh Dickins wrote: > > On Sat, 11 Jun 2022, Miaohe Lin wrote: > > > >> Use helper transhuge_vma_enabled() to check whether transhuge is enable > >> on vma. Minor readability improvement. > >> > >> Signed-off-by: Miaohe Lin > > > > No thanks, that's a readability regression, forcing reader > > to go and look up what transhuge_vma_enabled() actually means. > > > > What you call a helper, I call an obfuscator - as I implied in > > b9e2faaf6fa0 ("huge tmpfs: revert shmem's use of transhuge_vma_enabled()") > > The same reasoning should also be applicable for other calls sites > for transhuge_vma_enabled(). Should not they be dropped as well ? Yes, the only caller was hugepage_vma_check(). It was changed to open-code and the helper was removed by series: https://lore.kernel.org/linux-mm/20220615172926.546974-1-shy828301@gmail.com/T/#m7610c2a4e5dda753cbc850986d5486f59a821c1a > > > > > Hugh > > > >> --- > >> mm/shmem.c | 3 +-- > >> 1 file changed, 1 insertion(+), 2 deletions(-) > >> > >> diff --git a/mm/shmem.c b/mm/shmem.c > >> index 133c67057d41..59cc2e980c95 100644 > >> --- a/mm/shmem.c > >> +++ b/mm/shmem.c > >> @@ -480,8 +480,7 @@ bool shmem_is_huge(struct vm_area_struct *vma, > >> return false; > >> if (shmem_huge == SHMEM_HUGE_DENY) > >> return false; > >> - if (vma && ((vma->vm_flags & VM_NOHUGEPAGE) || > >> - test_bit(MMF_DISABLE_THP, &vma->vm_mm->flags))) > >> + if (vma && !transhuge_vma_enabled(vma, vma->vm_flags)) > >> return false; > >> if (shmem_huge == SHMEM_HUGE_FORCE) > >> return true; > >> -- > >> 2.23.0 > > >