From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5F2DC4338F for ; Wed, 18 Aug 2021 17:04:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 520686102A for ; Wed, 18 Aug 2021 17:04:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 520686102A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C15326B006C; Wed, 18 Aug 2021 13:04:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC54F6B0072; Wed, 18 Aug 2021 13:04:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB30F8D0001; Wed, 18 Aug 2021 13:04:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id 95CBD6B006C for ; Wed, 18 Aug 2021 13:04:56 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3D11580317AF for ; Wed, 18 Aug 2021 17:04:56 +0000 (UTC) X-FDA: 78488826192.20.382B700 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf15.hostedemail.com (Postfix) with ESMTP id 014A7D00620E for ; Wed, 18 Aug 2021 17:04:55 +0000 (UTC) Received: by mail-ej1-f54.google.com with SMTP id x11so6581637ejv.0 for ; Wed, 18 Aug 2021 10:04:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Si7U6HwgT/s1/0DUykgf8Mxxnbx+qV+oZXkcnS5dKHQ=; b=AChYjDKZR7xEN/R81QQ9I2hRsbNGAI7NqftHe4v8mPniSSGnl/OrNvA5bEeVQApm+O ibB1uQgvIRSxkzQx4SECL93cgAfhppiDnrNRpIl1zsFnwkqprUOkuVE5Z0bsNwqKy1DK AQpCFTY1JVxMWMxVOUFVrPpc/+axmg4D1Mp12sDjducva8Umbc439ZhN5lsokrQEfN+V wCjzQ268htspW9T9IGu5U9JiHo+mrVh/6a43zfQdeG2u+2zlni0wJ81QYsD/oM5TJ0tx LCAn5PA/Rl5fV175bfdLlDt3KCgvLpCyvpNcj5pFtAsB1cTNaA5If82yuAZE8eBRavgZ wdug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Si7U6HwgT/s1/0DUykgf8Mxxnbx+qV+oZXkcnS5dKHQ=; b=p5msTZ03wfV0aZETIV2Lq7VGgFq7V1Jwc1T8AVNDcUecYzu9bKKe5d9I2bD/dxuelF aNr6Y0ZeoCAPiCTGqT6TzIKK3LRShbYvDTtVPtHpVG4yrJLbg5/59u58HWUMMedvCyyI UWPnK1EOoeNLqwhwNxH41aL6gwvxfakiE98M+zt0Bfqx7hBdd9pzb/NSv598COCdhIcV lnWkKBGvzf9LSATr5tsnygiLMbeyCiwOGdD75RUluDdzk3zDfzBFB9l5ppTKUynEpJ7w Bofd2r5sFQdWvbigSM0usH+UTNfGSoCb9vLRWEjeRnL5qDHbCwZUpGPlBg1Bopfm1S7O qO+A== X-Gm-Message-State: AOAM531UsMeI2wHXb2VRpnXZ/mZsYLLN0QQYYbuLFAbDHJw+84iWCKEz eOUPHKFACP6mIpzIvhInWjalHuGz/X69AR/1EIk= X-Google-Smtp-Source: ABdhPJwsmFeTJicZf4gc/8UKoIhnK1UkHukA04WmnpY7zZI030kGbN9o3u27fYTEth+eye5/qhxeuEakJIo/vBLukbg= X-Received: by 2002:a17:906:b890:: with SMTP id hb16mr10503469ejb.383.1629306294582; Wed, 18 Aug 2021 10:04:54 -0700 (PDT) MIME-Version: 1.0 References: <20210816180909.3603-1-shy828301@gmail.com> <20210818063042.GA2310427@u2004> <20210818075316.GB501393@hori.linux.bs1.fc.nec.co.jp> In-Reply-To: From: Yang Shi Date: Wed, 18 Aug 2021 10:04:42 -0700 Message-ID: Subject: Re: [PATCH 1/2] mm: hwpoison: don't drop slab caches for offlining non-LRU page To: David Hildenbrand Cc: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Naoya Horiguchi , "osalvador@suse.de" , "tdmackey@twitter.com" , "akpm@linux-foundation.org" , "corbet@lwn.net" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=AChYjDKZ; spf=pass (imf15.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 014A7D00620E X-Stat-Signature: 9q1r6jku89zhpegzhffwm58nsnj9t1qk X-HE-Tag: 1629306295-709606 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 18, 2021 at 12:55 AM David Hildenbrand wrote= : > > On 18.08.21 09:53, HORIGUCHI NAOYA(=E5=A0=80=E5=8F=A3 =E7=9B=B4=E4=B9=9F)= wrote: > > On Wed, Aug 18, 2021 at 09:24:01AM +0200, David Hildenbrand wrote: > > ... > >> > >> Might we want to add a TODO in the code? We have a similar one in > >> mm/page_isolation.c:set_migratetype_isolate() and it's certainly a rem= inder > >> that something of value is missing. > > > > Yes, that will be helpful. The below's what's in my mind, but if someo= ne > > has better idea, that's fine. > > > > @@ -296,11 +296,9 @@ void shake_page(struct page *p, int access) > > } > > > > /* > > - * Only call shrink_node_slabs here (which would also shrink > > - * other caches) if access is not potentially fatal. > > + * TODO: Could shrink slab caches here if a lightweight range-bas= ed > > + * shrinker will be available. > > */ > > - if (access) > > - drop_slab_node(page_to_nid(p)); > > } > > EXPORT_SYMBOL_GPL(shake_page); > > Just what I had in mind, thanks! Fine to me, will add this in v2. > > > -- > Thanks, > > David / dhildenb > >