From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5326C433ED for ; Tue, 18 May 2021 17:03:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 30123610CD for ; Tue, 18 May 2021 17:03:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30123610CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 23CD86B0148; Tue, 18 May 2021 13:03:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1ECEB6B0149; Tue, 18 May 2021 13:03:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 066CA6B014A; Tue, 18 May 2021 13:03:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0116.hostedemail.com [216.40.44.116]) by kanga.kvack.org (Postfix) with ESMTP id C65CD6B0148 for ; Tue, 18 May 2021 13:03:43 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4B91A8249980 for ; Tue, 18 May 2021 17:03:43 +0000 (UTC) X-FDA: 78154973526.18.343E8D2 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf14.hostedemail.com (Postfix) with ESMTP id 9CC11C0001EA for ; Tue, 18 May 2021 17:03:39 +0000 (UTC) Received: by mail-ej1-f54.google.com with SMTP id l1so15696920ejb.6 for ; Tue, 18 May 2021 10:03:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+yKT9VRX5m+z9HWCRwmzqc/7Spel7DRB/8tz06yBbSc=; b=KgCzmRBnEk+FBeH4IXkbyazMgVuK6l+0wvBjyhuXjhDJ7nDNQ3FI46ylRTNZKU1uZ7 1kLWFo2614PuTeO9Wrcr7UMS1VoL6RBKw+qpZbR1noDv49O0VpyKVnrWYUHctBOwDWCv +4y1Czusp+Q1ifmvdwPID8oTFGKrE/N0y0ex+KFIoQnM257FoW1UhRk3FxEYwoxsPgIX 0kBXkdHkb62bjTMPfZBF/Enyw4Gxml6pUfjcBMyCosPZXNW4lwWzkxdNV4za7Q2OnppY e6ne4A6TO0ZFMKm/ECelG8Oz+JUZSxva4cuqrzgggtjN8+kjV08owqQRsNT+RqeLHefR JW5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+yKT9VRX5m+z9HWCRwmzqc/7Spel7DRB/8tz06yBbSc=; b=cEdMaUIrEZSSzdNIPM1ePZxPe+ocGyNdomfnC/AlRJR7OvdcvIFExVXPNEbZQtQH89 nsIT0dtoKQHu69pGTAzEjvx0qP7c2nuxYnpJ2eUWa/HDR753zgiObIJ8E+BZE3wv+Sf1 606LPWU9BxxIUOx8BYWpHOGou84BRo8Q3l7X+Num1TKIoOsgXWsXk/XSdCbiY6FWBmnm leoL+jhSfdWvGglgpPO1T+Xo2iQHliBea/GTSByu2Yj5tudWVpXv0MtDQyJH1aW3d64v FKwV3TqdLzKvrvs4xiKVNYkYRbrW7k8NqIQxyo1BdY5XpplVN1tfklB9jOHvCE+/8J3W 5sOw== X-Gm-Message-State: AOAM532Voc93rq4GMcTSc+SSEF6mCA3XY9XMKv1pEId6CJf5EhLTKnLD 7qYcx4M1Dlv8e6mY4yoXATpvRO1Hdcv002ro2/4= X-Google-Smtp-Source: ABdhPJzvL/IaT6iWafLi67GSHjDYC6UUb2ja6gBkTR6vrY4J/BK5CM3tIxcEchXu/+KE/IPW7IAND/9aPimaLl3YkUw= X-Received: by 2002:a17:906:b7d6:: with SMTP id fy22mr6849660ejb.383.1621357421618; Tue, 18 May 2021 10:03:41 -0700 (PDT) MIME-Version: 1.0 References: <20210413212416.3273-1-shy828301@gmail.com> <20210413212416.3273-2-shy828301@gmail.com> <20210517150922.GU3672@suse.de> <20210518073618.GA3672@suse.de> In-Reply-To: <20210518073618.GA3672@suse.de> From: Yang Shi Date: Tue, 18 May 2021 10:03:30 -0700 Message-ID: Subject: Re: [v2 PATCH 1/7] mm: memory: add orig_pmd to struct vm_fault To: Mel Gorman Cc: "Kirill A. Shutemov" , Zi Yan , Michal Hocko , Huang Ying , Hugh Dickins , Gerald Schaefer , hca@linux.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com, Andrew Morton , Linux MM , linux-s390@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=KgCzmRBn; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9CC11C0001EA X-Stat-Signature: ws1gdr38hngwdjwgh713ibn45r63oedb X-HE-Tag: 1621357419-714987 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 18, 2021 at 12:36 AM Mel Gorman wrote: > > On Mon, May 17, 2021 at 12:39:49PM -0700, Yang Shi wrote: > > On Mon, May 17, 2021 at 8:09 AM Mel Gorman wrote: > > > > > > On Tue, Apr 13, 2021 at 02:24:10PM -0700, Yang Shi wrote: > > > > Add orig_pmd to struct vm_fault so the "orig_pmd" parameter used by huge page > > > > fault could be removed, just like its PTE counterpart does. > > > > > > > > Signed-off-by: Yang Shi > > > > > > > > > > > > > > > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > > > index 25b9041f9925..9c5856f8cc81 100644 > > > > --- a/include/linux/mm.h > > > > +++ b/include/linux/mm.h > > > > @@ -547,6 +547,9 @@ struct vm_fault { > > > > * the 'address' > > > > */ > > > > pte_t orig_pte; /* Value of PTE at the time of fault */ > > > > + pmd_t orig_pmd; /* Value of PMD at the time of fault, > > > > + * used by PMD fault only. > > > > + */ > > > > > > > > struct page *cow_page; /* Page handler may use for COW fault */ > > > > struct page *page; /* ->fault handlers should return a > > > > > > Could this be a union? > > > > Do you mean orig_pte and orig_pmd, or cow_page and page? > > orig_pte and orig_pmd given that one for PTE faults and one is for PMD > faults and it's very unlikely they would both need to be considered during > a single fault. Yes, agreed. > > -- > Mel Gorman > SUSE Labs