From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2041C47077 for ; Tue, 16 Jan 2024 20:57:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 462DB6B00A1; Tue, 16 Jan 2024 15:57:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4139E6B00A2; Tue, 16 Jan 2024 15:57:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 302CC6B00A3; Tue, 16 Jan 2024 15:57:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1DBE36B00A1 for ; Tue, 16 Jan 2024 15:57:57 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1C850C06AA for ; Tue, 16 Jan 2024 20:57:56 +0000 (UTC) X-FDA: 81686386152.21.750D76B Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf03.hostedemail.com (Postfix) with ESMTP id 4FF022000C for ; Tue, 16 Jan 2024 20:57:54 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="e/cc0gH0"; spf=pass (imf03.hostedemail.com: domain of shy828301@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705438674; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G/EZzmK6HfHQLA68MEdpLWPQjpi5m5+fEzjurqyk7MQ=; b=BK7BM8gadbMfzx0E+WAjFHMzsb6DhhnYUYa/VEvvnHqdJ8gLMSXrvUi0Iludn2f3RmF2V/ NhIY+mNwJOIuRr5AEqOxtaKyRZzoOv/RZOsUwcV4CFK8hWlAeHlO6Y8V+sfPTNDEa72VGt yUOnc/2+yZNEt0q/c4GRKNteQx2LBR8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705438674; a=rsa-sha256; cv=none; b=juWPHTmYxcN5RzMYLoiyqQ767bVg4In3dlJtYeuNEhQH3ejUoqft9YrZWH7mO4KZs6efFH sH1OK8mICLOalGEfsCJvG1EjnICcM7tWJyJf+pHfKYstffTPPncYimpQnYYKPWNLJ9xJcH gGXIfrZfa7qCDHyHaNSOBZaxPgVlCng= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="e/cc0gH0"; spf=pass (imf03.hostedemail.com: domain of shy828301@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-28e75ee994cso865197a91.1 for ; Tue, 16 Jan 2024 12:57:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705438673; x=1706043473; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=G/EZzmK6HfHQLA68MEdpLWPQjpi5m5+fEzjurqyk7MQ=; b=e/cc0gH0g4zYkmrXdi2leVMoRbjrkKMkYH0/E/oUUp4gQpzkiUhtqlADYLxB6Z8BQ2 PerG5lRZfJIn+EvLpEf4RuA2LptgH+eYRIeNcKzQrvOJ4RbOPAu4hDKHvwwgAqls5x3g dUQvG2y1HtE5TQSGvkL1LiEZMEUPsJ/uv4Iqqx1B8VXv+stwJzF/Cps2xwNCeTqwn/CA +V1K8tlgssBddM8E+9ix5FinjKuAVRVvgG4vboMX3jz5MK1kMd00o0Sphn6GvrQ3JyD4 x4i0Lh80RQ6++EY/p9otyiFmMxRB0Wefv3K+Q4fFNsk4jiwPRNozUcwrIpk4gSvGo5q4 vmbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705438673; x=1706043473; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G/EZzmK6HfHQLA68MEdpLWPQjpi5m5+fEzjurqyk7MQ=; b=wzrb5JBykC6oklnGUTY7EkMkrNOEOxbIojsu8H6aDCmB7K5rCaV5Hzc0c9UIEF8yEh MQDRsrGgbu02DVpHnNzGVcr9+oIyfRTr1viQ8x8Y4nlGKhFHx7pYgmbrouqsWTeo/3Q/ NZgQmoO9GG0wPwxpr9XEQgngp9imY0tNMlergrkMku2jPEsYPdMWzGk/RKdX/95EG0gH MON9X7kymp4d1CmA7BQsKkwmzFqWYHKsNiZa9bp41kLZfeQQ2fx2W3GdMJEEgtvY0xJL t9x22WEoDPOfWksp3UZYk+/aCv1AI1QfaiCn+KoBs3meJETqjr/sUVdaeLVy+y7ry/S2 by+g== X-Gm-Message-State: AOJu0YxB/S9T932cF+yhba4fqKOO0lhA7u3s5htuKsiH/Tw43kVGOJZC iBrHAk6KcTLTVH6ihmYJLwvpGiFQTAE7ta1Z3Zg= X-Google-Smtp-Source: AGHT+IGciLCO/ufPtmnqCC3a0V4mBdZDL05fQwHfzJlaDGT2mgEqh8UsQIVb9NU946JH1W05lXyphPZYeKh7zUb9O8k= X-Received: by 2002:a17:90b:690:b0:28d:f01a:1abd with SMTP id m16-20020a17090b069000b0028df01a1abdmr10062825pjz.14.1705438673199; Tue, 16 Jan 2024 12:57:53 -0800 (PST) MIME-Version: 1.0 References: <20231221065943.2803551-1-shy828301@gmail.com> <20231221065943.2803551-2-shy828301@gmail.com> <7433e325-9af7-4b8c-888e-07a0debf8e46@intel.com> In-Reply-To: From: Yang Shi Date: Tue, 16 Jan 2024 12:57:41 -0800 Message-ID: Subject: Re: [PATCH 2/2] mm: mmap: map MAP_STACK to VM_NOHUGEPAGE To: "Zach O'Keefe" Cc: Yin Fengwei , oliver.sang@intel.com, riel@surriel.com, willy@infradead.org, cl@linux.com, ying.huang@intel.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4FF022000C X-Rspam-User: X-Stat-Signature: suqk3dkq8dujyppt8cfztcftbpzy9u6s X-Rspamd-Server: rspam03 X-HE-Tag: 1705438674-728123 X-HE-Meta: U2FsdGVkX19weOCVBiohKRSBftXvFQ1QonA7NsYvzPquRO/zSqRYyiW7h8JUKiDIxpJHAYxURjEGCZ/oNc69tdhbiYlPTGx6KWdlaTygCzi0MfMD5ioGCzcYhDPDGLopEJxsBTMvrVKz7Yfcy7PNdp19Zc9UOQwHHGN5sQN9uuiYecU9Rjw3ZoeuKIhIHYaL6nBwJt1UVXC2BsP0ihG2VQsUkoNZvsmSvfjFPanY9ILnlPuVVtbInQWb1CC7nD3MCZC+i+7lkzGm9iMBF0T7vnlTIOQjiC64Qh8ZrG9gfgyX46CyeVaThZVVuh6wLqJUsihXrj76iP5bJfHx4TpDV5m67l4TdH0WcaZ4OLgv3PPk4M7THsToZYBGTbFa90g2JRy/3SSVnNz0zuNULDk87F6BFyNi2lEcFmY7FPhfK/i58rtzmxisAcCOudk7PEdcQeOR6Du/smJIPyLcbHI6o3IYlY23fzGZmNhyLvgjwJM3GhCwnFXsdMezzL0VrrTCD6in3IW09CYdBAE39xDvV8Ijz5Z48tLnzYeTVlHD3XDLeoMPgTwicSYgHstm5FnsthzO19eLDbVC3/Eyr0q8I56Ev5ZH7on6pQEpKbQGd+1RxUVoHW0TtSD3Y1gz571Tg1hcsM3s/sZv2saVQYNwV5GidE1TgbYciyWGMpHspTLcNp39yIbCIuzQkPnk8f3tTJOAbuyGOUfyWZHHmmuagzvA1o3DUyhp30QAaQKIjxc9a8h3MOachAf5nm7RDvm9ueaJSKwwPb6fA00yQoJs/Szg9vHDr4uJofDjpWcFpQzXIf1Aekwr302GtSDxgDYKm/F+msm3JTh7XDCPCaEfEktiVNhiQGL2BPFjl6/M8PTtk2E3VxnKrJrar16fRSZDKyGBKEC5Xir6knTHvvSzlBRbRKKfIL20tYg9FRYTm3uPgeKw/SLn8gdOzQ/UR1+GNh7RWsloWQY0GF0hHVX ChBQ5OWi RI2CVV3f4bzwlOzsH9wQo5T3gHgOqpPZbXTQMSnf4rVmEO9U6WlM6l//+qbJ9yJ7xhsY9/qt1pGW54bmm65HnO9+80RuXbeW//xD/+yYDo4jLML7u9QcCRXIbHxbP3CbNSABtvt0U8quO78OjeqdaQ3Sk4ML3Y1LHTKV1vJGlWXHZXm/HkeT+S6NRRM5ITyO02C/Q2ujCrg/OYw/hhkBgnFSbxE3XhpJDR6SMYy1ZUSbMmMYIAshfl7pYOqr2w/A8CcyZahkOe1dP1E8fsTx1PbIF77XJzm0wnogy06GJBRy1AjQR/fmZsO8WNipM4M2QwJbfyBs4LWpsQgOpyaXWMgooRItb2nG6eeD4pcVFSv+VRFAp9VWwT87COujFTC7RxE9c5+vB0/GKI5nVKOu0bnCpjP7akJXtgvGiYh6z+l6i+4c8Vfg9VcEijXFShKefkefkuhH8R3TwV25BnZlw17OrWczbK5/LJmDtWb7LzWzU6TOWjTFhdxtw8/PGepfxT+RkULKahYr5iLWWwurG374w2A9fhWeCRSN0xVtLvtj5aBjfp1NAAJuUKHrfQZIfdfCd30QTvSW6zK/9s1jbstgtiY9zVGPYTUs4e7iDf2E8CnbAHz05e8pb30pUUc3Qmk+UwNNA/gQY293nPeKxNxt121tBIlz+H63UKPJABH5KbWA2uidVbET2I+mjbQSF4kQrclVrVGV0T9aXRM8F0Szo6d+4MAmqojiRbGC/kfINhwg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 16, 2024 at 11:22=E2=80=AFAM Zach O'Keefe = wrote: > > Thanks Yang, > > Should this be marked for stable? Given how easily it is for pthreads > to allocate hugepages w/o this change, it can easily cause memory > bloat on larger systems and/or users with high thread counts. I don't > think that will be welcomed, and seems odd that just 6.7 should suffer > this. Thanks for the suggestion, fine to me. > > Thanks, > Zach > > On Tue, Jan 9, 2024 at 5:36=E2=80=AFPM Yin Fengwei wrote: > > > > > > > > On 2023/12/21 14:59, Yang Shi wrote: > > > From: Yang Shi > > > > > > The commit efa7df3e3bb5 ("mm: align larger anonymous mappings on THP > > > boundaries") incured regression for stress-ng pthread benchmark [1]. > > > It is because THP get allocated to pthread's stack area much more pos= sible > > > than before. Pthread's stack area is allocated by mmap without VM_GR= OWSDOWN > > > or VM_GROWSUP flag, so kernel can't tell whether it is a stack area o= r not. > > > > > > The MAP_STACK flag is used to mark the stack area, but it is a no-op = on > > > Linux. Mapping MAP_STACK to VM_NOHUGEPAGE to prevent from allocating > > > THP for such stack area. > > > > > > With this change the stack area looks like: > > > > > > fffd18e10000-fffd19610000 rw-p 00000000 00:00 0 > > > Size: 8192 kB > > > KernelPageSize: 4 kB > > > MMUPageSize: 4 kB > > > Rss: 12 kB > > > Pss: 12 kB > > > Pss_Dirty: 12 kB > > > Shared_Clean: 0 kB > > > Shared_Dirty: 0 kB > > > Private_Clean: 0 kB > > > Private_Dirty: 12 kB > > > Referenced: 12 kB > > > Anonymous: 12 kB > > > KSM: 0 kB > > > LazyFree: 0 kB > > > AnonHugePages: 0 kB > > > ShmemPmdMapped: 0 kB > > > FilePmdMapped: 0 kB > > > Shared_Hugetlb: 0 kB > > > Private_Hugetlb: 0 kB > > > Swap: 0 kB > > > SwapPss: 0 kB > > > Locked: 0 kB > > > THPeligible: 0 > > > VmFlags: rd wr mr mw me ac nh > > > > > > The "nh" flag is set. > > > > > > [1] https://lore.kernel.org/linux-mm/202312192310.56367035-oliver.san= g@intel.com/ > > > > > > Reported-by: kernel test robot > > > Tested-by: Oliver Sang > > > Cc: Yin Fengwei > > > Cc: Rik van Riel > > > Cc: Matthew Wilcox > > > Cc: Christopher Lameter > > > Cc: Huang, Ying > > > Signed-off-by: Yang Shi > > > > Reviewed-by: Yin Fengwei > > > > > --- > > > include/linux/mman.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/include/linux/mman.h b/include/linux/mman.h > > > index 40d94411d492..dc7048824be8 100644 > > > --- a/include/linux/mman.h > > > +++ b/include/linux/mman.h > > > @@ -156,6 +156,7 @@ calc_vm_flag_bits(unsigned long flags) > > > return _calc_vm_trans(flags, MAP_GROWSDOWN, VM_GROWSDOWN ) | > > > _calc_vm_trans(flags, MAP_LOCKED, VM_LOCKED ) | > > > _calc_vm_trans(flags, MAP_SYNC, VM_SYNC ) | > > > + _calc_vm_trans(flags, MAP_STACK, VM_NOHUGEPAGE) | > > > arch_calc_vm_flag_bits(flags); > > > } > > > > >