From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5153D3E2A1 for ; Mon, 28 Oct 2024 18:38:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F7BC8D0001; Mon, 28 Oct 2024 14:38:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 231286B009D; Mon, 28 Oct 2024 14:38:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F7488D0001; Mon, 28 Oct 2024 14:38:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E8E206B0092 for ; Mon, 28 Oct 2024 14:38:02 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AF17C40DA7 for ; Mon, 28 Oct 2024 18:38:02 +0000 (UTC) X-FDA: 82723869942.18.F48922F Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf07.hostedemail.com (Postfix) with ESMTP id 0015B40019 for ; Mon, 28 Oct 2024 18:37:27 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Ou/OZ4ej"; spf=pass (imf07.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730140470; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6mCmmrBqrwBBNHAYFi5nvtCwYkQdKfmKUY6CuxD0pIc=; b=PJofsqqOpES0Ln9eSPIVKADfNmzJzNnF60dJtvBxQc7GyB8gwQq432sjc+HyIJsCsonbmS 8qIqFKEuWcNNc9U1epxfKvhXYyohL/kg2Nh+ui2hQqXZcCgTeg64pJdZGM06SdGflwie6w qVgFcfecI1LQ2gtAsCcFqNXJCa77KtE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="Ou/OZ4ej"; spf=pass (imf07.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730140470; a=rsa-sha256; cv=none; b=wbtcQeVZptmDYgWuI2ogT+oRhxYt96qDoEIpLNsu1dkEsKyHFJRq4lFongRq1bFkEpMv2f 38lPmVY4FDUqjaKi3m/vsvXV2eCKhPBDNZf1wG0hW7ny4pjn7MvEO8dTDxI/au6bntdINe Q0egUEw/6skaLwBskooZzFwZVGJiyT0= Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2fb388e64b0so44961741fa.0 for ; Mon, 28 Oct 2024 11:38:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730140679; x=1730745479; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6mCmmrBqrwBBNHAYFi5nvtCwYkQdKfmKUY6CuxD0pIc=; b=Ou/OZ4ejLmxz9Wd6wEeWo+m6AF7j+p7MmZFE8WKRF0J3jP/nV9UjQ6GEhn7Swcubtj hzkLHguas5FXURngzYESNtNDDF00WgOb7RQdnoE4kQhzB+qZKAxj5dDYj+kIrZZ9ZLa1 H8BUTuv7nfAl4BWnjFr6bgjh67iNVxC1fi5bzX9g1SoiGJrN1nanou1cIsYH6DYLlm7g EtFMGwUwXq2VGRBJTX8msTB+YMhTF6si25+qDBDfzSfqQushqBJ2Krwr9t0qxH05293q j7gA5OIcKm339p6roagArIjR/jbaIWxwhqjLxoOZVO0zF+YEpw4W7xomDOA/rFgLQf8n eO9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730140679; x=1730745479; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6mCmmrBqrwBBNHAYFi5nvtCwYkQdKfmKUY6CuxD0pIc=; b=ItD3DRrb0+nW/a6aOt0a9h0/HkmFWkPyl23Z0bEA+tDbrVXE/vU2sPQuzU/5I7e3z0 m6/Wdx2evMdY4NVqkX/vfhy8QhqffEVS3dfqsb7tPI0r+8/+SLUrkGBoP0G9hmmBn6yJ aICwSRhVhoqa7nkPcYOgnzoDhIP/8YuqgoMeblchtEtLLJki5wjGv+FprC+t67p3Zp3R NAVJiFBLip/kJ7FPjvUSoKZMaKubKRJ1A1sBJ61BVazWWmv3XM7+/wexo5B1dqdVV+/N Abq4m4RQ4FWS0nniRRbeMZi1eGWeZIC+p3r6qW60KgD/3HwcVronxQdGTLh+LRC7hJhy I+4A== X-Forwarded-Encrypted: i=1; AJvYcCX7uQFqeU4MNTDV4WRIvFgo7dVttjfddjW/NcRwJeq0elUV68goXRlhNlPGyaSwOC8LZeutCRmZxQ==@kvack.org X-Gm-Message-State: AOJu0YzLBFMQZR8SAWYSftQ7yLFOd+8ZIgqSjcL13lW9SQP13X7jCaRI cHfgTMOuAC1h1iN2kSEoLsqDRbC5L/QcvA+kg+WDv7xs1ZRG9BOmUc4m7T9yccKapOLu1x3eBOJ oflJFyGlCo/wCTDMdcOeY6mBYwqk= X-Google-Smtp-Source: AGHT+IGj9vDsgFF7Rl8j8yeOh9b8zyNZNy8GvabiZtXorwUqfIqcxNgE+yeFuonlz9qIHRk/d8tczdt7WFJYEdw6ywo= X-Received: by 2002:a2e:80a:0:b0:2fb:8df2:13eb with SMTP id 38308e7fff4ca-2fcbe063702mr33376021fa.36.1730140678504; Mon, 28 Oct 2024 11:37:58 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yang Shi Date: Mon, 28 Oct 2024 11:37:46 -0700 Message-ID: Subject: Re: [PATCH] mm: delete the unused put_pages_list() To: Hugh Dickins Cc: Andrew Morton , Pasha Tatashin , Matthew Wilcox , David Hildenbrand , Peter Xu , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0015B40019 X-Stat-Signature: 4qkau57y638he47umt8mth3jtxhwes59 X-Rspam-User: X-HE-Tag: 1730140647-585397 X-HE-Meta: U2FsdGVkX1+8yBKnly0wo76xUz0T0sIYx23pugAMuEm76x9WhKpok20PN1m7UGI0V3m4Pm0lCBjfNoiViKkvo9Nyzz14n45VijSConZgXBThpurBLZsjB2hWgPm5hkVZ8A/12IOWpE3qQNW2dNS38FAPLwoU7qA6MbPFWH5vvqdMRxdPI4wR3voZQTm2KtVzr7qgbBKLAhODHuxCSL9/MFeMJIKEPnDTQwogr9Z/nbXe8GukNE+4IaVDayojQcvAQ0706Sex0Za0b2hhUZxQO/V2IC/q7xfhBcsKnOrtjwuSWu79kCzU/Zc7RLRrM5heGxs4uCUpPvl0L3gSxdkUPTIedB8H5lOe6WWenzTbB4uPKEqPsb4NTQKF+c6bdrd8FKNppPVhbxCgg7QJCcfeEH9XP8/4k++68pzZR3KzSR7qnyaWEBoTAesB04tKKGqlDZzJDXHP+oytrct+RRZZLafUiaW168IYu4Jd7SdA7pNGN3rTAYboCWNKh3N0wx8N/qVtOJKO5JH6ikUKoKAHf6wLDbn/Vh4Fg36wPNQejpimpNWFmsphccHVM09Sk1eTFXoq1V8mPch7Ql+i4XUNw2btndB/1Q9SLTZRiXQu/gVcATLbAlTtuD2TYR5chK3ukPSlUC/XOUFROl9bboNtdKjpezJjmWZNMpPwQ8AkQcv89qmjRZ5xZ7bKHCvgInoHFAWWatb8ON5ImYEkrpNJxrJy85iPWF+7nkFUR7x37KKeZhs91RoNDuKim0vUuYqPzQDgYI6RlJGT6X0pXQ9XeQRHzH4ybg8nyD73Q38ZhRaxvzdhT5prnlpHFF6E1/lMPzp+zi34F3/RDbtJV0IZVr2DtrHFmLlQqXEWkgvjN/dgNGS7M8dDeVZzTxj1ScNUz7iqciEkd363Dd+D1RdKstya2kStdPBOsaj155Y86wmV53Ug4ebCTSc93jxQ+cj5tBN4pKg1FDTgS9CRfA2 DT2Kh9Ui w1v8IMk1Ly1GQ+DzMl0zJrH/S75021ysumSovc0aEfzeksG59s1aToGoBy7/5ZIGnCAs02Zoo4O1jqZP6ObhX/ounoaE6NramSBBsz+X4ptDx2M+vdBmw7wEyvFHVf4OmeBZCe0MG6vfeaEuatLKDXDMhhodaSaP5yR7l99gH9tS4sSpXLdHN+a6RGojhz0jRd17alfUIoBUd0SyFR/4LZFElukGd42Kv24s1y1MUltkXJkjJ2G/xMZdYrYExQSJD8qu7D5rF3AHPgIs9jZpi5eKxzYDqKn+0x81P46BIgUIpaCWcCdGqRE7Hf1iZzOAecoHLdl2w/55RzPq60a+H64h5mI1idW8YLnRKPPm2nm6/o9mHlOm43X5u2i7Eo+m3BuTTadrBjzheoauSaWwsFL2YTs4wBsQkYBq+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Oct 27, 2024 at 1:15=E2=80=AFPM Hugh Dickins wro= te: > > The last user of put_pages_list() converted away from it in 6.10 commit > 06c375053cef ("iommu/vt-d: add wrapper functions for page allocations"): > delete put_pages_list(). > > Signed-off-by: Hugh Dickins Reviewed-by: Yang Shi > --- > include/linux/mm.h | 2 -- > mm/swap.c | 31 ------------------------------- > 2 files changed, 33 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index ecf63d2b0582..8524bf86dd74 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1286,8 +1286,6 @@ static inline struct folio *virt_to_folio(const voi= d *x) > > void __folio_put(struct folio *folio); > > -void put_pages_list(struct list_head *pages); > - > void split_page(struct page *page, unsigned int order); > void folio_copy(struct folio *dst, struct folio *src); > int folio_mc_copy(struct folio *dst, struct folio *src); > diff --git a/mm/swap.c b/mm/swap.c > index b8e3259ea2c4..638a3f001676 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -127,37 +127,6 @@ void __folio_put(struct folio *folio) > } > EXPORT_SYMBOL(__folio_put); > > -/** > - * put_pages_list() - release a list of pages > - * @pages: list of pages threaded on page->lru > - * > - * Release a list of pages which are strung together on page.lru. > - */ > -void put_pages_list(struct list_head *pages) > -{ > - struct folio_batch fbatch; > - struct folio *folio, *next; > - > - folio_batch_init(&fbatch); > - list_for_each_entry_safe(folio, next, pages, lru) { > - if (!folio_put_testzero(folio)) > - continue; > - if (folio_test_hugetlb(folio)) { > - free_huge_folio(folio); > - continue; > - } > - /* LRU flag must be clear because it's passed using the l= ru */ > - if (folio_batch_add(&fbatch, folio) > 0) > - continue; > - free_unref_folios(&fbatch); > - } > - > - if (fbatch.nr) > - free_unref_folios(&fbatch); > - INIT_LIST_HEAD(pages); > -} > -EXPORT_SYMBOL(put_pages_list); > - > typedef void (*move_fn_t)(struct lruvec *lruvec, struct folio *folio); > > static void lru_add(struct lruvec *lruvec, struct folio *folio) > -- > 2.35.3