From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE0B1C43334 for ; Wed, 15 Jun 2022 17:53:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4481F6B0072; Wed, 15 Jun 2022 13:53:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F7ED6B0074; Wed, 15 Jun 2022 13:53:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 298C86B0075; Wed, 15 Jun 2022 13:53:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1B7B76B0072 for ; Wed, 15 Jun 2022 13:53:50 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E0955349FA for ; Wed, 15 Jun 2022 17:53:49 +0000 (UTC) X-FDA: 79581218178.23.E384B71 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf17.hostedemail.com (Postfix) with ESMTP id 1619640003 for ; Wed, 15 Jun 2022 17:53:48 +0000 (UTC) Received: by mail-pl1-f180.google.com with SMTP id y6so68796plg.0 for ; Wed, 15 Jun 2022 10:53:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7490IR4u02XQR5Rx7eoe3R4qdOLni9htSGuUTdPLVYA=; b=KEHOZIsr6INrHpmLs6MZXeDUYYHY5HNCqRxG73Sz35/4gussDzCfuA8qC4mRSt2T7l DCyWH1tXqBXL9xls0S1CUuBnBuTFQl94uw8VYX4sp8DqBs1/LNJK4snKvrAwZcQALw0B SZUpmdgm6YQTwtHKzfGs7GV8//2YR5wyOCyNBlK34b9gchnZIO9E9FsXClR7YZ2WzM2k pkIaPoKdXz9iTmCS5VFCzRPsjGQALQrvGcY3i0frCGeOsfOFvMfMpxSUiAQzvns5lrpz qh5wdbokPBfdKu4kHt8kxaqMYGUxsgN5q2OHdttc+Q2lOFnM53/KPUCzLX14G7n5H3Rf 1tpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7490IR4u02XQR5Rx7eoe3R4qdOLni9htSGuUTdPLVYA=; b=CttuZ/o5LsSx3x/w8svZbxx+mEmd9BEtVGShm1fg51+uc1G2tetbzykNoZOSNWa8Gx ssMCA5uBnjO6D8gvGaJtZ0m1m6j8DsRCx9M90XuZU2vVnK9uAhfH1RRs7GVIj/0N1Ndl y2CrA3CjnqwT0v80FCs77OCtUXsx2HVsAHcNVTkRuwKKIEBxp0oecz6nQ34dYrRK4S4V zqKUHpsRarDw0qmoLOqtWkB3Po2CaUgHIhPfFjOTTnMwkTfjcgu/57p+Ycr3T4MIFn1d INzTeUt0uiG9mwO5Bxrs5o7Y+PT5CROnLk63raHjKN0ZgAk09IQHaa48A5NPQLaDEfCC a6VA== X-Gm-Message-State: AJIora8V3CLrJMpXhoH68WzT+vOVttTBBIoW0ZHzamgYqK0dHSH6cxA2 tAKmO5drC4EMh2YjBkpznmOL9R2Om9ovHhf4et4= X-Google-Smtp-Source: AGRyM1vPqbItoG7qZmRwvuecyIl7+jw3KNUfRZn6FWYRHajhbjya+hjZ9ZKi7WlcFjdgLC7Zd0Df81bUgvk9NSfonhs= X-Received: by 2002:a17:902:8492:b0:167:6cbf:145b with SMTP id c18-20020a170902849200b001676cbf145bmr953726plo.26.1655315628118; Wed, 15 Jun 2022 10:53:48 -0700 (PDT) MIME-Version: 1.0 References: <20220611084731.55155-1-linmiaohe@huawei.com> <20220611084731.55155-4-linmiaohe@huawei.com> In-Reply-To: <20220611084731.55155-4-linmiaohe@huawei.com> From: Yang Shi Date: Wed, 15 Jun 2022 10:53:36 -0700 Message-ID: Subject: Re: [PATCH 3/7] mm/khugepaged: trivial typo and codestyle cleanup To: Miaohe Lin Cc: Andrew Morton , Andrea Arcangeli , Matthew Wilcox , Vlastimil Babka , David Howells , NeilBrown , Alistair Popple , David Hildenbrand , Suren Baghdasaryan , Peter Xu , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655315629; a=rsa-sha256; cv=none; b=YfciBtWZmUena9aQjNLmMlRgts/DST2Dsv1PMhLW4gDmwfVg4YEyQ+4H+WWqcQxSZf83ic A1WgyjEJ49xYer72l8xNnThCAYrKq9yA3LVbi2RvoEDBQ++SMX5tyfzX0YJzGFNCzUPTsR 4GvUgI1AdS3sXwioUo6NZEw7IeqCwDo= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KEHOZIsr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of shy828301@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655315629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7490IR4u02XQR5Rx7eoe3R4qdOLni9htSGuUTdPLVYA=; b=rdMILMS3ulgm4XfUgl6ayJzymWyornosRTUlOZjrpnRsBlraMAEns2nKAkDw2xSbiiwCH0 wLSELwsS6/WOiU+DEu3WrYPBonuaMRP2Uy3GSXDNNf4xIwkMBleO0RCkORqhl8dEtF8xki lWhM2V49ng6TE8Dop6sduaS3KJXqTyk= X-Rspamd-Queue-Id: 1619640003 X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KEHOZIsr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of shy828301@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-Rspamd-Server: rspam06 X-Stat-Signature: n4u9b7hqy5dsf9wrfqxyd7jmcpbrczgn X-HE-Tag: 1655315628-846091 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 11, 2022 at 1:47 AM Miaohe Lin wrote: > > Fix some typos and tweak the code to meet codestyle. No functional > change intended. > > Signed-off-by: Miaohe Lin Reviewed-by: Yang Shi > --- > mm/khugepaged.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index a8adb2d1e9c6..1b5dd3820eac 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -260,7 +260,7 @@ static ssize_t khugepaged_max_ptes_none_store(struct kobject *kobj, > unsigned long max_ptes_none; > > err = kstrtoul(buf, 10, &max_ptes_none); > - if (err || max_ptes_none > HPAGE_PMD_NR-1) > + if (err || max_ptes_none > HPAGE_PMD_NR - 1) > return -EINVAL; > > khugepaged_max_ptes_none = max_ptes_none; > @@ -286,7 +286,7 @@ static ssize_t khugepaged_max_ptes_swap_store(struct kobject *kobj, > unsigned long max_ptes_swap; > > err = kstrtoul(buf, 10, &max_ptes_swap); > - if (err || max_ptes_swap > HPAGE_PMD_NR-1) > + if (err || max_ptes_swap > HPAGE_PMD_NR - 1) > return -EINVAL; > > khugepaged_max_ptes_swap = max_ptes_swap; > @@ -313,7 +313,7 @@ static ssize_t khugepaged_max_ptes_shared_store(struct kobject *kobj, > unsigned long max_ptes_shared; > > err = kstrtoul(buf, 10, &max_ptes_shared); > - if (err || max_ptes_shared > HPAGE_PMD_NR-1) > + if (err || max_ptes_shared > HPAGE_PMD_NR - 1) > return -EINVAL; > > khugepaged_max_ptes_shared = max_ptes_shared; > @@ -599,7 +599,7 @@ static int __collapse_huge_page_isolate(struct vm_area_struct *vma, > int none_or_zero = 0, shared = 0, result = 0, referenced = 0; > bool writable = false; > > - for (_pte = pte; _pte < pte+HPAGE_PMD_NR; > + for (_pte = pte; _pte < pte + HPAGE_PMD_NR; > _pte++, address += PAGE_SIZE) { > pte_t pteval = *_pte; > if (pte_none(pteval) || (pte_present(pteval) && > @@ -1216,7 +1216,7 @@ static int khugepaged_scan_pmd(struct mm_struct *mm, > > memset(khugepaged_node_load, 0, sizeof(khugepaged_node_load)); > pte = pte_offset_map_lock(mm, pmd, address, &ptl); > - for (_address = address, _pte = pte; _pte < pte+HPAGE_PMD_NR; > + for (_address = address, _pte = pte; _pte < pte + HPAGE_PMD_NR; > _pte++, _address += PAGE_SIZE) { > pte_t pteval = *_pte; > if (is_swap_pte(pteval)) { > @@ -1306,7 +1306,7 @@ static int khugepaged_scan_pmd(struct mm_struct *mm, > /* > * Check if the page has any GUP (or other external) pins. > * > - * Here the check is racy it may see totmal_mapcount > refcount > + * Here the check is racy it may see total_mapcount > refcount > * in some cases. > * For example, one process with one forked child process. > * The parent has the PMD split due to MADV_DONTNEED, then > @@ -1557,7 +1557,7 @@ static void retract_page_tables(struct address_space *mapping, pgoff_t pgoff) > * mmap_write_lock(mm) as PMD-mapping is likely to be split > * later. > * > - * Not that vma->anon_vma check is racy: it can be set up after > + * Note that vma->anon_vma check is racy: it can be set up after > * the check but before we took mmap_lock by the fault path. > * But page lock would prevent establishing any new ptes of the > * page, so we are safe. > -- > 2.23.0 > >