From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 210F6C433EF for ; Fri, 8 Apr 2022 17:33:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 674FB6B0072; Fri, 8 Apr 2022 13:33:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 657746B0073; Fri, 8 Apr 2022 13:33:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 513916B0074; Fri, 8 Apr 2022 13:33:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0087.hostedemail.com [216.40.44.87]) by kanga.kvack.org (Postfix) with ESMTP id 445226B0072 for ; Fri, 8 Apr 2022 13:33:56 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 050F2183584EC for ; Fri, 8 Apr 2022 17:33:56 +0000 (UTC) X-FDA: 79334409672.26.6818ED1 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf21.hostedemail.com (Postfix) with ESMTP id 86EA61C0004 for ; Fri, 8 Apr 2022 17:33:55 +0000 (UTC) Received: by mail-pf1-f177.google.com with SMTP id s2so8946636pfh.6 for ; Fri, 08 Apr 2022 10:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cWTSCwpL+LxZEat1kSOLm6Y66SA98WkOuLuTeDHbBOY=; b=nyWjfBinfU86kLldN3MGvMLwWrnhwfPR7k3pKGK6ZNsNrVc0CELrTiP949H5bQLeKk IIx70qDFZ24FFVi50jCdiqYk5PxY6EirxrfP3+2GeVwvXKvmxoL1tpfA3mCtx9t652tQ FioOOz5cTDqtA/FDPfLsXnSo+D7RMi8LBgsJLdS+9OGm5Ml6D4xUUlQJK05L8ylzI4U8 jp1TnZAsC8/tm7zC9jeg61D1O5s8m3sMU39yfi9EWCXXVz9aWLrujOuwSxVO2T1ptbem v2KUAd4rhVgK56n2ggF2FaGzTrB+P4Y6U0oYn7N6gOpQkYfpOfv538XRpdNB9GVUOdaY KnIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cWTSCwpL+LxZEat1kSOLm6Y66SA98WkOuLuTeDHbBOY=; b=67Vdgo3ScyrtGPk+YHavDlYjw3m4uzFnbv4DgdHTOSVwD7YaU1e3Qq4r4YjQPVDjWQ Pyew2R5KLab3mCrvrlBLQWAfxa30ZhbQmq2HkCiH5MqQ7kme0EUhVITqwE8J7V4+tWVL DMnOlUMSjOKA6TDywaaqimiUvvpKvOQDiR1w91hsoU6YeCqxbOuvbvRgfvVZuSGT9lgl lxGtuqbxeVlF26joPHKk58jX3TPz+hQv3SxI5nTgxt3JwqvYKVZfMytFm1oyzmNUZ0Ir pFs9/r5ak4lAHoCrUigEhNp+qmGC91LXZLobvTExJ4QlA+YahSIIUYzqLHnSzxseZ+mL 8sVA== X-Gm-Message-State: AOAM532+0/rzxN8uDJErjCokoKM06NAcu5AA/S1hjLVnlSODOFDg460p wRaFalJUWJZmD/cicZe52JRTSk4k2tK6lxTYihc= X-Google-Smtp-Source: ABdhPJxF5AIdyZ+ydJ0RBeGeKXy3z0SVAB7XnzwvpqXcdsd3dszavCZTo3rjZDGS1c+jBUdGlD3JBbCm8pYSME7spg4= X-Received: by 2002:a65:6951:0:b0:381:f10:ccaa with SMTP id w17-20020a656951000000b003810f10ccaamr16018673pgq.587.1649439234602; Fri, 08 Apr 2022 10:33:54 -0700 (PDT) MIME-Version: 1.0 References: <20220407130352.15618-1-linmiaohe@huawei.com> <20220407130352.15618-3-linmiaohe@huawei.com> In-Reply-To: <20220407130352.15618-3-linmiaohe@huawei.com> From: Yang Shi Date: Fri, 8 Apr 2022 10:33:43 -0700 Message-ID: Subject: Re: [PATCH 2/3] mm/memory-failure.c: minor cleanup for HWPoisonHandlable To: Miaohe Lin Cc: Andrew Morton , =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Mike Kravetz , David Hildenbrand , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 86EA61C0004 X-Stat-Signature: f3bqqcse7jdwkdg4ybbo4st1qsnkz3z7 X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nyWjfBin; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of shy828301@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-HE-Tag: 1649439235-345924 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 7, 2022 at 6:03 AM Miaohe Lin wrote: > > The local variable movable can be removed by returning true directly. Also > fix typo 'mirgate'. No functional change intended. > > Signed-off-by: Miaohe Lin Reviewed-by: Yang Shi > --- > mm/memory-failure.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 2e97302d62e4..bd563f47630c 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1180,13 +1180,11 @@ void ClearPageHWPoisonTakenOff(struct page *page) > */ > static inline bool HWPoisonHandlable(struct page *page, unsigned long flags) > { > - bool movable = false; > - > - /* Soft offline could mirgate non-LRU movable pages */ > + /* Soft offline could migrate non-LRU movable pages */ > if ((flags & MF_SOFT_OFFLINE) && __PageMovable(page)) > - movable = true; > + return true; > > - return movable || PageLRU(page) || is_free_buddy_page(page); > + return PageLRU(page) || is_free_buddy_page(page); > } > > static int __get_hwpoison_page(struct page *page, unsigned long flags) > -- > 2.23.0 >