From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE1ACD64072 for ; Fri, 8 Nov 2024 17:44:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E8EC6B00C4; Fri, 8 Nov 2024 12:44:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 58D376B00C9; Fri, 8 Nov 2024 12:44:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3DD706B00C8; Fri, 8 Nov 2024 12:44:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1F8F26B00C3 for ; Fri, 8 Nov 2024 12:44:10 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B02FC120EA2 for ; Fri, 8 Nov 2024 17:44:09 +0000 (UTC) X-FDA: 82763650242.21.44BF671 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf16.hostedemail.com (Postfix) with ESMTP id D4DB518000B for ; Fri, 8 Nov 2024 17:43:29 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QdMsghw7; spf=pass (imf16.hostedemail.com: domain of shy828301@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731087619; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ESmAf4yLQwsg9nhw10R3AZt+48J8H9iRkE7tVpXSLDI=; b=5eO4W+1HuosrgDoFjZaWOwkdeUOqn4p5q+dpJO0xu45RoBVdzfcdj2Cl6VupRF31fMOOdi NKr38lZVocuup3t66N51BGHM4nxiG4EiSgRRCgaikBmqSRQW4IfRS45SfhfDDlK2IhT9lC 0ab2JRjbYD52vFLF7LamMP6vCnwhMfk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QdMsghw7; spf=pass (imf16.hostedemail.com: domain of shy828301@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731087619; a=rsa-sha256; cv=none; b=FRysTiQ7K0kC8IXiiYLQerqleEaANjWS6Gu1zkxAX2hCsLmeW/8Nbpy6lwVe7Ko5zxDslE Zy4t5Hd/VUh0/A+RTVUb3Bt9+QojpPBLG244z7VpM9v59Ipp3urUcWanlRGk8ToHNDZP9P 0WEinlpP4Fb8Nummnr+JAN43/vL0Uz8= Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-53a097aa3daso2369843e87.1 for ; Fri, 08 Nov 2024 09:44:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731087845; x=1731692645; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ESmAf4yLQwsg9nhw10R3AZt+48J8H9iRkE7tVpXSLDI=; b=QdMsghw7x8rom+QM+bvJALZwOAZd2lqdc5+ZOBF0Zqbhg5YzpCa7Hb3joGEQfJFqyn vlrpxOlw+3/CLMJe7Vx1npcM4VqgH1VPLPJCzOc4cKKFmAUlIshApPaaodj8M3bISm/V KXJOmZzfHxQpf529eRPbMuvXUNB9P8yseirVAKzA2B0h1KuNkDDPAUMbTf0QKap7uW2H 0s+hNeES85+DPZYrfSfN4FDW2D0JqAQQBjVwe2yyh9aBvwCMWE1KEmrHi+GVsqug9SwG BRUGesprq2TaNyHkKRAHhAYQ1a0MN6HxgwWiV3tiRjT/aY0mO6dhI7JLVVRmP3DQwoHf miyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731087845; x=1731692645; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ESmAf4yLQwsg9nhw10R3AZt+48J8H9iRkE7tVpXSLDI=; b=SozvWYKJY7bDVtaIW6LlsdYTBS35ZWdyptU4KnDpgyjBwSr7Hy7ExLJWAzZ8XEHm3o 1pVwoe7pY8cedtlWIfKwruLd+D9kaZuWXNquQqugYauLLxlaiZN5OxrhwowUYpleQUAs e1k82Ut1nozKdSEjuGsvy48O7Kf1if0v6/n5qxRxpdiQDLTDaCRpt4Lg+tulgYDlKiu3 w/3bXM0D+DlhU8qeg4HaoJGEZ3qg/T9vASa9Rjgb7fINx87axZzbU76KYYZkLf9ioPh9 fQgWkHDEoNwaDO8KPARvJJ4FEuQ4/E29VMKT0zs9OCSsmucaxh727i4MsHD7aEGavBiX N5mQ== X-Forwarded-Encrypted: i=1; AJvYcCVONyUmbu+2NBUcgRKw5yqmG6RsTOx4EJOiOvIvgmJVHOX9HLhJBcjACVi+fhqdPyATMTn5jtzx2Q==@kvack.org X-Gm-Message-State: AOJu0Yx3GFyhTe02G6Ut4FaykNCmWWhu8rJam0/SEWb31yL1ZrbxOlkG OG6ADniRyDf2IN4Eifhhg/LbbGZG/TsHyOrBJQmoZNKe2/MsTTyJXQcnFS8qMUmI5xIYyVkCJ8Q zqT/ZPRRxcDZF/6NCwP4qndDUTNU= X-Google-Smtp-Source: AGHT+IGR76l3CDWmxRniOHE20cK7Simwu1gyMoy6NuqvCHl5lfV6QHE7PDtWAuAC296q4awh0BEpcsfCtLPQZvk5VIg= X-Received: by 2002:a05:6512:b09:b0:539:f74b:62a5 with SMTP id 2adb3069b0e04-53d862c467emr2194468e87.25.1731087844672; Fri, 08 Nov 2024 09:44:04 -0800 (PST) MIME-Version: 1.0 References: <9c3fecc3-19dc-42d4-6c89-4a48e9ad19cc@redhat.com> <5a1e67c3-481e-4c6e-8507-5a8ea0bd9f28@suse.cz> <3c599659-d4b2-4e4b-8086-0925dd6b2c4e@suse.cz> In-Reply-To: <3c599659-d4b2-4e4b-8086-0925dd6b2c4e@suse.cz> From: Yang Shi Date: Fri, 8 Nov 2024 09:43:53 -0800 Message-ID: Subject: Re: slab warning: kmem_cache of name 'dm_bufio_buffer' already exists To: Vlastimil Babka , saeedm@nvidia.com, tariqt@nvidia.com Cc: Mikulas Patocka , Pedro Falcato , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , zkabelac@redhat.com, Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D4DB518000B X-Stat-Signature: c7m41tiipyaj7fththpt5syc8qgojesm X-Rspam-User: X-HE-Tag: 1731087809-90838 X-HE-Meta: U2FsdGVkX19eux60r67tjfFwjQaz+gt72qcCdxYP1VERZt0bO8dGEAo3TrETzdNQHPfHyg8bu4aCuF6pb4tWf1bVqZBcrzoLcrn+um4Nx3vCSt8cwg1TP1FBI4BVIAO+S0ALU+0sFdNHcBfLww/eJ1knnvzlMVUqNPb/saENxdPuWYHUCnIieb6BFmCgtSS0E9HHeUtItuEIaeYCeFJI4zYnDIsVYzz8uEqeea6BH/CvxeM282Y7IFZUPCUr0Jv4qeZbRlWc8sRRY03taEgd+6HPAejXgMfmcefBNV+mBccxXTWcONmbA40y+mC9SnKuxOGxMpS0f9xCFRgNs94xgr59H4wDJhskzBTs8H2InnemCbsltxSKzsdUCGDK7O/GslCr5k0JzWGI0wUiKnZnFokbydeVYYY3CR5rpcjvxzAR0/7VFcGjKchVE0+3lRnz+/kbPQ6R9ZK2MOxGSvWTTRbu6qwpqcmvdd7P8KjopuHlHrPqsIQnqufmISoWGyhbPuNmS501D1mpsUnFLahZKD/Qaeg1/2fLRZv6x5gV1JThe4x1oZDmyINBBirwPI9iU+QxtvL/2XQiVQ+TakFl7gVOsxaq+e7nTpj6aNPsDmgf0XIVzgxbJ4mBIZYNJsx6UY6oRM0ptYK6NgUWNnQ02Z+gz+LydNr99zI+7Igno7mf7wWuo6a9u0Gz9++xglYwFH9NSDfHuD2ay43FpZrlfm+ykECF5jRc7kK2I4d4ETTTkL4p4FlBNYi444LuqUVgNWiyVn2mexqxGHpgt41P0okr07QIY1J5RSfceWtxuBfPWZabacAWIVu+u8OFjatIpsAlLPXeEZg08TYZI8HOckccW4PF3C8j90t7cZx4QQlwZOPlLtXfKp3X019M+QqfG3h3bY2CqTW3+IcTiFwYdBnWMsE/s7ihasKz90TZZLQZNJ+JlgF+qdU5KUxwjzIyQTV03TUJh03AOh8hXh3 7dGWyfcj HuIQUxvnFUGaAFQKbyR5xeAuLiA47NJN+f8i4Ke3HuZqcrHYN5am67GKqJJbC191uSuf7b0MywnWgfPA2sLYsHyLjDFYVTQ35cEFxnFK1v6UzQiUVksx5Ws+t4dmT3BdXt/wEc48zCT8zuZPs/DmFnghdLgi+YXLXhJXaKkM1/1G+tQJllU3WlI3Ctp09ZGWdYk4mLiThCLTtcTlfpgVToaJmNHS4QOBNpxjl6atmdygEh3mgRB8cCNQU29bLkoiwg3YqN44p08mks4bMRwXSUm+0HDzYsMbX/0wwvwCPNxzowJH/sJS75nY0GIqX3zuohEu6MlZQN+JvVChqAg9eQti5P/IcktJaicDS7sq8f6vczjrqFuyeRfcMx05JA6QdeyrBunj/OfINk7sapJCk+oZ3mzbkexkNjmb5CFqloO3gI5yj/YEUr9yxqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 8, 2024 at 9:00=E2=80=AFAM Vlastimil Babka wro= te: > > On 11/8/24 17:49, Yang Shi wrote: > > On Wed, Nov 6, 2024 at 3:35=E2=80=AFAM Vlastimil Babka = wrote: > >> > >> On 11/6/24 12:19, Mikulas Patocka wrote: > >> > Hi > >> > >> Hi, > >> > >> > The commit 4c39529663b93165953ecf9b1a9ea817358dcd06 ("slab: Warn on > >> > duplicate cache names when DEBUG_VM=3Dy") is causing large number of > >> > warnings about "dm_bufio_buffer", "dm_bufio_buffer-%u" (and other) d= evice > >> > mapper caches. > >> > >> Hmm wonder why nobody run into this before. We thought the code that w= ould > >> cause the warning would be all fixed before introducing it, but we mis= sed > >> some, sorry. > > > > Another data point, I also saw such warning when booting 6.12-rcX (rc1 > > and rc6), but from mlx5 driver. I thought it was mlx driver specific > > issue, it seems not. > > Well this particular issue is mlx driver specific. > The caches it creates (per device?) don't seem to be have specific size o= r > anything to that device, so it should be relatively simple to fix. Aha, thank you. Added mlx driver maintainers. > > > [ 63.537874] kmem_cache of name 'mlx5_fs_ftes' already exists > > [ 63.546399] WARNING: CPU: 0 PID: 9 at mm/slab_common.c:107 > > __kmem_cache_create_args+0xb4/0x330 > > [ 63.557839] Modules linked in: vfat fat mlx5_core(+) dax_hmem > > cxl_acpi ampere_cspmu cxl_port cxl_core mlxfw psample einj arm_spe_pmu > > arm_cspmu_module tls pci_hyperv_intf acpi_ipmi acpi_tad ipmi_ssif > > ipmi_devintf arm_cmn ipmi_msghandler cppc_cpufreq(+) fuse loop > > nfnetlink zram xfs crct10dif_ce polyval_ce polyval_generic ghash_ce > > sha3_ce nvme sha512_ce nvme_core sha512_arm64 sbsa_gwdt nvme_auth > > xgene_hwmon > > [ 63.596473] CPU: 0 UID: 0 PID: 9 Comm: kworker/0:1 Tainted: G > > W 6.12.0-rc6 #80 > > [ 63.609156] Tainted: [W]=3DWARN > > [ 63.614976] Hardware name: ZOLLNER SUNMOONLAKE/SunMoon Lake, BIOS > > 00.00. 2024-10-30 13:48:02 11/06/2024 > > [ 63.624359] Workqueue: events work_for_cpu_fn > > [ 63.631569] pstate: 63400009 (nZCv daif +PAN -UAO +TCO +DIT -SSBS BT= YPE=3D--) > > [ 63.638523] pc : __kmem_cache_create_args+0xb4/0x330 > > [ 63.646340] lr : __kmem_cache_create_args+0xb4/0x330 > > [ 63.654158] sp : ffff800080d1bc00 > > [ 63.660330] x29: ffff800080d1bc00 x28: 0000000000000000 x27: 0000000= 000000000 > > [ 63.670318] x26: 0000000000000000 x25: ffffbf101f234410 x24: 0000000= 0000002d8 > > [ 63.677446] x23: 0000000000000000 x22: ffff800080d1bc58 x21: ffffbf1= 01f2344b8 > > [ 63.687436] x20: ffffbf0ff94870a8 x19: ffff2001053a1700 x18: 0000000= 000000014 > > [ 63.694563] x17: 00000000a871ae29 x16: ffffbf101c282f18 x15: 0000000= 07773661b > > [ 63.704552] x14: 0000000000000000 x13: 7374736978652079 x12: 6461657= 26c612027 > > [ 63.714539] x11: 736574665f73665f x10: 35786c6d2720656d x9 : ffffbf1= 01c1722f0 > > [ 63.724531] x8 : ffff800080d1b890 x7 : 0000000000000001 x6 : 0000000= 000000001 > > [ 63.734518] x5 : ffff001f7d803448 x4 : 0000000000000000 x3 : 0000000= 000000000 > > [ 63.741646] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff000= 108e3a440 > > [ 63.751634] Call trace: > > [ 63.754072] __kmem_cache_create_args+0xb4/0x330 > > [ 63.761542] mlx5_fs_core_alloc+0x158/0x1a8 [mlx5_core] > > [ 63.769708] mlx5_init_once+0x13c/0x520 [mlx5_core] > > [ 63.777528] mlx5_init_one_devl_locked+0xa8/0x280 [mlx5_core] > > [ 63.786127] probe_one+0xe0/0x200 [mlx5_core] > > [ 63.790569] local_pci_probe+0x48/0xc0 > > [ 63.794307] work_for_cpu_fn+0x24/0x40 > > [ 63.798044] process_one_work+0x180/0x430 > > [ 63.802042] worker_thread+0x25c/0x380 > > [ 63.805778] kthread+0xf4/0x108 > > [ 63.808907] ret_from_fork+0x10/0x20 > > > >> > >> > I'd like to ask - how to properly fix it? > >> > > >> > We create a "dm_bufio_buffer" or "dm_bufio_buffer-%u" cache with eve= ry dm > >> > bufio client. It used to work (and the duplicate caches are merged),= but > >> > >> Note the merging can be disabled so then it's really several caches wi= th > >> exactly same name in /proc/slabinfo and inability to create their > >> sysfs/debugfs directories. > >> > >> > now it warns. > >> > > >> > Should I append a pointer to the dm_bufio structure to the slab cach= e name > >> > to make them different? Or is there any other preferred solution? > >> > >> Anything that uniquely identifies the client should be ok, but beware = e.g. > >> device names that can have slashes, see commit a360f311f57a36 (also fo= r the > >> simplest possible fix that is an incremented number). > >> > >> > Note that it is not possible to pre-create the cache "dm_bufio_buffe= r-%u" > >> > in the module's init function, because the size of per-buffer auxili= ary > >> > data is not known at this point. > >> > >> Looks like some chose to solve this the harder way, see 4d784c042d164f > >> > >> > Mikulas > >> > > >> > >> >