From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95089C43334 for ; Thu, 7 Jul 2022 22:09:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9E3A900002; Thu, 7 Jul 2022 18:09:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4A9E6B0073; Thu, 7 Jul 2022 18:09:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B12F5900002; Thu, 7 Jul 2022 18:09:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A2A166B0072 for ; Thu, 7 Jul 2022 18:09:47 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 738843429C for ; Thu, 7 Jul 2022 22:09:47 +0000 (UTC) X-FDA: 79661696814.29.F65AB99 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf24.hostedemail.com (Postfix) with ESMTP id 1364B180047 for ; Thu, 7 Jul 2022 22:09:46 +0000 (UTC) Received: by mail-pl1-f181.google.com with SMTP id p16so114838plo.0 for ; Thu, 07 Jul 2022 15:09:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oiKzxxQq+e2peVSgseIuQeYKf8iC8MiiAaC/vEMci1U=; b=RN49uaXs7amTDQLs6qAy+di2sdSsChOURTrpBIUf9KdE0R2KO2rUGUZRA/bXnCthZN /PMGeaka3SlU/70fn57ECamlKQxTGp4U1TRI0b962fZSUzUvCfIH6ADjIlIxLYATgsfo b6AFH96hzw4VKne1ooduLLbmE18pmBV9v6v5VszJWuDS4v5g4S8mG8lBKi8FTiY106SE kZSEAulT8N+M+2XwHw0XxkG6dxYkIDs+iD+3FTewKe5K8W+D5jFy3D9vBfGRtL2SlNUe HWaJ2TYCw7G+BZjNv39x0q1Pwfzchs+8peU3LbXw3C29xeo7y67gYy5jXWwVdc1Of3gr D4IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oiKzxxQq+e2peVSgseIuQeYKf8iC8MiiAaC/vEMci1U=; b=36YdFWqRKoFSy1HC5Tw6EAAoyzongRkG3V2Hd/ccQwxauxETWeXb9UVZBs4ccS0rRc bpf/uELZbDI9Jp8uVxaoaxhOwFhTol5c6IVcbrgY9TaPO64YULjLrSSChgYwUHbUibxA 4JstyprPNTVcWj3P0jXbrxJRAWj86C0FTt4t8OSVy28gPIyuXmgDsQwcTX9v1AdMmfnc TYUs1ud2ysellGQHCPZoMSJq4VRc1fqJO5H3bebR02cuHYfnBx75VEhTFbX64H64WYpC gNz5yaKd5R0PpwBIHyc5xjaNSh5KItZrEh/IznArJBolEyOmVn4DTojG3noYKZOpNWL9 zS0w== X-Gm-Message-State: AJIora9XyZvSyMBBQKqnFih7o4bz4kF6dJ5lAq3Ewbs8SjwFHSqwIc24 3FUU8p2ZGhLlMefyHOPhPr7DorxSMIYf9akTBao= X-Google-Smtp-Source: AGRyM1su2Q9NtDCHaCaKx1bubaW/lXjKHjJn7VoibPxKdaj3KLB5RDOUyLQxSpnq/jW4E/qtyVplXtu7guDpXuVgAQ0= X-Received: by 2002:a17:903:2405:b0:16a:8010:1e16 with SMTP id e5-20020a170903240500b0016a80101e16mr286315plo.87.1657231786005; Thu, 07 Jul 2022 15:09:46 -0700 (PDT) MIME-Version: 1.0 References: <20220707165650.248088-1-rppt@kernel.org> In-Reply-To: From: Yang Shi Date: Thu, 7 Jul 2022 15:09:32 -0700 Message-ID: Subject: Re: [PATCH v2] secretmem: fix unhandled fault in truncate To: "Darrick J. Wong" Cc: Mike Rapoport , Andrew Morton , Axel Rasmussen , Eric Biggers , Hillf Danton , Matthew Wilcox , Mike Rapoport , Linux FS-devel Mailing List , Linux MM , syzkaller-bugs , syzbot+9bd2b7adbd34b30b87e4@syzkaller.appspotmail.com Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RN49uaXs; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of shy828301@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657231787; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oiKzxxQq+e2peVSgseIuQeYKf8iC8MiiAaC/vEMci1U=; b=gy8oBuEyQ8u5VoSyeuy1/O71twNnwU+xK069eX1L8L0zCPHmJVb9MtsjCg8WqZnuWLO9ng 2xzDWaMvHBpRL3Ojgb/QyuMfUqO1IB1Y1+FCRVTbAQJoIfpioG7ibxWNXxUjKC2uY+gSai BuRFI/PPFy0MK6sOrxUPSorHUcUre0s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657231787; a=rsa-sha256; cv=none; b=xNx+peDjaWttaR7wroyM4CA0K3pelAu4bkb69vQGgaRpQbJRRm6wzAvYOxK3o7GZWzWVZX Ugm2kAvNJ8R+5XQDZ93cvr5yvNn4h3Wvtr+fxmpz91IqSTtsmT+3v+S7xIYA/eJ/v3y9um uXAl4jVECWp8ydc3AnZtaHu+qSIqIs0= X-Stat-Signature: bse1idtw7ye85maap79a4rit1i3rikaq X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1364B180047 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RN49uaXs; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of shy828301@gmail.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-Rspam-User: X-HE-Tag: 1657231786-659579 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 7, 2022 at 1:55 PM Darrick J. Wong wrote: > > On Thu, Jul 07, 2022 at 10:48:00AM -0700, Yang Shi wrote: > > On Thu, Jul 7, 2022 at 9:57 AM Mike Rapoport wrote: > > > > > > From: Mike Rapoport > > > > > > syzkaller reports the following issue: > > > > > > BUG: unable to handle page fault for address: ffff888021f7e005 > > > PGD 11401067 P4D 11401067 PUD 11402067 PMD 21f7d063 PTE 800fffffde081060 > > > Oops: 0002 [#1] PREEMPT SMP KASAN > > > CPU: 0 PID: 3761 Comm: syz-executor281 Not tainted 5.19.0-rc4-syzkaller-00014-g941e3e791269 #0 > > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 > > > RIP: 0010:memset_erms+0x9/0x10 arch/x86/lib/memset_64.S:64 > > > Code: c1 e9 03 40 0f b6 f6 48 b8 01 01 01 01 01 01 01 01 48 0f af c6 f3 48 ab 89 d1 f3 aa 4c 89 c8 c3 90 49 89 f9 40 88 f0 48 89 d1 aa 4c 89 c8 c3 90 49 89 fa 40 0f b6 ce 48 b8 01 01 01 01 01 01 > > > RSP: 0018:ffffc9000329fa90 EFLAGS: 00010202 > > > RAX: 0000000000000000 RBX: 0000000000001000 RCX: 0000000000000ffb > > > RDX: 0000000000000ffb RSI: 0000000000000000 RDI: ffff888021f7e005 > > > RBP: ffffea000087df80 R08: 0000000000000001 R09: ffff888021f7e005 > > > R10: ffffed10043efdff R11: 0000000000000000 R12: 0000000000000005 > > > R13: 0000000000000000 R14: 0000000000001000 R15: 0000000000000ffb > > > FS: 00007fb29d8b2700(0000) GS:ffff8880b9a00000(0000) knlGS:0000000000000000 > > > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > CR2: ffff888021f7e005 CR3: 0000000026e7b000 CR4: 00000000003506f0 > > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > > Call Trace: > > > > > > zero_user_segments include/linux/highmem.h:272 [inline] > > > folio_zero_range include/linux/highmem.h:428 [inline] > > > truncate_inode_partial_folio+0x76a/0xdf0 mm/truncate.c:237 > > > truncate_inode_pages_range+0x83b/0x1530 mm/truncate.c:381 > > > truncate_inode_pages mm/truncate.c:452 [inline] > > > truncate_pagecache+0x63/0x90 mm/truncate.c:753 > > > simple_setattr+0xed/0x110 fs/libfs.c:535 > > > secretmem_setattr+0xae/0xf0 mm/secretmem.c:170 > > > notify_change+0xb8c/0x12b0 fs/attr.c:424 > > > do_truncate+0x13c/0x200 fs/open.c:65 > > > do_sys_ftruncate+0x536/0x730 fs/open.c:193 > > > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > > > do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80 > > > entry_SYSCALL_64_after_hwframe+0x46/0xb0 > > > RIP: 0033:0x7fb29d900899 > > > Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 11 15 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 > > > RSP: 002b:00007fb29d8b2318 EFLAGS: 00000246 ORIG_RAX: 000000000000004d > > > RAX: ffffffffffffffda RBX: 00007fb29d988408 RCX: 00007fb29d900899 > > > RDX: 00007fb29d900899 RSI: 0000000000000005 RDI: 0000000000000003 > > > RBP: 00007fb29d988400 R08: 0000000000000000 R09: 0000000000000000 > > > R10: 0000000000000000 R11: 0000000000000246 R12: 00007fb29d98840c > > > R13: 00007ffca01a23bf R14: 00007fb29d8b2400 R15: 0000000000022000 > > > > > > Modules linked in: > > > CR2: ffff888021f7e005 > > > ---[ end trace 0000000000000000 ]--- > > > > > > Eric Biggers suggested that this happens when > > > secretmem_setattr()->simple_setattr() races with secretmem_fault() so > > > that a page that is faulted in by secretmem_fault() (and thus removed > > > from the direct map) is zeroed by inode truncation right afterwards. > > > > > > Since do_truncate() takes inode_lock(), adding inode_lock_shared() to > > > secretmem_fault() prevents the race. > > > > Should invalidate_lock be used to serialize between page fault and truncate? > > I would have thought so, given Documentation/filesystems/locking.rst: > > "->fault() is called when a previously not present pte is about to be > faulted in. The filesystem must find and return the page associated with > the passed in "pgoff" in the vm_fault structure. If it is possible that > the page may be truncated and/or invalidated, then the filesystem must > lock invalidate_lock, then ensure the page is not already truncated > (invalidate_lock will block subsequent truncate), and then return with > VM_FAULT_LOCKED, and the page locked. The VM will unlock the page." > > IIRC page faults aren't supposed to take i_rwsem because the fault could > be in response to someone mmaping a file into memory and then write()ing > to the same file using the mmapped region. The write() takes > inode_lock and faults on the buffer, so the fault cannot take inode_lock > again. Do you mean writing from one part of the file to the other part of the file so the "from" buffer used by copy_from_user() is part of the mmaped region? Another possible deadlock issue by using inode_lock in page faults is mmap_lock is acquired before inode_lock, but write may acquire inode_lock before mmap_lock, it is a AB-BA lock pattern, but it should not cause real deadlock since mmap_lock is not exclusive for page faults. But such pattern should be avoided IMHO. > > That said... I don't think memfd_secret files /can/ be written to? Hard > to say, since I can't find a manpage describing what that syscall does. > > --D > > > > > > > > > Reported-by: syzbot+9bd2b7adbd34b30b87e4@syzkaller.appspotmail.com > > > Suggested-by: Eric Biggers > > > Signed-off-by: Mike Rapoport > > > --- > > > > > > v2: use inode_lock_shared() rather than add a new rw_sem to secretmem > > > > > > Axel, I didn't add your Reviewed-by because v2 is quite different. > > > > > > mm/secretmem.c | 21 ++++++++++++++++----- > > > 1 file changed, 16 insertions(+), 5 deletions(-) > > > > > > diff --git a/mm/secretmem.c b/mm/secretmem.c > > > index 206ed6b40c1d..a4fabf705e4f 100644 > > > --- a/mm/secretmem.c > > > +++ b/mm/secretmem.c > > > @@ -55,22 +55,28 @@ static vm_fault_t secretmem_fault(struct vm_fault *vmf) > > > gfp_t gfp = vmf->gfp_mask; > > > unsigned long addr; > > > struct page *page; > > > + vm_fault_t ret; > > > int err; > > > > > > if (((loff_t)vmf->pgoff << PAGE_SHIFT) >= i_size_read(inode)) > > > return vmf_error(-EINVAL); > > > > > > + inode_lock_shared(inode); > > > + > > > retry: > > > page = find_lock_page(mapping, offset); > > > if (!page) { > > > page = alloc_page(gfp | __GFP_ZERO); > > > - if (!page) > > > - return VM_FAULT_OOM; > > > + if (!page) { > > > + ret = VM_FAULT_OOM; > > > + goto out; > > > + } > > > > > > err = set_direct_map_invalid_noflush(page); > > > if (err) { > > > put_page(page); > > > - return vmf_error(err); > > > + ret = vmf_error(err); > > > + goto out; > > > } > > > > > > __SetPageUptodate(page); > > > @@ -86,7 +92,8 @@ static vm_fault_t secretmem_fault(struct vm_fault *vmf) > > > if (err == -EEXIST) > > > goto retry; > > > > > > - return vmf_error(err); > > > + ret = vmf_error(err); > > > + goto out; > > > } > > > > > > addr = (unsigned long)page_address(page); > > > @@ -94,7 +101,11 @@ static vm_fault_t secretmem_fault(struct vm_fault *vmf) > > > } > > > > > > vmf->page = page; > > > - return VM_FAULT_LOCKED; > > > + ret = VM_FAULT_LOCKED; > > > + > > > +out: > > > + inode_unlock_shared(inode); > > > + return ret; > > > } > > > > > > static const struct vm_operations_struct secretmem_vm_ops = { > > > > > > base-commit: 03c765b0e3b4cb5063276b086c76f7a612856a9a > > > -- > > > 2.34.1 > > > > > >