From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72A8CC7EE43 for ; Mon, 12 Jun 2023 21:58:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 934AA6B0074; Mon, 12 Jun 2023 17:58:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E49B6B0075; Mon, 12 Jun 2023 17:58:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7ABDE6B0078; Mon, 12 Jun 2023 17:58:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6ABF06B0074 for ; Mon, 12 Jun 2023 17:58:13 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3517F120327 for ; Mon, 12 Jun 2023 21:58:13 +0000 (UTC) X-FDA: 80895459666.09.21561AA Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf06.hostedemail.com (Postfix) with ESMTP id 616A6180005 for ; Mon, 12 Jun 2023 21:58:11 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=od+5GOwq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of shy828301@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686607091; a=rsa-sha256; cv=none; b=D/Wt00ZfrtJ1WMW0jFrXH18R7r5XxgAFLyJXBazbFb0wlguyPmwPKMfu9ltLdGGbUd/Ypt a8nkDQkcAYMXYyZyutvVWaZdehaPocdPMn/Yn30iyV26Jw4+hZL9jfK5A6lj80QmKshQS+ lWlLH/iCQ4sDWGV/iCjOuTJgyReAsLs= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=od+5GOwq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of shy828301@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686607091; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/5eEw1L+15ry6U4Pjjiy2xa5UbjIi1vlwGFKCgVY01g=; b=X5vcBX1X4pGTWa+/S23xOEmvDpXODmWN/CglukVpaUwHzUytj+3+Yj1l8vdzSaWdHYjVIR V35ZOPHWMtHUGixFh0DCURCtaf9HrQZi3zPgAZrUY7MYinSTuUNcRQqRgqzcBNSEgmz4+x BgQtnVmdGEd3v0a7UANm9VVVGHz004U= Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-25c101bf7deso276486a91.1 for ; Mon, 12 Jun 2023 14:58:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686607090; x=1689199090; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/5eEw1L+15ry6U4Pjjiy2xa5UbjIi1vlwGFKCgVY01g=; b=od+5GOwqnjdySkprgJDd461UY1jYfkrNx5K228+Gm0JYXuxu5dRXnEhs2uqKBoau/P Cnq+b3yUVsuK6WbjZ+UEbxhf59qXkV1gnRojP5Sxt0PGau7jRFUHXQTSVYW8vvPoeRZM oqzbZfL/e+WKNREciEdqjHl36r3nMByViRTDVUBp07MvCTa486Fm3u6uzTW761CeAryj GBf6ClEl2/kHdm16qbSqlp+h22aXjW7d5wqaWtSwRmb8ZNP+kplXWdEdKO1pXRmMNsLG UqXHaMUXNTu7gF8XPb71bC7cKl849Swbo69Mz7bZEUffE5TJe8ozck/4nZdv974RQAYA 1UXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686607090; x=1689199090; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/5eEw1L+15ry6U4Pjjiy2xa5UbjIi1vlwGFKCgVY01g=; b=cnMreci/Fz5nIFb7fYGcRcJol2MWpk8A+R4JU8heGhyq9uCauH5JKUWzhkrh+ks2ym Q0dAv6k8j91xbQ1G7eKKLFsbWnQk4/8N+26XcSlp61z3U7OebEXKOgxfIFHQKgv6iXGV P8s33JmDeYXPnKCCnSfDqyjxLfQUmGStzDgxshVIE//XCPgNULLIuYtEmn4UpuuU4h6/ uCo1uTOcVqo2gbNuYWZxPOPlzZV55WafzjKHlefUs+q8Y+RaYCG0gAt30s1gA13ZKbVD z7WDus2EvOGxP4Ems1V6ptE2QAzN8B+gkSCpdc3lmTXuB8BrOSBzu6zsCL8H/L2ho8im a5Pg== X-Gm-Message-State: AC+VfDywYyygfFoU1lgrQH+nMhfHX+ZtCRplBbcFM2OuaQIstb6W9/P+ st+Qnr6M0CipZIW9U1f1m6CZis+JJUkjzEtg/ef49kKm X-Google-Smtp-Source: ACHHUZ79QtDxan/84RbUmRYJUrtnUMHFsswon5Y2H4Adu7u5YDjKAIXJ7GM6bZX6u/HGGeikemCFg5ReKX41QDldP+k= X-Received: by 2002:a17:90a:1a05:b0:255:8fd0:fbf4 with SMTP id 5-20020a17090a1a0500b002558fd0fbf4mr9578415pjk.5.1686607090068; Mon, 12 Jun 2023 14:58:10 -0700 (PDT) MIME-Version: 1.0 References: <20230610034114.981861-1-linmiaohe@huawei.com> In-Reply-To: <20230610034114.981861-1-linmiaohe@huawei.com> From: Yang Shi Date: Mon, 12 Jun 2023 14:57:58 -0700 Message-ID: Subject: Re: [PATCH] memory tier: remove unneeded !IS_ENABLED(CONFIG_MIGRATION) check To: Miaohe Lin Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 616A6180005 X-Stat-Signature: ok5qmyc6fk6nnkj3yygob88mn4bpidra X-HE-Tag: 1686607091-423168 X-HE-Meta: U2FsdGVkX1+JbLLOZGip2rV0hYCX+xu2hpoot1QKzm8YjLBUicoRSn3/QmNI5+pEFHarHSNmu4c1V9LO0kArAIFnZg1wTpE/8wfxLRdEGcP3sljHbP5WU31Wwyk3sNgIdDRQzNDODHXxwK3HvTLnwRICdnaKKNueUFEucQ7/5f099KIv2o4rx/nPBhHglnPi7thnT0iAChMZKceq/zC/sjW1YixjY9dq4CJGCg+W+DUfUHY8Mhfwumi28Vqs9IioeiKEQ+yhQj8h1SD4Il1AS0XGY6QLWadFhzviMSizzE0OlZ9SPL9ZdJSMOuz6zTwOarvvGKlQQOrzpCN6vVIZx2WMSz6DSKllzv88FKySo1aNt68BCLMUD8sFxebsZqwk8Yzm/StCzObS7Wnn/KOm9XF4cV5Ya2zB7zgPAqk5bMvgZKzQXH1fTEOvdhWkxHCZcVzdWAVXoYoTLvKcWN+A6H7qOoQOrzbrTcyOTIyX6ATcI53LVI6lNj/NDPSK4OEBz4Oiiy3ZeJjCBVU+jtoxAcHX0RyXw6UpiveKlC42kjI8kZvfaduutIBl7Q0ho2lxUoqQmmlNiS8b79aDD4Sd3VgCOIig890JojPiImViZpnDs73PyAeMbxfDfjANeDkU5NiJuNIKfLDKcvVKyg+pXFavJ0RTTBjNm/AX+7ZIZf0TqkKGR13HiyCYhnsF8Brjwh3wx4Ptdtg2O7Y7KTJrtghmhwff5qzy4fxnATr0SAB4jbHrOwZ7G3o0W4Tx3fYVUEUeK3vSr8WObDp3a0jD5HUHpWkYQx+lHN48yJAEXKxaEqKGyHN31S30NKJKuov+M75ZZohZxLgIoJtoNssiiCcNwhuTsXMA1bANXg/kSVUUGZ087oM2Eltt3DAgZ1Va6Dk07OuzGTyuz5btAwzXMpk+FFnh6CZVjPyN05H3SZWANUF9yR3JpVScqCgS/TAuJ/yof6QkmoF9fjST/un 4SyWF83T jxzsOjj8zrprlRBEKCk6MG1i0LU/q/nfkz0rrOq/yXJbx2i++i+5w4LTkI3qTqK1w3zow0S6AQWQpzi1X59WN6Poq5mljxrJwdbhXM4W1TSm1w5tAAx2ts5jBBTp+5gFSR1ALJytx/KnNjP/U+ux8R+KZsXv/NQmXOL2nm8kOCUnlJ51ObJ8YFz59f2Sewg2JqhVsqrzEahY5H2JcHnB9mLCBiu4OeqAwwkKP182Ssuf71Z+C2FhtEKCAqhkwp9wu4XpI2wOGsseGny/HUX6cGWYAgl75ZGyD68wQY2YjOc90Wix+UoNgUYqRKz0mzcni1sryFOG7J2WuaIKhYit969Yebw9u1cL3mEXSVJDs94+V8a22LMamE3B+gZ7glUUuxMOKX+iRXVtCRtwf3W22vKvmYBMVP4wnO1OPUvitYDYsLYfS5go1YGS9gyes6hyZ1JDb0Zn2rCXJChjKJfkCpxMwez0qXnmNh/px5oUURFFnjBw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 9, 2023 at 8:41=E2=80=AFPM Miaohe Lin wr= ote: > > establish_demotion_targets() is defined while CONFIG_MIGRATION is > enabled. There's no need to check it again. > > Signed-off-by: Miaohe Lin Reviewed-by: Yang Shi > --- > mm/memory-tiers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c > index dd04f0ce5277..a516e303e304 100644 > --- a/mm/memory-tiers.c > +++ b/mm/memory-tiers.c > @@ -366,7 +366,7 @@ static void establish_demotion_targets(void) > > lockdep_assert_held_once(&memory_tier_lock); > > - if (!node_demotion || !IS_ENABLED(CONFIG_MIGRATION)) > + if (!node_demotion) > return; > > disable_all_demotion_targets(); > -- > 2.27.0 > >