From: Yang Shi <shy828301@gmail.com>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Vlastimil Babka <vbabka@suse.cz>,
David Howells <dhowells@redhat.com>, NeilBrown <neilb@suse.de>,
Alistair Popple <apopple@nvidia.com>,
David Hildenbrand <david@redhat.com>,
Suren Baghdasaryan <surenb@google.com>,
Peter Xu <peterx@redhat.com>, Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/7] mm/khugepaged: use helper macro __ATTR_RW
Date: Thu, 16 Jun 2022 08:48:40 -0700 [thread overview]
Message-ID: <CAHbLzkpkzgq+YK9s1fLW9L90oBo87eaZPp3GEPv=Ug1uV9mmcA@mail.gmail.com> (raw)
In-Reply-To: <c48b8562-4375-ab22-9dfa-224f3e27a079@huawei.com>
On Thu, Jun 16, 2022 at 12:07 AM Miaohe Lin <linmiaohe@huawei.com> wrote:
>
> On 2022/6/16 5:28, Yang Shi wrote:
> > On Sat, Jun 11, 2022 at 1:47 AM Miaohe Lin <linmiaohe@huawei.com> wrote:
> >>
> >> Use helper macro __ATTR_RW to define the khugepaged attributes. Minor
> >> readability improvement.
> >>
> >> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> >> ---
> >> mm/khugepaged.c | 37 +++++++++++++++----------------------
> >> 1 file changed, 15 insertions(+), 22 deletions(-)
> >>
> >> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> >> index 8e6fad7c7bd9..142e26e4bdbf 100644
> >> --- a/mm/khugepaged.c
> >> +++ b/mm/khugepaged.c
> >> @@ -147,8 +147,7 @@ static ssize_t scan_sleep_millisecs_store(struct kobject *kobj,
> >> return count;
> >> }
> >> static struct kobj_attribute scan_sleep_millisecs_attr =
> >> - __ATTR(scan_sleep_millisecs, 0644, scan_sleep_millisecs_show,
> >> - scan_sleep_millisecs_store);
> >> + __ATTR_RW(scan_sleep_millisecs);
> >>
> >> static ssize_t alloc_sleep_millisecs_show(struct kobject *kobj,
> >> struct kobj_attribute *attr,
> >> @@ -175,8 +174,7 @@ static ssize_t alloc_sleep_millisecs_store(struct kobject *kobj,
> >> return count;
> >> }
> >> static struct kobj_attribute alloc_sleep_millisecs_attr =
> >> - __ATTR(alloc_sleep_millisecs, 0644, alloc_sleep_millisecs_show,
> >> - alloc_sleep_millisecs_store);
> >> + __ATTR_RW(alloc_sleep_millisecs);
> >>
> >> static ssize_t pages_to_scan_show(struct kobject *kobj,
> >> struct kobj_attribute *attr,
> >> @@ -200,8 +198,7 @@ static ssize_t pages_to_scan_store(struct kobject *kobj,
> >> return count;
> >> }
> >> static struct kobj_attribute pages_to_scan_attr =
> >> - __ATTR(pages_to_scan, 0644, pages_to_scan_show,
> >> - pages_to_scan_store);
> >> + __ATTR_RW(pages_to_scan);
> >>
> >> static ssize_t pages_collapsed_show(struct kobject *kobj,
> >> struct kobj_attribute *attr,
> >> @@ -221,13 +218,13 @@ static ssize_t full_scans_show(struct kobject *kobj,
> >> static struct kobj_attribute full_scans_attr =
> >> __ATTR_RO(full_scans);
> >>
> >> -static ssize_t khugepaged_defrag_show(struct kobject *kobj,
> >> +static ssize_t defrag_show(struct kobject *kobj,
> >> struct kobj_attribute *attr, char *buf)
> >
> > Why do you rename all the functions? Seems unnecessary and less intriguing TBH.
>
> It's because e.g. __ATTR_RW(defrag) expects the defrag_show and defrag_store instead
> of khugepaged_defrag_show and khugepaged_defrag_store.
Aha, I see. I missed this.
Reviewed-by: Yang Shi <shy828301@gmail.com>
>
> Thanks.
>
> >
> >> {
> >> return single_hugepage_flag_show(kobj, attr, buf,
> >> TRANSPARENT_HUGEPAGE_DEFRAG_KHUGEPAGED_FLAG);
> >> }
> >> -static ssize_t khugepaged_defrag_store(struct kobject *kobj,
> >> +static ssize_t defrag_store(struct kobject *kobj,
> >> struct kobj_attribute *attr,
> >> const char *buf, size_t count)
> >> {
> >> @@ -235,8 +232,7 @@ static ssize_t khugepaged_defrag_store(struct kobject *kobj,
> >> TRANSPARENT_HUGEPAGE_DEFRAG_KHUGEPAGED_FLAG);
> >> }
> >> static struct kobj_attribute khugepaged_defrag_attr =
> >> - __ATTR(defrag, 0644, khugepaged_defrag_show,
> >> - khugepaged_defrag_store);
> >> + __ATTR_RW(defrag);
> >>
> >> /*
> >> * max_ptes_none controls if khugepaged should collapse hugepages over
> >> @@ -246,13 +242,13 @@ static struct kobj_attribute khugepaged_defrag_attr =
> >> * runs. Increasing max_ptes_none will instead potentially reduce the
> >> * free memory in the system during the khugepaged scan.
> >> */
> >> -static ssize_t khugepaged_max_ptes_none_show(struct kobject *kobj,
> >> +static ssize_t max_ptes_none_show(struct kobject *kobj,
> >> struct kobj_attribute *attr,
> >> char *buf)
> >> {
> >> return sysfs_emit(buf, "%u\n", khugepaged_max_ptes_none);
> >> }
> >> -static ssize_t khugepaged_max_ptes_none_store(struct kobject *kobj,
> >> +static ssize_t max_ptes_none_store(struct kobject *kobj,
> >> struct kobj_attribute *attr,
> >> const char *buf, size_t count)
> >> {
> >> @@ -268,17 +264,16 @@ static ssize_t khugepaged_max_ptes_none_store(struct kobject *kobj,
> >> return count;
> >> }
> >> static struct kobj_attribute khugepaged_max_ptes_none_attr =
> >> - __ATTR(max_ptes_none, 0644, khugepaged_max_ptes_none_show,
> >> - khugepaged_max_ptes_none_store);
> >> + __ATTR_RW(max_ptes_none);
> >>
> >> -static ssize_t khugepaged_max_ptes_swap_show(struct kobject *kobj,
> >> +static ssize_t max_ptes_swap_show(struct kobject *kobj,
> >> struct kobj_attribute *attr,
> >> char *buf)
> >> {
> >> return sysfs_emit(buf, "%u\n", khugepaged_max_ptes_swap);
> >> }
> >>
> >> -static ssize_t khugepaged_max_ptes_swap_store(struct kobject *kobj,
> >> +static ssize_t max_ptes_swap_store(struct kobject *kobj,
> >> struct kobj_attribute *attr,
> >> const char *buf, size_t count)
> >> {
> >> @@ -295,17 +290,16 @@ static ssize_t khugepaged_max_ptes_swap_store(struct kobject *kobj,
> >> }
> >>
> >> static struct kobj_attribute khugepaged_max_ptes_swap_attr =
> >> - __ATTR(max_ptes_swap, 0644, khugepaged_max_ptes_swap_show,
> >> - khugepaged_max_ptes_swap_store);
> >> + __ATTR_RW(max_ptes_swap);
> >>
> >> -static ssize_t khugepaged_max_ptes_shared_show(struct kobject *kobj,
> >> +static ssize_t max_ptes_shared_show(struct kobject *kobj,
> >> struct kobj_attribute *attr,
> >> char *buf)
> >> {
> >> return sysfs_emit(buf, "%u\n", khugepaged_max_ptes_shared);
> >> }
> >>
> >> -static ssize_t khugepaged_max_ptes_shared_store(struct kobject *kobj,
> >> +static ssize_t max_ptes_shared_store(struct kobject *kobj,
> >> struct kobj_attribute *attr,
> >> const char *buf, size_t count)
> >> {
> >> @@ -322,8 +316,7 @@ static ssize_t khugepaged_max_ptes_shared_store(struct kobject *kobj,
> >> }
> >>
> >> static struct kobj_attribute khugepaged_max_ptes_shared_attr =
> >> - __ATTR(max_ptes_shared, 0644, khugepaged_max_ptes_shared_show,
> >> - khugepaged_max_ptes_shared_store);
> >> + __ATTR_RW(max_ptes_shared);
> >>
> >> static struct attribute *khugepaged_attr[] = {
> >> &khugepaged_defrag_attr.attr,
> >> --
> >> 2.23.0
> >>
> >>
> > .
> >
>
next prev parent reply other threads:[~2022-06-16 15:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-11 8:47 [PATCH 0/7] A few cleanup patches for khugepaged Miaohe Lin
2022-06-11 8:47 ` [PATCH 1/7] mm/khugepaged: remove unneeded shmem_huge_enabled() check Miaohe Lin
2022-06-11 20:33 ` Andrew Morton
2022-06-13 1:48 ` Miaohe Lin
2022-06-13 18:02 ` Andrew Morton
2022-06-15 0:13 ` Zach O'Keefe
2022-06-15 17:35 ` Yang Shi
2022-06-11 8:47 ` [PATCH 2/7] mm/khugepaged: stop swapping in page when VM_FAULT_RETRY occurs Miaohe Lin
2022-06-15 15:14 ` Zach O'Keefe
2022-06-15 17:51 ` Yang Shi
2022-06-16 6:08 ` Miaohe Lin
2022-06-15 17:49 ` Yang Shi
2022-06-16 6:40 ` Miaohe Lin
2022-06-16 15:46 ` Yang Shi
2022-06-11 8:47 ` [PATCH 3/7] mm/khugepaged: trivial typo and codestyle cleanup Miaohe Lin
2022-06-15 0:23 ` Zach O'Keefe
2022-06-15 17:53 ` Yang Shi
2022-06-11 8:47 ` [PATCH 4/7] mm/khugepaged: minor cleanup for collapse_file Miaohe Lin
2022-06-15 15:54 ` Zach O'Keefe
2022-06-15 18:18 ` Yang Shi
2022-06-16 6:10 ` Miaohe Lin
2022-06-11 8:47 ` [PATCH 5/7] mm/khugepaged: use helper macro __ATTR_RW Miaohe Lin
2022-06-15 0:29 ` Zach O'Keefe
2022-06-15 7:48 ` Miaohe Lin
2022-06-15 21:28 ` Yang Shi
2022-06-16 7:07 ` Miaohe Lin
2022-06-16 15:48 ` Yang Shi [this message]
2022-06-11 8:47 ` [PATCH 6/7] mm/khugepaged: remove unneeded return value of khugepaged_add_pte_mapped_thp() Miaohe Lin
2022-06-15 0:19 ` Zach O'Keefe
2022-06-15 21:35 ` Yang Shi
2022-06-11 8:47 ` [PATCH 7/7] mm/khugepaged: try to free transhuge swapcache when possible Miaohe Lin
2022-06-15 17:13 ` Zach O'Keefe
2022-06-16 3:38 ` Mika Penttilä
2022-06-16 7:33 ` Miaohe Lin
2022-06-15 23:58 ` Yang Shi
2022-06-16 7:42 ` Miaohe Lin
2022-06-16 15:53 ` Yang Shi
2022-06-17 2:26 ` Miaohe Lin
2022-06-17 16:35 ` Yang Shi
2022-06-18 3:13 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHbLzkpkzgq+YK9s1fLW9L90oBo87eaZPp3GEPv=Ug1uV9mmcA@mail.gmail.com' \
--to=shy828301@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=david@redhat.com \
--cc=dhowells@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=neilb@suse.de \
--cc=peterx@redhat.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox