From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50ABCC4708F for ; Tue, 1 Jun 2021 17:30:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E5713613BD for ; Tue, 1 Jun 2021 17:30:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5713613BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4F6E96B0070; Tue, 1 Jun 2021 13:30:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B3156B0071; Tue, 1 Jun 2021 13:30:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 320C96B0072; Tue, 1 Jun 2021 13:30:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id 003D96B0070 for ; Tue, 1 Jun 2021 13:30:30 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 919C7181AEF09 for ; Tue, 1 Jun 2021 17:30:30 +0000 (UTC) X-FDA: 78205844220.29.8016883 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf17.hostedemail.com (Postfix) with ESMTP id 808DA4202A1F for ; Tue, 1 Jun 2021 17:30:21 +0000 (UTC) Received: by mail-ed1-f44.google.com with SMTP id dg27so8635479edb.12 for ; Tue, 01 Jun 2021 10:30:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lZU7MeMeqaOuCTZ3sqp7bNYhGpsFZJI5NcMTixuEmNc=; b=n9Lkz/pQ9CpyYXguK6RFMVoa//agj46r+6vl7yAaoW12EwCNXx87X8icEPAZtFBBsY iAbIjVUHXw2q8R5OsNvAFcEpET/6nZ8qHI7ZbqqES/DFhTD1uCFaLfIhTTnxSox6tIDC I0TsUS5YS76KnR2D9vljqANHKlocu7ceGhkpW/e7LbN2FjTWy1O6SCNnegExUZQoFYmn CAG+UfgY9YakqAlJfh4PIF4vmVtUwf890jHcUKUGg5XBYoZ0+HYEzHNIfsWz0iqyJEHh lZQm6MUB/HBW9vcCprnYYEid4l00IACyaGO0cPC7iA7I16lE5AzQa+zTzoaxz0PB962U DwhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lZU7MeMeqaOuCTZ3sqp7bNYhGpsFZJI5NcMTixuEmNc=; b=i7M2v9Ahb0+TJZWt1Lz6jsjw6quQOsrqSjelUf2r3lPhU7udBDg1Z3l6v26LpVN6Zv 2p5bsaRHshTQXId3LLNQDt1TRdeyl9Qmf9wIEEH8FyFQsYZv9jBBwExzN4YqaFAaKZ3r ZRy/iCi1dPBgpk2o6IhW+OA1xkH4EovNJub9c6tWBSe9jl3bUhnCgQoUrj7cMOpgGMy3 03LDlt+qD+3RBvB5wbCAmbkQBy49AoWcJlZjEdsDdjK2PHRfFRQraGpwWyAsirTKTbu2 F9HBC5gxc+Nma6CdoDvC5FTAPkj1DGWwx1ITBiyovR82CKJTrFaIyrgXD4bSx3cFcbZZ I45A== X-Gm-Message-State: AOAM532mW/Uqt2LHYqmXIUHmbFBsjSx8HKBTRWvlV/wLgwrQD1hqnHj1 4ZufiTNsmxg1DjMLpu0/YjG/DDeN2quwuu8Afdw= X-Google-Smtp-Source: ABdhPJyapykyMAghFYqhlGXruK4mnwOOIfqX2WKDoXOZPMZ4aqHhZ6LL4Gyfo4slkwBtRa+WuZSOuuveZTkz7XRLEq8= X-Received: by 2002:a05:6402:145a:: with SMTP id d26mr2712959edx.151.1622568629059; Tue, 01 Jun 2021 10:30:29 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yang Shi Date: Tue, 1 Jun 2021 10:30:17 -0700 Message-ID: Subject: Re: [PATCH] mm: thp: fix a double unlock bug To: Dan Carpenter Cc: Andrew Morton , Mel Gorman , Linux MM , Linux Kernel Mailing List , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b="n9Lkz/pQ"; spf=pass (imf17.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 808DA4202A1F X-Stat-Signature: 8r4578omj7tcyqgetrfzjuxkfjf4pfrw X-HE-Tag: 1622568621-910014 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 1, 2021 at 2:24 AM Dan Carpenter wrote: > > We're supposed to be holding the "vmf->ptl" spin_lock when we goto > out_map. The lock is dropped after if finishes cleaning up. > > Fixes: 9aff7b33c74a ("mm: thp: refactor NUMA fault handling") > Signed-off-by: Dan Carpenter Thanks for catching this. Acked-by: Yang Shi > --- > mm/huge_memory.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index e353bbc6cee3..caa0148f15bb 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1465,10 +1465,8 @@ vm_fault_t do_huge_pmd_numa_page(struct vm_fault *vmf) > > pmd = pmd_modify(oldpmd, vma->vm_page_prot); > page = vm_normal_page_pmd(vma, haddr, pmd); > - if (!page) { > - spin_unlock(vmf->ptl); > + if (!page) > goto out_map; > - } > > /* See similar comment in do_numa_page for explanation */ > if (!was_writable) > -- > 2.30.2 >