From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9605AC3DA4A for ; Thu, 11 Jul 2024 20:53:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 310316B0093; Thu, 11 Jul 2024 16:53:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C0B76B0096; Thu, 11 Jul 2024 16:53:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AF266B0099; Thu, 11 Jul 2024 16:53:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F23496B0093 for ; Thu, 11 Jul 2024 16:53:18 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AF33BA3156 for ; Thu, 11 Jul 2024 20:53:18 +0000 (UTC) X-FDA: 82328672076.10.EB55C09 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf29.hostedemail.com (Postfix) with ESMTP id CBBE4120007 for ; Thu, 11 Jul 2024 20:53:16 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="k5U9/yyu"; spf=pass (imf29.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720731180; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eifVTfA78D16hjjAq/8UE2aeQnYl1ZF3qifvJyf4EDI=; b=aY9WTRGYIOOwXmAjbyF3MPhh8WryVzfG49wx4WM71l6Rx7ddo0/2Wqy4fY/ArfQ75Rmtze D2IItAq6ynj0n6i8BJVuOZJiRyuPczwEQr1scZCdykR51xNr17Fdg/yZPYBVlaQHnVI0cN 0LaGhjvItNu8zVy1AsESY9QJ3RBAaV0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="k5U9/yyu"; spf=pass (imf29.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720731180; a=rsa-sha256; cv=none; b=DJdSwb1Syh7q7dYrSWHJMLfsYIMYEKLdUuenqLL6MDWSJhKFYfM+/Vai6a840IK1DQ6lsv XgK0qGAGNnNOAuLgp9rWIor7h1ts12RWHVycl87wf4B9jkdrhzkdcF32V1XFKxj4YHx9bi bG1J9v+1i4Ujrhlu6/B8tprUaWcaR+E= Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-58b0beaf703so1713517a12.2 for ; Thu, 11 Jul 2024 13:53:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720731195; x=1721335995; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eifVTfA78D16hjjAq/8UE2aeQnYl1ZF3qifvJyf4EDI=; b=k5U9/yyuqDjC0RtAoFOD24tfX0xCVlbtSlcMV9wkK82X+N1f2Vi34qHNgIeXx6G2Ju tM26Vb25Biu6mgnV/jQxj5J9/JyTo3wSg+X0pg3vpcnW2UKJ4BLUEhaTHM6OS+s/S2+C BRRzeDhoj7xwcQoV8MbcVM7K1hKS+ri7iUXNUINXu7D5xj71AQG3Av2o8fhT4SDWo6Se 5ml61fo9aaa6hUzlbTV1gB3mI0rCUVBZSEaPzVy8uVMv9MJbW7NKJYeE/KmYm8ZG9Cnx CDfLvLBKtk0HDC5FZiIHm/RG5uopvO61M6M3hr4BvtOheD2QvbZSllJj0CDVDbuByYyB azYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720731195; x=1721335995; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eifVTfA78D16hjjAq/8UE2aeQnYl1ZF3qifvJyf4EDI=; b=YCkYPpJCyMl9ocjg6e/Kf4XrbI8juktcpjCTYnoxdNNtmrFXHxapqANXq0uENvuAnB eSakJikgDsPwIhPmEiYDNk1e1Eg1GdPnQgL7JEWYKWod8Lzh+Ll+RadJ9q9T/eebrOQy iBQCKvobv/keBawbjBZu8HQK/pd6TxMhUQkZR2wjAlsTSc5AzNppWUP4axx+vD3I9dWM UjUy6u46ZYo+/BdquTzOVpJkXYg48tqCF3UQNT0twRj3L5nqjFNK8MillG0dpSsVGPbC LIBJ5OPGzRndzfme3tRzrfFO4HsCkyJjR1gfZLYlaGpPNogcy8Ic3PX8c4yjsanVnbP0 9Z2w== X-Forwarded-Encrypted: i=1; AJvYcCUTdadjs9CNHo1UvQya3ITBwkfiXrJY2krjjqhw6jJZw38XQfSSsAT1CUubeJEG7QGEdiQa/7NPATAjo8XXJ4tfVM8= X-Gm-Message-State: AOJu0YxCfKNJk35p+C6b3aG1ggAmAho27d5h/NeOZtUMqSw5L0o+rnH6 Ib3B6eag4P66QBMW4+Ct4vUZXv8zE7Beutda9FK0bRXXTPU9cmaaE31cVlJWDB+uEsrKpdlvPtK 90Rkbu9sCSya02KZ9EGcdd/ksANA= X-Google-Smtp-Source: AGHT+IFqofIDypTOBbYh5WuV9HpljaJUNgCQenj+lbukNK18xzZgVDCFcr5Ytmy/DEmCceS4hlo69w1DRs2kjVVzW28= X-Received: by 2002:a17:906:2bc5:b0:a77:aebc:8fb1 with SMTP id a640c23a62f3a-a780b6b1befmr587614366b.17.1720731195175; Thu, 11 Jul 2024 13:53:15 -0700 (PDT) MIME-Version: 1.0 References: <20240118133504.2910955-1-shy828301@gmail.com> <2d7bd8b2b9736d4a7d0a26169978372b5e002a62.camel@debian.org> In-Reply-To: From: Yang Shi Date: Thu, 11 Jul 2024 13:53:04 -0700 Message-ID: Subject: Re: [PATCH] mm: huge_memory: don't force huge page alignment on 32 bit To: Matthew Wilcox Cc: Yves-Alexis Perez , jirislaby@kernel.org, surenb@google.com, riel@surriel.com, cl@linux.com, akpm@linux-foundation.org, yang@os.amperecomputing.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Salvatore Bonaccorso , Ben Hutchings Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: CBBE4120007 X-Stat-Signature: aowaxm4yeooewhkat5etd1ahpfmywhzp X-HE-Tag: 1720731196-586423 X-HE-Meta: U2FsdGVkX19y5Ln2d3SXDwRI5g0YUKV1xOWDn1eoBkuN7Hfogt+JUDdAPnztQ8UC/5tmLPSf45G1noTZWu/kD1KxmwDKOwf2FlO2AiXr2yPNVVf6dG2bJtjhj0c7ntotq+MVi15lJPf6IXrQFrh/3w47ic/FM+NQJiKEDLGSPIyjKr81sBY2dla6EuffZLVlxYFKnUcxXyI4oXedvkMu2aPIPuxAvMQa6ztiVv28ClqDBv8+ysy4Io+pNKvxC7zj+DGnxBsk2ONYPWDdy3Ql3LXBqRfSDjGcLT+Eh17/Z1zL3lQEE7+gItt+f4m0dKn99phPHjyctit6uTdKEy7P9D+VgQfOHf7IDzeSSnOfbgfoMI8l7jOikl/Ni/AdOmr29oleDWY7fv5xiZUaFG3dS//IVcgf3sBSq2r0DSwXJ1nCGE0d7HMjb7cxNFuJdkN9SVB9V0wssbnXPfiBKNHVnlDFFZNXQVka8ofQm0wIibahb4DbHrV38N8Ug5eTrlOAdGdFYF7D6LSh5EbK8D9YSfk7B2Lddirrcu3VTI/QDdlFTOghWJ76QClXhUKSeCSRg6583f8AFGFhpgy2dGEJRXUJ6ve5L9F7wa5uRwIBIsfCkF+pXtVPXKHIwEahM+w82q4G+OhDkk481EWi+ICz25+8MuDx0vcjAN67H0n63rPIG5srP8hnXenLV+hNMRdubLvLN6P6x9It/briGbIE3U+3WUtuz7AUlRwyUiVU6DhoNERVdoVg7rOnegSCuD0Vd9Aa55RvDulROXKNNTCBsRq1anuas0wF/Ognvvdc5/dhok0KDvD8YdGQzLc02PwftBM/8kbkie9IXqcPPQNsvA083UA4hYdTu5B0PX/X34U+H4QwQY63is/968xuYon7OnRjeUK8Plf2RiKJ7Ugtc4Ddi6QzIP8tG0ofhhNgvD+QPEyJ/T1crcCefNNho2oIUmfltnIaotF4Lqytv8J JqzWzLLV xy4PV4kT9efyXgrGvGltL6PH3bdfNzOEoig8QW2RvhYTvc8XYGj7OPXtRU00W/lf4ObcnkK4mssWHxl5Zyt9ZP6x5LdW1HqZXaQ1PHiOk6xHuOb/KllEUUNvP2V6LyzQnx9xNVqIOX8sAU0CM0wPLDiPz0TA+7t5wa81k6Wp/ppl+5o+JEnvCX2RocIy4VSvF+mk79eVFBc9G2gET+wE6abd2/Dv16yH49M8QGay9oMWgjlHUdiBCb0sCD6H6I70McwQ4JFpsChTfZPiisbC3xxSpRq52vH4EgYXpozuev9rNtUsNJDTML48uQRHkDcW+KOll2WiCbx5dyHo4WwwKYsUkNSAIhEE+PaanytTRr+UtNbfsR+Q3+Wg7hdbbHcSDpPLM8DWkcCWqiYSvVwF+nukjiQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.083389, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 11, 2024 at 1:50=E2=80=AFPM Matthew Wilcox wrote: > > On Thu, Jul 11, 2024 at 01:47:00PM -0700, Yang Shi wrote: > > +++ b/mm/huge_memory.c > > @@ -857,7 +857,8 @@ static unsigned long > > __thp_get_unmapped_area(struct file *filp, > > loff_t off_align =3D round_up(off, size); > > unsigned long len_pad, ret, off_sub; > > > > - if (IS_ENABLED(CONFIG_32BIT) || in_compat_syscall()) > > + if (IS_ENABLED(CONFIG_32BIT) || IS_ENABLED(CONFIG_X86_32) || > > + in_compat_syscall()) > > Why not: > > if (!IS_ENABLED(CONFIG_64BIT) || in_compat_syscall()) Nothing specific, just didn't think of it, sigh... Thanks for the suggestion. Definitely preferable way. >