From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8D30C4363A for ; Thu, 29 Oct 2020 15:57:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3410D206ED for ; Thu, 29 Oct 2020 15:57:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rpMrco7c" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3410D206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 57C356B0068; Thu, 29 Oct 2020 11:57:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 504EA6B006C; Thu, 29 Oct 2020 11:57:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37EE76B006E; Thu, 29 Oct 2020 11:57:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0001.hostedemail.com [216.40.44.1]) by kanga.kvack.org (Postfix) with ESMTP id 011196B0068 for ; Thu, 29 Oct 2020 11:57:46 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 913FE180AD817 for ; Thu, 29 Oct 2020 15:57:46 +0000 (UTC) X-FDA: 77425418532.01.spoon65_340b0802728e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 6D0C710047836 for ; Thu, 29 Oct 2020 15:57:46 +0000 (UTC) X-HE-Tag: spoon65_340b0802728e X-Filterd-Recvd-Size: 3954 Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Thu, 29 Oct 2020 15:57:45 +0000 (UTC) Received: by mail-ed1-f66.google.com with SMTP id dn5so3528328edb.10 for ; Thu, 29 Oct 2020 08:57:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JPnk/G7BX8SIzBEguNflOMTQJEcMKd2LhAeOHUohXx0=; b=rpMrco7c8TIn+xeDLi4hUw/J2nDZC1S/yseVOZolm5cwBmWMXh9/I84w1CHoq+iLOy QY3YBcqavaSD/pX6kNIGp5Oq1fTAubJXFM3yaXkrYJ3lcYyR/gW87npmYbnu30kXbyCi kRgUU9BVdp8yAPaYnp3oSmW2poLHKvpLtLlLxY2vtYJS7P9VLZ3W1ovDJuQvJRxd/JE3 c5RZQmScQcvTt3NZbrrHwYFGdOxYKot2payT1OwVdJU0+DeqV6ZNvDufPVPQfrD5Br3U 7ZT4bJd28mJ22FB4N9UiZeEc48BxxTS17rlfGXaRxt8uhL0+kHx9KQZsgbY6wVOSFMEN s0iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JPnk/G7BX8SIzBEguNflOMTQJEcMKd2LhAeOHUohXx0=; b=StFQr3L0UoYtXW/wEHo6xL7SYAq5h3cuOgm1LSHqnseX4MG8W1OaKrOuPOIv5mZYky OQFBsL1cR557OhODVjYCupfkn5LWMR6HstS4ll0ms3AhvCBg0IDGSLW5d+zXfMhnee6U zo7X6XV4qJrb9VjRsPC590jKFYBYIwRmXGm/pO35NJN1XJ6Flv1ckLw58LQG5l48E+av LDzk0z00SYW2+1RHRHjTUDPi+o/p+01gZHcCbwo+VBCS/JGhzfIRHIfq682Ufg8Envdy kNdA+lddPgynlgoe5e3ycwwXzs5bmgIo12jYRQsuZotqAKFgUOLo7ncxSJtlTlRqVVGs 33AQ== X-Gm-Message-State: AOAM5314dDARImHtbZiWzgqg9fFRB0ZVNVkBLtyBacKUxlbdadbufU8z Jv33/DiStmMsCJ4iabGH23PQBxNx4t4fLsyDRdk= X-Google-Smtp-Source: ABdhPJzJt8zjHrjYi/9z5vlQquco3PAqMPP/29FKyDPYEzhWuf/iF4bwR5KUYd7dXJw1vuR4gDnv62+UgHjbfiq5HMQ= X-Received: by 2002:a05:6402:6d8:: with SMTP id n24mr4776181edy.168.1603987064744; Thu, 29 Oct 2020 08:57:44 -0700 (PDT) MIME-Version: 1.0 References: <20201007161736.ACC6E387@viggo.jf.intel.com> <20201007161749.4C56D1F1@viggo.jf.intel.com> <20201029081454.GA30442@linux> <99dff0cd-2b1a-2c41-2596-eda7ecc7c160@intel.com> In-Reply-To: <99dff0cd-2b1a-2c41-2596-eda7ecc7c160@intel.com> From: Yang Shi Date: Thu, 29 Oct 2020 08:57:32 -0700 Message-ID: Subject: Re: [RFC][PATCH 7/9] mm/vmscan: Consider anonymous pages without swap To: Dave Hansen Cc: Oscar Salvador , Dave Hansen , Linux Kernel Mailing List , Linux MM , kbusch@kernel.org, "Verma, Vishal L" , Yang Shi , David Rientjes , Huang Ying , Dan Williams , David Hildenbrand Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000138, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 7:33 AM Dave Hansen wrote: > > On 10/29/20 1:14 AM, Oscar Salvador wrote: > > With this patch, we will use always the atomic version > > get_nr_swap_pages from now on. Is that ok? I guess so, but it might > > warrant a mention in the changelog? > > I _think_ it's OK. But, you're right that it's a potential behavior > change that's not mentioned in the changelog. > > I'll mention it in the changelog and see if I can dream up any other > practical implications from this change. IMHO, we don't have to modify those two places at all. They are used to rebalance the anon lru active/inactive ratio even if we did not try to evict anon pages at all, so "total_swap_pages" is used instead of checking swappiness and available swap space. The changes may result in imbalanced anon lru. > > Thanks for taking a look! >