From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D2D1C433F5 for ; Mon, 14 Mar 2022 17:34:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F02DD6B0071; Mon, 14 Mar 2022 13:34:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB2E58D0002; Mon, 14 Mar 2022 13:34:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7A798D0001; Mon, 14 Mar 2022 13:34:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id C4A676B0071 for ; Mon, 14 Mar 2022 13:34:30 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 75A911808C937 for ; Mon, 14 Mar 2022 17:34:30 +0000 (UTC) X-FDA: 79243691100.31.F806EA1 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf30.hostedemail.com (Postfix) with ESMTP id DDD9180007 for ; Mon, 14 Mar 2022 17:34:29 +0000 (UTC) Received: by mail-pl1-f175.google.com with SMTP id n2so14170880plf.4 for ; Mon, 14 Mar 2022 10:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CcHP8n4xtuNuolJ/LTK32L7lLsQLGVbj8PkneJtl+jA=; b=I02igLL//BGsHnk7q1Iu0tjDOAKFUc7OCqxNL7bkuq06fsHUQHIaSR1pzgk7SqFgAq Y4Hi1Xb5y6QuW6c1pu+nI109X+0KBIhFJMLsZEZfXZksr5YAAlSLVzzuKKrno1Mk4ikh g3piJjUiAasrUkQGFJ1zZ8YNm+QId+ZssW5GomynQ9PGNQzy21JXYegtH85bTREuhL7I /HAfztEvBTEqyedbbnxobKByArDB82xJuH9wmJA0d/PQ0UPJKbzB4p7mBwuCoX1+7U8F 9BK3O/bf/R0CiO9ayj65XaUrxvtp0nC3yVWAVUzDkTA/fkah6qV5xm49zTEy1HyUqa3k V0QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CcHP8n4xtuNuolJ/LTK32L7lLsQLGVbj8PkneJtl+jA=; b=a5uGHOOv/i3ZgYzlL0YZK7eg+ey35Xf71l66kLrsWMGfqemFv6fhiBFt3ka+h9kXUz R+Fcpu9tf0muACKXpQhc60TDMu4LqAjGNL4sX9sQzA+tQ1J3gZgeMlCwF+prNqs4Skpa 2PeopzXA973ymAXpQfubPfY0HZvZp0qdL7SKOlvCLma1hz9nOj5sXfHa3Im3Zpca5HTE Ml4ctIUtvx1pjHDTppglO2MfDNR2mJaeMqSzTUP8WVE2hWsg2uHsgl58n1B5ynLWFnnw /Y7Xiksous+ZbHRNDiyKZsjkCoRoCvi5rWwE0CFeqVqjXhJYpxh9s/QdxVrnwMJRLtOM EI/g== X-Gm-Message-State: AOAM533gqlT60bWuawD2hN/b65dQgNIbYBlnk+anAsYv++qrUH5D5QCn kSq591ndYDl2zgG/zojsIasDwpaSdyhuFaD5/t4= X-Google-Smtp-Source: ABdhPJyXmcMDtH2qOdtDOufWlVuBQ+aJdiEMM8xw+FZt5o4ecpnj24p8rZJYBpCOqw5nFxE1WR//PxQ8S2E0ELNFEXY= X-Received: by 2002:a17:903:124a:b0:151:99fe:1a10 with SMTP id u10-20020a170903124a00b0015199fe1a10mr24476612plh.87.1647279268835; Mon, 14 Mar 2022 10:34:28 -0700 (PDT) MIME-Version: 1.0 References: <20220312074613.4798-1-linmiaohe@huawei.com> <20220312074613.4798-4-linmiaohe@huawei.com> In-Reply-To: <20220312074613.4798-4-linmiaohe@huawei.com> From: Yang Shi Date: Mon, 14 Mar 2022 10:34:17 -0700 Message-ID: Subject: Re: [PATCH v2 3/3] mm/memory-failure.c: make non-LRU movable pages unhandlable To: Miaohe Lin Cc: akpm@linux-foundation.org, tony.luck@intel.com, bp@alien8.de, naoya.horiguchi@nec.com, mike.kravetz@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: DDD9180007 X-Rspam-User: Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="I02igLL/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of shy828301@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-Stat-Signature: 9hja4zkzxaho7isr4tdfnmyow1946ama X-Rspamd-Server: rspam04 X-HE-Tag: 1647279269-653989 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 11, 2022 at 11:47 PM Miaohe Lin wrote: > > We can not really handle non-LRU movable pages in memory failure. Typically > they are balloon, zsmalloc, etc. Assuming we run into a base (4K) non-LRU > movable page, we could reach as far as identify_page_state(), it should not > fall into any category except me_unknown. For the non-LRU compound movable > pages, they could be taken for transhuge pages but it's unexpected to split > non-LRU movable pages using split_huge_page_to_list in memory_failure. So > we could just simply make non-LRU movable pages unhandlable to avoid these > possible nasty cases. > > Suggested-by: Yang Shi > Signed-off-by: Miaohe Lin Reviewed-by: Yang Shi > --- > mm/memory-failure.c | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 2ff7dd2078c4..ba621c6823ed 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1177,12 +1177,18 @@ void ClearPageHWPoisonTakenOff(struct page *page) > * does not return true for hugetlb or device memory pages, so it's assumed > * to be called only in the context where we never have such pages. > */ > -static inline bool HWPoisonHandlable(struct page *page) > +static inline bool HWPoisonHandlable(struct page *page, unsigned long flags) > { > - return PageLRU(page) || __PageMovable(page) || is_free_buddy_page(page); > + bool movable = false; > + > + /* Soft offline could mirgate non-LRU movable pages */ > + if ((flags & MF_SOFT_OFFLINE) && __PageMovable(page)) > + movable = true; > + > + return movable || PageLRU(page) || is_free_buddy_page(page); > } > > -static int __get_hwpoison_page(struct page *page) > +static int __get_hwpoison_page(struct page *page, unsigned long flags) > { > struct page *head = compound_head(page); > int ret = 0; > @@ -1197,7 +1203,7 @@ static int __get_hwpoison_page(struct page *page) > * for any unsupported type of page in order to reduce the risk of > * unexpected races caused by taking a page refcount. > */ > - if (!HWPoisonHandlable(head)) > + if (!HWPoisonHandlable(head, flags)) > return -EBUSY; > > if (get_page_unless_zero(head)) { > @@ -1222,7 +1228,7 @@ static int get_any_page(struct page *p, unsigned long flags) > > try_again: > if (!count_increased) { > - ret = __get_hwpoison_page(p); > + ret = __get_hwpoison_page(p, flags); > if (!ret) { > if (page_count(p)) { > /* We raced with an allocation, retry. */ > @@ -1250,7 +1256,7 @@ static int get_any_page(struct page *p, unsigned long flags) > } > } > > - if (PageHuge(p) || HWPoisonHandlable(p)) { > + if (PageHuge(p) || HWPoisonHandlable(p, flags)) { > ret = 1; > } else { > /* > @@ -2308,7 +2314,7 @@ int soft_offline_page(unsigned long pfn, int flags) > > retry: > get_online_mems(); > - ret = get_hwpoison_page(page, flags); > + ret = get_hwpoison_page(page, flags | MF_SOFT_OFFLINE); > put_online_mems(); > > if (ret > 0) { > -- > 2.23.0 >