From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E03E2C433ED for ; Tue, 18 May 2021 20:19:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 788DE610E9 for ; Tue, 18 May 2021 20:19:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 788DE610E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ED0058E004F; Tue, 18 May 2021 16:19:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7E978E002F; Tue, 18 May 2021 16:19:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1FFF8E004F; Tue, 18 May 2021 16:19:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0072.hostedemail.com [216.40.44.72]) by kanga.kvack.org (Postfix) with ESMTP id A323A8E002F for ; Tue, 18 May 2021 16:19:42 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 453F1824999B for ; Tue, 18 May 2021 20:19:42 +0000 (UTC) X-FDA: 78155467404.12.980E5FC Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf03.hostedemail.com (Postfix) with ESMTP id 91F15C000C73 for ; Tue, 18 May 2021 20:19:40 +0000 (UTC) Received: by mail-ej1-f46.google.com with SMTP id p24so15321757ejb.1 for ; Tue, 18 May 2021 13:19:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AbjKDwD1WRRxmkhXc4f3TugAgjL4KbmiuHqJM1zpTUo=; b=IRuZgZtPG7LPVpmRZeET6NZ2nUuo/rMgBH40E6dtMMqRu/janHK2WrJ1WE5BQ6xR3L Of0dOjvc29GpBADtaHjv82d4GytQD3CByP51KBsTCelfA2a00s9gKUSteF5oAgznkjE/ 7+xvgGWolTbd7loHjJeop7lYPMFIZqHekb6wrP41Q2oTLsJj7J02CA+wt+sfWOuVR1KS QpaR+JzM5ud7py7Wd/q5k1n+b9Q+TRwljLGB58Rbwn0BPtvSsTjsbhWpaJgmYMc7IdKl qY9qylcFFgtdwiEdt9Yd4E6lyn4Qw0F8UF4LXVGtTYXhIwAu73QTmtdS/WVJT+QLTDsJ Zdpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AbjKDwD1WRRxmkhXc4f3TugAgjL4KbmiuHqJM1zpTUo=; b=IvVnZFuzIFc6V55zp7WgaUWE+Yv6GjFib2ryb8CvBBxMnN0JT0e8dxXFGXFhQgKDFz 6P19niCIeIEjLzrmFMvIEJA+rNwB1ZHy2J/XQeMJ4UrViF8EZLRlo2+gEJoUG0a1IwPn cYV13UCoq2rt8ul5vWlOZNuPXSjf2cXn3WyTNfuOJReVJLOE4cV9iOd7n7sm/UBRBapR s2mjyLg2fpLrGhDXrLXp+UgiDq6iveF9xVcbtuo+1wh26IWD2JobMzzIWUjOdJHxss6C jIKpYTR96PENceeFrxbIDGiw7VYf2cl/FetANYwdVZZIQ2TIELP8diBAE6xrqvJ1VdvH WDmw== X-Gm-Message-State: AOAM533LTFdyOFEQhOgyAMiuT2s30kdGgcgkWKMvp21A1b2ec3vzjtK2 +6LjjEyzH2B86dGDRw4kx64ihyhhidaEr+4rzuU= X-Google-Smtp-Source: ABdhPJzztRLQmBRFMR015kSLwVbJs7ud7gcNtBafi3NrcJ4G/wbN67YksdWdiHm8F4e5xKQxmN/kDCovr3axkj55iUw= X-Received: by 2002:a17:906:1699:: with SMTP id s25mr7720560ejd.238.1621369180706; Tue, 18 May 2021 13:19:40 -0700 (PDT) MIME-Version: 1.0 References: <20210518200927.69011-1-jrdr.linux@gmail.com> In-Reply-To: <20210518200927.69011-1-jrdr.linux@gmail.com> From: Yang Shi Date: Tue, 18 May 2021 13:19:29 -0700 Message-ID: Subject: Re: [PATCH] mm/huge_memory.c: Remove unused variable unmap_success To: Souptick Joarder Cc: Andrew Morton , Linux MM , Linux Kernel Mailing List , kernel test robot Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=IRuZgZtP; spf=pass (imf03.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 91F15C000C73 X-Stat-Signature: n6ayfghkamzpyn3nf5c8xhx9595a84ej X-HE-Tag: 1621369180-33360 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 18, 2021 at 1:09 PM Souptick Joarder wrote: > > Kernel test robot throws below warning -> > > mm/huge_memory.c: In function 'unmap_page': > >> mm/huge_memory.c:2345:7: warning: variable 'unmap_success' set but not used [-Wunused-but-set-variable] > 2345 | bool unmap_success; > | ^~~~~~~~~~~~~ > > Remove the unused variable unmap_success. > > Reported-by: kernel test robot > Signed-off-by: Souptick Joarder Thanks for catching this. Reviewed-by: Yang Shi Just like https://lore.kernel.org/linux-mm/CAHbLzkonsd9f=48+cxKOJamNb9e8qpvWJCYDGFB_wNTdET2zmQ@mail.gmail.com/T/#t, not sure why my compiler didn't catch such warning. > --- > mm/huge_memory.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 52ca04b905cf..ff79a12993c9 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2342,14 +2342,13 @@ static void unmap_page(struct page *page) > { > enum ttu_flags ttu_flags = TTU_IGNORE_MLOCK | > TTU_RMAP_LOCKED | TTU_SPLIT_HUGE_PMD; > - bool unmap_success; > > VM_BUG_ON_PAGE(!PageHead(page), page); > > if (PageAnon(page)) > ttu_flags |= TTU_SPLIT_FREEZE; > > - unmap_success = try_to_unmap(page, ttu_flags); > + try_to_unmap(page, ttu_flags); > } > > static void remap_page(struct page *page, unsigned int nr) > -- > 2.25.1 > >