From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4237BC46CCD for ; Thu, 21 Dec 2023 18:07:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B87D36B0087; Thu, 21 Dec 2023 13:07:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B38326B0088; Thu, 21 Dec 2023 13:07:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FFD26B0089; Thu, 21 Dec 2023 13:07:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8DE336B0087 for ; Thu, 21 Dec 2023 13:07:25 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 538B9120635 for ; Thu, 21 Dec 2023 18:07:25 +0000 (UTC) X-FDA: 81591607650.23.0687A9A Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf21.hostedemail.com (Postfix) with ESMTP id 63BC61C0024 for ; Thu, 21 Dec 2023 18:07:23 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aWNa+GiH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of shy828301@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703182043; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2vwxm4MQFnXmGAoqWrhD8p/Elnnju7eM5veCA6QYgeM=; b=2mtRKAZe4LSEW+FzSLdaEggeLncZBPvpgBS3SOUEaN5pZQsSW5PpvkM/sM6eeruRKC7sBf iGwMpyiGmmlWORIkKkTmq1clV7Uy/88EXVihksEzCnQYmaBecXp/ntIlGEC0qs3oxOWvhX YSyeP4oZWaX76c9I2TiDB5XzLgkCaew= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aWNa+GiH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of shy828301@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703182043; a=rsa-sha256; cv=none; b=LqbjHNU5uTK38w6gpOptJ793rXeNKvVhIZEktnXyB1rabWzNC+fWkHx5HtGA4qpXP99be3 ALD9BXhQVXvZ3X6QpGbxnT6VrRFaw0VJqczx+XBzJGmKyxCFsS3Pn/ODVR2iGzM7WQwYDT Tu2YQZYQwi0AE103BjP8thprFjkgvGQ= Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-28b400f08a4so861606a91.1 for ; Thu, 21 Dec 2023 10:07:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703182042; x=1703786842; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2vwxm4MQFnXmGAoqWrhD8p/Elnnju7eM5veCA6QYgeM=; b=aWNa+GiHosmbuqgkGPtnM+Z8bnCM+CDATI/+Jg+Wy3mkhPyp0BvPsM7x3PlVslI5gN NRLB5LIM17jTggpfj0lJQPd7ChQVdvCz4xCglds+yym+BHUEjIDb8M+NuAbPS5CmTLbs zMpjkngygVQSMHeFUoOv3+1RX6psD5v7l6F513k0fw7WTCAKSU55V+nICunLGu1ZGk6F eEWU+wxFOkSifZh2Vi7h0Ew21tcB55h+K6MI+JSAo0neaUNFtDuVd5cduXSKsEEYr8zQ eUifNeuEiMzs3vHTQgcMERKFYPsfRtmjcZLX1DY7yV3oWIWaMdBY+KyyCCvpvDK3lygK bnrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703182042; x=1703786842; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2vwxm4MQFnXmGAoqWrhD8p/Elnnju7eM5veCA6QYgeM=; b=FQywvF4Bi8YoRH0V3VghxnCW75r/Up4mxeSXSsrjB7DXp/30cYCYkXpAn8VPapaOuE qSY4EmrMx+N+fcU2spxgTEQ5Aq12JnYvzz5uk319S/axUFUccpyfvXYVE/RGQ2jvMVfY hr6rJxpRU72qdU9xH6S57abC0E6c/QYsWIKNt7RAytZuT7yVRjCt7mEiLpEPMscmfxs2 nMymaX6IDXCCrgMPQ5kiUxk87u2vYlWMeQTt3sMAwqUarxJeXqGVcXLWqSUjUUtS6Z1H QZw8idbFmkAaQQvl3QwputGp/8KdEhpv1AlUyZEbmQX0a7Rj+y+XF0ZBCyF/plniLn56 D4vw== X-Gm-Message-State: AOJu0YxZAZktlV9uuX8F8F67FB6SdTSdPgnQ4ImX2NW303vb54IapX86 KGuUzcNzqsCxc4jnGzIttIKkcqixsob0brNqPOODdY30 X-Google-Smtp-Source: AGHT+IHgFrSJEiJzYZUEnd12x4d9QQsMLaIrDdPk07kby7mfbP3yC87Js/SZ1hHmoSSEOZ+YSyUpUR/gyVK/CHIYHHo= X-Received: by 2002:a17:90a:ce05:b0:28c:5b6:f95e with SMTP id f5-20020a17090ace0500b0028c05b6f95emr21572pju.5.1703182042204; Thu, 21 Dec 2023 10:07:22 -0800 (PST) MIME-Version: 1.0 References: <202312192310.56367035-oliver.sang@intel.com> In-Reply-To: From: Yang Shi Date: Thu, 21 Dec 2023 10:07:09 -0800 Message-ID: Subject: Re: [linux-next:master] [mm] 1111d46b5c: stress-ng.pthread.ops_per_sec -84.3% regression To: Matthew Wilcox Cc: Yin Fengwei , kernel test robot , Rik van Riel , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Andrew Morton , Christopher Lameter , ying.huang@intel.com, feng.tang@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 63BC61C0024 X-Stat-Signature: hm9ddi6iy9ofb313yxwg8hop8szqttmu X-Rspam-User: X-HE-Tag: 1703182043-401845 X-HE-Meta: U2FsdGVkX1/UI4ql1Ocz76Udq2jn51VSPaN7HONk0i+14EgegqxQE4NF40Zjar1iIb+MrkpGIxQE/MKuQxtMxfmEUXryXYtHrwwHnmQhXqaacmSfDG0KNT6+JuRuUcOueFpvuHX39F4tXi0oqAGMid6+G0C0+IWgdykeaQhwEuNfc3KVhYIs8YxO3NIvSPd3DQ5Vc8e2rEhGPEEOIvOBopEPSvt0nZyP2f7Ck1kmU632EyurIjTUgpr+jnXFMSx93+jXOubjSJI0IA3aMulaEpYmHndzGqnqrUlJDTONOMf/AUefaa0kII0Rl2SQphcWU/hdHP6zurPzOR8bDnGcxxaKFkvaIpnLsBmfBZzOUdDGL/9IPh68r2zUJG13POe5LnvCfNYrGPoPRPBNU/HjasloASeHvqt3nLFKEqFq+tvG8A7J421jyd+iN1l6SrcG1tU8ceIgJeuv5UcNR7veeTN52Lgs+zfHjCLvSVFdzL5ZtOJXlw2iJUk8qoaC4YmTfXI/HV1iZpwOI8/aqONRkSPDDInjf04bR93jcJLDf5yDUOtIMh7Otc46ealHma71jARng7H9CU4Na+jfe5/6BHhq+UE/p+3yAAJ3IcKm74ill4S7/sV4+SqtP5y2XTh6xobkHdiMn8fnlAgFTy/EIQ/E95JTQ2lsmtvzutE0NfsgYm1w+JnkQE+cKqckxFFkCCTnOQwSzJ+N91sUL1/hPh9Ojs44RuPvUo5X7Ljx2yFFOLn/wza/17EU9KWaT3Ml8iv2Ibvq/w8BA/IouItxqMmhmf0GzbhKpegYHVEd/dG56pmCgp/T7ajX0VZr+WljIlC7FtdJRzyWAtUJyigqaHqQcLzmTS/j9U8c+ugHKAJMS1DOjcMa44pf9Uz5MRtcRFxyvKbFV8AVoky5S05P2rkhNjo3DfdhgvK/bAAAiXn3nwBx1FspRwQ1MOaaBkfA0Ym6hMCGKJ3Nu82QFNL mS6jOkMj kh5cV9kZ7bB5mrwvQYx1vm5ssVHDuUuMxMQ3y4fFIV1L1EukRhkYX/LA+BFyIPpS8OgJzcid5LP2TVt3rtpDHjO33Q+VnC6H5ZgISZz48fsJozt6TlFn6yyRTw5H1yejqp7DRgr9M3jBtZ0c0epOxvqznRPaCPWoJAvYpRROnsc4LYkt/NVINEb39pOkpA9/J0ZnR6W7CCRvROKTLF/OpjOIfkf3xSD3ltU+KWVgNKmTXxW0PSkz59OniX5eMBNdZWGxNSGrVp7phVapNfJ5E9VxY7GTgQFFiHkmE5VGiiAdqCSiTHfHeBulEeBwBReIZD8B0aA1hu/5IYWrgO94OZyDf85aLETzrMpm39PLxY4IjM2ZgUR8Dr19IRDUbA8CLFPkJB+8UHyfZ+Qd2fhm4BRA4rd0l3p7jd96Lg+S/Ne08VGBm8OcHcmhecPqlGPQlGa17XOavR6abuxg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 20, 2023 at 8:49=E2=80=AFPM Matthew Wilcox wrote: > > On Thu, Dec 21, 2023 at 08:58:42AM +0800, Yin Fengwei wrote: > > Yes. MAP_STACK is also mentioned in manpage of mmap. I did test to > > filter out of the MAP_STACK mapping based on this patch. The regression > > in stress-ng.pthread was gone. I suppose this is kind of safe because > > the madvise call is only applied to glibc allocated stack. > > > > > > But what I am not sure was whether it's worthy to do such kind of chang= e > > as the regression only is seen obviously in micro-benchmark. No evidenc= e > > showed the other regressionsin this report is related with madvise. At > > least from the perf statstics. Need to check more on stream/ramspeed. > > FWIW, we had a customer report a significant performance problem when > inadvertently using 2MB pages for stacks. They were able to avoid it by > using 2044KiB sized stacks ... Thanks for the report. This provided more justification regarding honoring MAP_STACK on Linux. Some applications, for example, pthread, just allocate a fixed size area for stack. This confuses kernel because kernel tell stack by VM_GROWSDOWN | VM_GROWSUP. But I'm still a little confused by why THP for stack could result in significant performance problems. Unless the applications resize the stack quite often.