From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCC8CC433EF for ; Thu, 3 Mar 2022 19:14:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1440B8D0002; Thu, 3 Mar 2022 14:14:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F3D78D0001; Thu, 3 Mar 2022 14:14:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFCE18D0002; Thu, 3 Mar 2022 14:14:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id E0A878D0001 for ; Thu, 3 Mar 2022 14:14:17 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9931DA0F86 for ; Thu, 3 Mar 2022 19:14:17 +0000 (UTC) X-FDA: 79204025754.16.C316480 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf27.hostedemail.com (Postfix) with ESMTP id 18EAF40008 for ; Thu, 3 Mar 2022 19:14:16 +0000 (UTC) Received: by mail-ej1-f54.google.com with SMTP id hw13so12706869ejc.9 for ; Thu, 03 Mar 2022 11:14:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MOPMhEIV3XBqtSikTY4+v1vOWvKvVs3Rd1CFsa26faY=; b=fR/x2GeKfTrG9900nwOrBgV5oSRy4W2QKTw4oL1vHBDVFBa38opaw7zkQ3fLU9TsLn ntWBKdfXvF11tgQtBZbED1QqD8NWDqW/TOsb7DrwQvr7xRz6vtmalgZ/qAUUM3D+CDkS N1fkOb8+Cymr61nGyH5KcFvnbZwcUu3vi3GeSOjkB6mo/uQ7Om7MZl+EReG1/3C5LSkM q3p7IDRiDte3vM4YjYfE8cNWe/XT65G0xlcAhzB4Dhre25tA5tRd0rMngqg+m0a5Vzw2 t14HeSI0vcMIi8fZJHEMwEiN8FGnfbB/zqkhELp53IB4njYD2h3vskak5Xu9MvO70XbU cWRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MOPMhEIV3XBqtSikTY4+v1vOWvKvVs3Rd1CFsa26faY=; b=l5vcSRkqdtkHg2BioPjKhTLcj8NVMKF0cNkhovC/HbAb1v7B81zH+MQIwAA3hH4Qut 5toxktkWE6neII0ZIOdQU6fdCfCmIFpx88EC/cyg8CfweCc5VCtuOUrG20h9rWHeWEDW ZMXy7Ec8PXfFY5CU7+eL7TIOmJAgQNQFuuQOEFt18GcKsiS+lxs7fgcju6uQM2Q+RJQq j6yYtI4cp9ejlKbA/M3JYqzTdnoIt1TjuefqplJnILsDtxqnjta9F/32oAlSldLpIm1J a+yLCpLdYOKDiE7canp6FgbBQZzqM7l8P3m/c+dIBDPPQYhMgLYXhON6MFFu1uYA6mKz yrAA== X-Gm-Message-State: AOAM53123ThWEJ8TskozITW1jO0CLNMCYczbODyGurTX4U0ikYXrDgPt MyMkRZakh/CKrBNJ1RBNGK8H0KxSRD4/NbmuT5Y= X-Google-Smtp-Source: ABdhPJyQRfkxu/g6AA1xO+7oThr+yX8gEw6C/+hhhtZO3+lPLKAOC5cvmmD1Mk0guaV/AzzmFu6KIscF0rWwnMGoeGQ= X-Received: by 2002:a17:906:e28a:b0:6d6:e2e9:d39d with SMTP id gg10-20020a170906e28a00b006d6e2e9d39dmr12350886ejb.2.1646334855632; Thu, 03 Mar 2022 11:14:15 -0800 (PST) MIME-Version: 1.0 References: <202203020034.2Ii9kTrs-lkp@intel.com> <6c8b9d6b-fc31-11d6-c5d4-c18b3854b4e9@huawei.com> In-Reply-To: <6c8b9d6b-fc31-11d6-c5d4-c18b3854b4e9@huawei.com> From: Yang Shi Date: Thu, 3 Mar 2022 11:14:03 -0800 Message-ID: Subject: Re: [PATCH 4/8] mm: thp: only regular file could be THP eligible To: Miaohe Lin Cc: Dan Carpenter , kernel test robot , kbuild-all@lists.01.org, Linux MM , Linux FS-devel Mailing List , linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, Linux Kernel Mailing List , kbuild@lists.01.org, Vlastimil Babka , "Kirill A. Shutemov" , Song Liu , Rik van Riel , Matthew Wilcox , Zi Yan , Andrew Morton , "Theodore Ts'o" , Andreas Dilger , darrick.wong@oracle.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 18EAF40008 X-Stat-Signature: wra5gwnt519qjxipnz3kmfa1xzux1nth Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="fR/x2GeK"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-HE-Tag: 1646334856-153298 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 3, 2022 at 3:48 AM Miaohe Lin wrote: > > On 2022/3/3 19:43, Dan Carpenter wrote: > > Hi Yang, > > > > url: https://github.com/0day-ci/linux/commits/Yang-Shi/Make-khugepaged-collapse-readonly-FS-THP-more-consistent/20220301-075903 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev > > config: arm64-randconfig-m031-20220227 (https://download.01.org/0day-ci/archive/20220302/202203020034.2Ii9kTrs-lkp@intel.com/config) > > compiler: aarch64-linux-gcc (GCC) 11.2.0 > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > Reported-by: Dan Carpenter > > > > smatch warnings: > > include/linux/huge_mm.h:179 file_thp_enabled() warn: variable dereferenced before check 'vma->vm_file' (see line 177) > > mm/khugepaged.c:468 hugepage_vma_check() error: we previously assumed 'vma->vm_file' could be null (see line 455) > > include/linux/huge_mm.h:179 file_thp_enabled() warn: variable dereferenced before check 'vma->vm_file' (see line 177) > > > > vim +179 include/linux/huge_mm.h > > > > 2224ed1155c07b Yang Shi 2022-02-28 175 static inline bool file_thp_enabled(struct vm_area_struct *vma) > > 2224ed1155c07b Yang Shi 2022-02-28 176 { > > 2224ed1155c07b Yang Shi 2022-02-28 @177 struct inode *inode = vma->vm_file->f_inode; > > ^^^^^^^^^^^^^^ > > Dereference. > > > > 2224ed1155c07b Yang Shi 2022-02-28 178 > > 2224ed1155c07b Yang Shi 2022-02-28 @179 return (IS_ENABLED(CONFIG_READ_ONLY_THP_FOR_FS)) && vma->vm_file && > > ^^^^^^^^^^^^ > > Checked too late. > > Yep. We should check vma->vm_file first before we access vma->vm_file->f_inode. Ah, yes, thanks for the report and the suggestion. > > Thanks. > > > > > 2224ed1155c07b Yang Shi 2022-02-28 180 (vma->vm_flags & VM_EXEC) && > > 2224ed1155c07b Yang Shi 2022-02-28 181 !inode_is_open_for_write(inode) && S_ISREG(inode->i_mode); > > 2224ed1155c07b Yang Shi 2022-02-28 182 } > > > > --- > > 0-DAY CI Kernel Test Service, Intel Corporation > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org > > > > . > > >