From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B746C47077 for ; Tue, 16 Jan 2024 21:39:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11F2D6B00A0; Tue, 16 Jan 2024 16:39:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A8916B00A8; Tue, 16 Jan 2024 16:39:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E649A6B00A9; Tue, 16 Jan 2024 16:39:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D28606B00A0 for ; Tue, 16 Jan 2024 16:39:35 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AB24F409C3 for ; Tue, 16 Jan 2024 21:39:35 +0000 (UTC) X-FDA: 81686491110.04.6DCBEEC Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf05.hostedemail.com (Postfix) with ESMTP id E4585100012 for ; Tue, 16 Jan 2024 21:39:33 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=m6FApYOz; spf=pass (imf05.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705441173; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sn9WRxszwhkZhf1JTzhEy6otcflMsj6ENkJnNyTS5zU=; b=0UHOvZrExnvrG4VZqmI5dSHKnAq9UWNcFZ/iotiEBiFXNfNYxbVTJgcpy/kCfpTA/fD1wU tQOYty6J6N1c+bW30p7LKE74uCxsdk5RGpqk7CJVRvgo6WAGwYGTWBFA2VszQr8UX+LHDH kKScWxA4nU9yBRU+StF4eYcBMb2uBSI= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=m6FApYOz; spf=pass (imf05.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705441173; a=rsa-sha256; cv=none; b=Xz8T8qD+6Pz4U+6UTJyViqYfgFVCYTR7vEw+SAjmbZydjay+mOSrblAAFgsOcDWUWTdFuX hJOVfK98keH2NMoIS+jQq/Yp+fa2VvL/ghC2mt4jFzHAZA14Dm8PtRuyOO1M0+bsJD0JND BOlu5HhTe3CM1x23awsrAl1KOHsDRC4= Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-517ab9a4a13so7999225a12.1 for ; Tue, 16 Jan 2024 13:39:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705441173; x=1706045973; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=sn9WRxszwhkZhf1JTzhEy6otcflMsj6ENkJnNyTS5zU=; b=m6FApYOz2KVDoUWsF0lhbzVXmgQcRDHlql8iYmTuVVIrVGxV3I0S3h+jV4QprrGJPx j5wg3mPWOgn8QqgIWcXDtLy1pUzj4m85BqjodsG2tLZu8HJZHUBjc65uxTHypVehcKHC K1URBPM/3Cg5rnxKw/JLo7GBZ2ctuecr/duhnkIfMXI+BV8ldmTax+UGDbG+Ya8W0VmC JxtMX0BoKFwggv6c/OYSN4MFHgsosybZXknLicDPiz1RD75SnROEqEl7a6VBY898hGmP QWA6Lu1a+080OFczZrYl+1SXMC1IzVtQBOa6Hu7t0oE4yH0d5dfQkKFmWAE7i2p53AgV yKWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705441173; x=1706045973; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sn9WRxszwhkZhf1JTzhEy6otcflMsj6ENkJnNyTS5zU=; b=oPFdlt9yzmNCD0WRlr11q+4CuheUDLmf9kGl333fdiM6mB5WqTjTJKNFdtNH3PQ9SB C7JohRWNQqzRYLKg9RZZnRq0Kd30Vx5J7uAKZ2lue8x7vXPxQZSsZMQjqOPd5HAGNrS/ v/e+g2XDQ5vPlxj9KN0rsKqLzdCRe38NByALxOWzcqRrNbIK3rju9CLK7IBVdFDLMzaW og7MJAzCLBwnh4Fru4P8U+aJufytyyxaqUo8gUZ2gqQKv1yUpZgsmxmjXTwvdPWbYENN ayQwG6wnaJzS2VAlnOijnk7Ju6bYFi+h3omwuORsHIdupw23u3YsnLWukZDRTsj7dJFs gQrw== X-Gm-Message-State: AOJu0Yy1d0R8Xve/PcGl+T+HchPY4Y+UaZk6aRwuyImhNy6fp05AFSTK rd7LMhYzMLIMCanZfRMhe2RCt9gn7r1hPm+Eoqw= X-Google-Smtp-Source: AGHT+IEzZt7O2Sc7ssRMjvQPsqfBvGNDOIRMqRH7bdmPLwfSN3okiE+h45m+bhNx9/rquAIig9ZxSSkZ0ZAR8g18cik= X-Received: by 2002:a05:6a20:7c25:b0:19a:5d55:2d8 with SMTP id p37-20020a056a207c2500b0019a5d5502d8mr7102543pzi.44.1705441172798; Tue, 16 Jan 2024 13:39:32 -0800 (PST) MIME-Version: 1.0 References: <20231221065943.2803551-1-shy828301@gmail.com> <877ckb16xl.fsf@yhuang6-desk2.ccr.corp.intel.com> In-Reply-To: <877ckb16xl.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Yang Shi Date: Tue, 16 Jan 2024 13:39:20 -0800 Message-ID: Subject: Re: [PATCH 1/2] mm: mmap: no need to call khugepaged_enter_vma() for stack To: "Huang, Ying" Cc: oliver.sang@intel.com, riel@surriel.com, fengwei.yin@intel.com, willy@infradead.org, cl@linux.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E4585100012 X-Rspam-User: X-Stat-Signature: gsft857uqfrfhtm9ormhyype6zgxzjkq X-Rspamd-Server: rspam01 X-HE-Tag: 1705441173-68262 X-HE-Meta: U2FsdGVkX184cWCLcoSxFVKK4mcGkHFAhTe/JPZWFTbRbtDWMGF2QkMPPWAebu4eUpO/PufOQ3bFBjaKPa45j0pf2Pq9RjbAAjhqfHCxOW7kxw7lwSULR7zGbq7Rtm8+vpDpqSYog6brnm3UyjtrZ92BD11OirI+ZeSisKNBQvxq6mWy3UXCvnpCllh3j98qG+0I+3sFLtcooIBBOWy2btbi7GxmA6WX63KdtaxlXVjy3d71SxlMyOFOTMgLMzALqiXYPzQiT/9jbST2QvZks6vz5ijfeUTsim2A/cnRKiCD246dUPk45fTZ4lyYLtdcWgh9j/PABEeCaSmtNwvAJjGVgt4ZaMKBZSHRl9Y5qZ9YnBHlvyMSuY9BEgvGLi3xfPhnMKjjoDlKvbREQLpD+YVYm6hOKx5bidPiLmSPGhl3E2uGaiH/Bl/xbwTYyIKmvgYYn4MXrtouvHXzA98qk050OmzgCBY0lV+XyPjMctkLNWWhQAk40l+SlGx3B1/8efcsn9xNWuNJHaLvyrWhQ2An7o0yZzXtPOmO7K/1inkjktK+obiRVMrCt35P17OOB8H4Ke5qT+BJ96Uf2aTIpb+MSmL0NDy74sepMmsfwtLtR7e57kfd0IkdCUSSepWxEmejvS5Yox+c4H0J+ihV7jso+IX2iRo49qeehspqtxoTq/BpFcDGxNkpK7VqEolUMcKZhkaRM9BK+iYzq8wMH2Trx0YI2sHwsKPPTm+V9MG6u9lhpc4qREYrFBb7vf5WP4u5SbdZtU9HgVElnSHiF72kgX9yk5K9BplwlP0Xu/SESA5HK3LXPv2QBX2IOrNl5TD212zdJ8DPJG8kx42OcUum1Idadb3x4rQ6/WkvCVj4gfYC9GbW7zimB+GEvA69wi1Sx8LkFrTlNnAy5hobNbcernXoj11rWNKRW5AoHYwAR3PxXvYHbb2fIhayxCgccOcOuJ2i2yZQZ11jE7V lZAaNHcT SvegqK8eDXT8tqRb+2bQbc7LcZM++vHstIboRRq3j3nxgwgXmSpVUpDINsokyIFdDlIgYJ4dfTCuDSMwMgagwGVzQQGID9T/DVlfpDFw8XmSgIkQdjjZl0Uoq0EtjuCeAg8n/F/MGn26uq7jL2eG0b5YiJB0SLqjHolcMIxjxnRVz+TYZVciwmh6pMywDuLg0PVwiXpyrgP24AGYTAJxJgdr0E3m+SWYTXY5MUwqdHByFDygrH3JaxTEVXcpTNcPaDh28MuJWM5hvZCgUAAlI7MVHXF95gKqWcTugouo94iZT4k2OVMOmAhmnj5T/A1cvz3NtF+DIY8qGjwJJTPweXIAt0MlYzGFsb9zEIf9FduyqksVQUUPVBsJvAGrxgxPlx2by7L+l8nTtiBDfHuS+ifHxbPPPZDZO33NGV3ly6guV7bWZqwlf3iswkpxcqNSxYoIyN3VGTxF3YHdLzkoWKE2gcDL1jepttLbfTmWbOUBt+gB4KcryEvOUn6ng0FD2DqrhlgHNl4rBC4I0uhX5cHyNDw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jan 14, 2024 at 9:52=E2=80=AFPM Huang, Ying = wrote: > > Yang Shi writes: > > > From: Yang Shi > > > > We avoid allocating THP for temporary stack, even tnough > ~~~~~~ > though? Yeah, it is a typo. Thanks for noticing this. > > -- > Best Regards, > Huang, Ying > > > khugepaged_enter_vma() is called for stack VMAs, it actualy returns > > false. So no need to call it in the first place at all. > > > > Signed-off-by: Yang Shi > > --- > > mm/mmap.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/mm/mmap.c b/mm/mmap.c > > index b78e83d351d2..2ff79b1d1564 100644 > > --- a/mm/mmap.c > > +++ b/mm/mmap.c > > @@ -2046,7 +2046,6 @@ static int expand_upwards(struct vm_area_struct *= vma, unsigned long address) > > } > > } > > anon_vma_unlock_write(vma->anon_vma); > > - khugepaged_enter_vma(vma, vma->vm_flags); > > mas_destroy(&mas); > > validate_mm(mm); > > return error; > > @@ -2140,7 +2139,6 @@ int expand_downwards(struct vm_area_struct *vma, = unsigned long address) > > } > > } > > anon_vma_unlock_write(vma->anon_vma); > > - khugepaged_enter_vma(vma, vma->vm_flags); > > mas_destroy(&mas); > > validate_mm(mm); > > return error;