From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FF6DC25B79 for ; Tue, 14 May 2024 21:56:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C47B6B02B0; Tue, 14 May 2024 17:56:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 074826B02B2; Tue, 14 May 2024 17:56:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E56D06B02B1; Tue, 14 May 2024 17:56:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C80F16B02AF for ; Tue, 14 May 2024 17:56:08 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 712A41A016C for ; Tue, 14 May 2024 21:56:08 +0000 (UTC) X-FDA: 82118360016.02.7B74D34 Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com [209.85.222.51]) by imf12.hostedemail.com (Postfix) with ESMTP id AAC6640018 for ; Tue, 14 May 2024 21:56:06 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hvMfuoUk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of shy828301@gmail.com designates 209.85.222.51 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715723766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VqnUZ1TYuNAyNcXd26loTgoWFylrwHFb/LkAEYuc1fU=; b=TYinlreWNMACfPU2O46NOcbOcEVbVEtJjq06P6xtd7MVvQIkWgo97mFQse20GJm2ZSLX59 oCFncc64BQ4QllSnHThGuoWsHObpAXiy8tyvqx//fWBn2SiwjHSGjNhzUX6E7UxckWANkH eqiK1BTglKKZzsq+l2sefPULes/MvR4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hvMfuoUk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of shy828301@gmail.com designates 209.85.222.51 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715723766; a=rsa-sha256; cv=none; b=d4q6VWc1dCg6Ax5s8v1IRTRlwhNZ7kCJDZ7phB9YKqDfCfm3Q+Lzf/XU7AmILn4Mhv7vQq frnptwI66HCy/Gl54enpkVSpXw1GsG/JFX1YqQK/jV+UAekRAEvL16BmWASv0vrTK7n/dX Z72OsQzwzvIQ1KPDg47BwOwHnxyQ1B8= Received: by mail-ua1-f51.google.com with SMTP id a1e0cc1a2514c-7f82c932858so1653872241.0 for ; Tue, 14 May 2024 14:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715723765; x=1716328565; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VqnUZ1TYuNAyNcXd26loTgoWFylrwHFb/LkAEYuc1fU=; b=hvMfuoUkBx2X5OV8M0uyHjnxkSik9KokfdFI/r2f9WaKd8d1VrjKwOXbrNTxz6ZIs9 9k0zzHpBUWXPC8TM92i8M0vC/2kZMhaNE0FQibh2KNYzb8+Tkpa27L6C7mYQBwpIQ2T5 w/F3kzJtkfIY0DeSXa4uf3pYG2pE/Vy71AVikb0TOMIUhrmX28WM8SjKbeOrxxnodLfH zZFI6zyyLWef4ryZnN8cFOJ9tzoU0JMETUxJXmsFi1Q9W6otj/l/GXXP7HDUEDve7CHZ AoIJl/INVmGk23CsKmTjJMLwkPgVGQ0f5pj1B0MBuOBIJfCAIHBYrH4nkmuD09GC0HMS 52tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715723765; x=1716328565; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VqnUZ1TYuNAyNcXd26loTgoWFylrwHFb/LkAEYuc1fU=; b=l+YQ20M2S83dWhoIRckMKgkP3K8yQyTIxQQjqGmai5B8XSD5UFKllSbTYZVHtE8HNv hYa//T94reR6eDKLs1/8EHv5uOJtcWz1qeKs2+D7Iqmo8D2lEEfQS4WeMj6sEQc5u2O5 wDRuVpJSemyMX9y16oOuvv/dBYzD+6S4qpf0EGlU0AkTuUP+jyWjaNeMtM1r+9FHQCrd EEZFdsWnrN+DroD4A9qfqNm68n9rRDhxG2IsFDuF89YwLy9KDCIOFxFcmj4y+BUTvl0x aN+Q6HZxROIBvN9pn0/uieaBlKbsa5KzQK0OyLkXeL1MybyMFnBRaDDGeZXs1EYucufj LQJQ== X-Forwarded-Encrypted: i=1; AJvYcCWGUjzkdxtu4zUIvFeYhSaNU9tQ3mCLzmeBbRLWSJQL4pqeeXKL+f4fRHnKnOZi278WldQeh4RK6CmQU4GtrMYM87s= X-Gm-Message-State: AOJu0YwsHNWysE5W+zCAM9s6BmYwum+UltO52u580CwZj7pTED0xhb9r INsphPq+E8YlEQPtdySjREETE+3MfetaLwbnC/Xn8BN4PmYPHzX2M4U0uSvNHVNSEiymvm1rMst GGT12XuwsR3sYAwx71yqrHlnQ/l4= X-Google-Smtp-Source: AGHT+IGLzOBgHUY87f8e0Twy3+9pCPi3j15GjRmTqzdayIiiA3rorIR2aVB42ywo9o9J/htubvmkklO3I3olKk/wmao= X-Received: by 2002:a05:6102:951:b0:47c:122b:a3bd with SMTP id ada2fe7eead31-48077db7661mr15052080137.2.1715723765650; Tue, 14 May 2024 14:56:05 -0700 (PDT) MIME-Version: 1.0 References: <20240511035435.1477004-1-linmiaohe@huawei.com> <20240514141439.55fba39c81c1af55c9a100e1@linux-foundation.org> <20240514144204.88790f125b0275ef68acf6de@linux-foundation.org> In-Reply-To: <20240514144204.88790f125b0275ef68acf6de@linux-foundation.org> From: Yang Shi Date: Tue, 14 May 2024 15:55:52 -0600 Message-ID: Subject: Re: [PATCH -rc7] mm/huge_memory: mark huge_zero_page reserved To: Andrew Morton Cc: Miaohe Lin , nao.horiguchi@gmail.com, xuyu@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: AAC6640018 X-Stat-Signature: 5i3j9impnsmn1aca6fb4rtf5yz6fxijo X-HE-Tag: 1715723766-471232 X-HE-Meta: U2FsdGVkX18sRYTSgkX5QTRLNSiaQ0A2BmU4pDG852IefbYcdqlS/MgwFqtga5oZlMppf/7gCXHZytEJFINqCbDvyMEVisj/85gbOkgxkLMxtwGkI2T694pX9CdKPjDByNzc2oFXaw2eZIg+Q1KSNMLtLEBTUi4YqcmmgLpcwMs9KyLp4qkyHcy3tLHDMkQHwhgrRup/zimP9bqB5pbrnC2/Q2fWQicdsKm8vvdxDdkli2x/t5rnfrW5TPQikwzyWgJmi0ixxB/oVvVbBZFneROUUmGZbffci2ctfgJ2r6004afa5pGX8Ve+sHsFafEyQwXP2QfKGnm6j4U6cI5IN8Kb9QDiKAcdb1zGyiiN4QOcrCGvXLWJi/S28F1HEuTbhnNV9doWpENFyXwmw2lbHNvy+62zw6K328pff83vdTiUBeFcDq3j7InDe1iftS6ulMLaGacpy/G44yIfxABzDTdosjI33KqDnFDqVx5xYYYOvzjQehU058DBdgknRDfKNNnWpzm2qyLDs0vTFcqotyvhoDL3jOw0fVgD4yWEvr7AN42VzNY7Dl3vkia5QDhqIpqqsX1bABI3vZHNme1qUMA8JaD0GrMseVTEl/aYZVwjcjlrzzV876XmsFKdtTYepQxSghzv+4ehc3hKtaFtxsYHaq4VnQE8Q4xdK+Ez6nY8Cfq4ZjxwvVaUHiMdKBUnENhMVAnnAuIdfl8kuVY4r5AXIcnqWHlRR5JxAAAHtBMw8Ks2Q59R1cjtIjnB7wru1p2KzKTIqzSIv4F1lul0KdWk68fMGF92UVnruZcHAHBkfp9BiogfKyOXfvw1WsPjyV3m9dlZx+8nu4S/7O8k8rm3J/l/IC7g7pqcM1wvaxmB1vMFSLpa+i/GyodkfWhzmmBXIurCwygYZPAImNmhCIDsGBJTh5ISr2RFB2Pds6TWEsOv0wLcUpio01/2grvoqJF1iEIpS3hF9RfYodZ jnKAAcST HqC7v4c0QpCH2X/mdPJScaXGKe65X7TVkeHT9O4axMwQKH9tlY53139BqK8vuE2i72mmfvwqW2564rgiEbKPSzZg8z2l4jVa2ZxRwWEhkVFFexY/JrOqnTDdaeIJ/P5j75iYUArdb7rJY9XvkWvKDZ6vinl4Jt3AYtTtLHkrTwRNloAT8SVo7ny5xNToxlB2GOmbX0P7kny/iFVDN4yaK+f1u27l5I6VwXvCbmXWV7KsW6RyG8arIK1eyLL01INdYfT9mAQe4wPxDvbzkV/b16d1IPSi0ZBjmg5wF/K/pWktHgMD1PwTadFliRfVcm7kyhq0WTPKH2nQfuP6tMIIwSPyqkRNWkmVWXRhYgP3KaTwb3BRIIffYqTFGCz/L84M+mYkcA3cY6ZiFZEFqErjFgHTrfad9CANl9hyDRbmphcQOw+cxMrZ1oxU70irtG3ZhRHXyaBv51Jh8rRgp9q01i6j1IVFNX7G501uYUgA4fyRqyhg+vPTgPGOngEQjLSTk28AD3sOxDEY+WmSmaBPNUD5z/gLApDAcatzPyry9btq3twdOcnmBpLyILh5Vt5gfT4jQrZVWgdAX5kxQvDINw6AcI0RTu7pf4oi+QdLWjGQ8KZrJFM2Wzr3rqLtvRnUUkeig X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 14, 2024 at 3:42=E2=80=AFPM Andrew Morton wrote: > > On Tue, 14 May 2024 15:28:12 -0600 Yang Shi wrote: > > > On Tue, May 14, 2024 at 3:14=E2=80=AFPM Andrew Morton wrote: > > > > > > On Sat, 11 May 2024 11:54:35 +0800 Miaohe Lin = wrote: > > > > > > > When I did memory failure tests recently, below panic occurs: > > > > > > > > kernel BUG at include/linux/mm.h:1135! > > > > invalid opcode: 0000 [#1] PREEMPT SMP NOPTI > > > > CPU: 9 PID: 137 Comm: kswapd1 Not tainted 6.9.0-rc4-00491-gd5ce28f= 156fe-dirty #14 > > > > > > > > ... > > > > > > > > --- a/mm/huge_memory.c > > > > +++ b/mm/huge_memory.c > > > > @@ -208,6 +208,7 @@ static bool get_huge_zero_page(void) > > > > __free_pages(zero_page, compound_order(zero_page)); > > > > goto retry; > > > > } > > > > + __SetPageReserved(zero_page); > > > > WRITE_ONCE(huge_zero_pfn, page_to_pfn(zero_page)); > > > > > > > > /* We take additional reference here. It will be put back by = shrinker */ > > > > @@ -260,6 +261,7 @@ static unsigned long shrink_huge_zero_page_scan= (struct shrinker *shrink, > > > > struct page *zero_page =3D xchg(&huge_zero_page, NULL= ); > > > > BUG_ON(zero_page =3D=3D NULL); > > > > WRITE_ONCE(huge_zero_pfn, ~0UL); > > > > + __ClearPageReserved(zero_page); > > > > __free_pages(zero_page, compound_order(zero_page)); > > > > return HPAGE_PMD_NR; > > > > } > > > > > > This causes a bit of a mess when staged ahead of mm-stable. So to > > > avoid disruption I staged it behind mm-stable. This means that when > > > the -stable maintainers try to merge it, they will ask for a fixed up > > > version for older kernels so you can please just send them this > > > version. > > > > Can you please drop this from mm-unstable since both I and David > > nack'ed a similar patch in another thread. > > https://lore.kernel.org/linux-mm/20240511032801.1295023-1-linmiaohe@hua= wei.com/ > > That appears to link to the incorrect email thread? I meant that patch is actually same with this one. Just used folio interface instead of page. I'm not sure why Miaohe posted two. Maybe target to different version.