From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69450C43334 for ; Wed, 15 Jun 2022 17:36:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F18706B0071; Wed, 15 Jun 2022 13:36:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC8816B0072; Wed, 15 Jun 2022 13:36:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D43CD6B0074; Wed, 15 Jun 2022 13:36:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C17B66B0071 for ; Wed, 15 Jun 2022 13:36:03 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 97D2E2048D for ; Wed, 15 Jun 2022 17:36:03 +0000 (UTC) X-FDA: 79581173406.11.E1AB3A1 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf06.hostedemail.com (Postfix) with ESMTP id 188AC18009B for ; Wed, 15 Jun 2022 17:36:02 +0000 (UTC) Received: by mail-pg1-f180.google.com with SMTP id f65so11994856pgc.7 for ; Wed, 15 Jun 2022 10:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Mi2I/nBbKUPGwcrimfjZmC5H+6RsJZl43u1D1xw78cY=; b=B66OjH+4Usdm01B88GgTuR/lmUJB0yO00pSelOSh083ZtTXiu1AwQJlTqrIt7iN1o1 evsW15/3cKi/CZagQcCEfKXGJumsp1BU+poSvnEn7cudXQmxzKTD3QENL2y2T4976O9j i0ZLhJ0ft2FkpnSj8IzCFrei8kQ9eKB5iSDLexX8j0vcevavvFerz2T3/3rwtxxgqMBm rkj0Kj/vJ19f74xZFOAOJbeuBbmrJmGttzXqv6tyI0TprHd5JAFNP8rbnM7OdJ8RJEQ4 EeeHy39WCK+4xcmilNUWY3DRCFHBOtHPpU9yidhLR60eOltc3A8qXrlixHcMO4Mryy3L RGRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Mi2I/nBbKUPGwcrimfjZmC5H+6RsJZl43u1D1xw78cY=; b=5D5ZnPe5hHgi3KfJ5qkV/rmkpyuHDOt60vKXfvyTo7uanWz8OzywPtnk2E6Xu6C2jj Afgz+GErkqI9ijbFccY6Iyr+VXqg6bFNRwXDzeNvXNmv/gihHiBKEz7GFOs97Qz3igZr hngCMiR5NZq6DPb7uxubJnsheK5IJ5Qbh7ssodcUGUKGDaqUvTHmoWjPwJBiS322GLig Xfk1bQ8iRsCzpASuZkHFEgWs22PiwyJ5jMVZ+0Umm3DkF1d3ceOrrBkpSCk7+DKPfb0n f9SNKgurNJcWZ0T0d682QX2VOKw/TfY+5hMZInFToXy09gKF7MpXa9wi6cbjDWQSwQnP BIsg== X-Gm-Message-State: AJIora89ixCN+StObRa3YAvbrGtCUmaNqfS7TGdiCMATAdjr2r5OZldP R0f3UtYAeEwiFtfpzUleA/8iqX5y9S7UDUVDO6E= X-Google-Smtp-Source: AGRyM1t1JjCHUP3dw4DmAlpOPQwoeQrKrh+19gynjKHWa0zTJBXh1GqCw/KHHovV3kRQib8Hapf/cxIRD+zNC/JSCDw= X-Received: by 2002:a05:6a00:2291:b0:51b:e4c5:627 with SMTP id f17-20020a056a00229100b0051be4c50627mr603454pfe.20.1655314562174; Wed, 15 Jun 2022 10:36:02 -0700 (PDT) MIME-Version: 1.0 References: <20220611084731.55155-1-linmiaohe@huawei.com> <20220611084731.55155-2-linmiaohe@huawei.com> In-Reply-To: <20220611084731.55155-2-linmiaohe@huawei.com> From: Yang Shi Date: Wed, 15 Jun 2022 10:35:49 -0700 Message-ID: Subject: Re: [PATCH 1/7] mm/khugepaged: remove unneeded shmem_huge_enabled() check To: Miaohe Lin Cc: Andrew Morton , Andrea Arcangeli , Matthew Wilcox , Vlastimil Babka , David Howells , NeilBrown , Alistair Popple , David Hildenbrand , Suren Baghdasaryan , Peter Xu , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655314563; a=rsa-sha256; cv=none; b=tZd6qqb6UfaWxp/ZB1ZuSUdlZNSSlNIZHD7QDq8FoYTXVhRT3638dI3m+GBXZap+dOEurE LnMOYUAw+ce/iGZbSBjcvYx7ED+A7Defdbp/zD86aG9R6Vit/4Zz2MfZnJeoUUt8HL6rHe IlyVM7I/VtuFTSgN1L+ysEbClFBN1JU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=B66OjH+4; spf=pass (imf06.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655314563; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Mi2I/nBbKUPGwcrimfjZmC5H+6RsJZl43u1D1xw78cY=; b=V7bNJgbYsuhnlj8lxKhP7hCRI3W0RWCEc08pdl8XpEHUN+VflFPAnnzFPbNhtsioWPbLCt /3b8/ayvKMDHS4NjCHRSLM5Mp/cTIJFiJAX3lStzJ5HH78E8tpW38EU20V7NvTqBQadB41 1ChXrmuttcGsT9ORsjORd3qmbQXM0o4= X-Stat-Signature: bm6i8gbusof814pys3ri5p188r5yco46 X-Rspamd-Queue-Id: 188AC18009B Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=B66OjH+4; spf=pass (imf06.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1655314562-688588 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 11, 2022 at 1:47 AM Miaohe Lin wrote: > > If we reach here, hugepage_vma_check() has already made sure that hugepage > is enabled for shmem. Remove this duplicated check. > > Signed-off-by: Miaohe Lin Reviewed-by: Yang Shi > --- > mm/khugepaged.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 476d79360101..73570dfffcec 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -2153,8 +2153,6 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages, > if (khugepaged_scan.address < hstart) > khugepaged_scan.address = hstart; > VM_BUG_ON(khugepaged_scan.address & ~HPAGE_PMD_MASK); > - if (shmem_file(vma->vm_file) && !shmem_huge_enabled(vma)) > - goto skip; > > while (khugepaged_scan.address < hend) { > int ret; > -- > 2.23.0 > >