From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3865CC433F5 for ; Wed, 13 Oct 2021 21:54:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C88E1610EA for ; Wed, 13 Oct 2021 21:54:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C88E1610EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 53F476B006C; Wed, 13 Oct 2021 17:54:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C6C96B0071; Wed, 13 Oct 2021 17:54:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36764900002; Wed, 13 Oct 2021 17:54:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0079.hostedemail.com [216.40.44.79]) by kanga.kvack.org (Postfix) with ESMTP id 2083D6B006C for ; Wed, 13 Oct 2021 17:54:29 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D7096181AC550 for ; Wed, 13 Oct 2021 21:54:28 +0000 (UTC) X-FDA: 78692768616.34.D587135 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf29.hostedemail.com (Postfix) with ESMTP id A3F71900024B for ; Wed, 13 Oct 2021 21:54:27 +0000 (UTC) Received: by mail-ed1-f50.google.com with SMTP id d3so15849751edp.3 for ; Wed, 13 Oct 2021 14:54:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NR5UsFP3dYqPNqjHTBBDDTVrGmVsspEdSRSWs3/jlLw=; b=BfNHxSB8hxObjp1bMQsBmrGB9gJ7uInlW5FrzpgmA/m7zJl9PFcPC37W4psmH79eGK gSLAud7DlfrAL1n4Ol2KAmBkZghWwQczH30prCvWsAPQGNk0wbDkG7bVnFQtO6QbXDtK nGktlLcBigmWDUO6TDBynu4ONl/OBYAQGfk7IRqv1sCHl9locvaMAgQhxflAcPJlFEjB d/q+j/qdRZheDTAegWYsLf8YVJkw2IT0vibeRG1EaEBFqgB9e5GazN8eUUz/YO8DHF5O qDkrTZ6wm3dSKO2iS3IcNf46f8ADO6WGqioM0eWdwKjluOqNTWjyL2KeywjbBRArY6Yu UMgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NR5UsFP3dYqPNqjHTBBDDTVrGmVsspEdSRSWs3/jlLw=; b=hkmRAT39/p1xyDVbUTu0FkPCbHfw0VUWoJWXc8sO9YegD8c97Mbu1bYEhngVvWXhga vg0mJl8z4vQzzZZaL8pmIzyNuC43uftVt0ts5ODsv51rEDSUbSHftMXFDdKfXQkbDmIy G0WyMZaXjNaUrjj8u9tm0COPtYv6+TPXMQqIyk8yj6iHnspfcScgPFenb8KN0FrYsoYb +0k7/iTm1K3nitGRgvCFMh7QXmsTKcCfmgXy4RCjjJT/XN37xzTszOjfojQgzFLylpZX kYgLDKYaa5btcS72Nsm4mOPlJ4bPRu2UheRoo8XWpYbRki6oix4s/kuIl2KsVxU8ZLJR ojIw== X-Gm-Message-State: AOAM530UTcXp7R9i/245AdJJcdNzashW34y+iKs5ZuLaSCRQXz6cnQdO 0wudcM+LOZ7O37a+PJUaDtKcQdRSMvKZkW7rYPA= X-Google-Smtp-Source: ABdhPJxLKr3XQdGM0E1jJ29PHetPNXpbY/Po16bUBCZNXQ/lC/+9js9YegWX28iqKLeO4yHUOgXXcYjkvzZLRmSyxUs= X-Received: by 2002:a17:906:a94b:: with SMTP id hh11mr2133127ejb.85.1634162067267; Wed, 13 Oct 2021 14:54:27 -0700 (PDT) MIME-Version: 1.0 References: <20211008083938.1702663-1-ying.huang@intel.com> <20211008083938.1702663-2-ying.huang@intel.com> In-Reply-To: <20211008083938.1702663-2-ying.huang@intel.com> From: Yang Shi Date: Wed, 13 Oct 2021 14:54:15 -0700 Message-ID: Subject: Re: [PATCH -V9 1/6] NUMA Balancing: add page promotion counter To: Huang Ying Cc: Linux Kernel Mailing List , Andrew Morton , Michal Hocko , Rik van Riel , Mel Gorman , Peter Zijlstra , Dave Hansen , Zi Yan , Wei Xu , osalvador , Shakeel Butt , Linux MM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A3F71900024B X-Stat-Signature: 6akwqamb741fxqis358ja6sopmu16qt5 Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BfNHxSB8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-HE-Tag: 1634162067-141145 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 8, 2021 at 1:40 AM Huang Ying wrote: > > In a system with multiple memory types, e.g. DRAM and PMEM, the CPU > and DRAM in one socket will be put in one NUMA node as before, while > the PMEM will be put in another NUMA node as described in the > description of the commit c221c0b0308f ("device-dax: "Hotplug" > persistent memory for use like normal RAM"). So, the NUMA balancing > mechanism will identify all PMEM accesses as remote access and try to > promote the PMEM pages to DRAM. > > To distinguish the number of the inter-type promoted pages from that > of the inter-socket migrated pages. A new vmstat count is added. The > counter is per-node (count in the target node). So this can be used > to identify promotion imbalance among the NUMA nodes. > > Signed-off-by: "Huang, Ying" > Cc: Andrew Morton > Cc: Michal Hocko > Cc: Rik van Riel > Cc: Mel Gorman > Cc: Peter Zijlstra > Cc: Dave Hansen > Cc: Yang Shi > Cc: Zi Yan > Cc: Wei Xu > Cc: osalvador > Cc: Shakeel Butt > Cc: linux-kernel@vger.kernel.org > Cc: linux-mm@kvack.org > --- > include/linux/mmzone.h | 3 +++ > include/linux/node.h | 5 +++++ > include/linux/vmstat.h | 2 ++ > mm/migrate.c | 10 ++++++++-- > mm/vmstat.c | 3 +++ > 5 files changed, 21 insertions(+), 2 deletions(-) > > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index 6a1d79d84675..37ccd6158765 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -209,6 +209,9 @@ enum node_stat_item { > NR_PAGETABLE, /* used for pagetables */ > #ifdef CONFIG_SWAP > NR_SWAPCACHE, > +#endif > +#ifdef CONFIG_NUMA_BALANCING > + PGPROMOTE_SUCCESS, /* promote successfully */ > #endif > NR_VM_NODE_STAT_ITEMS > }; > diff --git a/include/linux/node.h b/include/linux/node.h > index 8e5a29897936..26e96fcc66af 100644 > --- a/include/linux/node.h > +++ b/include/linux/node.h > @@ -181,4 +181,9 @@ static inline void register_hugetlbfs_with_node(node_registration_func_t reg, > > #define to_node(device) container_of(device, struct node, dev) > > +static inline bool node_is_toptier(int node) > +{ > + return node_state(node, N_CPU); > +} > + > #endif /* _LINUX_NODE_H_ */ > diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h > index d6a6cf53b127..75c53b7d1539 100644 > --- a/include/linux/vmstat.h > +++ b/include/linux/vmstat.h > @@ -112,9 +112,11 @@ static inline void vm_events_fold_cpu(int cpu) > #ifdef CONFIG_NUMA_BALANCING > #define count_vm_numa_event(x) count_vm_event(x) > #define count_vm_numa_events(x, y) count_vm_events(x, y) > +#define mod_node_balancing_page_state(n, i, v) mod_node_page_state(n, i, v) I don't quite get why we need this new API. Doesn't __count_vm_events() work? > #else > #define count_vm_numa_event(x) do {} while (0) > #define count_vm_numa_events(x, y) do { (void)(y); } while (0) > +#define mod_node_balancing_page_state(n, i, v) do {} while (0) > #endif /* CONFIG_NUMA_BALANCING */ > > #ifdef CONFIG_DEBUG_TLBFLUSH > diff --git a/mm/migrate.c b/mm/migrate.c > index a6a7743ee98f..c3affc587902 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -2148,6 +2148,7 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma, > pg_data_t *pgdat = NODE_DATA(node); > int isolated; > int nr_remaining; > + int nr_succeeded; > LIST_HEAD(migratepages); > new_page_t *new; > bool compound; > @@ -2186,7 +2187,8 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma, > > list_add(&page->lru, &migratepages); > nr_remaining = migrate_pages(&migratepages, *new, NULL, node, > - MIGRATE_ASYNC, MR_NUMA_MISPLACED, NULL); > + MIGRATE_ASYNC, MR_NUMA_MISPLACED, > + &nr_succeeded); > if (nr_remaining) { > if (!list_empty(&migratepages)) { > list_del(&page->lru); > @@ -2195,8 +2197,12 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma, > putback_lru_page(page); > } > isolated = 0; > - } else > + } else { > count_vm_numa_events(NUMA_PAGE_MIGRATE, nr_pages); > + if (!node_is_toptier(page_to_nid(page)) && node_is_toptier(node)) > + mod_node_balancing_page_state( > + NODE_DATA(node), PGPROMOTE_SUCCESS, nr_succeeded); > + } > BUG_ON(!list_empty(&migratepages)); > return isolated; > > diff --git a/mm/vmstat.c b/mm/vmstat.c > index 8ce2620344b2..fff0ec94d795 100644 > --- a/mm/vmstat.c > +++ b/mm/vmstat.c > @@ -1236,6 +1236,9 @@ const char * const vmstat_text[] = { > #ifdef CONFIG_SWAP > "nr_swapcached", > #endif > +#ifdef CONFIG_NUMA_BALANCING > + "pgpromote_success", > +#endif > > /* enum writeback_stat_item counters */ > "nr_dirty_threshold", > -- > 2.30.2 >