From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A06BC388F9 for ; Tue, 27 Oct 2020 16:41:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EA4F92076A for ; Tue, 27 Oct 2020 16:41:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eCyFghPG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA4F92076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5962F6B0062; Tue, 27 Oct 2020 12:41:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51D996B0068; Tue, 27 Oct 2020 12:41:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E7B06B006C; Tue, 27 Oct 2020 12:41:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id 0DD1F6B0062 for ; Tue, 27 Oct 2020 12:41:44 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 974B6181AC9CC for ; Tue, 27 Oct 2020 16:41:43 +0000 (UTC) X-FDA: 77418271686.25.arch63_07106772727d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 679081804E3A0 for ; Tue, 27 Oct 2020 16:41:43 +0000 (UTC) X-HE-Tag: arch63_07106772727d X-Filterd-Recvd-Size: 6512 Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Tue, 27 Oct 2020 16:41:42 +0000 (UTC) Received: by mail-ed1-f68.google.com with SMTP id l24so2114796edj.8 for ; Tue, 27 Oct 2020 09:41:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FZmDD+YwecYMtLs7AF3FCkDHyOxts/Yev02gIWozl0c=; b=eCyFghPGjK49KlpfZ0325tZmiqVZTeRLrVNqj5Gb9jpiNopib6XnZOPOome/iWhWbM vKlwHpfBXdeSTVDpUdp+O183n3p0CgtI2cdh39gsRRU9iAPsxuPBndh8m4vhWZR8VNGb 4331kSpwQ9XrTqAG7MzhQBVfJlPNUQXGfkq5WEZtDAQbLmaJ7ZU4dwWJOENoMtlwCc0g 9WtCv0LA0HIFLgNoa8outBTKEprJCuoJpGKeXRd70p80Cd66rpRjmqIxHOVi++SlyMuY ZEt459ogF4FwWypbDUrC4JtFAauisb2WRCT5O6g35gM+9huFq9khSCNBn/kWna7un2AA 2t8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FZmDD+YwecYMtLs7AF3FCkDHyOxts/Yev02gIWozl0c=; b=dGyqOew8tTPcFPlfwokgl0eTm94+VCxobn2CJfDGwtZYSBICIKhBcD0TjdJgksL3ok jOaSREGJo5MQyjb6+Ch+/DWFiqryxJNCjU/IU0m6T4T/H/qzEBXa4eqbceYpBISwbt65 aguxDjroXzqTv1+uefRPQEieShJy38Nc40960ZN0Ci87P4SRvomqHdLcnwpAM/6mpPpf j46z461dR3nYaLi5iztwqLGB+qj359y1hMvykRznoxwaWlPtY5F8ZX06R4+6AbcAYVac TnmiW8kjzYU7/sIVsPInkGFieQ2PxfXYF0gKREB6IVK8TUqgcZBiD+CsF+z9MV4o4CEj j8Yw== X-Gm-Message-State: AOAM531qjGKdcq+E9drLwa9rWTBkzPNFw02Meu7oyzjl7xqxSufuwQ6S EQqlb1wmMlUz1Q/NV95XGT0+4wphDVjzKRMiaB8= X-Google-Smtp-Source: ABdhPJxE+b5plorT12cDmUEPqZISsyoknTOw4zb/BvzQnJMV3xvzcD7OUAZXB5qvfm4jtx2lLCvNguR3PCR9x8fKfjo= X-Received: by 2002:aa7:cd42:: with SMTP id v2mr3103548edw.151.1603816901602; Tue, 27 Oct 2020 09:41:41 -0700 (PDT) MIME-Version: 1.0 References: <20201007161736.ACC6E387@viggo.jf.intel.com> <20201007161747.FE7288F0@viggo.jf.intel.com> <87v9f6hdik.fsf@yhuang-dev.intel.com> In-Reply-To: <87v9f6hdik.fsf@yhuang-dev.intel.com> From: Yang Shi Date: Tue, 27 Oct 2020 09:41:27 -0700 Message-ID: Subject: Re: [RFC][PATCH 6/9] mm/vmscan: add page demotion counter To: "Huang, Ying" Cc: Dave Hansen , Linux Kernel Mailing List , Linux MM , Yang Shi , David Rientjes , Dan Williams , David Hildenbrand Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 19, 2020 at 12:38 AM Huang, Ying wrote: > > Dave Hansen writes: > > > From: Yang Shi > > > > Account the number of demoted pages into reclaim_state->nr_demoted. > > It appears that you don't add "nr_demoted" into struct reclaim_state. > > > Add pgdemote_kswapd and pgdemote_direct VM counters showed in > > /proc/vmstat. > > > > [ daveh: > > - __count_vm_events() a bit, and made them look at the THP > > size directly rather than getting data from migrate_pages() > > It appears that we get the data from migrate_pages() now. > > > ] > > > > Signed-off-by: Yang Shi > > Signed-off-by: Dave Hansen > > Cc: David Rientjes > > Cc: Huang Ying > > Cc: Dan Williams > > Cc: David Hildenbrand > > --- > > > > b/include/linux/vm_event_item.h | 2 ++ > > b/mm/vmscan.c | 6 ++++++ > > b/mm/vmstat.c | 2 ++ > > 3 files changed, 10 insertions(+) > > > > diff -puN include/linux/vm_event_item.h~mm-vmscan-add-page-demotion-counter include/linux/vm_event_item.h > > --- a/include/linux/vm_event_item.h~mm-vmscan-add-page-demotion-counter 2020-10-07 09:15:32.171642439 -0700 > > +++ b/include/linux/vm_event_item.h 2020-10-07 09:15:32.179642439 -0700 > > @@ -33,6 +33,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PS > > PGREUSE, > > PGSTEAL_KSWAPD, > > PGSTEAL_DIRECT, > > + PGDEMOTE_KSWAPD, > > + PGDEMOTE_DIRECT, > > PGSCAN_KSWAPD, > > PGSCAN_DIRECT, > > PGSCAN_DIRECT_THROTTLE, > > diff -puN mm/vmscan.c~mm-vmscan-add-page-demotion-counter mm/vmscan.c > > --- a/mm/vmscan.c~mm-vmscan-add-page-demotion-counter 2020-10-07 09:15:32.173642439 -0700 > > +++ b/mm/vmscan.c 2020-10-07 09:15:32.180642439 -0700 > > @@ -147,6 +147,7 @@ struct scan_control { > > unsigned int immediate; > > unsigned int file_taken; > > unsigned int taken; > > + unsigned int demoted; > > It appears that this newly added field isn't used in the patch. My original patch tracked nr_demoted in reclaim_stat as well, but it seems Dave dropped that part. If Dave thinks it is not necessary to keep tracking nr_demoted in reclaim_stat, then that field should be dropped. > > > } nr; > > > > /* for recording the reclaimed slab by now */ > > @@ -1134,6 +1135,11 @@ static unsigned int demote_page_list(str > > target_nid, MIGRATE_ASYNC, MR_DEMOTION, > > &nr_succeeded); > > > > + if (current_is_kswapd()) > > + __count_vm_events(PGDEMOTE_KSWAPD, nr_succeeded); > > + else > > + __count_vm_events(PGDEMOTE_DIRECT, nr_succeeded); > > + > > return nr_succeeded; > > } > > > > diff -puN mm/vmstat.c~mm-vmscan-add-page-demotion-counter mm/vmstat.c > > --- a/mm/vmstat.c~mm-vmscan-add-page-demotion-counter 2020-10-07 09:15:32.175642439 -0700 > > +++ b/mm/vmstat.c 2020-10-07 09:15:32.181642439 -0700 > > @@ -1244,6 +1244,8 @@ const char * const vmstat_text[] = { > > "pgreuse", > > "pgsteal_kswapd", > > "pgsteal_direct", > > + "pgdemote_kswapd", > > + "pgdemote_direct", > > "pgscan_kswapd", > > "pgscan_direct", > > "pgscan_direct_throttle", > > _ > > Best Regards, > Huang, Ying >