From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FF00C43334 for ; Tue, 5 Jul 2022 19:46:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F30B26B0071; Tue, 5 Jul 2022 15:46:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE0EE6B0073; Tue, 5 Jul 2022 15:46:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA92E6B0074; Tue, 5 Jul 2022 15:46:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C94A06B0071 for ; Tue, 5 Jul 2022 15:46:04 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 94DB1601E4 for ; Tue, 5 Jul 2022 19:46:04 +0000 (UTC) X-FDA: 79654077048.14.F733B06 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf03.hostedemail.com (Postfix) with ESMTP id 38DCB2000A for ; Tue, 5 Jul 2022 19:46:03 +0000 (UTC) Received: by mail-pl1-f175.google.com with SMTP id c13so8095621pla.6 for ; Tue, 05 Jul 2022 12:46:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BxbTn0CECdrZXETflGt2gGDbEAPGwlDhM6o4bF0C3yE=; b=Fdw6fzHTpa73THj5FbnWvsryc9rX9O54EvNLbsmVn8I2OqAr35tJitYbGgkTDKBqwq 195R0eKEaHXRMxRuYaHFdey6D6R5j8lnecgTglFyJ5u2Sxa3BV4KDrjhCQAvy5hAQg8K NnBaFDbUCRr+zIrvGQ+p6HSLSFQaA0+G69is3GhXEycNbYxDTyVmSHm6CKVwEkAAf3W9 ZXJwspvQ0f/RvRrlmkvyyMdu3f5U+LsH/zsrrmzN7VXBxi7qGUR9D5olyg+R0ZD5o8kg 69JxKMa050Xl4PspweOy03E95RIAvogwR8rcssCIiTyYyhCItPBpf5TS4xfl8gplnW4F g81w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BxbTn0CECdrZXETflGt2gGDbEAPGwlDhM6o4bF0C3yE=; b=3B2/zjkhZnlbeK6trkl3UxZRe8HvcZJ1oSLmKTjPsQU/2VLDg44vMFFaaZyNmfNE/H 2BKFUAmCOHtszpwYcW3hTuetV4cp87tPTOhkiVN7VEe928qtbBjBiQe+sDjVCUq21QHh q62A0SRzhtLPTmooDmSONwUy/O0adGzT/5W/I8BSiqQdOH9wxcfD79qBhwd3vivJ9JZC Atxxr1K8ZT8dseTkWQP4z2B275IK+pCrGj3s95muZobfgc3kzY2FSYb+hoqD2KPO3CG6 1q048gnFcRWzaPRYGwOMXhkz78UcE8zCqlxUP6VpNVjJhoceCjV+baxyg90Xdd3xRY6o Lo4A== X-Gm-Message-State: AJIora9505s9Cz6GiX531qlHNrg+pnWdveSKcDTG9y7W6z7UmTPidfbl sCMV/ESNgRA2f1hnZfD0NLtNRFRRrtkE166IHz8= X-Google-Smtp-Source: AGRyM1vnZOyBKIvJzumKYrmgw1LwXomVfZE8/AO11upfxcNuo8eGdcG5ysjznGDWIIJwoyjStENtCUcgLB4X8pZIVUg= X-Received: by 2002:a17:902:ab8a:b0:16a:7cf2:a394 with SMTP id f10-20020a170902ab8a00b0016a7cf2a394mr41982956plr.26.1657050363017; Tue, 05 Jul 2022 12:46:03 -0700 (PDT) MIME-Version: 1.0 References: <20220616174840.1202070-1-shy828301@gmail.com> <20220703161422.71e0c7316cca0442c682fcaf@linux-foundation.org> In-Reply-To: <20220703161422.71e0c7316cca0442c682fcaf@linux-foundation.org> From: Yang Shi Date: Tue, 5 Jul 2022 12:45:50 -0700 Message-ID: Subject: Re: [mm-unstable v5 PATCH 0/7] Cleanup transhuge_xxx helpers To: Andrew Morton Cc: Vlastimil Babka , "Kirill A. Shutemov" , Matthew Wilcox , "Zach O'Keefe" , Miaohe Lin , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657050364; a=rsa-sha256; cv=none; b=lSAge061ZI1wYz6QZuRHoMCZFrtzJ1eofAChQsy3o+Ltdg50vcnjo+F33QR1N4I5HNX/n5 d2y87aU2PeOqRKSeIP+9FoQiAKUvmPtqyEUg9JzlLkq1UkPKcvQ/5S1usk6p5qS7j1vE5u 3lzLBpHL3zBFCsbQNTEIawP/65L6oPY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Fdw6fzHT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of shy828301@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657050364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BxbTn0CECdrZXETflGt2gGDbEAPGwlDhM6o4bF0C3yE=; b=BSasDcKsfzKbqBDbA1KOGn1I7aifJKmza3tSW2Atnm7w43qG398Qo4JWoTaxgljC8cAXjP hHyQgADQOMUdbLcJ8wwsMkCiePixpqR8fBodirTqn6R61d5A0EnYaJCZFGTo69JhnMwFDz vcGZUMQMJSIxFlnvMKSgq57WhqBeNHo= X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 38DCB2000A X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Fdw6fzHT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of shy828301@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=shy828301@gmail.com X-Stat-Signature: rjqyw6dcihx8iibggfi5bkgsscwmc6i7 X-HE-Tag: 1657050363-345306 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 3, 2022 at 4:14 PM Andrew Morton wrote: > > On Thu, 16 Jun 2022 10:48:33 -0700 Yang Shi wrote: > > > This series is the follow-up of the discussion about cleaning up transhuge_xxx > > helpers at https://lore.kernel.org/linux-mm/627a71f8-e879-69a5-ceb3-fc8d29d2f7f1@suse.cz/. > > > > THP has a bunch of helpers that do VMA sanity check for different paths, they > > do the similar checks for the most callsites and have a lot duplicate codes. > > And it is confusing what helpers should be used at what conditions. > > > > This series reorganized and cleaned up the code so that we could consolidate > > all the checks into hugepage_vma_check(). > > > > The transhuge_vma_enabled(), transparent_hugepage_active() and > > __transparent_hugepage_enabled() are killed by this series. > > I plan to move this into mm-stable later this week, along with two fixups: > > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-thp-kill-transparent_hugepage_active-fix.patch > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-thp-kill-transparent_hugepage_active-fix-fix.patch Looks good to me. Thanks for the heads up.