From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB6BEC43334 for ; Wed, 15 Jun 2022 21:36:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 476466B0071; Wed, 15 Jun 2022 17:36:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FE2B6B0072; Wed, 15 Jun 2022 17:36:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29E986B0074; Wed, 15 Jun 2022 17:36:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1A1396B0071 for ; Wed, 15 Jun 2022 17:36:03 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DFC1534C00 for ; Wed, 15 Jun 2022 21:36:02 +0000 (UTC) X-FDA: 79581778164.18.1029A9D Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf08.hostedemail.com (Postfix) with ESMTP id 89F3E16008C for ; Wed, 15 Jun 2022 21:36:02 +0000 (UTC) Received: by mail-pj1-f48.google.com with SMTP id 3-20020a17090a174300b001e426a02ac5so3390059pjm.2 for ; Wed, 15 Jun 2022 14:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=liEq3vTBzjbeEOgGm9j8jdSvHDZIAOUrgNJBC9Mei7k=; b=SfpbG/R/1cL+p415YQgXtEAqXlPY2tWuY5j5/RzVTJWFDAclmh8IcA35qoSdcVUE8B V1IfBRuDWrn5+htxaFyyCjh7MDMNohRxD8EZFppRYvipzz4fF3iBlYQ3eJBlCYgS6fwi z7vu8Itu7b8j/HYfaqt2UW71Ad2XAzi+Kn2Owajt8QvGnU/KbznSzR+88BkMTvJmmPoh l9/75WwY9Lsx3z5EMeN6IPpCq71SEwAAsZz5QB4GGZ7KM/1+BVb2rMqVmg7bH7qUbeiP RQTy/CkiAcQO7mMpQILl9QUoPhtPCFfOp9Eqw7GzoRiO9Wuy2K+C26KkxgB2LJIx2pg+ urPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=liEq3vTBzjbeEOgGm9j8jdSvHDZIAOUrgNJBC9Mei7k=; b=mESxIWL+UCux+2Y8AW1U16dy/QZGJqeRT6A4aUraaAutl2TRsANtuaHdsmxX1JAn94 ieAgsxLXuzSYbHStK7vBkz0U0JRQXCjbYNHz/6pSHAc6mNuUN+INb8/q9HSjzOkCveuv 3P0r2d8MkLLIpK51IKJZCpoDM9im88MYsJQi1OpMIK5BSZ7EG4V+Id/4YlF5u0Ty2bMk nUQQVps+jtEdDKOfiYdiA7NqhacaSHnqaTJKB+hu4mNDPSYZI7PrTrOmRmVwnC1aVEEU VRC7GYY0Ex5P6JJsndP9fed62OiSWvGzuPuOCvEnsmAPfKV3GKRN/KOAAyuUunhlEi+y RvxQ== X-Gm-Message-State: AJIora+dY0Nb8jy+cgufIGqTmxtRDuPcvSdgR5oqV+RgEH7YhEXg9pC0 yKC+XIDCrzN60gMbYzPj/egCK1VEhoENiUv38nk= X-Google-Smtp-Source: AGRyM1v9bzZXIMQlrwrf3iX44DrRyXyp98zyb72ewbQ0053q7cZtMja4mrbigfHdyi9NBRoH9cWxHDN3rdfrMd54uaI= X-Received: by 2002:a17:902:8492:b0:167:6cbf:145b with SMTP id c18-20020a170902849200b001676cbf145bmr1750643plo.26.1655328961593; Wed, 15 Jun 2022 14:36:01 -0700 (PDT) MIME-Version: 1.0 References: <20220611084731.55155-1-linmiaohe@huawei.com> <20220611084731.55155-7-linmiaohe@huawei.com> In-Reply-To: <20220611084731.55155-7-linmiaohe@huawei.com> From: Yang Shi Date: Wed, 15 Jun 2022 14:35:49 -0700 Message-ID: Subject: Re: [PATCH 6/7] mm/khugepaged: remove unneeded return value of khugepaged_add_pte_mapped_thp() To: Miaohe Lin Cc: Andrew Morton , Andrea Arcangeli , Matthew Wilcox , Vlastimil Babka , David Howells , NeilBrown , Alistair Popple , David Hildenbrand , Suren Baghdasaryan , Peter Xu , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655328962; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=liEq3vTBzjbeEOgGm9j8jdSvHDZIAOUrgNJBC9Mei7k=; b=gFKwULuzBVWJA3kt9Vx72rLTHVzNwf6V+hm4RVCJqqoec3rR2fTGjTpE9foncvyFGmmRC8 g7uWtQwn5vTcwEQ+aC7MnbjaCKFjcm5LlGucVBkujz3Z/m1JBt4cltxPF9sXKJXSF6qhST namV7oZT1C1DDIRUg5L7Vhvtg7KGghI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="SfpbG/R/"; spf=pass (imf08.hostedemail.com: domain of shy828301@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655328962; a=rsa-sha256; cv=none; b=ObNp60j9qrWFJ5/THsob4jGIOC/5dY4veaUi7RGdO0mnzaf3FGatCfoKj3LcuFs1anO0+o 38TKFhBZf69QG4BxO0jj5gItWCFwVvN4lx2u1yvwYXgQYT+Iqrjx3cx0L9FZ/6i/4eJAJL AV14RU9bxEy0zjuJ0j+nC0RgzFq1+8E= X-Stat-Signature: npmwy68nfooe4m4r8n8wayrn3f63nacc X-Rspamd-Queue-Id: 89F3E16008C X-Rspamd-Server: rspam11 X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="SfpbG/R/"; spf=pass (imf08.hostedemail.com: domain of shy828301@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1655328962-6450 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 11, 2022 at 1:47 AM Miaohe Lin wrote: > > The return value of khugepaged_add_pte_mapped_thp() is always 0 and also > ignored. Remove it to clean up the code. > > Signed-off-by: Miaohe Lin Reviewed-by: Yang Shi > --- > mm/khugepaged.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 142e26e4bdbf..ee0a719c8be9 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -1372,7 +1372,7 @@ static void collect_mm_slot(struct mm_slot *mm_slot) > * Notify khugepaged that given addr of the mm is pte-mapped THP. Then > * khugepaged should try to collapse the page table. > */ > -static int khugepaged_add_pte_mapped_thp(struct mm_struct *mm, > +static void khugepaged_add_pte_mapped_thp(struct mm_struct *mm, > unsigned long addr) > { > struct mm_slot *mm_slot; > @@ -1384,7 +1384,6 @@ static int khugepaged_add_pte_mapped_thp(struct mm_struct *mm, > if (likely(mm_slot && mm_slot->nr_pte_mapped_thp < MAX_PTE_MAPPED_THP)) > mm_slot->pte_mapped_thp[mm_slot->nr_pte_mapped_thp++] = addr; > spin_unlock(&khugepaged_mm_lock); > - return 0; > } > > static void collapse_and_free_pmd(struct mm_struct *mm, struct vm_area_struct *vma, > -- > 2.23.0 > >