From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76C9AC48292 for ; Mon, 5 Feb 2024 17:07:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 052DB6B0074; Mon, 5 Feb 2024 12:07:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0033F6B0075; Mon, 5 Feb 2024 12:07:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0D1E6B0078; Mon, 5 Feb 2024 12:07:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CE6256B0074 for ; Mon, 5 Feb 2024 12:07:34 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 314871A0AE8 for ; Mon, 5 Feb 2024 17:07:34 +0000 (UTC) X-FDA: 81758381628.28.80F90E7 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf17.hostedemail.com (Postfix) with ESMTP id 46FAE4000F for ; Mon, 5 Feb 2024 17:07:30 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aRdq8L7U; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of shy828301@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707152850; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=88D1RK/nOy77l4ZbsApJZs4VjFYfeQsWMWLEgTtNVGA=; b=N0gyMIfvdMu0m0r942HVJdJgmNQF78uFo2hEiTi+cbSikL4qvIdQrD51gsStetoWMYaaUe Lxe9Kzft/PLVhQcf8XW4f4v6vrGPbjnWmHDWGiO5efZWsXFTwUVzdjw/V/as84KhoYtcA7 EFM1TTiOUe4sgiQ46crKa65HG0TDnKg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aRdq8L7U; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of shy828301@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707152850; a=rsa-sha256; cv=none; b=u7i7p3D2BlrocmEuLbEe1m9SDDt63+bI6bHPGLnrhW/xv2PK7WMVi8A+1u65DLPjiSfAQ/ hm37uRizSi1bsLgzZmrObffujpgHUH4thF7NZd8pYmQ4auDimwBPVbHEDCyjqYz2mXeI0i 3dlix4QXES8rQGr/GzgzziQbk8OUpag= Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-6e04ef43213so419534b3a.2 for ; Mon, 05 Feb 2024 09:07:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707152849; x=1707757649; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=88D1RK/nOy77l4ZbsApJZs4VjFYfeQsWMWLEgTtNVGA=; b=aRdq8L7UIc3X+cDKzHzNBlSzNazwBWAaaSLcT4CpTLKeApoBWcLviD3C+40nOH9hJo WhGGimMg3xFxsD5vqpFeJCT+M6rwmDrZmhk6HxyJ8mp/tpk9XHguSolm2nBlV19X/kD4 CC3AEETY5vSZLITgcHW919tmLOv8gmiJlPTQGDTcFKRafIGn7C4OSb1yexYEAlbgmU4b Aw5rViLwUDJ+X+fYaLld2EMz6lhhOWfn3AEAjo//YKWGWDplvtEfYE+tVGMwvGjI5IoX TB0Qlf19+bd8MQSGKpFP/N+w8JzoyP44B8T24RmRS9AyTdIa9sOzZ/RbDCsXaCaIHg0T NN/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707152849; x=1707757649; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=88D1RK/nOy77l4ZbsApJZs4VjFYfeQsWMWLEgTtNVGA=; b=pbDdnFWbW++T3RyqqMN07OgsbCYWIjfJxowBmKAFaxmEKn0gW3jWNIgHMQlVvihhsj q1jlPeoyIOocdCJOKo1xwjjU+BvxNiQyjn/ljverNYdQah4l1wMb1R+34gLiv0cXZhlB KTBw9I4NlpEVeljX8NNJiZLV/vPvGW0Gi64MWKPhNC6ZJxISynwOBs7jOqcDPBz1gDDl HhK9ksY13vwHdVuqfeQ2u3wSOSLpOPAkLwi7mqDYBihHJRkGeoEIOO4kpa7W7MIPOSVo lpWfKnIz4dy3/tjw1PLhaXpA62fP5lIVpWlow63PBdL0uJ9reVKX9T/betFQklcu6DXi VNzA== X-Gm-Message-State: AOJu0Yw0l//grm794oxNaVTSqXUa93qq96Gy+v4jdqf09rnYDCjKfrNi p685F18NvZRNJfalTW0u1hPg6zPpyjQYE/nthz6fR1duyZM0BEYMp8PyAlbbcuJQLGKFLKsThAR viTWS6AFZlt1UnUzYIVVRDPbMycI= X-Google-Smtp-Source: AGHT+IG3d9Ex5sF4UKpwysbNM/TqGT2KKEe4K6rs/cP9WQWpfDJTFBMSBnqfKweEDscuLgchA+SD2nBAFH0HEM4EPng= X-Received: by 2002:a05:6a20:7291:b0:19a:1cff:f574 with SMTP id o17-20020a056a20729100b0019a1cfff574mr141172pzk.36.1707152848960; Mon, 05 Feb 2024 09:07:28 -0800 (PST) MIME-Version: 1.0 References: <20240118133504.2910955-1-shy828301@gmail.com> In-Reply-To: From: Yang Shi Date: Mon, 5 Feb 2024 09:07:16 -0800 Message-ID: Subject: Re: [PATCH] mm: huge_memory: don't force huge page alignment on 32 bit To: Thorsten Leemhuis Cc: jirislaby@kernel.org, surenb@google.com, riel@surriel.com, willy@infradead.org, cl@linux.com, akpm@linux-foundation.org, Linux kernel regressions list , yang@os.amperecomputing.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 46FAE4000F X-Stat-Signature: 8dr6yrawbkd5c1jpk6pei93k1nwz5emd X-HE-Tag: 1707152850-384932 X-HE-Meta: U2FsdGVkX1+fVBZoRMDVaoCU4fKYk5YqmjmqdK2s3+OPEMXNnTYcjdW+l5xZk4MrAPRM/pthzipiaGi7lF1ulGysexg0zc/DGnH5c/8Q4RrOtyJNz8MXDSwibCUbfnryTdWHVxIS8siTcATeASHn7Io6/hBVlt4dxJGT+KLD2NCg6V7eJ9eFE/0wQhU6W6JVSinX9W38Cpszt2h2s+pFCdzVwvUHe2FnDMdSNLIabSlDKNrpdGwMZV8/jkCLhN1gYipxA6FDEZl75sN7v70BCycJGEjiPvFGVk4uEVhefNdHTBJEdJWmcJELvqJCoGsqigWX0oIF1LMmFU8KVrDIT30GCLAkcpDzjw5lMMqdP0EUQKt1T3PhZLWCvn9uWWDzFLeALAAXB2hWNXYcUYpaFcL49eWtCOmtkQOB+sFGMFERNXs2nlTmtalUAZDvwhla0EP3K6tgNIKwbXClacsveRXm2dyzZ3Uz7Z1/t0Og7afpeOiFnMybf4H+naw4B8GIufgg12+NdURg6V+S2kQqr7IIEw8T7vPKXhkHPQCwElnAeCC8/GBIf8fbwaXxSPwComzDTFJKaQVb1d1sdxjJ/y4uoKtlY5PEO3D/dfUsi2YTiNHQisc0xPhPATRsOby6LkFHNxD+owtBvOMVErIuX5E11yo1JZMqLe5EcsRDnHgo3I0YiysQ/Q/Nt7ksxEKY6z4DT/Xh8TqVe47yZ9lGp8sP7PKcHljf4caAmRClsPmH68shMsuajFpBC/qhObGN3B+iVCjnauT3ICWUl3Clx707aMBN0pcE7SV/ptuFxYKqIcrFza2Sh6JTgI0O2FmLvihIcPUKqJJ0QBd7J3hPYSbXQ+ua1QLy20K2ndDdaxlYBw0DtCqxGQ3Umq7ASLJLNGpuSjX+EE7Cr27/FrR7cLHG0YGaa5283IZX6d+OX52WogsI941Cseecq6Ubr1a9bCKNlsQD60N68+29JuP lwD8qxxs jAP7PWJ/lhfuygiKqbIjthd51NjU9NybwrEEf7a3n9hIzBXZvYXX9m/1OyGgjBTkDINkn5hTtjIDamPm+B7d2DVMM3DmZs86RMyylVlJ64CulEaFG4j4QGCD2HQsrr1UkDmD/AZKo2f4wOWipjrXqxzL1c5rZMSlsPr+HSSkbJDWW8rZDYet3ACvsrWeqmXqKoWtooI/zByQyP+AyBIZlNZYnabjEoi7lptQt1M4v3v64lzMXUSICyk32JIOcGXId5Uzjb2H5ahLpKjrFToKXaSGnXg2ZPqqatAflkxw1nU81PCMLBt9/CYDeaR0Mzv+yvZaX0ZYPA+UUkLniBJhUa3hJv72dSUYcLqPh0A+h++d6fp+u8bkQzCsmqOPom6WpjawDTm2Guhw3YhM06q4BQGGro5n3sXO+T22gzyEMTUD9irsP8lGnrJmr4Vq1v6Zj6qkDqP812a8J2qgIXkWIt6nV5trY51bq3IbhHpktbR/wRXbwdXPPxaLqpABhPGiwB7csD91QOvdjYL3L8sstaacIiKGkD5L81n1a+OKziMfyoFo/kXVnIVgL32Xh/jlf3UFclMW30ETVsnQrzjo6kqwf6Ql4Ms5y7fsuGCFYHJoB/XD/yBbE+Vj/tVgjypozME4iKyNmZJPQRfBIa3BY9UPldby9ZFpT6UnbfP1iRwSJZG3XcwYIJ9JQvDHuCztS8l+l3OIqjha1i2IV+en7qVWkM1fD5pxKbdSgg5iYheLFZYTRSVYMl6ik0eNhT3XyX/fJkNELrZvTbEbV03fNcnmbwo3vmlF79/7qADbUM2DULgs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Feb 3, 2024 at 1:24=E2=80=AFAM Thorsten Leemhuis wrote: > > On 18.01.24 14:35, Yang Shi wrote: > > From: Yang Shi > > > > The commit efa7df3e3bb5 ("mm: align larger anonymous mappings on THP > > boundaries") caused two issues [1] [2] reported on 32 bit system or com= pat > > userspace. > > > > It doesn't make too much sense to force huge page alignment on 32 bit > > system due to the constrained virtual address space. > > > > [1] https://lore.kernel.org/linux-mm/CAHbLzkqa1SCBA10yjWTtA2mKCsoK5+M1B= thSDL8ROvUq2XxZMw@mail.gmail.com/T/#mf211643a0427f8d6495b5b53f8132f453d60ab= 95 > > [2] https://lore.kernel.org/linux-mm/CAHbLzkqa1SCBA10yjWTtA2mKCsoK5+M1B= thSDL8ROvUq2XxZMw@mail.gmail.com/T/#me93dff2ccbd9902c3e395e1c022fb454e48ecb= 1d > > [FWIW, this is now 4ef9ad19e17676 ("mm: huge_memory: don't force huge > page alignment on 32 bit") in mainline] > > Quick question: it it okay to ask Greg to pick this up for linux-6.7.y > series? Yes, definitely. Thanks for following up. Yang > > I'm wondering because Jiri's report ([1] in above quote) sounded like > this is something that will affect and annoy quite a few people with the > linux-6.7.y. > > Ciao, Thorsten > > > Fixes: efa7df3e3bb5 ("mm: align larger anonymous mappings on THP bounda= ries") > > Reported-by: Jiri Slaby > > Reported-by: Suren Baghdasaryan > > Tested-by: Jiri Slaby > > Tested-by: Suren Baghdasaryan > > Cc: Rik van Riel > > Cc: Matthew Wilcox > > Cc: Christopher Lameter > > Signed-off-by: Yang Shi > > --- > > mm/huge_memory.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > index 94ef5c02b459..e9fbaccbe0c0 100644 > > --- a/mm/huge_memory.c > > +++ b/mm/huge_memory.c > > @@ -37,6 +37,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > @@ -811,6 +812,14 @@ static unsigned long __thp_get_unmapped_area(struc= t file *filp, > > loff_t off_align =3D round_up(off, size); > > unsigned long len_pad, ret; > > > > + /* > > + * It doesn't make too much sense to froce huge page alignment on > > + * 32 bit system or compat userspace due to the contrained virtua= l > > + * address space and address entropy. > > + */ > > + if (IS_ENABLED(CONFIG_32BIT) || in_compat_syscall()) > > + return 0; > > + > > if (off_end <=3D off_align || (off_end - off_align) < size) > > return 0; > >