From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CFCBC433EF for ; Mon, 4 Oct 2021 18:17:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E2B9461247 for ; Mon, 4 Oct 2021 18:17:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E2B9461247 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 242FB940066; Mon, 4 Oct 2021 14:17:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F2A694000B; Mon, 4 Oct 2021 14:17:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BA5F940066; Mon, 4 Oct 2021 14:17:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0166.hostedemail.com [216.40.44.166]) by kanga.kvack.org (Postfix) with ESMTP id F111B94000B for ; Mon, 4 Oct 2021 14:17:42 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A412D1803016E for ; Mon, 4 Oct 2021 18:17:42 +0000 (UTC) X-FDA: 78659563164.04.1CDA876 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf29.hostedemail.com (Postfix) with ESMTP id 72B3A9008008 for ; Mon, 4 Oct 2021 18:17:42 +0000 (UTC) Received: by mail-ed1-f54.google.com with SMTP id p13so40253688edw.0 for ; Mon, 04 Oct 2021 11:17:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=p1OSvDb4flrM7vqMy0d0m8z6YVSkZgWPxJGyGi50ATw=; b=U9w6Bi/zaRZct2JenV+NVutYNh91g/jdBva9yA/bKrtTMia3MI+MYcrS0EIw894eDb 6N/Itct6PxVtQWwSwG/vmMNK0JcetUfrYonaS9BVyoMs3mm94OKwZwQhvsybpsLJGmm1 9wJ6c7egRspNqUtmMHXfnunwUjz8uDiZwn5pHA7QI1S104vXFrGBbyG8VauT/uOaGEvx s7+4X4QOzTsxWE6R2+8Z3di3GQlitgzklu1H/RKLtOnX5CwN6EbrSrKFZcJmp75Ph3XV P7p8cYGx68oBGqM1uCWZlwkVN5kJW+PJP0W6JIE6siW55NHEt3iQOPMSlKZ+MXOgInP+ r60g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p1OSvDb4flrM7vqMy0d0m8z6YVSkZgWPxJGyGi50ATw=; b=gi/mgewOqPriXFxl7On68h4b6de31DIUIInW7GguH3DB04YvslzssM/4XUIVPpYK1i 2pBQuwMjmY4c9akNNFmNMnfwnHkMCF+C5/vSeW9C9V9Ju9PdO01vocMJElar2UQm7ADu vRPeWxkV60XvdSOuY0wBlQQM10bpCDLXPvzOyh5FEtcgMASWa1yjbW9Kt9Vbsci70u2e w/C76D17SKRjNP9PgCT6kWyCOH8N4HFtVD6SN7qikvNUtZ0qbUYNvH8ESCdr+Wmv+Z1H imelbSNh/4A4cjo7h0L85j5nHw0up5XL78tgdlwZ+65ubRsmulfI1yWGMQrOxOVqOquP P7RQ== X-Gm-Message-State: AOAM533njau2I/OC7DvRcVMt9qsAvPK83VJ0+nphxDEIgtAzMsd4pPXZ C+0ftb6AE+dNb8aL5mSKO9bo0wzzXqDcNDkkrXo= X-Google-Smtp-Source: ABdhPJyiqlAaEJw5chaLwE/+uRpnajHGMoQ/SjnHQFon0jCpmUlCUyW6Uf+uYok6k+AY3fALQ/bxtzEohx2OoLDTxVI= X-Received: by 2002:a17:906:c7d0:: with SMTP id dc16mr19510961ejb.555.1633371461107; Mon, 04 Oct 2021 11:17:41 -0700 (PDT) MIME-Version: 1.0 References: <20210930215311.240774-1-shy828301@gmail.com> <20210930215311.240774-3-shy828301@gmail.com> <20211004140637.qejvenbkmrulqdno@box.shutemov.name> In-Reply-To: <20211004140637.qejvenbkmrulqdno@box.shutemov.name> From: Yang Shi Date: Mon, 4 Oct 2021 11:17:29 -0700 Message-ID: Subject: Re: [v3 PATCH 2/5] mm: filemap: check if THP has hwpoisoned subpage for PMD page fault To: "Kirill A. Shutemov" Cc: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Hugh Dickins , "Kirill A. Shutemov" , Matthew Wilcox , Peter Xu , Oscar Salvador , Andrew Morton , Linux MM , Linux FS-devel Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 72B3A9008008 X-Stat-Signature: hg5ceursdwizgqscwerkdstex75m3myc Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="U9w6Bi/z"; spf=pass (imf29.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1633371462-31782 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 4, 2021 at 7:06 AM Kirill A. Shutemov wrote: > > On Thu, Sep 30, 2021 at 02:53:08PM -0700, Yang Shi wrote: > > diff --git a/mm/filemap.c b/mm/filemap.c > > index dae481293b5d..2acc2b977f66 100644 > > --- a/mm/filemap.c > > +++ b/mm/filemap.c > > @@ -3195,12 +3195,12 @@ static bool filemap_map_pmd(struct vm_fault *vmf, struct page *page) > > } > > > > if (pmd_none(*vmf->pmd) && PageTransHuge(page)) { > > - vm_fault_t ret = do_set_pmd(vmf, page); > > - if (!ret) { > > - /* The page is mapped successfully, reference consumed. */ > > - unlock_page(page); > > - return true; > > - } > > + vm_fault_t ret = do_set_pmd(vmf, page); > > + if (!ret) { > > + /* The page is mapped successfully, reference consumed. */ > > + unlock_page(page); > > + return true; > > + } > > } > > > > if (pmd_none(*vmf->pmd)) { > > Hm. Is it unrelated whitespace fix? It is a coding style clean up. I thought it may be overkilling to have a separate patch. Do you prefer separate one? > > -- > Kirill A. Shutemov