From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EDC4C3DA7A for ; Tue, 20 Dec 2022 17:56:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9CB28E0002; Tue, 20 Dec 2022 12:56:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D4B408E0001; Tue, 20 Dec 2022 12:56:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3A3B8E0002; Tue, 20 Dec 2022 12:56:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B306A8E0001 for ; Tue, 20 Dec 2022 12:56:33 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8851A1C64E1 for ; Tue, 20 Dec 2022 17:56:33 +0000 (UTC) X-FDA: 80263439466.17.28A9E6D Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf06.hostedemail.com (Postfix) with ESMTP id E67E5180013 for ; Tue, 20 Dec 2022 17:56:31 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="WqPQX/XN"; spf=pass (imf06.hostedemail.com: domain of shy828301@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1671558992; a=rsa-sha256; cv=none; b=Wk443eCJqJJS+O5jomCcYoqYdZI1FKpGrbfLuqo1mwnR7C/kyUn/2vCODUPdyA9E3PJ91y H/JQzv0ICxEQ3SERh9xVUk8o0FEJ5BjGffvhu5lxC05GeXLIwtQidWPVWjIsDvT31P1mPT h/MtrAVZxSofZybGNcACpLZV/sAvVpc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="WqPQX/XN"; spf=pass (imf06.hostedemail.com: domain of shy828301@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1671558992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WnsQ7W4+w46kWzm3CDvn6Yr9ZWGsCxW++5kHHfpJvH8=; b=G/Jt5I/udTX4N8f6LSH9FoOGuK8bI8jf/pfmsxTad2hNTmfbXkpDJ0uTcMVcnTOSp+52s8 Gkaie1FfmHHb07FGYhIwKIbNqQqVL/Hf6uJ1Xe9UUqYVTvwweFpmTXTzgKhhaCYoI9RkOf 9Rl7T2ngd81I58vKArBfxrYvY3LAFWU= Received: by mail-pl1-f170.google.com with SMTP id d3so13000601plr.10 for ; Tue, 20 Dec 2022 09:56:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WnsQ7W4+w46kWzm3CDvn6Yr9ZWGsCxW++5kHHfpJvH8=; b=WqPQX/XN3ypnmZR7hVdZaErjEpeBprcSPWJZRlN5w7lez6a167Y0Tbfew6lzmirQVF KN+x/awIInFQx32HhHQDxRZcwN3eGwoeUd+h37lIW4/xOicA5YFuqhfV4Cqh+F40t+HY CXnT1PVVebxNGA+xr0NcFg87xpg1z2x75Bi71IGrsHPXzc4ex2HVFyfCTW8YVM1h2DK0 AOzlQIXSYr2Uaek6S3ZZvfKDcZo0uY4e7k2QNEE5RmoEgRErG7ZmeErFBk4Ptt7OjCvU Gnf5wHzJYavQyjCJs6hZDnNosZSLfvJ0KAAQdoSLfcoNs9Jy95WgtMaCz2cfwsIZ5xW2 dvuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WnsQ7W4+w46kWzm3CDvn6Yr9ZWGsCxW++5kHHfpJvH8=; b=N1XuWfWOkp3XNp6mydnD03Ybp5uDFxWdnpaDGxlsJUF/HIhEKRHlL5gSyq6xuXuEtj XdxueX/2M45+/sibiRsXcSRoR3LRuxkml+cyLr0p/F7HdIOsdZCqSw72TMc2c2qAOg3u tRwqhcENPh3pbh7lXZ2n3gdCdjfGmtFi2mKg2bOSsUFVYCgDq8Uw/AgYxrMUqrbRa41K Q8ds/gx8rxaPUMVZcHE+r2fGHhZzm4L/gtyEGnTTUvCsMNBal8JI9Ukn7ZxlJvDIfmuP euH4mR+JkFqUsk2qlpwGwnFdEGfJQv03KooZu0QI/PQNuQiYt0gS5oKqyYYdsxNf8nXZ i52w== X-Gm-Message-State: AFqh2krC0DhSA/ES+KS58Za8sXrupRRIswEBT34+mWtiP7lIVwvzrz70 NAEToTGTo+7xTy77nHhg4Wl1PIhdOEgHCj/hssU= X-Google-Smtp-Source: AMrXdXvQ2GFm24bfI45BUCwPfwnk4StLIIGyZMfE+dkxDcvnbaPCDIJyASRRPhLGyDOZHTWR0IlP3YAyyaOSiQVrt7g= X-Received: by 2002:a17:902:ccc5:b0:191:2b33:7010 with SMTP id z5-20020a170902ccc500b001912b337010mr254971ple.119.1671558990724; Tue, 20 Dec 2022 09:56:30 -0800 (PST) MIME-Version: 1.0 References: <20221217001554.554913-1-lstoakes@gmail.com> <20221219100734.jag6zejp4tug77yq@techsingularity.net> In-Reply-To: <20221219100734.jag6zejp4tug77yq@techsingularity.net> From: Yang Shi Date: Tue, 20 Dec 2022 09:56:19 -0800 Message-ID: Subject: Re: [PATCH] mm: remove unused alloc_pages_bulk_list() To: Mel Gorman Cc: Lorenzo Stoakes , Matthew Wilcox , linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org, Andrey Konovalov , Ingo Molnar , Marco Elver , Michal Hocko Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: E67E5180013 X-Rspamd-Server: rspam01 X-Stat-Signature: oo8ybcj4i3bz1ci7yo35e8hf1czdqd3a X-HE-Tag: 1671558991-692475 X-HE-Meta: U2FsdGVkX19rtW4iZ3spMS0MISZMe4BHec+6vKCZLsEgwhnqPsTkRA2Z0SId7MPtENHeNiG+A6MWFFkrFR4uHisjH/EyhBnhFIYHCy0wYv27WI/D3xqjzRO1k5uLnxddxLaR9L3SpwTqAwmPLvSUGEYKi6rrGB4G7KsijLjp8Qlmma/Ou1rT+4rjviTH2a4rYCIJIJdm0twXkalP2VixlHPG8lUdh3NhkcqP4slhphmpIYcwuGqIz66WHIXvCpwAXXRiPkd+Qyj4rIasRnwxQ0o/2uMqwUVzAvf0laMHM2lTBT9XqvwBNNcwdNfnt/beCEEdLrMBWE3n3lDqaI0dhB0wG0Q2C0sQ3rCIcDPkgWwHgmSycBtIDCqsk9M4uxUK535zRdHqgH3MI/FMv5o+CrsHRJv7OuqT8VF/gLG5xEtwzI9BeZFxI0iuImKlFQCWu4mzPOAHY63nn24jw2LOvaWsXwPa6S6N/7Mqv51T+tRSB1D/udhMkBNkPfoAyH/c/yzukrILNQX2p6fLQKmOSHtBmjr1awjJAjVifosLUSHZa9amcXf/3pSdI8pgSaMgVhosnS3T1zIbTz4/QFWQjk0Ul+Zf56R/nIHEPGAtPjV/jbwLYl8Y5FHoIXtO/B3SkInz/WBwlI7WxwjJu6U8NyZ6JmqK1qJ6fCzvPrewZm4jSc8DBY8Gq5g9C6xgE1d26vpHhKXHYg0bnvZRGX8xXCVMQEqqUk/urMjjoHw9QlBUSu5hIvaMldmMXNfhCTQJ41ZWrNEu2noVOcRlHgXz3EkNz3CnfSYfFgift85ua4rn0E+tjiTotHx4GglOTRVZPpgC6BWclcGzmpFjLrzkFHMXXc55jxGl+7kZzEQzkRCkulhuDr9O/uYanK025OERDjbAjvFLPovMLVen1e2sbVX5gO7xq8sqX7IAfEUfNY4PtiS68zqXmx7c5mqmpoTPYBOlg5jnqCU5lrFNwtd zTgPBW0c lMyB59hqCNeEh4Ew4KNo1uKUkhXB5toZqwMaKfYe5AkifBYnp9gMgNseFdpa14PwTXxK4UjhIgsFHIk6dJFzT0eYMolssXDaRmyCh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 19, 2022 at 2:07 AM Mel Gorman wrote: > > On Sat, Dec 17, 2022 at 08:34:58AM +0000, Lorenzo Stoakes wrote: > > + Mel > > > > On Sat, Dec 17, 2022 at 04:56:03AM +0000, Matthew Wilcox wrote: > > > I think we're waiting to see if any users show up. It's only been 18 > > > months or so, so perhaps wait a little longer? > > > > Apologies, I should have researched the background of this further. I see it was > > added speculatively in 0f87d9d30f. > > > > > Also, if we do get rid of this, then __alloc_pages_bulk() can lose > > > the "list" argument. > > > > Ack. Will do a v2 if Mel feels it's appropriate to remove at this stage, > > otherwise we can drop the idea and wait for users to emerge. > > I reckon we should give it another few months until May. There has been > one user recently that tried to use list but it turned out arrays were > more appropriate. Another recent try was the patches for dm-crypt. However Mel suggested adding a callback interface instead of using list since list is not necessary for that usecase. Or are we talking about the same one? I didn't get time to implement Mel's suggestion yet due to my employment change. Hopefully I can find some time after the new year. > > -- > Mel Gorman > SUSE Labs >