From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 867EEC433ED for ; Tue, 27 Apr 2021 20:46:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 35F436105A for ; Tue, 27 Apr 2021 20:46:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35F436105A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BBF816B0036; Tue, 27 Apr 2021 16:46:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B6F746B006E; Tue, 27 Apr 2021 16:46:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E8CB6B0070; Tue, 27 Apr 2021 16:46:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0192.hostedemail.com [216.40.44.192]) by kanga.kvack.org (Postfix) with ESMTP id 79E986B0036 for ; Tue, 27 Apr 2021 16:46:36 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 452598249980 for ; Tue, 27 Apr 2021 20:46:36 +0000 (UTC) X-FDA: 78079330392.40.EB8E47D Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf22.hostedemail.com (Postfix) with ESMTP id 6B029C0001FA for ; Tue, 27 Apr 2021 20:46:29 +0000 (UTC) Received: by mail-ej1-f46.google.com with SMTP id mu3so302741ejc.6 for ; Tue, 27 Apr 2021 13:46:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=N7anHoC9geqIkxnuhdLcMLt4gZDNLzLFNeoRehcS0eM=; b=VGtpo6qcu9pwPNSpCONhtfXzC1L4N3ADxE8GLhYafQrTehJfXYTbV/mVQF1uo8bCHd 7qdI4XOn9t1qBaG9UN+htWrWmQkEEn5BpVHxmdm9cU+52a63OBb62IeUjMOyH/new9yy +E9DgX96XW4QOXIh8k6jJJMYqTS51fpyK2cWJpiDLKeJUQEmWSvOo2mbuRUHArQ2zmwz /iodnOSZ4X9lEnAlRvl+dZYttq3OyeXJH0k7irNum+AFbUN8q+arGPVMdqylpEfL5xD0 C2LrPTIxj1BaQLHteLZ8VUMfLAMAgwc0mAHJQnjmoDUzrNsMFu8tElVJf8w8OhK+zMzN bcqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=N7anHoC9geqIkxnuhdLcMLt4gZDNLzLFNeoRehcS0eM=; b=FoyMt2MPlB0goX+qi5WyImABvyYVJispqEats7w94xQjEc7Fd4m7iB8+QGJPIqxUgp cmBgAArquXrhax5+IH4vdnRUeZsbKS/14x7Z7c+u6AcoIZ6+eoBmyY+Yo05MBlBdCBiO c+K3xzugUmK8juXR0rfEBl3761IsSlojcBdm+nJzNg1qguCrpPhdpppa3UpNulC3+E/Z fYR3WgvAC8qq5Af25gtZp5brXzctGvKTBUwsmm370S6fUIj2bSNI3nm9Dy+myGIbRf/5 bByyWm9hFuJWh4WaKUek0k51RuXwfuKJXF9ayemg4/F2EqwkCtYq4c174369bqMbntIZ MDMQ== X-Gm-Message-State: AOAM532nW6sQg3faQxj/cvTFtCeL+70tHm78dwtjM+xJva2BhjLiAVTz C6XYrk0aoZtL8Xd69UNDyKVrDLRrLsexi/pvOuQ= X-Google-Smtp-Source: ABdhPJxXo2gK1QGVsMN3JZqRTR6rlQ4Uj9PKOZ1UWnsXGw4hbPccVrX2oBup0LddQn8xy3zYV6h7JlOmwcpwbjmdj7M= X-Received: by 2002:a17:906:3b13:: with SMTP id g19mr14421196ejf.238.1619556394715; Tue, 27 Apr 2021 13:46:34 -0700 (PDT) MIME-Version: 1.0 References: <20210427133214.2270207-1-linmiaohe@huawei.com> <20210427133214.2270207-3-linmiaohe@huawei.com> In-Reply-To: <20210427133214.2270207-3-linmiaohe@huawei.com> From: Yang Shi Date: Tue, 27 Apr 2021 13:46:23 -0700 Message-ID: Subject: Re: [PATCH 2/5] mm/huge_memory.c: use page->deferred_list To: Miaohe Lin Cc: Andrew Morton , Zi Yan , william.kucharski@oracle.com, Matthew Wilcox , Yang Shi , aneesh.kumar@linux.ibm.com, Ralph Campbell , Song Liu , "Kirill A. Shutemov" , Rik van Riel , Johannes Weiner , Minchan Kim , Linux Kernel Mailing List , Linux MM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 6B029C0001FA X-Stat-Signature: 8eojyyqhzha3re59boex1ou5cxi1uj7b X-Rspamd-Server: rspam02 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf22; identity=mailfrom; envelope-from=""; helo=mail-ej1-f46.google.com; client-ip=209.85.218.46 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619556389-824194 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 27, 2021 at 6:32 AM Miaohe Lin wrote: > > Now that we can represent the location of ->deferred_list instead of > ->mapping + ->index, make use of it to improve readability. Reviewed-by: Yang Shi > > Signed-off-by: Miaohe Lin > --- > mm/huge_memory.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 63ed6b25deaa..76ca1eb2a223 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2868,7 +2868,7 @@ static unsigned long deferred_split_scan(struct shrinker *shrink, > spin_lock_irqsave(&ds_queue->split_queue_lock, flags); > /* Take pin on all head pages to avoid freeing them under us */ > list_for_each_safe(pos, next, &ds_queue->split_queue) { > - page = list_entry((void *)pos, struct page, mapping); > + page = list_entry((void *)pos, struct page, deferred_list); > page = compound_head(page); > if (get_page_unless_zero(page)) { > list_move(page_deferred_list(page), &list); > @@ -2883,7 +2883,7 @@ static unsigned long deferred_split_scan(struct shrinker *shrink, > spin_unlock_irqrestore(&ds_queue->split_queue_lock, flags); > > list_for_each_safe(pos, next, &list) { > - page = list_entry((void *)pos, struct page, mapping); > + page = list_entry((void *)pos, struct page, deferred_list); > if (!trylock_page(page)) > goto next; > /* split_huge_page() removes page from list on success */ > -- > 2.23.0 > >