From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39DE6C2BBCA for ; Tue, 25 Jun 2024 20:34:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 854856B008A; Tue, 25 Jun 2024 16:34:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 803BA6B0092; Tue, 25 Jun 2024 16:34:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67E026B0093; Tue, 25 Jun 2024 16:34:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4B2836B008A for ; Tue, 25 Jun 2024 16:34:38 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C720B1C0580 for ; Tue, 25 Jun 2024 20:34:37 +0000 (UTC) X-FDA: 82270564194.16.96BB0C8 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by imf11.hostedemail.com (Postfix) with ESMTP id EF9EC4003F for ; Tue, 25 Jun 2024 20:34:35 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XBIEJTIe; spf=pass (imf11.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719347664; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dag1l+P4AHvt6y/RZEBB4jSeUQA1MVnCnAotCeIeMb8=; b=im6BsWuOZZdPm3KLmpt2mFqta+UcEaMCVG2C4YaugdmJz2CHIsr0tjP8V9Bi3XxjA8KLV/ hKOsqvl4Kf/qA+MfxmaAC6FGsM5JgJRx3N6b0JU7UBxwhf3j0zVb9w9hmyu9ng3WQCtNzN fAmmPRz3P9q2/QpfQbraiqJlpFaVMBs= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XBIEJTIe; spf=pass (imf11.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.48 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719347664; a=rsa-sha256; cv=none; b=E3uNMkrrt2REBJgJT12eEorY0pVlsz5YXX63uIEPgjtfGyaerbC+kUYRKQHNET0nycJR4y 7wfIfDjElYwnSnSzn8CioDranyraZAASd9eEXSZ+Rdc5+8fQF+U8PKRRrn77nQgVzRx/Vy z+qC0MlDpt5TKpENAwEZ6FYyVowzB2w= Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-57cbc66a0a6so981594a12.1 for ; Tue, 25 Jun 2024 13:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719347674; x=1719952474; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Dag1l+P4AHvt6y/RZEBB4jSeUQA1MVnCnAotCeIeMb8=; b=XBIEJTIeqHkFpI3kcSaVc3N+8uuWtcI6+/bj4CvDCChBWMbzVwwP5B0AEKmNy71hRY gkp6tdgoifyRFi+YJb7x96neUYolJVvE0T6YzjPQvpSFmJSHq7d6tfzISf0Cr/eQSEdR AvuTU+LDyqXeoNEfPaF/AQbWKCVWUuKwEQXijo1BzhXJO0+h9afLMRBSqmbg5QNX3ebb D8r+Fz0nFataLOQFlNKY+jPV5ibklrrj9F78ls0IJ/YjfSPCch+lUIp5LF9rpEaSzIfz 31dV4hNNdtE6smMcfbLuwUgYfNZEShDMNTASUwloiroVo3thAXV+5bGc4LSXqZ5RvFmO 2fXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719347674; x=1719952474; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Dag1l+P4AHvt6y/RZEBB4jSeUQA1MVnCnAotCeIeMb8=; b=g4gEpaImWq23nDlQdDCIzt9jgW46O2LTn2RpHWU7XR5CxD+woO7cYobn7OEx2N89PZ 8JOhajpgp/o/TUFqcCQNrtym3joP5qmQd0lK4/VCM1iY8qjVFJCJUolhpHhanVVegvqr SHeaq7/JUTDxr9Sqfe8uk8b33L6vSuqeUkNYqqDYTQ2IivrxoTjSm0mds0MdJJN2N36t S8Dl0RdZu2BhYrJ1PimC4me42jMcSQiCgKLNtpbuGsDCmEYUzi807UIdiwUn0+s66snB gzizQ2KN3QGNpA4Wcd2SRTkARuRgOk6HwVNnIbGdTXPMuhStH1roa6lipWEeXNImhXMj L0rA== X-Forwarded-Encrypted: i=1; AJvYcCWOwil0i7OXnNeLWpLSDfimsPHcfjju+Y+kWNW58Wy6BWqMwdXbSlSTNiA+SSZv/JTbp/R+ycn7shgxV60bpbmAmDk= X-Gm-Message-State: AOJu0YyGVo+kR6sZZZgNek7yFbS/5DtcWe30jr9FA2HWSywOxVAD1GFH i0wcVb/TmoSLtDLfhbHKvTwWiQvAkiDLzm4i9EHyL4h/4hA4frpGjPLTe2ulWgXJ9vXkcAEKY6Q 216JsDZ2yGxLgJdLHiw4MlWNB+fE= X-Google-Smtp-Source: AGHT+IGcPrR5rGeQLFy5hNRr/wqPc5YBbMiYo/9jo770rvfisIWgNgnaL/gSQEyki7GvGD0CaYuBONU2K2j/ryIQ3Fo= X-Received: by 2002:a05:6402:34c6:b0:57d:45af:112c with SMTP id 4fb4d7f45d1cf-57d45af127amr8896394a12.4.1719347673982; Tue, 25 Jun 2024 13:34:33 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yang Shi Date: Tue, 25 Jun 2024 13:34:20 -0700 Message-ID: Subject: Re: [linus:master] [mm] efa7df3e3b: kernel_BUG_at_include/linux/page_ref.h To: Oliver Sang Cc: Andrew Morton , Christopher Lameter , David Hildenbrand , Jason Gunthorpe , Matthew Wilcox , Peter Xu , Rik van Riel , Vivek Kasireddy , linux-kernel@vger.kernel.org, linux-mm@kvack.org, lkp@intel.com, oe-lkp@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: y5q8k661ydyx3inxd8qsos95mw9xggba X-Rspam-User: X-Rspamd-Queue-Id: EF9EC4003F X-Rspamd-Server: rspam02 X-HE-Tag: 1719347675-244653 X-HE-Meta: U2FsdGVkX1+eIsQClWrD+vRjDnQw0OPCc1D0pxVmIvPLfTGZmLCRf3eDYecHxqlJfwRssXNEYTWbpFD+lmxVz6S2VW8Qk76CQNQ89mlh2t4tbwmwCsQuphf7q097xJ3LH8ap+IAovh5ynimigqOeJMTOPGu+ap+kwNF6PgfgI33jX6ehyPLVQ4u9Io5S/S9VyzZPatfRE31jlpdKRwABsWKa71xJUnOYWP0J7RDNGY+ao1XrtUSw8iSkMvFJ3HQNtIeV6ZTqRkPa1hy5+wmInj7WbKH84wN3G9YYlWmW/7PZBbCxGdiTMfsPGCDlR4xcha8NfAnRJcdBwL1IMgrRFJzMQPHpz/zXjFEES+zwKSk8oGiruqYTDXuVncRaitsjC+zsL/X0X9cPvNTukbp+NjYpInwLvuDwrxAlXKCDYBZTarTnguDiZyx4Tkfw41g1ECWdgoUZZJxKislroA/B7FcMmxpTVSCChTs+QgMnACXL2KPNyRLi2Ip9XgDjKiD4WZhuknOMh8uhTr0Q6243P4PJUw+bkrNPeJ9WHXnd4mSjzmJERr8FQg8P0qjhAWKtnI6YpxTXPVcYgUzZzBFl96gWxEc84RuNVti/FSzoljzRbM+syX3FRnMpX98LbGBunwPzpcFQq3tS52ttIjXS5n7l39dEMFl4VlkGH1iuOCh8t+ZTxiaAo3zmBtOXP+dbpmmxHVRwRKD5OSgFQGm+3rP0CyfvQuTg5eaJA54jAZxzIdHCTnMcnevIsbIFMOOdRoWr+D1M6QGAgFd1EHKQQPuNyBiGr38S/ozvStRUWUnS4hLz1ovLwN+l93zLu17DmlyMHXLw5AcCtbrXb6BM70j6OBRJfny6zR3sebosIVwl1tQ9YEWnu7tvPJaCw+Mq9zXVwzktPhGqr7ENsAgycVBzzoT0Aeb1iMH8Gz7ntZpbrkIrKNFGtUJH/Av9toB9rPfguN2ghu7KqNEFJwr ldd/28l4 TagdHAZ82OdHwvtpPqczYqAmmRBdkvQNpoSBXZuzjN8WjR0FsW2s6g14RkfLi/XYkqcO5/4Uj3XQZhFPWpN8mxVhT9wSuh9Yv0c3+bRJtRsOhPMwLkts1o3dNJ8RCMeJ16ldTc3iaMP8WIwsNwL3qLwUkdXZhu4IJ6K9oPhivaPxdBD+aQuPRjuqp4RLQXIpRTrpG9cJ777AboeOnmFyz2VT5VhInX+VKR+WT6GjzUteAT18ThmA4zyMN9AgdFIBDQIFbg3PeV/155ISruxi3J0fTGnnV0RnBNBHeyvyGlrYO8Lar1h1BIr7t1oNAnyTRfbYJ3H8dFlj+eTZhhmTa2gBWUmdYrX9JB2fSA2YeUM9TyA1RYqxGjNpMV0Jqt5N+7kZNxaYb9FUD3gjnT5bMPFrUaUoZIyTsc2x7FOI4phNj4RdXNP4ajdvIQSeNR1Oz2ssPddM27ruZNOjc0onbbE+Pgtp2egp55VXSOsaJbCEHisfCt5NeEbupUno3ywtXGXOm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 11, 2024 at 11:01=E2=80=AFPM Oliver Sang wrote: > > hi, Yang Shi, > > On Wed, Jun 05, 2024 at 08:44:37PM -0700, Yang Shi wrote: > > Oliver Sang =E4=BA=8E2024=E5=B9=B46=E6=9C=885=E6= =97=A5 =E5=91=A8=E4=B8=8919:16=E5=86=99=E9=81=93=EF=BC=9A > > > > > hi, Yang Shi, > > > > > > On Tue, Jun 04, 2024 at 04:53:56PM -0700, Yang Shi wrote: > > > > On Mon, Jun 3, 2024 at 9:54=E2=80=AFAM Yang Shi wrote: > > > > > > > > > > On Mon, Jun 3, 2024 at 7:02=E2=80=AFAM Oliver Sang > > > wrote: > > > > > > > > > > > > hi, Yang Shi, > > > > > > > > > > > > On Fri, May 31, 2024 at 01:57:06PM -0700, Yang Shi wrote: > > > > > > > Hi Oliver, > > > > > > > > > > > > > > I just came up with a quick patch (just build test) per the > > > discussion > > > > > > > and attached, can you please to give it a try? Once it is > > > verified, I > > > > > > > will refine the patch and submit for review. > > > > > > > > > > > > what's the base of this patch? I tried to apply it upon efa7df3= e3b or > > > > > > v6.10-rc2. both failed. > > > > > > > > > > Its base is mm-unstable. The head commit is 8e06d6b9274d ("mm: ad= d > > > > > swappiness=3D arg to memory.reclaim"). Sorry for the confusion, I= should > > > > > have mentioned this. > > > > > > > > I just figured out a bug in the patch. Anyway, we are going to take= a > > > > different approach to fix the issue per the discussion. I already s= ent > > > > the series to the mailing list. Please refer to > > > > > > > https://lore.kernel.org/linux-mm/20240604234858.948986-1-yang@os.ampe= recomputing.com/ > > > > > > got it. seems you will submit v2? should we wait v2 to do the tests? > > > > > > The real fix is patch #1, that doesn=E2=80=99t need v2. So you just nee= d to test > > that. > > we've finished tests and confirmed patch #1 fixed the issue. > we also tested upon patch #2, still clean. Thanks for testing. Sorry for the late reply, just came back from vacation. It seems like Andrew didn't take the fix yet. I will resend the patch with your tested-by tag. And I will drop the patch #2 since it is just a clean up and I didn't receive any review comments. In addition, the undergoing hugepd clean up may make this clean up easier, so I will put the clean up on the back burner for now. > > our bot applied your patch upon 306dde9ce5c951 as below > > 5d45cc9b1beb57 mm: gup: do not call try_grab_folio() in slow path > fd3fc964468925 mm: page_ref: remove folio_try_get_rcu() > 306dde9ce5c951 foo > > on 306dde9ce5c951, we still observed the issue we reported. clean on both= patch > #1 and #2 > > 306dde9ce5c9516d fd3fc96446892528af48d6271a3 5d45cc9b1beb57386992c005669 > ---------------- --------------------------- --------------------------- > fail:runs %reproduction fail:runs %reproduction fail:runs > | | | | | > 47:50 -94% :50 -94% :50 = dmesg.Kernel_panic-not_syncing:Fatal_exception > 47:50 -94% :50 -94% :50 = dmesg.Oops:invalid_opcode:#[##]KASAN > 47:50 -94% :50 -94% :50 = dmesg.RIP:try_get_folio > 47:50 -94% :50 -94% :50 = dmesg.kernel_BUG_at_include/linux/page_ref.h > > > > > > For patch #2, I haven=E2=80=99t received any comment yet and I=E2=80=99= m going to travel so > > I=E2=80=99m not going to submit v2 soon . > > > > And I heard if hugepd is going to be gone soon, so I may wait for that = then > > rebase on top of it. Anyway it is just a clean up. > > > > > > > > > > > > sorry that due to resource constraint, we cannot respond test request= very > > > quickly now. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > Yang > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > Cheers, > > > > > > > > > > > > > > > > > > David / dhildenb > > > > > > > > > > > > > > > > > > > > > > > > > > > >