From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A78C7EE37 for ; Fri, 3 Mar 2023 18:55:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0EE976B0078; Fri, 3 Mar 2023 13:55:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 09F0A6B007B; Fri, 3 Mar 2023 13:55:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED08A6B007D; Fri, 3 Mar 2023 13:55:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DEA5E6B0078 for ; Fri, 3 Mar 2023 13:55:23 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AB76FC1248 for ; Fri, 3 Mar 2023 18:55:23 +0000 (UTC) X-FDA: 80528490126.05.11D4408 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by imf15.hostedemail.com (Postfix) with ESMTP id D9A30A0002 for ; Fri, 3 Mar 2023 18:55:21 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="DWFAH5M/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.177 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677869721; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N7wlGDroZzOg+2IjAVas7e/KeaMFCpHiT+RVQL9gPBs=; b=6yyTN5xNMP+3U+p1f8Doji8Dkr6VQ9aVU+AWX4CZEzOJtFF/T9GgvQY9aJINKta8nSoNSb +q2zvjV8d1Zt6XnW/gJwkBlXb1/AiMJdPsb8ngnKGQLDcvp2zgHqAHO40wlrQC+1Q52lKx GDyvwriq2BRZX8JQMZb5qvSe5TPkaog= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="DWFAH5M/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.177 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677869721; a=rsa-sha256; cv=none; b=qxESW7KwgF0+OjbXESqjwJ48WCK7k8Cd9s8Qsf1lK7QyDzaTVJ5QjLnJTydmCEo9P02uCU PGUHVxHjfwjQqoOs9KNT4/RHzyQoCf/MQbz3C842aOdCA7RyHgnoiZpWewQax2LunA4xuq tzt4yNRSOyKsMHmcUiE35tr2f8OaEuc= Received: by mail-pg1-f177.google.com with SMTP id bn17so2062349pgb.10 for ; Fri, 03 Mar 2023 10:55:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677869721; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=N7wlGDroZzOg+2IjAVas7e/KeaMFCpHiT+RVQL9gPBs=; b=DWFAH5M/qFHxUMQx0oKMPW/xb7JKmBEfDR/f4aTRQPFOLhXXydFA8V272o49Dwu+pN JoerO1de1Pm3ZeRJR8ch6VamHzgY63wim3VrWx8OQDTZBjmJ2pXMQOyMYRfWNpvMGuuW zyFQAjyc0PpAS7+ywQnQaxyUB2iBMzdAf75ZntaULB9DDv/RkUIFJDXt017jWKcJ92wW TLvy6wIyiB36g+E2Ok4koq3SaDOlGa+MHMUoa5SMpTce/m+Ttco3ne7xiC4SNHtb/VyV 3oJA1u2MnlryGNXXJ+sIwMiyFEHHFYkzm7BRiOPEnTKmtIOypzgSg7mT+i+OvkjvOJLe cRfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677869721; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N7wlGDroZzOg+2IjAVas7e/KeaMFCpHiT+RVQL9gPBs=; b=ZGMac1ryBtiHG4xynFTBikYHzZr4q02jR230BiGTsTwzdsacyMNiwDuDM+Y7uM3Fs+ 0Y+6cmiFrs6LIMePcLQG43fRpEqcZX64VMplu0oslvQYlBT4RGOpJvJkF5Sch5pcsI5Y FWss8wydlkAoVDZD4Xs7FCE5tu/AxP/VBPwc8FtsP6YgoR03CFgaG1c79bQgl7qCGIYZ NiEmYUsRGJWH1tDKitz+z2JfsJ8RSrf/I0GyLzzg2uLhqzmEFvDYjHAwqxWkEXP4cO99 rtLYBmJhwMpDjWYViqViCe1FfYu4MFU9yI6ExqGSV5dvKjs7T81T/I7b3sCDQDPQ/KPG Xxvw== X-Gm-Message-State: AO0yUKWMPAKqKRBPqjKho7J57pXPUXtgXmXT2ta1YfY8y6hXQeMRwKMa 1CxyQZK9zdc7QvpXkS6s8FcFqQnV++5abou/6nY= X-Google-Smtp-Source: AK7set8dmoPgvy6q2h3W+WcuHxL1wFt0qmnk/vBnXIwlYMiQHjtBrLN/BBCnWiOrjnPeu7tzgHM2B+WVk+4EViFRRF8= X-Received: by 2002:a63:7e11:0:b0:503:913f:77b9 with SMTP id z17-20020a637e11000000b00503913f77b9mr855552pgc.6.1677869720669; Fri, 03 Mar 2023 10:55:20 -0800 (PST) MIME-Version: 1.0 References: <20230217085439.2826375-1-stevensd@google.com> In-Reply-To: From: Yang Shi Date: Fri, 3 Mar 2023 10:55:09 -0800 Message-ID: Subject: Re: [PATCH v4 0/3] mm/khugepaged: fix khugepaged+shmem races To: Peter Xu Cc: David Stevens , linux-mm@kvack.org, Matthew Wilcox , Andrew Morton , "Kirill A . Shutemov" , David Hildenbrand , Hugh Dickins , linux-kernel@vger.kernel.org, "Zach O'Keefe" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D9A30A0002 X-Stat-Signature: zeam67rn6ptho13ej88o7px9uj7saf6i X-HE-Tag: 1677869721-695617 X-HE-Meta: U2FsdGVkX1+nOMjEWtxEu8aLlxkImR3WUno6FAv2Vue+qqnlX3IPfX4orI6T4nx5bFXJSb6ig0zDP2mzcdsdZH6ephRWJuCGd7/o+7ZiBE3UKA6iuXEN7NECP6pWbTQdzfLWB5cQHricrbus8++ZocH2veZ0ncg+1/YIangtfw6qVPRaf6Yofm3p69WYCJmuhit0dRMBDEZPIsEPULelveuT8b+0j2aIcPe4z2A4hPHFDw6Ui1ZGgI83hJN578JmfkKZ8q8fTJxQTFpEtqBx/B9rAHRU84dxFhlNdISXUw/aBRf1blZdnKG6USONBllgsTt34uP0i8ZAvTeVInaCC+SN+ZxHGKEdx+Mhg0GPTljDUGjzHEeA9H458mEq/MEuh5jHENw4FYkldg/ydMMAJRKV55FIt8+ja37d5gmcSkMxMPixVUhe9G2Ld43coe1/byp5BvFRD/VSNPYiGzR6Uv2rkiQ4GrjcVk31ohy/8JWURM289/od0fF4s3A7rwWPtqb9UVXTClv/M2IFQcZP+HvozPPgmD/lq1d1UDB/ySMRSWX7HK8qoiJbbnJe7aFwlTAtDBCsET8JBCvaftWP7QOF5rhK7v9byZjLAukupnTMfCz/ewTyTxV6ryqg9NAcyxlMYycSEwMx+hmKR7v2r6rMe0254B8jd1W7ArsZhivjOfgSVRYBMALx8Ua+RXvr7HKNR+9AP2hcsMXrI4uibeGAMb0pLAG7e3pg1L/gacjhICkuztAS6drXIVP7+7dfRo+KX2JxaXTY7/17VePsbDUzx9hZPrnVKS4MB0e2yfJV3/fNDo/3XzP0CBDMtrUCsjT1reEWnR1/Q6ZCKihPZere3RaoAsX0k6n16J6zZRX87gVrEYyqWcq5JAP98aiLj7rpNCn0JWqFCoCTbrz1MEbn7hV4pqd/7ZaDRB6AtdJRrUR6xbbik97f7EUithcTzHe5I0a2U+4HGaBoEE5 tYDv1lJM Jds3Q/JvnpsQ1U4HwYiB788OYKmKPZW+BalUXzpXcY56r3iSB+Ucc1HlqnFb7MCiOibZ7eLEil4PDpfKdaGuV8GQPobby0zgEpAQY4vzd7aT61TL1NibFkREVu7niYGWhxfJP3laySoQibtIcx2lfmsWwzwX2HrJno4cVzth3PoZm41Ab3Oeo3IHGvkvGZarhlumMq1lm9M3pDd9QFbHdOuqCJJBJnobZlQPMcG5/v9KTRM2lbpxj30kqx5QcYGgy9qcbB6UAOczPPGaAnCXSPRxjZzF9X4cG6rnrweYOkeUrPuhrGGp0zKXiKKJz0WRxkvl1/9BkE862BXDM38iBsgHzbXIdFl0AV/U3WjUCSWK2Rm73YNB2xI24c0wvwJYbE592S2z8+m7/hI0GXW7JHk50R5AMUZ9hXzSw5mEsXXLq1Fp8gvPVNbjMMWxMUvzfIT74wNnEK5HvlV1eeIGQ/QOSvbqr6oI254Yiwk72E1wMHFR/QJa32D6hU1bgvhG/ZYpC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 3, 2023 at 7:35=E2=80=AFAM Peter Xu wrote: > > On Fri, Feb 17, 2023 at 05:54:36PM +0900, David Stevens wrote: > > From: David Stevens > > > > Fix two races in khugepaged+shmem that cause issues with userfaultfd an= d > > lseek, respectively. > > > > v3 -> v4: > > - Base changes on mm-everything (fba720cb4dc0) > > - Add patch to refactor error handling control flow in collapse_file > > - Rebase userfaultfd patch with no significant logic changes > > - Different approach for fixing lseek race > > I just noticed this one hasn't landed unstable, so I guess I just posted = a > trivial cleanup that can conflict with this so it won't apply cleanly.. > > https://lore.kernel.org/r/20230303151218.311015-1-peterx@redhat.com > > The resolution will be fairly straightforward though, and I'm happy to > rebase that one to this since this targets a real bug so should have high= er > priority. > > I guess it's possible Andrew thought the series has unsettled comment so > Andrew could just have ignored that whole set in the mark ups. A repost > could possibly clarify that. IIUC this series should need to be rebased on top of your clean up patch? > > Again, it'll always great to get another eye on this slightly involved > series. Matthew / Yang were already on the list, also copying Zach for hi= s > recent works on khugepaged just in case he spots anything wrong. I had a quick look at it before, I didn't recall I spotted anything wrong about khugepaged, but I'm not familiar with userfaultfd. > > Thanks, > > -- > Peter Xu >