From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EE04C19F2A for ; Thu, 4 Aug 2022 17:44:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CEB06B0071; Thu, 4 Aug 2022 13:44:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 77D2E6B0072; Thu, 4 Aug 2022 13:44:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61EE88E0001; Thu, 4 Aug 2022 13:44:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4F0006B0071 for ; Thu, 4 Aug 2022 13:44:01 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2AE6C141284 for ; Thu, 4 Aug 2022 17:44:01 +0000 (UTC) X-FDA: 79762633482.23.E5D97FA Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf21.hostedemail.com (Postfix) with ESMTP id C3CFD1C00AC for ; Thu, 4 Aug 2022 17:44:00 +0000 (UTC) Received: by mail-pj1-f52.google.com with SMTP id q7-20020a17090a7a8700b001f300db8677so453014pjf.5 for ; Thu, 04 Aug 2022 10:44:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=/ppL5FkBSrChQnljuBdNYbX2wAl9Ivpv6wHBOwZJkEM=; b=mxw+F/7z3YXIMcgO7ctt+zVucnEskLncvgAK2HJeOmAnYh6Cph2ZRwfxDM1CRaSTOi iVzoLZzyS7etkgfM34YtE8JSjm9mqUzPZfnK+MZguv/duKOEV9jPlCLA5kAziuFnPkge bvWaLalW2JFcojyhfq6AO1gwrvtni8dZX3mZbSXLx4TPoTpRIs6cMvFu5wMgOVud8Rsn igo7++jcY0Q/pFvz5iEzmM+BK4VN/kLapf4xHAX+IGgt2tyh/sG8JoV4iUZq6wkeLMhR +n3po08Nut7agW9E9IMHR/bSt/ITrdC06VY7sAHjmKlx4Jy3RfINmQ3Fjpbzwv5k0PKS vS8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=/ppL5FkBSrChQnljuBdNYbX2wAl9Ivpv6wHBOwZJkEM=; b=sQ7x4ssLDLXKjuSSCDcRNzK/ImGBPwS6gnX2ZYCM29gWU1yCfNNygaCUWwn73MYgBf jD6XtEWQopsw0E0I3zVOULDTV9WcxOSI1KuGfbzcEhUNSHy2UGyMdmf23l4EwpIgrZjO TH6Wxpbw2etHppz4AWJkyJUraBlmlYII+lA55ZdAKepCv7BlcWZBGkFQQ3k8Od15WP6r gtAP6o5ixxvcjnzUZ4q7XlIuWj9m9hxbN81vqbtubF9Gwfo8p3KoQWddomayZHgCyILG 9orZjay1lOwiOlpxfCKnLRWesRbKjxQgLYFzqNKto3/Phj6hYu4Dfk2FbkNYQs17cP+C xQSg== X-Gm-Message-State: ACgBeo3ujJ7uuWlcoXaY/3iVkNJy2eQMdpmxJcV1ybmpf9PJEC32XSr7 Tp8hgwTMHYNoiEOxuAJt+kYLjc4ucpfRQGQFkxE= X-Google-Smtp-Source: AA6agR7xuV+991n6wMtC1ouAKAX7cI9gnY4rfxk9Dx/AvAaj9pYd/kwMVjbYwLgCyuGOWyg0bJBA+anG/BFDOzPSwxQ= X-Received: by 2002:a17:90b:1b45:b0:1f3:1974:eb8 with SMTP id nv5-20020a17090b1b4500b001f319740eb8mr3231740pjb.200.1659635039717; Thu, 04 Aug 2022 10:43:59 -0700 (PDT) MIME-Version: 1.0 References: <20220803220329.46299-1-peterx@redhat.com> In-Reply-To: <20220803220329.46299-1-peterx@redhat.com> From: Yang Shi Date: Thu, 4 Aug 2022 10:43:47 -0700 Message-ID: Subject: Re: [PATCH] mm/smaps: Don't access young/dirty bit if pte unpresent To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Nadav Amit , David Hildenbrand , Konstantin Khlebnikov Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659635040; a=rsa-sha256; cv=none; b=Sc0nNu48jH5qO4CRsF8p9mI9qdf4P1lwsirBcOQnFXipE4S0UEM27hstO/7wvDpYEHyLmO x0xeQ7FUqvPTfzIkuKqmzzpwfLZFXv+Ftw/OY/iaI9Baoiv1LwmST7ru9d4j8qSnqB3moB OpqZtMIe3CyMPYO7Nq/wzqKHaWrH+B4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="mxw+F/7z"; spf=pass (imf21.hostedemail.com: domain of shy828301@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659635040; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/ppL5FkBSrChQnljuBdNYbX2wAl9Ivpv6wHBOwZJkEM=; b=p9mBhh3ZNtFwVLidpRhA5VzMHeGuRuhHjzx0WcyR9gs2fI7iRk9FGhOt1uRmoeg4p1/gpV BYkNeOQFtq07FhaEzFdZwh8RgCg4BenjZbhclIiGFFjssm89IyCPb1IRr17WXH2dx+fNLJ JHI4xylV+F8q0L7fCMxGp4SUloBBSkY= X-Stat-Signature: ujuyceh8o7zsysqjdraizq8rgnnjukhz X-Rspamd-Queue-Id: C3CFD1C00AC Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="mxw+F/7z"; spf=pass (imf21.hostedemail.com: domain of shy828301@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1659635040-772560 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 3, 2022 at 3:03 PM Peter Xu wrote: > > These bits should only be valid when the ptes are present. Introducing two > booleans for it and set it to false when !pte_present(). > > Cc: Konstantin Khlebnikov > Fixes: b1d4d9e0cbd0 ("proc/smaps: carefully handle migration entries", 2012-05-31) > Signed-off-by: Peter Xu Reviewed-by: Yang Shi > --- > fs/proc/task_mmu.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 9913f3be9fd2..482f91577f8c 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -527,10 +527,12 @@ static void smaps_pte_entry(pte_t *pte, unsigned long addr, > struct vm_area_struct *vma = walk->vma; > bool locked = !!(vma->vm_flags & VM_LOCKED); > struct page *page = NULL; > - bool migration = false; > + bool migration = false, young = false, dirty = false; > > if (pte_present(*pte)) { > page = vm_normal_page(vma, addr, *pte); > + young = pte_young(*pte); > + dirty = pte_dirty(*pte); > } else if (is_swap_pte(*pte)) { > swp_entry_t swpent = pte_to_swp_entry(*pte); > > @@ -560,8 +562,7 @@ static void smaps_pte_entry(pte_t *pte, unsigned long addr, > if (!page) > return; > > - smaps_account(mss, page, false, pte_young(*pte), pte_dirty(*pte), > - locked, migration); > + smaps_account(mss, page, false, young, dirty, locked, migration); > } > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > -- > 2.32.0 >