From: Yang Shi <shy828301@gmail.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
kbusch@kernel.org, "Verma, Vishal L" <vishal.l.verma@intel.com>,
Yang Shi <yang.shi@linux.alibaba.com>,
David Rientjes <rientjes@google.com>,
Huang Ying <ying.huang@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
David Hildenbrand <david@redhat.com>,
Oscar Salvador <osalvador@suse.de>
Subject: Re: [RFC][PATCH 11/13] mm/vmscan: Consider anonymous pages without swap
Date: Tue, 2 Feb 2021 14:35:00 -0800 [thread overview]
Message-ID: <CAHbLzkoziAjggkufOx5avbYiYGS903kpMyPmQzv_2bwK3snNxw@mail.gmail.com> (raw)
In-Reply-To: <21785ed9-9591-e070-0941-6113999fa69e@intel.com>
On Tue, Feb 2, 2021 at 1:35 PM Dave Hansen <dave.hansen@intel.com> wrote:
>
> On 2/2/21 10:56 AM, Yang Shi wrote:
> >>
> >> /* If we have no swap space, do not bother scanning anon pages. */
> >> - if (!sc->may_swap || mem_cgroup_get_nr_swap_pages(memcg) <= 0) {
> >> + if (!sc->may_swap || !can_reclaim_anon_pages(memcg, pgdat->node_id)) {
> > Just one minor thing about may_swap. It may be cleared by
> > nr_boost_reclaim. But demotion should be fine for boost_reclaim.
>
> In other words, this if() is here is to avoid generating suboptimal I/O
> during boost_reclaim. But, since demotion doesn't generate any I/O, it
> *should* be fine for boost_reclaim.
>
> I agree with that in theory. Although, I'm tempted to put it in the
> TODO list as something to look at in the future. Do you think it's
> something that's immediately necessary?
No, I don't think so. We could tweak this later on.
next prev parent reply other threads:[~2021-02-02 22:35 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 0:34 [RFC][PATCH 00/13] [v5] Migrate Pages in lieu of discard Dave Hansen
2021-01-26 0:34 ` [RFC][PATCH 01/13] mm/vmscan: restore zone_reclaim_mode ABI Dave Hansen
2021-02-10 9:42 ` Oscar Salvador
2021-01-26 0:34 ` [RFC][PATCH 02/13] mm/vmscan: move RECLAIM* bits to uapi header Dave Hansen
2021-02-10 9:44 ` Oscar Salvador
2021-01-26 0:34 ` [RFC][PATCH 03/13] mm/vmscan: replace implicit RECLAIM_ZONE checks with explicit checks Dave Hansen
2021-01-31 1:10 ` David Rientjes
2021-02-10 9:54 ` Oscar Salvador
2021-01-26 0:34 ` [RFC][PATCH 04/13] mm/numa: node demotion data structure and lookup Dave Hansen
2021-01-31 1:19 ` David Rientjes
2021-02-01 17:49 ` Dave Hansen
2021-01-26 0:34 ` [RFC][PATCH 05/13] mm/numa: automatically generate node migration order Dave Hansen
2021-01-29 20:46 ` Yang Shi
2021-02-01 19:13 ` Dave Hansen
2021-02-02 11:43 ` Oscar Salvador
2021-02-02 17:46 ` Yang Shi
2021-02-03 0:43 ` Dave Hansen
2021-02-04 0:26 ` Yang Shi
2021-01-26 0:34 ` [RFC][PATCH 06/13] mm/migrate: update migration order during on hotplug events Dave Hansen
2021-01-29 20:59 ` Yang Shi
2021-02-02 11:42 ` Oscar Salvador
2021-02-09 23:45 ` Dave Hansen
2021-02-10 8:55 ` Oscar Salvador
2021-01-26 0:34 ` [RFC][PATCH 07/13] mm/migrate: make migrate_pages() return nr_succeeded Dave Hansen
2021-01-29 21:04 ` Yang Shi
2021-02-09 23:41 ` Dave Hansen
2021-01-26 0:34 ` [RFC][PATCH 08/13] mm/migrate: demote pages during reclaim Dave Hansen
2021-02-02 11:55 ` Oscar Salvador
2021-02-02 22:45 ` Yang Shi
2021-02-02 22:56 ` Dave Hansen
2021-02-02 18:22 ` Yang Shi
2021-02-02 18:34 ` Dave Hansen
2021-01-26 0:34 ` [RFC][PATCH 09/13] mm/vmscan: add page demotion counter Dave Hansen
2021-01-26 0:34 ` [RFC][PATCH 10/13] mm/vmscan: add helper for querying ability to age anonymous pages Dave Hansen
2021-01-26 0:34 ` [RFC][PATCH 11/13] mm/vmscan: Consider anonymous pages without swap Dave Hansen
2021-02-02 18:56 ` Yang Shi
2021-02-02 21:35 ` Dave Hansen
2021-02-02 22:35 ` Yang Shi [this message]
2021-01-26 0:34 ` [RFC][PATCH 12/13] mm/vmscan: never demote for memcg reclaim Dave Hansen
2021-01-26 0:34 ` [RFC][PATCH 13/13] mm/migrate: new zone_reclaim_mode to enable reclaim migration Dave Hansen
2021-01-31 1:13 ` [RFC][PATCH 00/13] [v5] Migrate Pages in lieu of discard David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHbLzkoziAjggkufOx5avbYiYGS903kpMyPmQzv_2bwK3snNxw@mail.gmail.com \
--to=shy828301@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=rientjes@google.com \
--cc=vishal.l.verma@intel.com \
--cc=yang.shi@linux.alibaba.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox