From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05306E77173 for ; Fri, 6 Dec 2024 16:28:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 806EB6B02A1; Fri, 6 Dec 2024 11:28:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B6AC6B02A3; Fri, 6 Dec 2024 11:28:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 658126B02A4; Fri, 6 Dec 2024 11:28:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 439616B02A1 for ; Fri, 6 Dec 2024 11:28:50 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9F9014353A for ; Fri, 6 Dec 2024 16:28:49 +0000 (UTC) X-FDA: 82865067306.13.6ABA52A Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf03.hostedemail.com (Postfix) with ESMTP id EB3812000F for ; Fri, 6 Dec 2024 16:28:39 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AolZ47hk; spf=pass (imf03.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733502511; a=rsa-sha256; cv=none; b=l+L5iGwLIK0EONwCJLAlwuHKrQW9Huzwx8OHrA9BbbulUTCmVhhEyTOVPxKQiTMb1n0nAH fG33SLSkBzQpVgZGGu7Lt5fzMEjs0TQEu0hF8Z1wwE60YBbqpTWDCxqlR7bodD2Ny5prQb vbb9NLpOtradk0exF2pZ/nrH6tqJp2o= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AolZ47hk; spf=pass (imf03.hostedemail.com: domain of shy828301@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733502511; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JywJlKrMBcpEVEJZlt+4MRZB//cmI0MtswgLvsUpZ1c=; b=T3aBc4JQNzxbx6JX+fsyTTMUU/ifYwlR6d+Fa0SlpD7JjFHGawceMxswHGdg+pKzAYQDAd 7Ysa+5Q8gwLYuWEdDnuUh7l/i08kr7dqn6nkjxt/CrYITQ4roMmrG76Vo9fN2DPpyRrUgh 0rhF+z4PBqbbtpfRLVEOAKsxoQtrDdM= Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2ff976ab0edso23979371fa.1 for ; Fri, 06 Dec 2024 08:28:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733502526; x=1734107326; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JywJlKrMBcpEVEJZlt+4MRZB//cmI0MtswgLvsUpZ1c=; b=AolZ47hkF2qqHxJNanN1g544AHzxbKu/qyE1Nuweh4WGJpzLYOYe5MHVw4zg5w1kh9 FSwLLrj/4VE9GcZHJ/e8dJHj79PlAO3LFdRj3sC5/bKlrZud9ge8b1tyFipkjn46BtR8 AVJjn990eM1aB5J0ZV5+0X05qewSGW7dy+HyxCA65BcIGCS7Ap7aiEW8FhHmKbNOgyid rZiIf1FnZFnhld15yM6wvyEcyMJDGTFVWB7pQNKBrafh/dYxWMXZZ9qtU/Liyr7nMbSA AvsWTltmlZpttDOGvS6Gti+V/qBXW1jR7M5P5jXWmRBmugU/nMBU9AjDOdWizIY3hQqh DnuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733502526; x=1734107326; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JywJlKrMBcpEVEJZlt+4MRZB//cmI0MtswgLvsUpZ1c=; b=pCpZ0sLlJsSiHBfqJp9UPUEQfl3yzKYjBXWxgqkjujEgORS2nrO9j+kiZgzrkz5eDf IQj9F8wYwf/jFGxMjX57B0HMw6ENhcig5DtHha1qoCNhLuj6rFo7mY+zUTIKFHDJxbeX oPeKSZieJAeN9QfU+BssaVhMU2+AFeY92YzLu23IRkyhCKz8VzCy6jfqWoi4J84RVlG7 Fic5crYO8TiaoKHW2aHVtmn2u3+kO7981VssaW+N9Rw8yMMPnwTBgNTIrsRc2FVCudLZ Vmqg/0CNo0ZABh1PY2dTYHmR6bG2gWxPVh2nyLCRtYqZKulX/ow544mbZPKMh9Tvz9S2 iV4w== X-Forwarded-Encrypted: i=1; AJvYcCWddIGeYEsuXnFAF1nfUAkquPdxH/o5v39ISdva7NybsiAutMEc10MSf8H298l+9AGaZ/Nbti+8Tg==@kvack.org X-Gm-Message-State: AOJu0Yx3kXz0gizZbR5nBNGoi7O/+e/ECrjtp/FteFmkaNijYdwCqFiV JkvUquL6aiiN8hOwr+ziihJ05uiKWu+9/SogeqbjxwTQ548cfkkEyCemvp9XuPDmxznXrHIZpWJ cdEzfeaIaUWnfmAhIZFU/dP88g8c= X-Gm-Gg: ASbGnct3xWnH/dNYT9lckre4O0pdklfU4muzH0w/I8Mh6xoFDeKFziw0sJ7IV6rCpMt ODkK4bNJl0uf+Z+thzIR7QfAfRxgaoelY/g== X-Google-Smtp-Source: AGHT+IFGfN8Q5G4mKa9ETMH5jrAjoOrfbVyC+nALAJ+ddCOr727yBpNj/RqbgC6OQGaOUv8YmJX6tSh3kWJ6rrTfu+c= X-Received: by 2002:a05:6512:2392:b0:53e:22ca:1720 with SMTP id 2adb3069b0e04-53e2c2c211dmr1695651e87.26.1733502525521; Fri, 06 Dec 2024 08:28:45 -0800 (PST) MIME-Version: 1.0 References: <20241206070345.2526501-1-wangkefeng.wang@huawei.com> In-Reply-To: <20241206070345.2526501-1-wangkefeng.wang@huawei.com> From: Yang Shi Date: Fri, 6 Dec 2024 08:28:34 -0800 Message-ID: Subject: Re: [PATCH -next] mm: don't try THP align for FS without get_unmapped_area To: Kefeng Wang Cc: Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Christophe Leroy , Rick Edgecombe , linux-mm@kvack.org, David Hildenbrand , Ryan Roberts Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: EB3812000F X-Stat-Signature: 5jxa5issnm7n37xhuskk7jfqgxpaei5m X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1733502519-641086 X-HE-Meta: U2FsdGVkX18cbGbpOKt+up3ZLGgrNMOsOEr3Hwwt97CSGI9QZs+ZCVLCyxxVTqHSViq8JeGKkoPt0HGU2Hu/NQ6xFphVGyryriXHa9WBFl+MqENZe/hWY0XN48wE2E/vQcuJ3MbvuPomfTrvNz41aQk3vXUvDLsvKUgI0mXR9Hhl+TLfr1orO8aHQVxwPG4YoF7dfQFDhAIAN4uM95b0REnroEX2w+hGvln+kevcIuJ15xb7LLscnJ20pGQD9E5WWDi+RMmOmQ/Oy6AcfhsbzP4V+ydSzbgsqU5DAzXPLvhvI9D7PQ5R8SPYv2+fYT2Q2HP+V9mWT0EuBFAdfcr8bO8Uo5Dp5//FDoYTZOjwZnH7fqdg4HrdkpiNg91DXdru7B5+bwICg1YL6y1RQefzPP6y1U+/UbHOp9MUlfMA1qLWcITU7GqdEfASx4E0oFjw0QkYC7ooqRAoFi5feLyouYiJi3cGmefS+uRUF0/QznuaEL+ggo+yLoKdvwAZqm0DCcMNb8NuhEoHYHtWzh6xosZvcis74bcSBka4nA/eotwy2MdRkQLlESzzDv2t8l/l++8EiNakcpf6km+B3yeEE5xIabtUvJKB7Nh0Zo3FbBKC/RP3m7/S7u1Jeby5ZSbP3ZZVsSBxp4ShGPy8NQq/kwIyBM9gjRMdm0W+PTE+QHPzWh7/EtlMu/Enszy+uW//1YuolOnuMNnX2iYxcvKauHnuOdWwW3ic+gQmpjDRym/jBe0TyyW4LipxHBxxPDD4HuFPuQPLnCsQHBJae0Ru7KMIzxMXDsgFwmaSH2h7+c6GK2fVaYFArPn2caeow3RG1ywZVR3SQXWRGrK3vL2OAtNmYena5OUPQ0hsiSMYUQEbbfA8codQfcWXxguoNga0wN/+ApaiYpbF6wFJaeYGvs5k3UoD2EfEnwZyu53SZyto4ruUyU2UsSUh1Bjw7eTUiN5DyM1TYK5buEtWfxA SPHYce+s HxfBfHbHXj0SNs0sKcsdsm+4iHxwQYPVvmw3+pJRkTALp8DSTSIJFeOFr3kgrv2LgfpXai2rN9MmBInfTLo5nRTLDmPzzGG/v1oWQC5IdoGa8Vk59AHWRWSVHKu7oOehgq5TXN1FQlB+Tt3/zZg97UnWWzDwtcmGZPgtywJ49Wa6EC97+/7rXTPH7fZatHqZIsgu0p1lh8ZOa60EnuWgsFYssxZdQjx7NDX7hFuPeGbkzitPzZsuoHyWIq3Ly5/dvUCjrlCSonbGire75OT/omCCWB9/OdjOtK+om9LsJvJGjMWSbYOHiLYzl82t741YW8ZeG5Hy5wrucUaPKTGc5W15gD/AP4VRkGD5xlPMvlgHSNMUtkMUJIOlUmvTHt+ryIoC2e9L9QZ8lHgglVDxUS4PweNYoxEGDmgWC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 5, 2024 at 11:04=E2=80=AFPM Kefeng Wang wrote: > > Commit ed48e87c7df3 ("thp: add thp_get_unmapped_area_vmflags()") > changes thp_get_unmapped_area() to thp_get_unmapped_area_vmflags() > in __get_unmapped_area(), which won't setup get_area for anonymous > mappings, but it leads to always try THP align when file ops without > '.get_unmapped_area' callback too as the get_area is NULL. > > Since commit efa7df3e3bb5 ("mm: align larger anonymous mappings on > THP boundaries") only want to enable THP align for anonymous, adding > !file check to fix it. Good catch. Reviewed-by: Yang Shi > > Fixes: ed48e87c7df3 ("thp: add thp_get_unmapped_area_vmflags()") > Signed-off-by: Kefeng Wang > --- > mm/mmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index 1c6bdffa13dd..b373486bd1c6 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -782,7 +782,7 @@ __get_unmapped_area(struct file *file, unsigned long = addr, unsigned long len, > > if (get_area) { > addr =3D get_area(file, addr, len, pgoff, flags); > - } else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) > + } else if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE) && !file > && !addr /* no hint */ > && IS_ALIGNED(len, PMD_SIZE)) { > /* Ensures that larger anonymous mappings are THP aligned= . */ > -- > 2.27.0 >