From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07C76C4361B for ; Thu, 10 Dec 2020 21:59:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6E60B23358 for ; Thu, 10 Dec 2020 21:59:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E60B23358 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5954B6B0036; Thu, 10 Dec 2020 16:59:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 51E526B005D; Thu, 10 Dec 2020 16:59:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 398626B0068; Thu, 10 Dec 2020 16:59:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0047.hostedemail.com [216.40.44.47]) by kanga.kvack.org (Postfix) with ESMTP id 200426B0036 for ; Thu, 10 Dec 2020 16:59:20 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D41303628 for ; Thu, 10 Dec 2020 21:59:19 +0000 (UTC) X-FDA: 77578739238.14.loss50_4902054273fb Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id B7C1D18229837 for ; Thu, 10 Dec 2020 21:59:19 +0000 (UTC) X-HE-Tag: loss50_4902054273fb X-Filterd-Recvd-Size: 4531 Received: from mail-ej1-f68.google.com (mail-ej1-f68.google.com [209.85.218.68]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Thu, 10 Dec 2020 21:59:19 +0000 (UTC) Received: by mail-ej1-f68.google.com with SMTP id a16so9539309ejj.5 for ; Thu, 10 Dec 2020 13:59:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mehdCErR0yhsbjduWQoy07Nba1zedRECDietLN/feuw=; b=vH37f4c4uUnV9Lj134aNl+bMtR+Z16rKS3qiQpYSYV8wounD/s646Yp7jfkbi34PD0 T/TUAnKDsD/maaoFwDIP2gw42w390vdr4cRsX5m5EWGrw6w4go8dfJW+54wB4sKeKMdB J50SUk9LykObnY0IqNdzt0epf9o7MlB7nI/Qnnu1qweP1woJULmga0XKmxAP47FximoF 68bhuW01qTVxo5WCTe4YBt+p55BgEH1vju3fUnWPCpqGPHaVoVqclXU+rwv4GYCE9fKE pxTq1UdecXQqDpXHasxWX24Mkpzd4kIuVAmP4+S4r8jZzVZOX1qcCojyrZqBzP4fnJcJ K7+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mehdCErR0yhsbjduWQoy07Nba1zedRECDietLN/feuw=; b=Plq4fwY89nwngwQgVJ+RMqnJHHwWv0BdwFh/kjjs8nW4I33F3sZa0qUfVPcbviixWG EdVxVBGqXrOuZXVcJQhGETMoXcsUiFPuI/a1yilmsY32g6Yw4WwCRlfkw4Efz/oqnW6j H/FqrXY3VhjwbB8gOa9/r8JcOcZsVDlmigGxj5C0b/e9iKlxbsO4Ju7yebcy0KVUaYLL l+VHUtUjwga/c8qkrmYQUiGNDmyOY227UiGY7ni2XeK6jtwUqrq1Sj5h7ExBsVFQLQlc t83TMprdSRaCqOr8NqWYDtxf/i4PkEqXGzhrfeubDTh2p/V999C88TpUHgb4yZLgCBc4 x6mQ== X-Gm-Message-State: AOAM532rDkSJbEX4XgCIstC1qL9ik6GUYz6KJdpbzHQMpRV+MAR+SI4B zzGHYrJU4NUL+ZrNXn5mwk1kuNTiNU+0DOw20qU= X-Google-Smtp-Source: ABdhPJwPvbcgp24AbDog3/LDvwOSMb9RWGw4IainYjFFWWVMewc9GhkVfUbSqtIQxX15N4ulroWGzz9o9gAeP2UdsHY= X-Received: by 2002:a17:906:cd06:: with SMTP id oz6mr8414384ejb.25.1607637557953; Thu, 10 Dec 2020 13:59:17 -0800 (PST) MIME-Version: 1.0 References: <20201202182725.265020-1-shy828301@gmail.com> <20201202182725.265020-6-shy828301@gmail.com> <20201210153356.GE264602@cmpxchg.org> In-Reply-To: <20201210153356.GE264602@cmpxchg.org> From: Yang Shi Date: Thu, 10 Dec 2020 13:59:06 -0800 Message-ID: Subject: Re: [PATCH 5/9] mm: memcontrol: add per memcg shrinker nr_deferred To: Johannes Weiner Cc: Roman Gushchin , Kirill Tkhai , Shakeel Butt , Dave Chinner , Michal Hocko , Andrew Morton , Linux MM , Linux FS-devel Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 10, 2020 at 7:36 AM Johannes Weiner wrote: > > On Wed, Dec 02, 2020 at 10:27:21AM -0800, Yang Shi wrote: > > @@ -504,6 +577,34 @@ int memcg_expand_shrinker_maps(int new_id) > > return ret; > > } > > > > +int memcg_expand_shrinker_deferred(int new_id) > > +{ > > + int size, old_size, ret = 0; > > + struct mem_cgroup *memcg; > > + > > + size = (new_id + 1) * sizeof(atomic_long_t); > > + old_size = memcg_shrinker_deferred_size; > > + if (size <= old_size) > > + return 0; > > + > > + mutex_lock(&memcg_shrinker_mutex); > > The locking is somewhat confusing. I was wondering why we first read > memcg_shrinker_deferred_size "locklessly", then change it while > holding the &memcg_shrinker_mutex. The concurrent shrinkers registration may have race. But, they should get different IDs, so it seems not matter. I agree it is a little bit confusing and not that straightforward, it does owe some comments in the code. > > memcg_shrinker_deferred_size only changes under shrinker_rwsem(write), > correct? This should be documented in a comment, IMO. > > memcg_shrinker_mutex looks superfluous then. The memcg allocation path > is the read-side of memcg_shrinker_deferred_size, and so simply needs > to take shrinker_rwsem(read) to lock out shrinker (de)registration. > > Also, isn't memcg_shrinker_deferred_size just shrinker_nr_max? And > memcg_expand_shrinker_deferred() is only called when size >= old_size > in the first place (because id >= shrinker_nr_max)?