From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F9A3C43331 for ; Fri, 27 Mar 2020 17:47:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 654392071B for ; Fri, 27 Mar 2020 17:47:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ifx83egn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 654392071B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F19C06B000E; Fri, 27 Mar 2020 13:47:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ECC676B0010; Fri, 27 Mar 2020 13:47:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E07B36B0032; Fri, 27 Mar 2020 13:47:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0249.hostedemail.com [216.40.44.249]) by kanga.kvack.org (Postfix) with ESMTP id CBA4B6B000E for ; Fri, 27 Mar 2020 13:47:11 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B17C1180AD80F for ; Fri, 27 Mar 2020 17:47:11 +0000 (UTC) X-FDA: 76641873462.04.dirt96_21a72694d3050 X-HE-Tag: dirt96_21a72694d3050 X-Filterd-Recvd-Size: 4179 Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Fri, 27 Mar 2020 17:47:11 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id u59so12225925edc.12 for ; Fri, 27 Mar 2020 10:47:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vl6M74fDKYNuH8RGWdOOCCv6ZP4dyjZ70PvCE1aC7GQ=; b=ifx83egnh61+hG/1a0lKBCQCmLlYS9+TKE+Yo3jgRE3LY7l7hLz+snpkDi/TJfnVSo tozJDHdlNGXlcu4jyUPuBaxB6Le71WOzFH6gUuhaj+D5ulqcJwDOZ/SvwNYbBfzYsMel OWTo+1fWpuyt+QKJzDVCvTfHemqcIeZZ1x2ajI2q3YDrc+5NAwXCxbE8rHylR2Ku+rGp CBU8rEnP3WuDCbrzGRxD/Fslrkh0syCkk4Pt6KVofOhljNAZJAXXxPnS4Z+1rwecUeOu 9JK1d8Fg0FHBN27uz7b7z181nfV9IwQPLyLjlhMp/hN8AiL3Uf/8EDDkg+WA4g6FTfHu 5cEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vl6M74fDKYNuH8RGWdOOCCv6ZP4dyjZ70PvCE1aC7GQ=; b=dZdqBIeNjuax6FX1b9j8VDM2W+KeAsOK/ITWLiL7dCmAuHa+sS8jT9tKTc6KP79f22 63frZjOE+tlk03IHTfwMN1sVecGUiV3xDekCcS8xrmO/C3vOQVcsU7TsJaQ08zYHISFl af6EHoGEgdHGLSmVu4TNQsBgOVFWDyVavTYgMaJPthagjA+GCuVZwfEceCaFjIrCe0FC zB+So9YA6DTkNyi/ZgjCuzgbSFK/YxM85IQIUrrI0ant6/MK4H/Xs2Z0XHRriEV+A3+0 JpAaauO+ZkbM/k4q5jqMWOjA74PpH++frRXrxdPN3rHEedJT9Fpt4R/n/WFHFB7Lz0ap cJlw== X-Gm-Message-State: ANhLgQ30hWsvXZW2qoPwwUs5d/9tN3hogJOzVlfz3yHCjGXx5T2cdrza T4+GHcWMOl4x9qrYL5TYG06n2EUUogjxxqP9k1s= X-Google-Smtp-Source: ADFU+vuNz8LGvg20VvbIcfg5Bu1FdbJR4PiA5lO7bRTDYECiX0Vg2LO3/1kSphKCavJm3xzTDVkEBGFdri5vVYruHgc= X-Received: by 2002:a50:9f6e:: with SMTP id b101mr245921edf.372.1585331229996; Fri, 27 Mar 2020 10:47:09 -0700 (PDT) MIME-Version: 1.0 References: <20200327170601.18563-1-kirill.shutemov@linux.intel.com> <20200327170601.18563-3-kirill.shutemov@linux.intel.com> In-Reply-To: <20200327170601.18563-3-kirill.shutemov@linux.intel.com> From: Yang Shi Date: Fri, 27 Mar 2020 10:46:55 -0700 Message-ID: Subject: Re: [PATCH 2/7] khugepaged: Do not stop collapse if less than half PTEs are referenced To: "Kirill A. Shutemov" Cc: Andrew Morton , Andrea Arcangeli , Linux MM , Linux Kernel Mailing List , "Kirill A. Shutemov" Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 27, 2020 at 10:06 AM Kirill A. Shutemov wrote: > > __collapse_huge_page_swapin() check number of referenced PTE to decide > if the memory range is hot enough to justify swapin. > > The problem is that it stops collapse altogether if there's not enough > refereced pages, not only swappingin. s/refereced/referenced > > Signed-off-by: Kirill A. Shutemov > Fixes: 0db501f7a34c ("mm, thp: convert from optimistic swapin collapsing to conservative") > --- > mm/khugepaged.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 99bab7e4d05b..14d7afc90786 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -905,7 +905,8 @@ static bool __collapse_huge_page_swapin(struct mm_struct *mm, > /* we only decide to swapin, if there is enough young ptes */ > if (referenced < HPAGE_PMD_NR/2) { > trace_mm_collapse_huge_page_swapin(mm, swapped_in, referenced, 0); > - return false; > + /* Do not block collapse, only skip swapping in */ > + return true; > } > vmf.pte = pte_offset_map(pmd, address); > for (; vmf.address < address + HPAGE_PMD_NR*PAGE_SIZE; > -- > 2.26.0 > >