From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A39CD2A537 for ; Wed, 16 Oct 2024 17:33:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9ECC16B0083; Wed, 16 Oct 2024 13:33:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99C1D6B0088; Wed, 16 Oct 2024 13:33:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 863A76B0089; Wed, 16 Oct 2024 13:33:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 679E36B0083 for ; Wed, 16 Oct 2024 13:33:58 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2608EC0853 for ; Wed, 16 Oct 2024 17:33:47 +0000 (UTC) X-FDA: 82680162978.19.6C2A4AF Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf27.hostedemail.com (Postfix) with ESMTP id 481C640009 for ; Wed, 16 Oct 2024 17:33:46 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LyltBRvO; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729099917; a=rsa-sha256; cv=none; b=vek/7Bv763jazwKrsIU61tLo49zpvoqqj+rWnktHjLI2a9Ly3asTDafwsnUQMN48hWvGag pXe3hWmaMQRUSiexH+sHtTQ1BSfhgOfPXnj4eJpwN6d38ytu9wIAxOei6xmmLnFKDY4tvy /9zJ6tHojX1crPe0GPLQyjjLD4HjOYo= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LyltBRvO; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of shy828301@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=shy828301@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729099917; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+IOikhW/mkeClxBwUKE9q02/XVbq9Al3HpYKbaOM8oc=; b=dE+2q2AXmtt1PvIdboNTQFDGyI15aCl1lbOzCzsl595bjmFJ6KLSOVC08UBesDe4N3bnDZ n44cFzGMlcViIyB5qnaS5o5B6BIvCUGoXguCJOxQZHh7n3fge0yckJQc93e50sBcCyAWcw cqhqyjPMHtv+Z+aVxYovnNVl3cgtHg0= Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a998a5ca499so9507366b.0 for ; Wed, 16 Oct 2024 10:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729100033; x=1729704833; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+IOikhW/mkeClxBwUKE9q02/XVbq9Al3HpYKbaOM8oc=; b=LyltBRvOQtsEz6NFEyQlWLqnw8P+qasVEjI+F6rpx1XIVVLrasxUSB1gM0Gxk9Cm/A 3WsoURpb/B7VMJl1MhcIwLUyHSMNMFJAGmEYx145lPi2G/15MV/sruknQLFgWeHKKOH6 XgiD63RSt2sMQML6ShkDhVdZ4Nmm2RGf1e0ZLTN/HfMYYLF21e7DX2Q9yGAMgtds5JHx uRJGY+iqC+daTyeo3Eq7dvH7nIS+KNSJ5TUPXoc9oF+tF/S02/I4TQf8LU5ffvPv5Uel qOON/+xKnsl3wGGk/QKtQkRgCBOTBxf5wMA//3rO8/1MgdkAeMgHf4WoupzcfshUyxSv egUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729100033; x=1729704833; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+IOikhW/mkeClxBwUKE9q02/XVbq9Al3HpYKbaOM8oc=; b=SGhbcNdXSJdgobZLLNCEinF04JhQupkdKIINGPRo6iEt8687u3c3PxfX+ZFuK26XdX b+upc9vhUimVBzNk/EQhZfRl5Ffk5AtO45E+cXJHZ52Ashb6uxaQW5Gwc+vt6Mkkw5Lq OCnwtzA3rU4+vYNIFlmyx0SFxbTDRSImx6zN5aGCHJmhjoD9H1oo+DuqCAuUtJqT4Dsh wCv36GjxiZCFFVPDdxX+F2ppFjsgqd94U+mhWPwr9vUrH2I3THM5fVgjBLNfheJ8PKy+ bOrtuR61dLLFMnEE03MEu5Oya8Xz4Hq4xoa84hhMncHwLX0L1Ho0YpKX7qY9bAYpynyi bzzg== X-Forwarded-Encrypted: i=1; AJvYcCUTl9/v+q3AqnzMpVEA3QhCyDxaNoQYhUnTIq3aKPbRhRNKXcKy3A/vviPK7zBVRXbyGqH4NcoOLQ==@kvack.org X-Gm-Message-State: AOJu0Yza0Ni13yXmrNPJ3jz4LLugYxBLyRuaOwX0KfzI9WCmgqi70TxY LaBb6VoTHvrRQ+mdydiuC+CHOMJ7jM2nvuzfD00yLr/DAapaufMzsW2Awyi1pUyfQbhhC4EfkEO KcdfJ7oqnl6vgayR5SPU3geohuoQ= X-Google-Smtp-Source: AGHT+IFP8z26q8+zMFhY0n7+zyhNFca/ubEfFS0Oeu7VoKL4Qp8i/zfK/GxAwwiqYj8Gwo/u0cRynUmK0xLGDPsGNaI= X-Received: by 2002:a17:907:ea6:b0:a9a:230b:ff2c with SMTP id a640c23a62f3a-a9a230bffe4mr694507166b.30.1729100033305; Wed, 16 Oct 2024 10:33:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yang Shi Date: Wed, 16 Oct 2024 10:33:41 -0700 Message-ID: Subject: Re: [PATCH 2/2] mm: shmem: improve the tmpfs large folio read performance To: Matthew Wilcox Cc: Baolin Wang , akpm@linux-foundation.org, hughd@google.com, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 481C640009 X-Stat-Signature: 1gpnx31g48u1u1g889yunkb6qbdagccu X-Rspam-User: X-HE-Tag: 1729100026-412206 X-HE-Meta: U2FsdGVkX18z8CDeEBQleQ29fYC/1+zBoo8SjJA7Ur36h/yJ08/zWX11KTvrDjCv+ECEEwy9z6TPUsl1rDoH+vsdA/AtvE4rJXFP8XrMobFLTl7THYxPoqZKPD24NRBrcj2mDSa1lrEnbZ1RmXf+LWdHmOFxc7fBAkK4HKdBxlfxzChmB6M+Lgcxau9EPH8ZHUbWpeBrjnXgbPs5w4+vLoclQdl24u4TjXCRmwLpzCyEfiyZxE98512SXQ4qQxHJopZUrJWLRwyr/Xcg8cf4Rp4ERtICnteHnrglDeGd4ny+wdzNtGtli3El6oQDq56spqUBFGPi3dQ/zfv+Kf1yaIRHFyqQ4QKz8guuWxWsiRmPhw/0rW/RF0JqKQBiuvuXeA95Y3c6lROcjDP4+AP3ql2N1p7uaNtl6xM33ZJg2d2WoMEMU4ilE9c3qG/myvekr9NWibqr9htoLkMmB9M0G9+xbCyVYU/XO37hVNr/5uwXV4mqAmuK3obdt8mlzeLxvX9aA2x9unj1Aheuog7UbXY7w98UFIzr3ZEB+OeqYYW5KnIZfwX0wFZWbjZtAOqH2rWf13ktaxIgtU9/a6Am2VWZXGdhJ6YYDEVkIFXe0Xfmd/GhBaWAGDEYx3QdGON+oX1uxeTOc+3gsCrLkwcyVKc5YNsmTl16EtGypgMXRhms3Ag1kc6M+6w0HVbJ86uv/3k0PXPmXK3RHPtgxFWvs6o0uN3EFgvOGpDKauFiLvTcE+caDSikLsqaHw32x7xis5n3ZSrLEcCif05iPHVJffgQHCRN/ZDODBaBGMm4kR25UVVb0Aw/NII1YWh84bdia+bxZ2M937knXauus4IKogilpsy0TsdL9myNlmkFAh1DNAutujIWZcyfsLW5bL3RSl9ECukBNbdqzYaT4vqraoOycnEBQETKM2FEvkClrJcBKvcc6SNRNzi2qpcgngOb+iZtdxyipA8bAVw4iTg kBZf+2dH u+WW7Ym9y67oC4pXO85EFDFhp4EoRNzAbd8V/m40eh9+LbWeTguMZYv3twdPnxzAIS5ol3/6ShNUP+UOuFX+xpSR+4WZhEkZv1Lk4JMeZlfx/tTgSCF4B+J7Pu6wSfTNna1eD0t2Ogyci/vFKIB5bZiEbHfR1EECe3CtgnHDaLDzUzDR/HSnTuZ5KFCL49PHC7ScTvbAIGb3iaTWwJVx0dwHdez2hQkMl0JBYzizAstx2II/a2Im6mJgRLmQPm6DWuWH3IviWs6Wdq3NuphXtA9sRWiAI6usjYOH6Gd2h6Xs1a3KkfEqHet94adXOmZhfaeaNztygVdG1b4Xu9GTKTd3tyH8RxbWwZvuKPCVFCnNjWowtsM5mtjHvW9Uir6mtUV5E X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 16, 2024 at 8:38=E2=80=AFAM Matthew Wilcox wrote: > > On Wed, Oct 16, 2024 at 06:09:30PM +0800, Baolin Wang wrote: > > @@ -3128,8 +3127,9 @@ static ssize_t shmem_file_read_iter(struct kiocb = *iocb, struct iov_iter *to) > > if (folio) { > > folio_unlock(folio); > > > > - page =3D folio_file_page(folio, index); > > - if (PageHWPoison(page)) { > > + if (folio_test_hwpoison(folio) || > > + (folio_test_large(folio) && > > + folio_test_has_hwpoisoned(folio))) { > > Hm, so if we have hwpoison set on one page in a folio, we now can't read > bytes from any page in the folio? That seems like we've made a bad > situation worse. Yeah, I agree. I think we can fallback to page copy if folio_test_has_hwpoisoned is true. The PG_hwpoison flag is per page. The folio_test_has_hwpoisoned is kept set if the folio split is failed in memory failure handler. > >