From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51ECFC433E0 for ; Mon, 11 Jan 2021 19:43:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DE45022BF3 for ; Mon, 11 Jan 2021 19:43:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE45022BF3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4D40B6B02F4; Mon, 11 Jan 2021 14:43:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4846E6B0319; Mon, 11 Jan 2021 14:43:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34CDD6B031B; Mon, 11 Jan 2021 14:43:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id 1C8806B02F4 for ; Mon, 11 Jan 2021 14:43:17 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D7B461EE6 for ; Mon, 11 Jan 2021 19:43:16 +0000 (UTC) X-FDA: 77694517992.09.game62_3015fbf2750f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id BC63C180AD815 for ; Mon, 11 Jan 2021 19:43:16 +0000 (UTC) X-HE-Tag: game62_3015fbf2750f X-Filterd-Recvd-Size: 3947 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Mon, 11 Jan 2021 19:43:16 +0000 (UTC) Received: by mail-ej1-f48.google.com with SMTP id x16so45618ejj.7 for ; Mon, 11 Jan 2021 11:43:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=heazb9k/m8/zIdtN3jRoAAnqyK1a1wK3ts+R6742L6M=; b=OUQ39xFQqtOehkimmfAf739cawBRIfUXq7buq8L9pTI+oTRJ3bvIXwHVcWE6jhQQjo XurM1fh92irZV6l+GGdJL9SBg1OgBxukzfs0olW8S9FIvE1Kfv8i32Yh9J0Dvx5Bj//E yN3ZmFAL92lFx4JciAQPbuQv5Rk79nG1RF8MDWIK80DMY8C6moQghyBcwOsszppodCVB 6TCLYY5/tHEvrxUEjBTWVRcxdcqH3UmGrYpKm17tZlq+ho8+RRbWffnTn066q+vYrNab roHQf8XBbRSxDHgBWRexLFM//N0oOmsaEBMEIy48QTokon4+JtzLtt1sgWVgNcFV5VsR Q1pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=heazb9k/m8/zIdtN3jRoAAnqyK1a1wK3ts+R6742L6M=; b=RbJTS9HN1+k0s9cJTfEkzKTugcs83+Eyz/2ALUHMKHWIR8BLWGtVrbuWHZbDxEMvyP DCiskMu+ol0gxzK2T+qDQRwoKrvU8ejkrmzHpE9tDwWdknXZVmoHcT04c1OLlP+dV5xe c19chRys5COycpuswxA+yfINZXJfI0//EHQ9o6UoW8AtfCZINaLrLsJI4ocjXg1Pgwue sUkuQ2hy0OU1+gpqzz4ene37m1JMGdPzKSy9/uwybIsQJK8xY7u9dmbFcXg9/hqnw8Jh BT6X+d3L24vo2zR8SJYpkqfbyl4AHsB0HJPHSF6Zeih7kE4RHOAiMF+CSkPMTVC15zEl EubA== X-Gm-Message-State: AOAM532phxqIv6f4MO7Hz0bVCdYMZeT9oHlQlK0sN58AZsdVPtno/F46 7b9kENVTIK/+6kX3tW1xObh7yyZ/w/QQ/yKUmBw= X-Google-Smtp-Source: ABdhPJxU1h3Fa4qWWsvhta1+jAtDt3hDvEy4bC1whizOT51BBn8be0SpuiWBBHYcXoccZ+wa/cKStF3Sn8sOozF3VDY= X-Received: by 2002:a17:907:20a4:: with SMTP id pw4mr677910ejb.499.1610394195084; Mon, 11 Jan 2021 11:43:15 -0800 (PST) MIME-Version: 1.0 References: <20210105225817.1036378-1-shy828301@gmail.com> <20210105225817.1036378-3-shy828301@gmail.com> <20210107001351.GD1110904@carbon.dhcp.thefacebook.com> <20210111193740.GB1388856@carbon.dhcp.thefacebook.com> In-Reply-To: <20210111193740.GB1388856@carbon.dhcp.thefacebook.com> From: Yang Shi Date: Mon, 11 Jan 2021 11:43:03 -0800 Message-ID: Subject: Re: [v3 PATCH 02/11] mm: vmscan: consolidate shrinker_maps handling code To: Roman Gushchin Cc: Kirill Tkhai , Shakeel Butt , Dave Chinner , Johannes Weiner , Michal Hocko , Andrew Morton , Linux MM , Linux FS-devel Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 11, 2021 at 11:37 AM Roman Gushchin wrote: > > On Mon, Jan 11, 2021 at 11:00:17AM -0800, Yang Shi wrote: > > On Wed, Jan 6, 2021 at 4:14 PM Roman Gushchin wrote: > > > > > > On Tue, Jan 05, 2021 at 02:58:08PM -0800, Yang Shi wrote: > > > > The shrinker map management is not really memcg specific, it's just allocation > > > > > > In the current form it doesn't look so, especially because each name > > > has a memcg_ prefix and each function takes a memcg argument. > > > > > > It begs for some refactorings (Kirill suggested some) and renamings. > > > > BTW, do you mean the suggestion about renaming memcg_shrinker_maps to > > shrinker_maps? I just saw his email today since gmail filtered his > > emails to SPAM :-( > > Yes. Thanks for confirming, will do it in v4.