From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6260C433DB for ; Thu, 28 Jan 2021 21:16:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 675FD64DE8 for ; Thu, 28 Jan 2021 21:16:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 675FD64DE8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B72236B0005; Thu, 28 Jan 2021 16:16:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B21A86B0006; Thu, 28 Jan 2021 16:16:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A35E16B006C; Thu, 28 Jan 2021 16:16:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0025.hostedemail.com [216.40.44.25]) by kanga.kvack.org (Postfix) with ESMTP id 879856B0005 for ; Thu, 28 Jan 2021 16:16:55 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5177F181AEF31 for ; Thu, 28 Jan 2021 21:16:55 +0000 (UTC) X-FDA: 77756443590.15.skirt70_58160c3275a2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 2784C1814B0C1 for ; Thu, 28 Jan 2021 21:16:55 +0000 (UTC) X-HE-Tag: skirt70_58160c3275a2 X-Filterd-Recvd-Size: 5507 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Thu, 28 Jan 2021 21:16:54 +0000 (UTC) Received: by mail-ed1-f42.google.com with SMTP id n6so8253917edt.10 for ; Thu, 28 Jan 2021 13:16:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6Bn/uZbi53prTbKMwEZWHXl6XCtApRQIRtzYnDibrEI=; b=M1Xs1mWrpvwVSmNxKUfVObBna2/o8jikxGlcqEeHhf0DSudNj8QY6OAX3C7uy2Dpx/ 1MZMRcZeq4VuYtZTJjUVrNOseOr8M/B75LrHOC+GhGpocyFVVJRDP7TdB09LgRzkIvZM By9mh5EVAdU0FegixQb+tT5mLFvocEcYinNP5sBPh25nKxAwSZvDdbzX5VoG0zMcTUK9 LBYCgT62MIreVF/Ke+S7X1DhrrxB+SKiJ72osOSrGkg790v42NGClbocqMbpYCFWoARD VmgwKYP4Aq1VGBmw/tAhIGRAsE899bCnYJ8Kf3HdmPScPV4Dx3xBHBlJDVFL88vm1f28 dxgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6Bn/uZbi53prTbKMwEZWHXl6XCtApRQIRtzYnDibrEI=; b=YbmrjqxLwvmJQjamGik0Axq9ODoeMS6DfpGdkNtUWjsoi9tXJEZ44RSuuCj2FOT3P3 IHy3M3Z9pnusy36VwnhFgITFHDBy8+ggfGV3VKea/G/HMXiY878R9ATeXa/42ShGHxr1 N8CfwhlSP1cP/jIGNN90lw4OY6DRQ8V4GnxGwG09BMvwbIzs95gGhyhKDWHQTqniN3pC 11TjKTkH4b012gdy3+vETzeJ3K4NWnfXwHwdc2KY1Azy9jnGt78WClEF1Yx5s0B+EyCY QoX9CgZLo3Cl8p7ELv/3mnhs59Kmq5E9FVoQjYEt7kb1UCQMYAGdrPF70NJ4XL+Dj6wi LWNA== X-Gm-Message-State: AOAM530E2quKK9MTwgq5+IbikHMiMf0WkQ3GuaSpnDy87RWRWamqD0/3 hDYhvS2E7LW1BnxIm7Bt2y/e0W1zJ5KGZ774dIM= X-Google-Smtp-Source: ABdhPJy9bs5zjsAcg8AJRyenRTcYrzHPwabscBl9E9PA/LMnOGH2QrK37cEXMePa86ZjH47zlOt/oZjVyiAUvhdIHHc= X-Received: by 2002:a05:6402:312e:: with SMTP id dd14mr1780887edb.366.1611868613546; Thu, 28 Jan 2021 13:16:53 -0800 (PST) MIME-Version: 1.0 References: <20210127233345.339910-1-shy828301@gmail.com> <20210127233345.339910-3-shy828301@gmail.com> <4b0a6d22-e29b-fb85-b05f-b9f9f62ca8ea@suse.cz> In-Reply-To: <4b0a6d22-e29b-fb85-b05f-b9f9f62ca8ea@suse.cz> From: Yang Shi Date: Thu, 28 Jan 2021 13:16:41 -0800 Message-ID: Subject: Re: [v5 PATCH 02/11] mm: vmscan: consolidate shrinker_maps handling code To: Vlastimil Babka Cc: Roman Gushchin , Kirill Tkhai , Shakeel Butt , Dave Chinner , Johannes Weiner , Michal Hocko , Andrew Morton , Linux MM , Linux FS-devel Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 28, 2021 at 8:10 AM Vlastimil Babka wrote: > > On 1/28/21 12:33 AM, Yang Shi wrote: > > The shrinker map management is not purely memcg specific, it is at the intersection > > between memory cgroup and shrinkers. It's allocation and assignment of a structure, > > and the only memcg bit is the map is being stored in a memcg structure. So move the > > shrinker_maps handling code into vmscan.c for tighter integration with shrinker code, > > and remove the "memcg_" prefix. There is no functional change. > > > > Signed-off-by: Yang Shi > > Acked-by: Vlastimil Babka > > Nits below: > > > @@ -1581,10 +1581,10 @@ static inline bool mem_cgroup_under_socket_pressure(struct mem_cgroup *memcg) > > return false; > > } > > > > -extern int memcg_expand_shrinker_maps(int new_id); > > - > > -extern void memcg_set_shrinker_bit(struct mem_cgroup *memcg, > > - int nid, int shrinker_id); > > +extern int alloc_shrinker_maps(struct mem_cgroup *memcg); > > +extern void free_shrinker_maps(struct mem_cgroup *memcg); > > +extern void set_shrinker_bit(struct mem_cgroup *memcg, > > + int nid, int shrinker_id); > > "extern" is unnecessary and people seem to be removing them nowadays when > touching the code OK, will fix in v6. > > > /* > > * We allow subsystems to populate their shrinker-related > > * LRU lists before register_shrinker_prepared() is called > > @@ -212,7 +338,7 @@ static int prealloc_memcg_shrinker(struct shrinker *shrinker) > > goto unlock; > > > > if (id >= shrinker_nr_max) { > > - if (memcg_expand_shrinker_maps(id)) { > > + if (expand_shrinker_maps(id)) { > > idr_remove(&shrinker_idr, id); > > goto unlock; > > } > > @@ -601,7 +727,7 @@ static unsigned long shrink_slab_memcg(gfp_t gfp_mask, int nid, > > Above this is a comment about barriers in memcg_set_shrinker_bit() that should > be updated. Thanks for catching this. Will fix in v6. > > > if (ret == SHRINK_EMPTY) > > ret = 0; > > else > > - memcg_set_shrinker_bit(memcg, nid, i); > > + set_shrinker_bit(memcg, nid, i); > > } > > freed += ret; > > > > >