From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BAE8C6FD18 for ; Thu, 30 Mar 2023 00:18:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 82E856B0072; Wed, 29 Mar 2023 20:18:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DF1E6B0074; Wed, 29 Mar 2023 20:18:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A5F46B0075; Wed, 29 Mar 2023 20:18:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5A3336B0072 for ; Wed, 29 Mar 2023 20:18:01 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2F3A31A08A3 for ; Thu, 30 Mar 2023 00:18:01 +0000 (UTC) X-FDA: 80623651962.18.C36E466 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf24.hostedemail.com (Postfix) with ESMTP id 637A718000F for ; Thu, 30 Mar 2023 00:17:59 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KYNyyyhq; spf=pass (imf24.hostedemail.com: domain of shy828301@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680135479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GFrxtn9d5G2riP70vvdw/yu25SnT/y5gfBPSK+n92IU=; b=x9GVfS4qIhs068CPwOK2iCXKWiLUQAo0uxFrwbLT4r6/baGJIw4n8/1fKLoL1RhuRshilX GIaQPPy6NqUsTBIz9S7GYIRtRRyQH2pWG76rOMI10JIKC4mZqg3ebaLPGOLyR4OFmgxEzg zddyJbmZuAbvYK0SwZW7LZ5ritFN0q8= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KYNyyyhq; spf=pass (imf24.hostedemail.com: domain of shy828301@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680135479; a=rsa-sha256; cv=none; b=1jnon51FGgKSH7NvcQuEx12uTYn5ptOoNEpIXQJvjIwBgV5yHmfgzJNOXL4yVaU5kZvD9o X64xgQGW9sPQ+6vvEqgkGSo2NK7r1tN0Upg9NPhSpNYu8zhMWybBUWNHt5AK4YBDCbfMvq P9sVEpJRcMrIgefJflhlsqlTqk4/Yic= Received: by mail-pf1-f170.google.com with SMTP id u38so11414493pfg.10 for ; Wed, 29 Mar 2023 17:17:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680135478; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GFrxtn9d5G2riP70vvdw/yu25SnT/y5gfBPSK+n92IU=; b=KYNyyyhqVrYmGqRxxi/SM2DiuO4mCIY7EWWchExvtXdrm1XO5oDXmK5Er2s+mn3Pk9 FIXNpsZ/Ua3VaC+qLRcNGDw6wPWb33mnRw6m/M+OaV8Qr7zs9AP2V/DrGD6ZUuF2+OUB o6Ua7cfXYbLRFXCBVkwJDiUT5QTRRpeH/v/wIbDaCuyXgMAom79byhB+4uNMuEUEU+k4 BH1NkWsGPTccS19YXMQKMiuXZTxILZIFb8xHIrqz8VjA3PccOBpiH9JmGdZE1DHpVHZ5 Tn9nyYB5YUxugZgn8IAWqsmKnLtuXTMPowJSCgZlhxdNAsP1q6BF5/rUHHwmLF1RvMxB h9lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680135478; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GFrxtn9d5G2riP70vvdw/yu25SnT/y5gfBPSK+n92IU=; b=Ggg9pOifRIT1qYqdESoK4Kd6Tz0III9x00kGyYdiDMAqopMNQ72timmhU5TP3lrMfN 47efSYGrExqKmH5Cti5i5i9qkA2CA0/eYRX6zsytFYAymQDf/HtANrD0AM7JdEI1D7zm 8N6P3WNLk7bTvUiYrhtEOQKvmeEu46iKeG6V9aWftTdlPwSKCLBq6yYY058iR8HJORpc G3i9+Q5O8xdYlEQD8OZeHNbqYKC5+t3VTa2XqHAtmW9gZxJwSoagvm89B4Tau+KThu7V LUg4J3lwtSTmygxiv6kEE9qF1kYONqUU3hCbvMubvECiHDGU+I8tOYe74hAuvrfLOLsh KLxQ== X-Gm-Message-State: AAQBX9fQGTpethhRGz830JeYMdljAjuEiHCcMwTAX4ZEw45RpExOC8pm MBHKDuUiFWmPnMRysXN5aTt2blW3TLmhIpfPbES22YfH X-Google-Smtp-Source: AKy350aEVPs1e5xvudW7+v0SaWp4yk4rckHRftoj/jiGIVi7YJx59Ax0QojqF2IskeBIF4cBFMwK7DyHsh5zud9IPEs= X-Received: by 2002:a05:6a00:2e9f:b0:628:1e57:afd7 with SMTP id fd31-20020a056a002e9f00b006281e57afd7mr10923270pfb.0.1680135478121; Wed, 29 Mar 2023 17:17:58 -0700 (PDT) MIME-Version: 1.0 References: <3a0f0c92-63cb-3624-c2fe-049a76d1a64a@opensource.wdc.com> In-Reply-To: <3a0f0c92-63cb-3624-c2fe-049a76d1a64a@opensource.wdc.com> From: Yang Shi Date: Wed, 29 Mar 2023 17:17:46 -0700 Message-ID: Subject: Re: [PATCH 18/19] dm-crypt: check if adding pages to clone bio fails To: Damien Le Moal Cc: Johannes Thumshirn , Jens Axboe , Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , David Sterba , linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 637A718000F X-Stat-Signature: ra38tia3dmfn537mumtbcbgzd8jh51bi X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680135479-296549 X-HE-Meta: U2FsdGVkX1+svibV83LrsBSSzV00QEJ9iGWrq7qYfy6QLzYFIpfK7pibyzxpK9JeVj9ov/NGweqS9VQWzKorstIRdkRviEzq4ca/nYKWP6cyYs2HDrAeNxXgiKxpUKBIaTMlIvBa5axlYZhZJ/j0HJzwzjJfueLB8J9x25q+UgsW9nhk0Nn3TiMIc1JPdHxMteIKAPn4Cyw5mCjJSdOZqihLHNkexTktAHkt5gaQx8pkgh8X4Tt9b0fps0UKEYe17++t9hq1dSUuhahWHJw135W4Rrwl7ZRndJFqHMMvJ8fZYVP0+pr0lGM20vTN39DyRKxKVQyrCtk+JJxLzl3/w8PoVg2f59j2psyJMv/IWo3TXGycdLhTPaLMpdI+jatrnG2egrkZr4J4zX2qt8zTk6RLdja8n6kL5halH/b9/cLbvtJIogzcaUsuwvihdyP07IBEJs8XV7Nx9oG7x58zFscTt7vPFcrYSAm/Vxo/zgr+VDEB6RP6o7lYWyI2K2n3PPttcJhSxnaobAuyD6pZKwKXIruEzQNfaasNhYTIbv0uvhZTN3rppE7HK5yXEFfiQPmzCVsCWgPRygAi06VcNCGlLxPA+SdShJ8LfsLWGUn/m1Sb5xn03H+iKJhWO1yTbhhS+gjYdq/TCcGdVfCm/L00dHRX/nn+DEJNpghje9nuWdLY25MTFhCajHdkr5IPCASwpngk3db1OvBSt/lxiTv4YPbMdIt7Uf7P8Caq2A5UC3uIeU/ylPAfL9bDvgJyH1xZdmRRtlo3BHRObfWbfgEVsqEtEJVRXXM+SZ3BCKBqersFC/oMB5zRoLnMgGGQV1NoMoPtHuwC5KdyhX4d9m1rKMl9RIEEj+rI3h0+zji5rBmzqoJncbl73nfFi0S/PyGADoOKFRV4fI46dS41FbTECRUYZZHr2B9RIRT9RirpTFKt9L/BixXxDeB/HODxHmGFsSgXPM5EFit/fWB 48FoQ0eI FDZVjD3FoPOtRMF9U+Ds2Zod208TalCxoPFIgwqNmJzJidWbiZpS5yXcCR5/pUAHObThDVw9Vub2CFZDnCyHFurb+/vTlCqTuEj0K2D9XJF52atFhvMIZ3CQqzGLWd3+fv6+end7mfcKTR0Xcx/htF95AmzVEusTqpPiydanZjP0xP/P9zN24FVgXf/m9zb3Hgb1njpszqM1YZo5zLgC54uLD3AAU6VOJj41viaIiGElrvk4hzKxgPLvXFp4cD0j16CKFunXIqXmqViYYF1fP90SplhTZypEmv0fhOxDJpZwrkk9FfmK7LsLu5a28nUhAopwwye5byPlxXFRSB+Bo/byLbQQ1KQTuiqydPTS6JmlpLP2Q5i1Ml3VthHiMWn7AsDSgowsJqRFYYY75TLuMgNjwTo7DteU43o3xl4Exvy26rL/0GaBIFIM2pFK5ADSv+pkoi5tljvwOryLB0Y++TzxCPQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 29, 2023 at 4:49=E2=80=AFPM Damien Le Moal wrote: > > On 3/30/23 02:06, Johannes Thumshirn wrote: > > Check if adding pages to clone bio fails and if bail out. > > Nope. The code retries with direct reclaim until it succeeds. Which is ve= ry > suspicious... It is not related to bio_add_page() failure. It is used to avoid a race condition when two processes are depleting the mempool simultaneously. IIUC I don't think page merge may happen for dm-crypt, so is __bio_add_page() good enough? I'm working on this code too, using __bio_add_page() would make my patch easier. > > > > > This way we can mark bio_add_pages as __must_check. > > > > Signed-off-by: Johannes Thumshirn > > With the commit message fixed, > > Reviewed-by: Damien Le Moal > > > -- > Damien Le Moal > Western Digital Research > >