From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65232C433ED for ; Tue, 27 Apr 2021 20:57:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EB4B0613F3 for ; Tue, 27 Apr 2021 20:57:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB4B0613F3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 487776B00B9; Tue, 27 Apr 2021 16:57:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4371D6B00BD; Tue, 27 Apr 2021 16:57:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D8A96B00BE; Tue, 27 Apr 2021 16:57:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0140.hostedemail.com [216.40.44.140]) by kanga.kvack.org (Postfix) with ESMTP id 12A816B00B9 for ; Tue, 27 Apr 2021 16:57:41 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BCF86364F for ; Tue, 27 Apr 2021 20:57:40 +0000 (UTC) X-FDA: 78079358280.25.B06470A Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf27.hostedemail.com (Postfix) with ESMTP id B0ABE80192FC for ; Tue, 27 Apr 2021 20:57:18 +0000 (UTC) Received: by mail-ed1-f46.google.com with SMTP id g14so11920580edy.6 for ; Tue, 27 Apr 2021 13:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5mcuDXZg50oHuBsNQdQxM5CN9VGwiDIz4IEF7rEKvL4=; b=LwiSk0gcQuTgh0shmC1wawB6cPEsfHSoPh9yM/jbcsDjoMB7x29BSL6Hs+5Kbue6uZ reHQ7lyfMO3rdelk1z9jevpglP1I1GCM5RFdQXVq1yn2uNf5VMbKMK9upmijcbTFaA8+ sPZ4Fu5XcJCE4M4wjpky2fuVz7gjU0VGgtfE4ozoiJv8QGxxvWWnK9tun1BFAznA3r4k 3xTxut6vgkRSEc9Iocgte4Y0wpEU/Cazo3aRSi1UBRlgpHGypibF5QYTZh0L+Ri+dfFM 33OK6Ci37IL8SLUPA+lQvjNd36ohl+dMF/F67oX5s1vpn/WrR8cDE2XSlwqGst8HrYLG YwKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5mcuDXZg50oHuBsNQdQxM5CN9VGwiDIz4IEF7rEKvL4=; b=PlxSmiLXwMLtydfwke1Lb7VYy2bXjwEeZ34LiiEf9yvGP1uhsRoI9jnFtNPoCAoLVA YP9pFcFme3Ubkh6R/G06NwJanAB0yT1kQ6WHbUZReE8sBWuijWL8SCNIZU2J9i7qT8/G sv1kfWcPgGbJy8wEZWJKrIhdgbxXVoC2xVipk4PgmH2MDoBfAzeQZRgo9KBtzWU3HI8m EXy5Y/BsF4Y+b650NfVSpSuR/54R45Io+Uk05JUGkpjafRefWrc7ftrVDIPztJ4uc8PV LxM4xsPNaENojED0N6R5whGp65M9wvuOIt3nqg+Z742INncYVac3U7RIbQmTpgvrmZy9 LpEw== X-Gm-Message-State: AOAM5329ZsVPhnH5bzbKcfAfjwQHvQSRFYaXnFth/5o5/UPMqxiWvb5y 6rPpISmwaAfztftsybcuxsK0E2ZllZTRwPgTL50= X-Google-Smtp-Source: ABdhPJwoqgdpHEb6Ku8QnZR6UAedR1QS5GfyNbMw4h6sPbSV4b2heZyqiGZUEsc0tnF7zmHyF0QrpUxkK3x0othw1fM= X-Received: by 2002:a05:6402:1907:: with SMTP id e7mr6677629edz.313.1619557059450; Tue, 27 Apr 2021 13:57:39 -0700 (PDT) MIME-Version: 1.0 References: <20210427133214.2270207-1-linmiaohe@huawei.com> <20210427133214.2270207-2-linmiaohe@huawei.com> In-Reply-To: <20210427133214.2270207-2-linmiaohe@huawei.com> From: Yang Shi Date: Tue, 27 Apr 2021 13:57:27 -0700 Message-ID: Subject: Re: [PATCH 1/5] mm/huge_memory.c: remove dedicated macro HPAGE_CACHE_INDEX_MASK To: Miaohe Lin Cc: Andrew Morton , Zi Yan , william.kucharski@oracle.com, Matthew Wilcox , Yang Shi , aneesh.kumar@linux.ibm.com, Ralph Campbell , Song Liu , "Kirill A. Shutemov" , Rik van Riel , Johannes Weiner , Minchan Kim , Linux Kernel Mailing List , Linux MM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B0ABE80192FC X-Stat-Signature: 9mde45dmacqka954n56mdcdc6eox8jjs Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf27; identity=mailfrom; envelope-from=""; helo=mail-ed1-f46.google.com; client-ip=209.85.208.46 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619557038-272840 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 27, 2021 at 6:32 AM Miaohe Lin wrote: > > Rewrite the pgoff checking logic to remove macro HPAGE_CACHE_INDEX_MASK > which is only used here to simplify the code. Reviewed-by: Yang Shi > > Signed-off-by: Miaohe Lin > --- > include/linux/huge_mm.h | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 9626fda5efce..0a526f211fec 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -152,15 +152,13 @@ static inline bool __transparent_hugepage_enabled(struct vm_area_struct *vma) > > bool transparent_hugepage_enabled(struct vm_area_struct *vma); > > -#define HPAGE_CACHE_INDEX_MASK (HPAGE_PMD_NR - 1) > - > static inline bool transhuge_vma_suitable(struct vm_area_struct *vma, > unsigned long haddr) > { > /* Don't have to check pgoff for anonymous vma */ > if (!vma_is_anonymous(vma)) { > - if (((vma->vm_start >> PAGE_SHIFT) & HPAGE_CACHE_INDEX_MASK) != > - (vma->vm_pgoff & HPAGE_CACHE_INDEX_MASK)) > + if (!IS_ALIGNED((vma->vm_start >> PAGE_SHIFT) - vma->vm_pgoff, > + HPAGE_PMD_NR)) > return false; > } > > -- > 2.23.0 > >