From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3879C433F5 for ; Wed, 27 Apr 2022 22:38:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 288206B0073; Wed, 27 Apr 2022 18:38:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 236FB6B0074; Wed, 27 Apr 2022 18:38:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D8B46B0075; Wed, 27 Apr 2022 18:38:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id EEFC16B0073 for ; Wed, 27 Apr 2022 18:38:14 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C8CA520660 for ; Wed, 27 Apr 2022 22:38:14 +0000 (UTC) X-FDA: 79404123708.18.18B0453 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf28.hostedemail.com (Postfix) with ESMTP id 410A1C0058 for ; Wed, 27 Apr 2022 22:38:06 +0000 (UTC) Received: by mail-pg1-f171.google.com with SMTP id k14so2549742pga.0 for ; Wed, 27 Apr 2022 15:38:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=drm1OQdyw43I3bW2ueb7Nz1xPsW07ECbYZ6BCyW/SWg=; b=g6C7JMcnrZ5ojJ8YLJNvmY7lTaxV4r0eAyKMoPajLiumweS31BhCzTuThLIrUiRBGc eRXEE8IQN7ojqtn7KQXhZzxHW3UtKQE6oXVeGGE/7u8c0+AKrAbRC9ttkrd+I6YHw0Vj Zj3iNJJBGhASQA/IKrYgpcgqfPs03eeGcULbEi/OVrmv2sYZefNNGnPQ8ETr6z7SF64Q FPPcYllE5FMCrqIDzoM6t3OkB6Otua3142EyPLSj76zSVSdg1uD5kFFlTpAqrgHq+wvR 8Ibq5glylHByEctpFQp8LKT/Fd5S/qFS+IN83Z3A9MNSxusFkYGbL/aYTcGfKwd0IMqv vxYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=drm1OQdyw43I3bW2ueb7Nz1xPsW07ECbYZ6BCyW/SWg=; b=HTJT+EERD2MAYUIqarkkNQEeQOdWRo6pjsRwZUBWJfErgUxANB8vjX3H2OtiboI8xs X0w4lnZ2mgNyHWAXvZlBY+Re5XbktHQKg2Ve+Ae+e/mk5s4x+4e2uSoznmpt0yBMQ7Yr 7OPwQtfaDZtlFBF9TUMqGgCbh7imij+Yct3iX+tMjY9Ry2OcdvJ+RXlUk2CwBbUgadjI rWdxfo4Jh4wYNldZdA9hLLQecLGltvMaRXDey8YvSoquluUTabTDT5coed51Mc0ZPsx0 IySyLhbKyc8T2QFCfxPQtvH2UEyrTACLInAoyPASt0faYW+aHpdI+qAHKiJ0+KK6sg0u seTQ== X-Gm-Message-State: AOAM531/+2cZXmDsnsJSlemro/WMnM84s9K5Bu7g1zSL65ZWAMGqz5ge 4DBYt1vYKYIiRKqRarD4WuZ4L5rKDCAOy3IThyk= X-Google-Smtp-Source: ABdhPJz5hgyo4J17oiLJQvgmGBUrY5Szb7LLTDZQuKW+KQqtiG1uSOJB7kXebmgJ2zuSLtC0gH0cpsi+p7k4QYGE8nk= X-Received: by 2002:a63:90ca:0:b0:3aa:fff3:6f76 with SMTP id a193-20020a6390ca000000b003aafff36f76mr19460147pge.206.1651099093287; Wed, 27 Apr 2022 15:38:13 -0700 (PDT) MIME-Version: 1.0 References: <20220404200250.321455-1-shy828301@gmail.com> In-Reply-To: From: Yang Shi Date: Wed, 27 Apr 2022 15:38:00 -0700 Message-ID: Subject: Re: [v3 PATCH 0/8] Make khugepaged collapse readonly FS THP more consistent To: Matthew Wilcox Cc: Vlastimil Babka , "Kirill A. Shutemov" , Miaohe Lin , Song Liu , Rik van Riel , Zi Yan , "Theodore Ts'o" , Andrew Morton , Linux MM , Linux FS-devel Mailing List , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 410A1C0058 X-Stat-Signature: ebemcuti5x88ny8izwieecs91gneoyo4 X-Rspam-User: Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=g6C7JMcn; spf=pass (imf28.hostedemail.com: domain of shy828301@gmail.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1651099086-727321 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 27, 2022 at 1:59 PM Matthew Wilcox wrote: > > On Mon, Apr 04, 2022 at 05:48:49PM -0700, Yang Shi wrote: > > When khugepaged collapses file THPs, its behavior is not consistent. > > It is kind of "random luck" for khugepaged to see the file vmas (see > > report: https://lore.kernel.org/linux-mm/00f195d4-d039-3cf2-d3a1-a2c88de397a0@suse.cz/) > > since currently the vmas are registered to khugepaged when: > > - Anon huge pmd page fault > > - VMA merge > > - MADV_HUGEPAGE > > - Shmem mmap > > > > If the above conditions are not met, even though khugepaged is enabled > > it won't see any file vma at all. MADV_HUGEPAGE could be specified > > explicitly to tell khugepaged to collapse this area, but when > > khugepaged mode is "always" it should scan suitable vmas as long as > > VM_NOHUGEPAGE is not set. > > I don't see that as being true at all. The point of this hack was that > applications which really knew what they were doing could enable it. > It makes no sense to me that setting "always" by the sysadmin for shmem > also force-enables ROTHP, even for applications which aren't aware of it. > > Most telling, I think, is that Song Liu hasn't weighed in on this at > all. It's clearly not important to the original author. I tend to agree that MADV_MADVISE should be preferred when this feature (or hack) was designed in the original author's mind in the first place. And "madvise" is definitely the recommended way to use THP, but I don't think it means we should not care "always" and assume nobody uses it otherwise the issue would have not been reported.