From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BE8DC433E0 for ; Tue, 5 Jan 2021 17:14:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0149022CE3 for ; Tue, 5 Jan 2021 17:14:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0149022CE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 374226B0075; Tue, 5 Jan 2021 12:14:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 325248D0089; Tue, 5 Jan 2021 12:14:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23A338D006E; Tue, 5 Jan 2021 12:14:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0109.hostedemail.com [216.40.44.109]) by kanga.kvack.org (Postfix) with ESMTP id 0B75E6B0075 for ; Tue, 5 Jan 2021 12:14:26 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C16088248076 for ; Tue, 5 Jan 2021 17:14:25 +0000 (UTC) X-FDA: 77672370090.11.debt97_3d0de96274da Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 99373180F8B82 for ; Tue, 5 Jan 2021 17:14:25 +0000 (UTC) X-HE-Tag: debt97_3d0de96274da X-Filterd-Recvd-Size: 4363 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Tue, 5 Jan 2021 17:14:24 +0000 (UTC) Received: by mail-ed1-f52.google.com with SMTP id r5so1237055eda.12 for ; Tue, 05 Jan 2021 09:14:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=x+304jrLdAurAmJH5NqHDACRNonQepT8iVWzqqXWcJc=; b=Xj6/eR9CvYPYbUrKWvQ8JDsfo+OG5VqNCb3TwIdnvnN9ufJzbYW1DQuM7TsK42+6wU q6BgmCCUZKHwPHxiClDijJkO3L5Pve9zzH3t1tHJXZWZlfyicKrzNxY1y9bV15qdWfeN pOsY7esyazalszVXu8funaSICWEGLnvZxMAKZm9LJmP6JZs3QS2bNoNPR7FEny/Qz8y/ g8sxQQl6FhxoPgEV29Vg9PKYbT+VeBqiLPSqfK+Qo/nJ5u0gYgTlcdixsSY7c0MNbooh 7BDZ/u/AZELOhjJFf445H+hVE8s9OrRWob/IKA41AiK72OhyY/b4utuBpig6AQgLPefj do2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x+304jrLdAurAmJH5NqHDACRNonQepT8iVWzqqXWcJc=; b=dNrMTYmq6R+XTo9Y5d3UgOInSJmxJ+O3QL5adaW6NKDxKnQsUYBq5gevjELbqnZNCa Q84ZhegPK/W2KRSmQNa4yoVgZv/Qau999+qX8d3pbF4mlbknNwT+c1BSwgO0Hwle+RxV lTIsedFYuvLf23Ha9phOzpEpKbfIXuWbq0PBqyzsIuCe8IBEPcg/qqGXQKUXDrO+eWe+ 3F4ot74lPT/Wf+0B4ThxG3wUjJ3rz9cwJvVJTzl1uJt0MyptEGS0b/lbytPApKMxP4hr f+AfwXNeGrgVnrXNs2UNJOBVDg6VZgZBEcya4OUeMvvTSwQs9xYXlbDc3a0bdM4ZVOlv l/vg== X-Gm-Message-State: AOAM532kopmHQi312u8qotB7lvS2f5SfSPMIySZRCUttEiP0IKAlyKyR dFjTptbfKZDKrZmWmkYv2r/YvpbZt45z3QSTuRM= X-Google-Smtp-Source: ABdhPJyZ0yJFQ+aCP6nEoSqqYgjLKcz/grwxVjrn9wNYJdtq4qsQ6W5Uw5RgFtiwGIWKfOLkjzAGHY8cTfAStuMapDc= X-Received: by 2002:aa7:c3d3:: with SMTP id l19mr792831edr.366.1609866863724; Tue, 05 Jan 2021 09:14:23 -0800 (PST) MIME-Version: 1.0 References: <456a021c7ef3636d7668cec9dcb4a446a4244812.1609855564.git.jstancek@redhat.com> In-Reply-To: <456a021c7ef3636d7668cec9dcb4a446a4244812.1609855564.git.jstancek@redhat.com> From: Yang Shi Date: Tue, 5 Jan 2021 09:14:11 -0800 Message-ID: Subject: Re: [PATCH] mm: migrate: initialize err in do_migrate_pages To: Jan Stancek Cc: Linux MM , Linux Kernel Mailing List , Zi Yan , Jan Kara , Matthew Wilcox , Mel Gorman , Michal Hocko , Song Liu , Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 5, 2021 at 6:14 AM Jan Stancek wrote: > > After commit 236c32eb1096 ("mm: migrate: clean up migrate_prep{_local}")', > do_migrate_pages can return uninitialized variable 'err' (which is > propagated to user-space as error) when 'from' and 'to' nodesets > are identical. This can be reproduced with LTP migrate_pages01, > which calls migrate_pages() with same set for both old/new_nodes. > > Add 'err' initialization back. Thanks for catching this. Acked-by: Yang Shi > > Fixes: 236c32eb1096 ("mm: migrate: clean up migrate_prep{_local}") > Cc: Zi Yan > Cc: Yang Shi > Cc: Jan Kara > Cc: Matthew Wilcox > Cc: Mel Gorman > Cc: Michal Hocko > Cc: Song Liu > Cc: Andrew Morton > Signed-off-by: Jan Stancek > --- > mm/mempolicy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 8cf96bd21341..2c3a86502053 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -1111,7 +1111,7 @@ int do_migrate_pages(struct mm_struct *mm, const nodemask_t *from, > const nodemask_t *to, int flags) > { > int busy = 0; > - int err; > + int err = 0; > nodemask_t tmp; > > migrate_prep(); > -- > 2.18.1 >